142972 2015-03-23 11:48:20 -0700 CSSParser is encountering seemingly malformed scroll-snap-destination input 2015-03-23 17:16:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED INVALID InRadar P2 Major --- 1 bfulgham bfulgham bfulgham webkit-bug-importer oldest_to_newest 1079325 0 bfulgham 2015-03-23 11:48:20 -0700 I placed the following assertion in CSSParser to catch instances where the scroll-snap-destination input processed by the CSSParser did not match expectations. --- a/trunk/Source/WebCore/css/CSSParser.cpp +++ b/trunk/Source/WebCore/css/CSSParser.cpp @@ -3354,5 +3354,4 @@ { RefPtr<CSSValueList> position = CSSValueList::createSpaceSeparated(); + ASSERT(m_valueList->size() == 2); if (m_valueList->size() != 2) return false; This is firing for the following test cases: css3/scroll-snap/scroll-snap-position-values.html css3/scroll-snap/scroll-snap-property-computed-style.html 1079326 1 webkit-bug-importer 2015-03-23 11:49:53 -0700 <rdar://problem/20261950> 1079481 2 bfulgham 2015-03-23 15:43:49 -0700 It looks like we're hitting this for the invalid case 'none': -webkit-scroll-snap-destination: none; The specification does not support 'none' as a valid input. 1079487 3 bfulgham 2015-03-23 15:50:49 -0700 The other case was expected bad input from 'scroll-snap-property-computed-style.js', which was passing three arguments to confirm we would reject it. The assertion should not be used because of these known tests. 1079514 4 bfulgham 2015-03-23 17:16:18 -0700 These cases all work properly. The assertion I added was invalid. Closing as invalid.