142964 2015-03-23 02:39:12 -0700 [GTK] Use std::abs() in ClickCounter::currentClickCountForGdkButtonEvent() 2015-03-23 03:06:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan berto cgarcia commit-queue gustavo mrobinson oldest_to_newest 1079252 0 zan 2015-03-23 02:39:12 -0700 [GTK] Use std::abs() in ClickCounter::currentClickCountForGdkButtonEvent() 1079254 1 249228 zan 2015-03-23 02:42:39 -0700 Created attachment 249228 Patch 1079256 2 commit-queue 2015-03-23 02:44:19 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1079259 3 249228 zan 2015-03-23 03:05:52 -0700 Comment on attachment 249228 Patch Clearing flags on attachment: 249228 Committed r181851: <http://trac.webkit.org/changeset/181851> 1079260 4 zan 2015-03-23 03:06:01 -0700 All reviewed patches have been landed. Closing bug. 249228 2015-03-23 02:42:39 -0700 2015-03-23 03:05:52 -0700 Patch bug-142964-20150323024516.patch text/plain 1898 zan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTg0OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAzLTIzICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBVc2Ugc3RkOjph YnMoKSBpbiBDbGlja0NvdW50ZXI6OmN1cnJlbnRDbGlja0NvdW50Rm9yR2RrQnV0dG9uRXZlbnQo KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyOTY0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAgIChDbGlja0NvdW50 ZXI6OmN1cnJlbnRDbGlja0NvdW50Rm9yR2RrQnV0dG9uRXZlbnQpOiBVc2UgdGhlIFNUTCdzIHN0 ZDo6YWJzKCkKKyAgICAgICAgaW5zdGVhZCBvZiBDJ3MgYWJzKCkuIFRoZSB0ZW1wbGF0ZWQgbmF0 dXJlIG9mIHN0ZDo6YWJzKCkgZW5zdXJlcyB0aGUgcHJvcGVyCisgICAgICAgIGNvbXB1dGF0aW9u IHRoYXQgbWF0Y2hlcyB0aGUgdHlwZXMgb2YgdGhlIHBhc3NlZC1pbiB2YWx1ZXMsIGFuZCBzaHV0 cyBkb3duCisgICAgICAgIGEgd2FybmluZyB3aGVuIGNvbXBpbGluZyB3aXRoIENsYW5nLgorCiAy MDE1LTAzLTIzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBBZGQgYSBjb25maWd1cmUgb3B0aW9uIHRvIGJ1aWxkIHdpdGhvdXQgUmVk aXJlY3RlZCBYQ29tcG9zaXRlIFdpbmRvdwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAkocmV2aXNpb24gMTgx ODQ5KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jh c2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTUsOCArMTE1LDggQEAgcHVibGljOgogICAgICAg ICB9CiAKICAgICAgICAgaWYgKChldmVudC0+dHlwZSA9PSBHREtfMkJVVFRPTl9QUkVTUyB8fCBl dmVudC0+dHlwZSA9PSBHREtfM0JVVFRPTl9QUkVTUykKLSAgICAgICAgICAgIHx8ICgoYWJzKGJ1 dHRvbkV2ZW50LT54IC0gcHJldmlvdXNDbGlja1BvaW50LngoKSkgPCBkb3VibGVDbGlja0Rpc3Rh bmNlKQotICAgICAgICAgICAgICAgICYmIChhYnMoYnV0dG9uRXZlbnQtPnkgLSBwcmV2aW91c0Ns aWNrUG9pbnQueSgpKSA8IGRvdWJsZUNsaWNrRGlzdGFuY2UpCisgICAgICAgICAgICB8fCAoKHN0 ZDo6YWJzKGJ1dHRvbkV2ZW50LT54IC0gcHJldmlvdXNDbGlja1BvaW50LngoKSkgPCBkb3VibGVD bGlja0Rpc3RhbmNlKQorICAgICAgICAgICAgICAgICYmIChzdGQ6OmFicyhidXR0b25FdmVudC0+ eSAtIHByZXZpb3VzQ2xpY2tQb2ludC55KCkpIDwgZG91YmxlQ2xpY2tEaXN0YW5jZSkKICAgICAg ICAgICAgICAgICAmJiAoZXZlbnRUaW1lIC0gcHJldmlvdXNDbGlja1RpbWUgPCBzdGF0aWNfY2Fz dDx1bnNpZ25lZD4oZG91YmxlQ2xpY2tUaW1lKSkKICAgICAgICAgICAgICAgICAmJiAoYnV0dG9u RXZlbnQtPmJ1dHRvbiA9PSBwcmV2aW91c0NsaWNrQnV0dG9uKSkpCiAgICAgICAgICAgICBjdXJy ZW50Q2xpY2tDb3VudCsrOwo=