142963 2015-03-23 02:33:26 -0700 [GTK][WK2] webkitBackForwardListChanged() should operate on a Vector reference 2015-03-23 03:03:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan berto cgarcia commit-queue gustavo mrobinson oldest_to_newest 1079249 0 zan 2015-03-23 02:33:26 -0700 [GTK][WK2] webkitBackForwardListChanged() should operate on a Vector reference 1079250 1 249227 zan 2015-03-23 02:34:57 -0700 Created attachment 249227 Patch 1079251 2 commit-queue 2015-03-23 02:37:08 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1079257 3 249227 zan 2015-03-23 03:02:48 -0700 Comment on attachment 249227 Patch Clearing flags on attachment: 249227 Committed r181850: <http://trac.webkit.org/changeset/181850> 1079258 4 zan 2015-03-23 03:03:00 -0700 All reviewed patches have been landed. Closing bug. 249227 2015-03-23 02:34:57 -0700 2015-03-23 03:02:48 -0700 Patch bug-142963-20150323023734.patch text/plain 3055 zan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTg0OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAzLTIzICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXSzJdIHdlYmtp dEJhY2tGb3J3YXJkTGlzdENoYW5nZWQoKSBzaG91bGQgb3BlcmF0ZSBvbiBhIFZlY3RvciByZWZl cmVuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 Mjk2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0QmFja0ZvcndhcmRMaXN0LmNwcDoKKyAgICAgICAgKHdl YmtpdEJhY2tGb3J3YXJkTGlzdENoYW5nZWQpOiBUaGlzIGZ1bmN0aW9uIG9ubHkgcmVhZHMgZnJv bSB0aGUgcGFzc2VkLWluCisgICAgICAgIFZlY3RvciBvZiByZW1vdmVkIGl0ZW1zLCBzbyBvbmx5 IGEgY29uc3QgbHZhbHVlIHJlZmVyZW5jZSB0byB0aGUgVmVjdG9yCisgICAgICAgIGlzIG5lZWRl ZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRCYWNrRm9yd2FyZExpc3RQcml2 YXRlLmg6CisKIDIwMTUtMDMtMjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHVEtdIEFkZCBhIGNvbmZpZ3VyZSBvcHRpb24gdG8gYnVpbGQg d2l0aG91dCBSZWRpcmVjdGVkIFhDb21wb3NpdGUgV2luZG93CkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRCYWNrRm9yd2FyZExpc3QuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEJhY2tGb3J3YXJkTGlz dC5jcHAJKHJldmlzaW9uIDE4MTg0OSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Z3RrL1dlYktpdEJhY2tGb3J3YXJkTGlzdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyOCwxMyAr MTI4LDEzIEBAIFdlYktpdEJhY2tGb3J3YXJkTGlzdCogd2Via2l0QmFja0ZvcndhcmQKICAgICBy ZXR1cm4gbGlzdDsKIH0KIAotdm9pZCB3ZWJraXRCYWNrRm9yd2FyZExpc3RDaGFuZ2VkKFdlYktp dEJhY2tGb3J3YXJkTGlzdCogYmFja0ZvcndhcmRMaXN0LCBXZWJCYWNrRm9yd2FyZExpc3RJdGVt KiB3ZWJBZGRlZEl0ZW0sIFZlY3RvcjxSZWZQdHI8V2ViQmFja0ZvcndhcmRMaXN0SXRlbT4+IHdl YlJlbW92ZWRJdGVtcykKK3ZvaWQgd2Via2l0QmFja0ZvcndhcmRMaXN0Q2hhbmdlZChXZWJLaXRC YWNrRm9yd2FyZExpc3QqIGJhY2tGb3J3YXJkTGlzdCwgV2ViQmFja0ZvcndhcmRMaXN0SXRlbSog d2ViQWRkZWRJdGVtLCBjb25zdCBWZWN0b3I8UmVmUHRyPFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0+ PiYgd2ViUmVtb3ZlZEl0ZW1zKQogewogICAgIFdlYktpdEJhY2tGb3J3YXJkTGlzdEl0ZW0qIGFk ZGVkSXRlbSA9IHdlYmtpdEJhY2tGb3J3YXJkTGlzdEdldE9yQ3JlYXRlSXRlbShiYWNrRm9yd2Fy ZExpc3QsIHdlYkFkZGVkSXRlbSk7CiAgICAgR0xpc3QqIHJlbW92ZWRJdGVtcyA9IG51bGxwdHI7 CiAKICAgICBXZWJLaXRCYWNrRm9yd2FyZExpc3RQcml2YXRlKiBwcml2ID0gYmFja0ZvcndhcmRM aXN0LT5wcml2OwotICAgIGZvciAoY29uc3QgYXV0byYgd2ViSXRlbSA6IHdlYlJlbW92ZWRJdGVt cykgeworICAgIGZvciAoYXV0byYgd2ViSXRlbSA6IHdlYlJlbW92ZWRJdGVtcykgewogICAgICAg ICByZW1vdmVkSXRlbXMgPSBnX2xpc3RfcHJlcGVuZChyZW1vdmVkSXRlbXMsIGdfb2JqZWN0X3Jl Zihwcml2LT5pdGVtc01hcC5nZXQod2ViSXRlbS5nZXQoKSkuZ2V0KCkpKTsKICAgICAgICAgcHJp di0+aXRlbXNNYXAucmVtb3ZlKHdlYkl0ZW0uZ2V0KCkpOwogICAgIH0KSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEJhY2tGb3J3YXJkTGlzdFByaXZhdGUuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRCYWNr Rm9yd2FyZExpc3RQcml2YXRlLmgJKHJldmlzaW9uIDE4MTg0OSkKKysrIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEJhY2tGb3J3YXJkTGlzdFByaXZhdGUuaAkod29ya2lu ZyBjb3B5KQpAQCAtMzIsNiArMzIsNiBAQAogV2ViS2l0QmFja0ZvcndhcmRMaXN0KiB3ZWJraXRC YWNrRm9yd2FyZExpc3RDcmVhdGUoV2ViS2l0OjpXZWJCYWNrRm9yd2FyZExpc3QqKTsKIFdlYktp dEJhY2tGb3J3YXJkTGlzdEl0ZW0qIHdlYmtpdEJhY2tGb3J3YXJkTGlzdEl0ZW1HZXRPckNyZWF0 ZShXZWJLaXQ6OldlYkJhY2tGb3J3YXJkTGlzdEl0ZW0qKTsKIFdlYktpdDo6V2ViQmFja0Zvcndh cmRMaXN0SXRlbSogd2Via2l0QmFja0ZvcndhcmRMaXN0SXRlbUdldEl0ZW0oV2ViS2l0QmFja0Zv cndhcmRMaXN0SXRlbSopOwotdm9pZCB3ZWJraXRCYWNrRm9yd2FyZExpc3RDaGFuZ2VkKFdlYktp dEJhY2tGb3J3YXJkTGlzdCosIFdlYktpdDo6V2ViQmFja0ZvcndhcmRMaXN0SXRlbSogd2ViQWRk ZWRJdGVtLCBWZWN0b3I8UmVmUHRyPFdlYktpdDo6V2ViQmFja0ZvcndhcmRMaXN0SXRlbT4+KTsK K3ZvaWQgd2Via2l0QmFja0ZvcndhcmRMaXN0Q2hhbmdlZChXZWJLaXRCYWNrRm9yd2FyZExpc3Qq LCBXZWJLaXQ6OldlYkJhY2tGb3J3YXJkTGlzdEl0ZW0qIHdlYkFkZGVkSXRlbSwgY29uc3QgVmVj dG9yPFJlZlB0cjxXZWJLaXQ6OldlYkJhY2tGb3J3YXJkTGlzdEl0ZW0+PiYpOwogCiAjZW5kaWYg Ly8gV2ViS2l0QmFja0ZvcndhcmRMaXN0UHJpdmF0ZV9oCg==