142952 2015-03-22 17:32:11 -0700 Fix DO_PROPERTYMAP_CONSTENCY_CHECK enabled build 2015-03-23 13:50:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue fpizlo joepeck oldest_to_newest 1079181 0 joepeck 2015-03-22 17:32:11 -0700 * SUMMARY Build error if you enable DO_PROPERTYMAP_CONSTENCY_CHECK. Also move the #if/#else blocks significantly closer together. 1079182 1 249209 joepeck 2015-03-22 17:37:10 -0700 Created attachment 249209 [PATCH] Proposed Fix Enabled this and ran all LayoutTests/js tests in a Debug build ran with no asserts. 1079183 2 commit-queue 2015-03-22 17:38:43 -0700 Attachment 249209 did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/Structure.cpp:1206: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1079215 3 249209 joepeck 2015-03-22 21:16:05 -0700 Comment on attachment 249209 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=249209&action=review > Source/JavaScriptCore/runtime/Structure.cpp:1206 > +#endif// DO_PROPERTYMAP_CONSTENCY_CHECK Style: Oops. I can update this when landing. 1079307 4 249209 ggaren 2015-03-23 10:56:38 -0700 Comment on attachment 249209 [PATCH] Proposed Fix r=me 1079393 5 joepeck 2015-03-23 13:50:15 -0700 http://trac.webkit.org/changeset/181867 249209 2015-03-22 17:37:10 -0700 2015-03-23 10:56:38 -0700 [PATCH] Proposed Fix fix-build.patch text/plain 2215 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDNiOTgzZDkuLmJkY2NkZmEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAzLTIyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgRml4IERPX1BST1BFUlRZTUFQX0NP TlNURU5DWV9DSEVDSyBlbmFibGVkIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI5NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvU3RydWN0dXJlLmNwcDoKKyAgICAgICAgKEpT Qzo6UHJvcGVydHlUYWJsZTo6Y2hlY2tDb25zaXN0ZW5jeSk6CisgICAgICAgIFRoZSBjaGVjayBv ZmZzZXQgbWV0aG9kIGRvZXNuJ3QgZXhpc3QgaW4gUHJvcGVydHlUYWJsZSwgaXQgZXhpc3RzIGlu IFN0cnVjdHVyZS4KKworICAgICAgICAoSlNDOjpTdHJ1Y3R1cmU6OmNoZWNrQ29uc2lzdGVuY3kp OgorICAgICAgICBTbyBtb3ZlIGl0IGhlcmUsIGFuZCBhbHdheXMgcHV0IGl0IGF0IHRoZSBzdGFy dCB0byBtYXRjaCBub3JtYWwgYmVoYXZpb3IuCisKIDIwMTUtMDMtMjEgIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBDb21wdXRlZCBQcm9wZXJ0eSBuYW1l cyBzaG91bGQgYWxsb3cgb25seSBBc3NpZ25tZW50RXhwcmVzc2lvbnMgbm90IGFueSBFeHByZXNz aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmUu Y3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmNwcAppbmRleCA4 NjljYmM1Li5kM2I2MWU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9TdHJ1Y3R1cmUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVj dHVyZS5jcHAKQEAgLTgyOCwxNSArODI4LDYgQEAgUHJvcGVydHlNYXBTdGF0aXN0aWNzRXhpdExv Z2dlcjo6flByb3BlcnR5TWFwU3RhdGlzdGljc0V4aXRMb2dnZXIoKQogCiAjZW5kaWYKIAotI2lm ICFET19QUk9QRVJUWU1BUF9DT05TVEVOQ1lfQ0hFQ0sKLQotaW5saW5lIHZvaWQgU3RydWN0dXJl OjpjaGVja0NvbnNpc3RlbmN5KCkKLXsKLSAgICBjaGVja09mZnNldENvbnNpc3RlbmN5KCk7Ci19 Ci0KLSNlbmRpZgotCiBQcm9wZXJ0eVRhYmxlKiBTdHJ1Y3R1cmU6OmNvcHlQcm9wZXJ0eVRhYmxl KFZNJiB2bSkKIHsKICAgICBpZiAoIXByb3BlcnR5VGFibGUoKSkKQEAgLTExMzMsNyArMTEyNCw2 IEBAIHZvaWQgU3RydWN0dXJlOjpkdW1wQ29udGV4dEhlYWRlcihQcmludFN0cmVhbSYgb3V0KQog CiB2b2lkIFByb3BlcnR5VGFibGU6OmNoZWNrQ29uc2lzdGVuY3koKQogewotICAgIGNoZWNrT2Zm c2V0Q29uc2lzdGVuY3koKTsKICAgICBBU1NFUlQobV9pbmRleFNpemUgPj0gUHJvcGVydHlUYWJs ZTo6TWluaW11bVRhYmxlU2l6ZSk7CiAgICAgQVNTRVJUKG1faW5kZXhNYXNrKTsKICAgICBBU1NF UlQobV9pbmRleFNpemUgPT0gbV9pbmRleE1hc2sgKyAxKTsKQEAgLTExOTEsNiArMTE4MSw4IEBA IHZvaWQgUHJvcGVydHlUYWJsZTo6Y2hlY2tDb25zaXN0ZW5jeSgpCiAKIHZvaWQgU3RydWN0dXJl OjpjaGVja0NvbnNpc3RlbmN5KCkKIHsKKyAgICBjaGVja09mZnNldENvbnNpc3RlbmN5KCk7CisK ICAgICBpZiAoIXByb3BlcnR5VGFibGUoKSkKICAgICAgICAgcmV0dXJuOwogCkBAIC0xMjA0LDcg KzExOTYsMTQgQEAgdm9pZCBTdHJ1Y3R1cmU6OmNoZWNrQ29uc2lzdGVuY3koKQogICAgIHByb3Bl cnR5VGFibGUoKS0+Y2hlY2tDb25zaXN0ZW5jeSgpOwogfQogCi0jZW5kaWYgLy8gRE9fUFJPUEVS VFlNQVBfQ09OU1RFTkNZX0NIRUNLCisjZWxzZQorCitpbmxpbmUgdm9pZCBTdHJ1Y3R1cmU6OmNo ZWNrQ29uc2lzdGVuY3koKQoreworICAgIGNoZWNrT2Zmc2V0Q29uc2lzdGVuY3koKTsKK30KKwor I2VuZGlmLy8gRE9fUFJPUEVSVFlNQVBfQ09OU1RFTkNZX0NIRUNLCiAKIGJvb2wgQ2xhc3NJbmZv OjpoYXNTdGF0aWNTZXR0ZXJPclJlYWRvbmx5UHJvcGVydGllcygpIGNvbnN0CiB7Cg==