142930 2015-03-20 19:05:09 -0700 Detect when url filter pattern with groups match the empty string 2015-03-22 19:04:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin achristensen oldest_to_newest 1079020 0 benjamin 2015-03-20 19:05:09 -0700 Detect when url filter pattern with groups match the empty string 1079021 1 249156 benjamin 2015-03-20 19:06:53 -0700 Created attachment 249156 Patch 1079194 2 249156 benjamin 2015-03-22 19:04:48 -0700 Comment on attachment 249156 Patch Clearing flags on attachment: 249156 Committed r181840: <http://trac.webkit.org/changeset/181840> 1079195 3 benjamin 2015-03-22 19:04:54 -0700 All reviewed patches have been landed. Closing bug. 249156 2015-03-20 19:06:53 -0700 2015-03-22 19:04:48 -0700 Patch bug-142930-20150320190619.patch text/plain 5892 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTMyNmI2MjQyZDQ4YzQz OTJkNmNhMWE4NWM3YzJiNDYwNTFjNTA1Zi4uZDY4NDg2MzQwMDI2MmI1YzMwYTUxNTExZWQ1ZThm ZjliZGE1MDdlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTAzLTIwICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIERldGVjdCB3aGVu IHVybCBmaWx0ZXIgcGF0dGVybiB3aXRoIGdyb3VwcyBtYXRjaCB0aGUgZW1wdHkgc3RyaW5nCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI5MzAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcHJldmlv dXMgdGVzdCB3YXMgb25seSBhY2NvdW50aW5nIGZvciBzaW1wbGUgYXRvbXMuIFRoaXMgcGF0Y2gg ZXh0ZW5kcworICAgICAgICBpdCB0byBncm91cHMuCisKKyAgICAgICAgKiBjb250ZW50ZXh0ZW5z aW9ucy9VUkxGaWx0ZXJQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGVudEV4dGVu c2lvbnM6OlRlcm06OnF1YW50aWZ5KToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRlbnRFeHRlbnNp b25zOjpUZXJtOjptYXRjaGVzQXRMZWFzdE9uZUNoYXJhY3Rlcik6CisgICAgICAgIChXZWJDb3Jl OjpDb250ZW50RXh0ZW5zaW9uczo6R3JhcGhCdWlsZGVyOjpmaW5hbGl6ZSk6CisgICAgICAgIChX ZWJDb3JlOjpDb250ZW50RXh0ZW5zaW9uczo6VGVybTo6cXVhbnRpZmllcik6IERlbGV0ZWQuCisK IDIwMTUtMDMtMjAgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTiAocjE3OTQyOSk6IFBvdGVudGlhbCBVc2UgYWZ0ZXIgZnJlZSBpbiBK YXZhU2NyaXB0Q29yZWBXVEY6OlN0cmluZ0ltcGw6OnJlZiArIDgzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9jb250ZW50ZXh0ZW5zaW9ucy9VUkxGaWx0ZXJQYXJzZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvY29udGVudGV4dGVuc2lvbnMvVVJMRmlsdGVyUGFyc2VyLmNwcAppbmRleCBhNDg4 ZjdhNmY5MTE0ZGVkZGRiMjU4NDNjNmQxZmJlZDRkM2M1ZWNiLi5kMGZlZjg3M2ZhODFlNWExMTRm MmMyYTUwMTQyN2VmM2YxZTlmZjdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jb250ZW50 ZXh0ZW5zaW9ucy9VUkxGaWx0ZXJQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2NvbnRl bnRleHRlbnNpb25zL1VSTEZpbHRlclBhcnNlci5jcHAKQEAgLTE3NSw3ICsxNzUsNiBAQCBwdWJs aWM6CiAgICAgICAgIEFTU0VSVF9XSVRIX01FU1NBR0UobV9xdWFudGlmaWVyID09IEF0b21RdWFu dGlmaWVyOjpPbmUsICJUcmFuc2l0aW9uIHRvIHF1YW50aWZpZWQgdGVybSBzaG91bGQgb25seSBo YXBwZW4gb25jZS4iKTsKICAgICAgICAgbV9xdWFudGlmaWVyID0gcXVhbnRpZmllcjsKICAgICB9 Ci0gICAgQXRvbVF1YW50aWZpZXIgcXVhbnRpZmllcigpIGNvbnN0IHsgcmV0dXJuIG1fcXVhbnRp ZmllcjsgfQogCiAgICAgdW5zaWduZWQgZ2VuZXJhdGVHcmFwaChORkEmIG5mYSwgdWludDY0X3Qg cGF0dGVybklkLCB1bnNpZ25lZCBzdGFydCkgY29uc3QKICAgICB7CkBAIC0yMjYsNiArMjI1LDI1 IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIG1fdGVybVR5cGUgPT0gVGVybVR5cGU6OkNoYXJh Y3RlclNldCAmJiBtX2F0b21EYXRhLmNoYXJhY3RlclNldC5jaGFyYWN0ZXJzLmJpdENvdW50KCkg PT0gMSAmJiBtX2F0b21EYXRhLmNoYXJhY3RlclNldC5jaGFyYWN0ZXJzLmdldCgwKTsKICAgICB9 CiAKKyAgICBib29sIG1hdGNoZXNBdExlYXN0T25lQ2hhcmFjdGVyKCkgY29uc3QKKyAgICB7Cisg ICAgICAgIEFTU0VSVChpc1ZhbGlkKCkpOworCisgICAgICAgIGlmIChtX3F1YW50aWZpZXIgPT0g QXRvbVF1YW50aWZpZXI6Olplcm9Pck9uZSB8fCBtX3F1YW50aWZpZXIgPT0gQXRvbVF1YW50aWZp ZXI6Olplcm9Pck1vcmUpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIGlmIChp c0VuZE9mTGluZUFzc2VydGlvbigpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAg ICAgIGlmIChtX3Rlcm1UeXBlID09IFRlcm1UeXBlOjpHcm91cCkgeworICAgICAgICAgICAgZm9y IChjb25zdCBUZXJtJiB0ZXJtIDogbV9hdG9tRGF0YS5ncm91cC50ZXJtcykgeworICAgICAgICAg ICAgICAgIGlmICh0ZXJtLm1hdGNoZXNBdExlYXN0T25lQ2hhcmFjdGVyKCkpCisgICAgICAgICAg ICAgICAgICAgIHJldHVybiB0cnVlOworICAgICAgICAgICAgfQorICAgICAgICAgICAgcmV0dXJu IGZhbHNlOworICAgICAgICB9CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKwogICAgIFRl cm0mIG9wZXJhdG9yPShjb25zdCBUZXJtJiBvdGhlcikKICAgICB7CiAgICAgICAgIGRlc3Ryb3ko KTsKQEAgLTQ0NCw3ICs0NjIsNyBAQCBwdWJsaWM6CiAgICAgICAgIC8vIENoZWNrIHRvIHNlZSBp ZiB0aGVyZSBhcmUgYW55IHRlcm1zIHdpdGhvdXQgPyBvciAqLgogICAgICAgICBib29sIG1hdGNo ZXNFdmVyeXRoaW5nID0gdHJ1ZTsKICAgICAgICAgZm9yIChjb25zdCBhdXRvJiB0ZXJtIDogbV9z dW5rVGVybXMpIHsKLSAgICAgICAgICAgIGlmICh0ZXJtLnF1YW50aWZpZXIoKSA9PSBBdG9tUXVh bnRpZmllcjo6T25lIHx8IHRlcm0ucXVhbnRpZmllcigpID09IEF0b21RdWFudGlmaWVyOjpPbmVP ck1vcmUpIHsKKyAgICAgICAgICAgIGlmICh0ZXJtLm1hdGNoZXNBdExlYXN0T25lQ2hhcmFjdGVy KCkpIHsKICAgICAgICAgICAgICAgICBtYXRjaGVzRXZlcnl0aGluZyA9IGZhbHNlOwogICAgICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdl TG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDM5YjIyMWE4ZThhNDU5ZDhmNTAyOWMzOTdjMzRh NTJhMTcyNjJkMWQuLjZmMjMyZmQxNzFjNjRhOGJjNmE5NDcxYTgyZDBhZjFkNTQ3NjFkNmUgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMiBAQAorMjAxNS0wMy0yMCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNv bT4KKworICAgICAgICBEZXRlY3Qgd2hlbiB1cmwgZmlsdGVyIHBhdHRlcm4gd2l0aCBncm91cHMg bWF0Y2ggdGhlIGVtcHR5IHN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQyOTMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvQ29udGVudEV4dGVu c2lvbnMuY3BwOgorCiAyMDE1LTAzLTIwICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUu Y29tPgogCiAgICAgICAgIFtXaW5dIFRlbXBvcmFyaWx5IHR1cm4gb2YgRVdTIFdpbmRvd3MgdGVz dHMgd2hpbGUgSSBkZWJ1ZyB0aGUgdGVzdCBmYWlsdXJlLgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL0NvbnRlbnRFeHRlbnNpb25zLmNwcCBiL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9Db250ZW50RXh0ZW5zaW9ucy5jcHAKaW5kZXggZTlm NjQ5OThlODk5NGE1OWIyYzhhYjQ0MzE4NTVlOTkzNGQzZGVlNS4uNDExYWFiMGJmNTJjN2YyZTg1 MGRlYjEyOTY2ZTc4NzkxMTJmNWQyNyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJDb3JlL0NvbnRlbnRFeHRlbnNpb25zLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYkNvcmUvQ29udGVudEV4dGVuc2lvbnMuY3BwCkBAIC00MDQsNCArNDA0LDMw IEBAIFRFU1RfRihDb250ZW50RXh0ZW5zaW9uVGVzdCwgUGFyc2luZ0ZhaWx1cmVzKQogICAgIHRl c3RQYXR0ZXJuU3RhdHVzKCIoYSlcXDEiLCBDb250ZW50RXh0ZW5zaW9uczo6VVJMRmlsdGVyUGFy c2VyOjpQYXJzZVN0YXR1czo6T2spOyAvLyBUaGlzIHNob3VsZCBiZSBCYWNrUmVmZXJlbmNlLCBy aWdodD8KIH0KIAorVEVTVF9GKENvbnRlbnRFeHRlbnNpb25UZXN0LCBQYXR0ZXJuTWF0Y2hpbmdU aGVFbXB0eVN0cmluZykKK3sKKyAgICAvLyBTaW1wbGUgYXRvbXMuCisgICAgdGVzdFBhdHRlcm5T dGF0dXMoIi4qIiwgQ29udGVudEV4dGVuc2lvbnM6OlVSTEZpbHRlclBhcnNlcjo6UGFyc2VTdGF0 dXM6Ok1hdGNoZXNFdmVyeXRoaW5nKTsKKyAgICB0ZXN0UGF0dGVyblN0YXR1cygiYSoiLCBDb250 ZW50RXh0ZW5zaW9uczo6VVJMRmlsdGVyUGFyc2VyOjpQYXJzZVN0YXR1czo6TWF0Y2hlc0V2ZXJ5 dGhpbmcpOworICAgIHRlc3RQYXR0ZXJuU3RhdHVzKCIuPyIsIENvbnRlbnRFeHRlbnNpb25zOjpV UkxGaWx0ZXJQYXJzZXI6OlBhcnNlU3RhdHVzOjpNYXRjaGVzRXZlcnl0aGluZyk7CisgICAgdGVz dFBhdHRlcm5TdGF0dXMoImE/IiwgQ29udGVudEV4dGVuc2lvbnM6OlVSTEZpbHRlclBhcnNlcjo6 UGFyc2VTdGF0dXM6Ok1hdGNoZXNFdmVyeXRoaW5nKTsKKworICAgIC8vIENoYXJhY3RlciBzZXRz LgorICAgIHRlc3RQYXR0ZXJuU3RhdHVzKCJbYS16XSoiLCBDb250ZW50RXh0ZW5zaW9uczo6VVJM RmlsdGVyUGFyc2VyOjpQYXJzZVN0YXR1czo6TWF0Y2hlc0V2ZXJ5dGhpbmcpOworICAgIHRlc3RQ YXR0ZXJuU3RhdHVzKCJbYS16XT8iLCBDb250ZW50RXh0ZW5zaW9uczo6VVJMRmlsdGVyUGFyc2Vy OjpQYXJzZVN0YXR1czo6TWF0Y2hlc0V2ZXJ5dGhpbmcpOworCisgICAgLy8gR3JvdXBzLgorICAg IHRlc3RQYXR0ZXJuU3RhdHVzKCIoZm9vYmFyKSoiLCBDb250ZW50RXh0ZW5zaW9uczo6VVJMRmls dGVyUGFyc2VyOjpQYXJzZVN0YXR1czo6TWF0Y2hlc0V2ZXJ5dGhpbmcpOworICAgIHRlc3RQYXR0 ZXJuU3RhdHVzKCIoZm9vYmFyKT8iLCBDb250ZW50RXh0ZW5zaW9uczo6VVJMRmlsdGVyUGFyc2Vy OjpQYXJzZVN0YXR1czo6TWF0Y2hlc0V2ZXJ5dGhpbmcpOworICAgIHRlc3RQYXR0ZXJuU3RhdHVz KCIoLiopIiwgQ29udGVudEV4dGVuc2lvbnM6OlVSTEZpbHRlclBhcnNlcjo6UGFyc2VTdGF0dXM6 Ok1hdGNoZXNFdmVyeXRoaW5nKTsKKyAgICB0ZXN0UGF0dGVyblN0YXR1cygiKGEqKSIsIENvbnRl bnRFeHRlbnNpb25zOjpVUkxGaWx0ZXJQYXJzZXI6OlBhcnNlU3RhdHVzOjpNYXRjaGVzRXZlcnl0 aGluZyk7CisgICAgdGVzdFBhdHRlcm5TdGF0dXMoIiguPykiLCBDb250ZW50RXh0ZW5zaW9uczo6 VVJMRmlsdGVyUGFyc2VyOjpQYXJzZVN0YXR1czo6TWF0Y2hlc0V2ZXJ5dGhpbmcpOworICAgIHRl c3RQYXR0ZXJuU3RhdHVzKCIoYT8pIiwgQ29udGVudEV4dGVuc2lvbnM6OlVSTEZpbHRlclBhcnNl cjo6UGFyc2VTdGF0dXM6Ok1hdGNoZXNFdmVyeXRoaW5nKTsKKyAgICB0ZXN0UGF0dGVyblN0YXR1 cygiKFthLXpdKikiLCBDb250ZW50RXh0ZW5zaW9uczo6VVJMRmlsdGVyUGFyc2VyOjpQYXJzZVN0 YXR1czo6TWF0Y2hlc0V2ZXJ5dGhpbmcpOworICAgIHRlc3RQYXR0ZXJuU3RhdHVzKCIoW2Etel0/ KSIsIENvbnRlbnRFeHRlbnNpb25zOjpVUkxGaWx0ZXJQYXJzZXI6OlBhcnNlU3RhdHVzOjpNYXRj aGVzRXZlcnl0aGluZyk7CisKKyAgICAvLyBOZXN0ZWQgZ3JvdXBzLgorICAgIHRlc3RQYXR0ZXJu U3RhdHVzKCIoKGZvbyk/KCguKSopKGJhcikqKSIsIENvbnRlbnRFeHRlbnNpb25zOjpVUkxGaWx0 ZXJQYXJzZXI6OlBhcnNlU3RhdHVzOjpNYXRjaGVzRXZlcnl0aGluZyk7Cit9CisKIH0gLy8gbmFt ZXNwYWNlIFRlc3RXZWJLaXRBUEkK