142909 2015-03-20 06:06:41 -0700 [EFL][GTK] WebKit2's generate-forwarding-headers.pl should fail if clashing headers found 2015-03-30 06:18:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 142907 1 ossy ossy cgarcia commit-queue gyuyoung.kim mrobinson ossy pnormand zan oldest_to_newest 1078845 0 ossy 2015-03-20 06:06:41 -0700 Long time ago clashing headers caused race conditon, which is absolutely undesirable. Build system must be deterministic. And then http://trac.webkit.org/changeset/79544 introduced a workaround for handling clashing headers, because Qt added a clashing header. But now there is no Qt and no clashing header and I don't think if we should prefer one from clashing headers, but exit with error to force the renaming. Its sideeffect will be to be able to fix bug142907 easier. :) 1078846 1 249110 ossy 2015-03-20 06:10:36 -0700 Created attachment 249110 Patch 1080257 2 249483 ossy 2015-03-26 04:31:22 -0700 Created attachment 249483 Patch updataed to ToT 1081135 3 249483 ossy 2015-03-30 05:25:25 -0700 Comment on attachment 249483 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249483&action=review > Source/WebKit2/Scripts/generate-forwarding-headers.pl:101 > + # If we found more headers with the same name, exit immediately. > + my @headers = grep($_ =~ "/$headerName\$", @frameworkHeaders); > + if (@headers != 1) { > + print("ERROR: Can't create $headerName forwarding header, because there are more headers with the same name:\n"); > + foreach (@headers) { print " - $_\n" }; > + die(); Ping for review? It is so simple patch, only this part changed, the other parts are only whitespace changes due to indentation. 1081147 4 249483 commit-queue 2015-03-30 06:18:42 -0700 Comment on attachment 249483 Patch Clearing flags on attachment: 249483 Committed r182138: <http://trac.webkit.org/changeset/182138> 1081148 5 commit-queue 2015-03-30 06:18:47 -0700 All reviewed patches have been landed. Closing bug. 249110 2015-03-20 06:10:36 -0700 2015-03-26 04:31:16 -0700 Patch bug-142909-20150320061002.patch text/plain 3503 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxODAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDkwYTVjZDI5OWM4Yzdi M2Q5NmFiYWQyZWRhY2Y2ZDRlMmNjZTA4ZC4uOGYyNzQ1NzM5YWU3NzI0MGM5NGZhODZlMTA1ZTEz Mjk0MjAzMWVhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTAzLTIwICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0VGTF1bR1RLXSBX ZWJLaXQyJ3MgZ2VuZXJhdGUtZm9yd2FyZGluZy1oZWFkZXJzLnBsIHNob3VsZCBmYWlsIGlmIGNs YXNoaW5nIGhlYWRlcnMgZm91bmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0MjkwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGw6Cisg ICAgICAgIChjcmVhdGVGb3J3YXJkaW5nSGVhZGVyc0ZvckZyYW1ld29yayk6CisKIDIwMTUtMDMt MjAgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBb Q01ha2VdIFJlbW92ZSBkdXBsaWNhdGVkIGNtYWtlIGZ1bmN0aW9uIGNhbGxzIGluIFdlYktpdDIv Q01ha2VMaXN0cy50eHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvZ2VuZXJh dGUtZm9yd2FyZGluZy1oZWFkZXJzLnBsIGIvU291cmNlL1dlYktpdDIvU2NyaXB0cy9nZW5lcmF0 ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwKaW5kZXggNjc4ZTA4Mzg0ZDhkY2IzYzE1NzAwMzVmYWI5 YzIyMjMxNzM0YzRkNy4uYzE0OTQxODZlNWViYzM1MmY0NDY5ZDE2NTMwMWE3NzJiMzg4MjcyNSAx MDA3NTUKLS0tIGEvU291cmNlL1dlYktpdDIvU2NyaXB0cy9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhl YWRlcnMucGwKKysrIGIvU291cmNlL1dlYktpdDIvU2NyaXB0cy9nZW5lcmF0ZS1mb3J3YXJkaW5n LWhlYWRlcnMucGwKQEAgLTkyLDIzICs5MiwyOCBAQCBzdWIgY3JlYXRlRm9yd2FyZGluZ0hlYWRl cnNGb3JGcmFtZXdvcmsgewogICAgIGZvcmVhY2ggbXkgJGhlYWRlciAoQGZyYW1ld29ya0hlYWRl cnMpIHsKICAgICAgICAgbXkgJGhlYWRlck5hbWUgPSBiYXNlbmFtZSgkaGVhZGVyKTsKIAotICAg ICAgICAjIElmIHdlIGZvdW5kIG1vcmUgaGVhZGVycyB3aXRoIHRoZSBzYW1lIG5hbWUsIG9ubHkg Z2VuZXJhdGUgYSBmb3J3YXJkaW5nIGhlYWRlciBmb3IgdGhlIGN1cnJlbnQgcGxhdGZvcm0KLSAg ICAgICAgaWYoZ3JlcCgkXyA9fiAiLyRoZWFkZXJOYW1lXCQiLCBAZnJhbWV3b3JrSGVhZGVycykg PT0gMSB8fCAkaGVhZGVyID1+ICIvJHBsYXRmb3JtLyIgKSB7Ci0gICAgICAgICAgICBteSAkZm9y d2FyZGluZ0hlYWRlclBhdGggPSBGaWxlOjpTcGVjLT5jYXRmaWxlKCR0YXJnZXREaXJlY3Rvcnks ICRoZWFkZXJOYW1lKTsKLSAgICAgICAgICAgIG15ICRleHBlY3RlZEluY2x1ZGVTdGF0ZW1lbnQg PSAiI2luY2x1ZGUgXCIkZnJhbWV3b3JrRGlyZWN0b3J5TmFtZS8kaGVhZGVyXCIiOwotICAgICAg ICAgICAgbXkgJGZvdW5kSW5jbHVkZVN0YXRlbWVudCA9IDA7CisgICAgICAgICMgSWYgd2UgZm91 bmQgbW9yZSBoZWFkZXJzIHdpdGggdGhlIHNhbWUgbmFtZSwgZXhpdCBpbW1lZGlhdGVseS4KKyAg ICAgICAgbXkgQGhlYWRlcnMgPSBncmVwKCRfID1+ICIvJGhlYWRlck5hbWVcJCIsIEBmcmFtZXdv cmtIZWFkZXJzKTsKKyAgICAgICAgaWYgKEBoZWFkZXJzICE9IDEpIHsKKyAgICAgICAgICAgIHBy aW50KCJFUlJPUjogQ2FuJ3QgY3JlYXRlICRoZWFkZXJOYW1lIGZvcndhcmRpbmcgaGVhZGVyLCBi ZWNhdXNlIHRoZXJlIGFyZSBtb3JlIGhlYWRlcnMgd2l0aCB0aGUgc2FtZSBuYW1lOlxuIik7Cisg ICAgICAgICAgICBmb3JlYWNoIChAaGVhZGVycykgeyBwcmludCAiIC0gJF9cbiIgfTsKKyAgICAg ICAgICAgIGRpZSgpOworICAgICAgICB9CiAKLSAgICAgICAgICAgICRmb3VuZEluY2x1ZGVTdGF0 ZW1lbnQgPSA8RVhJU1RJTkdfSEVBREVSPiBpZiBvcGVuKEVYSVNUSU5HX0hFQURFUiwgIjwkZm9y d2FyZGluZ0hlYWRlclBhdGgiKTsKLSAgICAgICAgICAgIGNob21wKCRmb3VuZEluY2x1ZGVTdGF0 ZW1lbnQpOworICAgICAgICBteSAkZm9yd2FyZGluZ0hlYWRlclBhdGggPSBGaWxlOjpTcGVjLT5j YXRmaWxlKCR0YXJnZXREaXJlY3RvcnksICRoZWFkZXJOYW1lKTsKKyAgICAgICAgbXkgJGV4cGVj dGVkSW5jbHVkZVN0YXRlbWVudCA9ICIjaW5jbHVkZSBcIiRmcmFtZXdvcmtEaXJlY3RvcnlOYW1l LyRoZWFkZXJcIiI7CisgICAgICAgIG15ICRmb3VuZEluY2x1ZGVTdGF0ZW1lbnQgPSAwOwogCi0g ICAgICAgICAgICBpZiAoISAkZm91bmRJbmNsdWRlU3RhdGVtZW50IHx8ICRmb3VuZEluY2x1ZGVT dGF0ZW1lbnQgbmUgJGV4cGVjdGVkSW5jbHVkZVN0YXRlbWVudCkgewotICAgICAgICAgICAgICAg IHByaW50ICJbQ3JlYXRpbmcgZm9yd2FyZGluZyBoZWFkZXIgZm9yICRmcmFtZXdvcmsvJGhlYWRl cl1cbiI7Ci0gICAgICAgICAgICAgICAgb3BlbihGT1JXQVJESU5HX0hFQURFUiwgIj4kZm9yd2Fy ZGluZ0hlYWRlclBhdGgiKSBvciBkaWUgIkNvdWxkIG5vdCBvcGVuICRmb3J3YXJkaW5nSGVhZGVy UGF0aC4iOwotICAgICAgICAgICAgICAgIHByaW50IEZPUldBUkRJTkdfSEVBREVSICIkZXhwZWN0 ZWRJbmNsdWRlU3RhdGVtZW50XG4iOwotICAgICAgICAgICAgICAgIGNsb3NlKEZPUldBUkRJTkdf SEVBREVSKTsKLSAgICAgICAgICAgIH0KKyAgICAgICAgJGZvdW5kSW5jbHVkZVN0YXRlbWVudCA9 IDxFWElTVElOR19IRUFERVI+IGlmIG9wZW4oRVhJU1RJTkdfSEVBREVSLCAiPCRmb3J3YXJkaW5n SGVhZGVyUGF0aCIpOworICAgICAgICBjaG9tcCgkZm91bmRJbmNsdWRlU3RhdGVtZW50KTsKIAot ICAgICAgICAgICAgY2xvc2UoRVhJU1RJTkdfSEVBREVSKTsKKyAgICAgICAgaWYgKCEgJGZvdW5k SW5jbHVkZVN0YXRlbWVudCB8fCAkZm91bmRJbmNsdWRlU3RhdGVtZW50IG5lICRleHBlY3RlZElu Y2x1ZGVTdGF0ZW1lbnQpIHsKKyAgICAgICAgICAgIHByaW50ICJbQ3JlYXRpbmcgZm9yd2FyZGlu ZyBoZWFkZXIgZm9yICRmcmFtZXdvcmsvJGhlYWRlcl1cbiI7CisgICAgICAgICAgICBvcGVuKEZP UldBUkRJTkdfSEVBREVSLCAiPiRmb3J3YXJkaW5nSGVhZGVyUGF0aCIpIG9yIGRpZSAiQ291bGQg bm90IG9wZW4gJGZvcndhcmRpbmdIZWFkZXJQYXRoLiI7CisgICAgICAgICAgICBwcmludCBGT1JX QVJESU5HX0hFQURFUiAiJGV4cGVjdGVkSW5jbHVkZVN0YXRlbWVudFxuIjsKKyAgICAgICAgICAg IGNsb3NlKEZPUldBUkRJTkdfSEVBREVSKTsKICAgICAgICAgfQorCisgICAgICAgIGNsb3NlKEVY SVNUSU5HX0hFQURFUik7CiAgICAgfQogfQo= 249483 2015-03-26 04:31:22 -0700 2015-03-30 06:18:42 -0700 Patch bug-142909-20150326043044.patch text/plain 3491 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyMDA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOGEzMmM2YzljMmI3MTI0 YjM2NTgyOTM2NGViYmY1N2NmNzg3NDk1ZS4uZmNmNjNjMTIxZjk4YzMxM2UyZWQ3OTNiMWI2ODYx YWMwMzQwMTU0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTAzLTI2ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0VGTF1bR1RLXSBX ZWJLaXQyJ3MgZ2VuZXJhdGUtZm9yd2FyZGluZy1oZWFkZXJzLnBsIHNob3VsZCBmYWlsIGlmIGNs YXNoaW5nIGhlYWRlcnMgZm91bmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0MjkwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGw6Cisg ICAgICAgIChjcmVhdGVGb3J3YXJkaW5nSGVhZGVyc0ZvckZyYW1ld29yayk6CisKIDIwMTUtMDMt MjYgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIEF2b2lk IHRoZSBWZWN0b3I8PiBjb3B5IGluIFdlYlRvdWNoRXZlbnQgY29uc3RydWN0b3IKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvZ2VuZXJhdGUtZm9yd2FyZGluZy1oZWFkZXJzLnBs IGIvU291cmNlL1dlYktpdDIvU2NyaXB0cy9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwK aW5kZXggMzBmNWVjZGMyMmQyYzc0ZDVhZGNjNzU4YWIyYWYzMjliZmEwNWFiYy4uZTcxYTlhMzJk YWNlNGUzZmEwZWU1Zjk1MTFiYTYyZDBlNmE2YTY3NiAxMDA3NTUKLS0tIGEvU291cmNlL1dlYktp dDIvU2NyaXB0cy9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwKKysrIGIvU291cmNlL1dl YktpdDIvU2NyaXB0cy9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwKQEAgLTkzLDIzICs5 MywyOCBAQCBzdWIgY3JlYXRlRm9yd2FyZGluZ0hlYWRlcnNGb3JGcmFtZXdvcmsgewogICAgIGZv cmVhY2ggbXkgJGhlYWRlciAoQGZyYW1ld29ya0hlYWRlcnMpIHsKICAgICAgICAgbXkgJGhlYWRl ck5hbWUgPSBiYXNlbmFtZSgkaGVhZGVyKTsKIAotICAgICAgICAjIElmIHdlIGZvdW5kIG1vcmUg aGVhZGVycyB3aXRoIHRoZSBzYW1lIG5hbWUsIG9ubHkgZ2VuZXJhdGUgYSBmb3J3YXJkaW5nIGhl YWRlciBmb3IgdGhlIGN1cnJlbnQgcGxhdGZvcm0KLSAgICAgICAgaWYoZ3JlcCgkXyA9fiAiLyRo ZWFkZXJOYW1lXCQiLCBAZnJhbWV3b3JrSGVhZGVycykgPT0gMSB8fCAkaGVhZGVyID1+ICIvJHBs YXRmb3JtLyIgKSB7Ci0gICAgICAgICAgICBteSAkZm9yd2FyZGluZ0hlYWRlclBhdGggPSBGaWxl OjpTcGVjLT5jYXRmaWxlKCR0YXJnZXREaXJlY3RvcnksICRoZWFkZXJOYW1lKTsKLSAgICAgICAg ICAgIG15ICRleHBlY3RlZEluY2x1ZGVTdGF0ZW1lbnQgPSAiI2luY2x1ZGUgXCIkZnJhbWV3b3Jr RGlyZWN0b3J5TmFtZS8kaGVhZGVyXCIiOwotICAgICAgICAgICAgbXkgJGZvdW5kSW5jbHVkZVN0 YXRlbWVudCA9IDA7CisgICAgICAgICMgSWYgd2UgZm91bmQgbW9yZSBoZWFkZXJzIHdpdGggdGhl IHNhbWUgbmFtZSwgZXhpdCBpbW1lZGlhdGVseS4KKyAgICAgICAgbXkgQGhlYWRlcnMgPSBncmVw KCRfID1+ICIvJGhlYWRlck5hbWVcJCIsIEBmcmFtZXdvcmtIZWFkZXJzKTsKKyAgICAgICAgaWYg KEBoZWFkZXJzICE9IDEpIHsKKyAgICAgICAgICAgIHByaW50KCJFUlJPUjogQ2FuJ3QgY3JlYXRl ICRoZWFkZXJOYW1lIGZvcndhcmRpbmcgaGVhZGVyLCBiZWNhdXNlIHRoZXJlIGFyZSBtb3JlIGhl YWRlcnMgd2l0aCB0aGUgc2FtZSBuYW1lOlxuIik7CisgICAgICAgICAgICBmb3JlYWNoIChAaGVh ZGVycykgeyBwcmludCAiIC0gJF9cbiIgfTsKKyAgICAgICAgICAgIGRpZSgpOworICAgICAgICB9 CiAKLSAgICAgICAgICAgICRmb3VuZEluY2x1ZGVTdGF0ZW1lbnQgPSA8RVhJU1RJTkdfSEVBREVS PiBpZiBvcGVuKEVYSVNUSU5HX0hFQURFUiwgIjwkZm9yd2FyZGluZ0hlYWRlclBhdGgiKTsKLSAg ICAgICAgICAgIGNob21wKCRmb3VuZEluY2x1ZGVTdGF0ZW1lbnQpOworICAgICAgICBteSAkZm9y d2FyZGluZ0hlYWRlclBhdGggPSBGaWxlOjpTcGVjLT5jYXRmaWxlKCR0YXJnZXREaXJlY3Rvcnks ICRoZWFkZXJOYW1lKTsKKyAgICAgICAgbXkgJGV4cGVjdGVkSW5jbHVkZVN0YXRlbWVudCA9ICIj aW5jbHVkZSBcIiRmcmFtZXdvcmtEaXJlY3RvcnlOYW1lLyRoZWFkZXJcIiI7CisgICAgICAgIG15 ICRmb3VuZEluY2x1ZGVTdGF0ZW1lbnQgPSAwOwogCi0gICAgICAgICAgICBpZiAoISAkZm91bmRJ bmNsdWRlU3RhdGVtZW50IHx8ICRmb3VuZEluY2x1ZGVTdGF0ZW1lbnQgbmUgJGV4cGVjdGVkSW5j bHVkZVN0YXRlbWVudCkgewotICAgICAgICAgICAgICAgIHByaW50ICJbQ3JlYXRpbmcgZm9yd2Fy ZGluZyBoZWFkZXIgZm9yICRmcmFtZXdvcmsvJGhlYWRlcl1cbiIgaWYgJHZlcmJvc2U7Ci0gICAg ICAgICAgICAgICAgb3BlbihGT1JXQVJESU5HX0hFQURFUiwgIj4kZm9yd2FyZGluZ0hlYWRlclBh dGgiKSBvciBkaWUgIkNvdWxkIG5vdCBvcGVuICRmb3J3YXJkaW5nSGVhZGVyUGF0aC4iOwotICAg ICAgICAgICAgICAgIHByaW50IEZPUldBUkRJTkdfSEVBREVSICIkZXhwZWN0ZWRJbmNsdWRlU3Rh dGVtZW50XG4iOwotICAgICAgICAgICAgICAgIGNsb3NlKEZPUldBUkRJTkdfSEVBREVSKTsKLSAg ICAgICAgICAgIH0KKyAgICAgICAgJGZvdW5kSW5jbHVkZVN0YXRlbWVudCA9IDxFWElTVElOR19I RUFERVI+IGlmIG9wZW4oRVhJU1RJTkdfSEVBREVSLCAiPCRmb3J3YXJkaW5nSGVhZGVyUGF0aCIp OworICAgICAgICBjaG9tcCgkZm91bmRJbmNsdWRlU3RhdGVtZW50KTsKIAotICAgICAgICAgICAg Y2xvc2UoRVhJU1RJTkdfSEVBREVSKTsKKyAgICAgICAgaWYgKCEgJGZvdW5kSW5jbHVkZVN0YXRl bWVudCB8fCAkZm91bmRJbmNsdWRlU3RhdGVtZW50IG5lICRleHBlY3RlZEluY2x1ZGVTdGF0ZW1l bnQpIHsKKyAgICAgICAgICAgIHByaW50ICJbQ3JlYXRpbmcgZm9yd2FyZGluZyBoZWFkZXIgZm9y ICRmcmFtZXdvcmsvJGhlYWRlcl1cbiI7CisgICAgICAgICAgICBvcGVuKEZPUldBUkRJTkdfSEVB REVSLCAiPiRmb3J3YXJkaW5nSGVhZGVyUGF0aCIpIG9yIGRpZSAiQ291bGQgbm90IG9wZW4gJGZv cndhcmRpbmdIZWFkZXJQYXRoLiI7CisgICAgICAgICAgICBwcmludCBGT1JXQVJESU5HX0hFQURF UiAiJGV4cGVjdGVkSW5jbHVkZVN0YXRlbWVudFxuIjsKKyAgICAgICAgICAgIGNsb3NlKEZPUldB UkRJTkdfSEVBREVSKTsKICAgICAgICAgfQorCisgICAgICAgIGNsb3NlKEVYSVNUSU5HX0hFQURF Uik7CiAgICAgfQogfQo=