142886 2015-03-19 17:22:22 -0700 Add support for deleting individual cache entries 2015-03-19 18:37:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 1078693 0 andersca 2015-03-19 17:22:22 -0700 Add support for deleting individual cache entries 1078694 1 249072 andersca 2015-03-19 17:26:40 -0700 Created attachment 249072 Patch 1078695 2 commit-queue 2015-03-19 17:29:37 -0700 Attachment 249072 did not pass style-queue: ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:368: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1078698 3 249072 koivisto 2015-03-19 17:49:34 -0700 Comment on attachment 249072 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249072&action=review > Source/WebKit2/NetworkProcess/NetworkProcess.cpp:370 > +static void clearDiskCacheEntries(const Vector<SecurityOriginData>& origins, std::function<void ()> completionHandler) > +{ > +#if ENABLE(NETWORK_CACHE) Maybe we should at some point just move this code within the NetworkCache? 1078708 4 andersca 2015-03-19 18:37:51 -0700 Committed r181775: <http://trac.webkit.org/changeset/181775> 249072 2015-03-19 17:26:40 -0700 2015-03-19 17:49:34 -0700 Patch bug-142886-20150319172608.patch text/plain 4134 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNzU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2FmNTQyZTk5MTc4YWI4 ZDkxNzE3ZTkzYTc1ZTFhMTgzNTllNGZjMC4uOTI4M2MwYTk0NWIxNzJlZDU5ZDdhYmU1MjEzYTQ2 OTgyMzZjYTEwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE1LTAzLTE5ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgQWRkIHN1cHBvcnQg Zm9yIGRlbGV0aW5nIGluZGl2aWR1YWwgY2FjaGUgZW50cmllcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyODg2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJv Y2Vzcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OmZldGNoRGlza0NhY2hlRW50cmllcyk6CisgICAg ICAgIFJlbW92ZSBhbiB1bm5lY2Vzc2FyeSBjYWxsIHRvIGNmVVJMQ2FjaGVPcmlnaW5zKCkuCisK KyAgICAgICAgKFdlYktpdDo6Y2xlYXJEaXNrQ2FjaGVFbnRyaWVzKToKKyAgICAgICAgSGVscGVy IGZ1bmN0aW9uIGZvciBjbGVhcmluZyBkaXNrIGNhY2hlIGVudHJpZXMuIFRoaXMgaGFuZGxlcyBi b3RoIHRoZSBvbGQgYW5kIG5ldyBjYWNoZSBpbXBsZW1lbnRhdGlvbnMuCisKKyAgICAgICAgKFdl YktpdDo6TmV0d29ya1Byb2Nlc3M6OmRlbGV0ZVdlYnNpdGVEYXRhRm9yT3JpZ2lucyk6CisgICAg ICAgIENhbGwgY2xlYXJEaXNrQ2FjaGVFbnRyaWVzIGlmIG5lZWRlZC4KKworMjAxNS0wMy0xOSAg QW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIENhY2hlOjpy ZW1vdmUgc2hvdWxkIHRha2UgYSBLZXkgaW5zdGVhZCBvZiBhbiBlbnRyeQogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyODc4CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcAppbmRleCBkYWZiNmY4 NjJhOGRhZTU1MmE3M2EzYmJlMGY0MzQ0ZGY3ZWYwMzQ2Li40ZTQ5MTRiNWU4NTY3YmJiODI4ZDg5 NWY0Y2I3ZTY1ODA4NjQ5MjhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJv Y2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3MvTmV0d29ya1Byb2Nlc3MuY3BwCkBAIC0yOTcsNyArMjk3LDYgQEAgc3RhdGljIHZvaWQgZmV0 Y2hEaXNrQ2FjaGVFbnRyaWVzKFNlc3Npb25JRCBzZXNzaW9uSUQsIHN0ZDo6ZnVuY3Rpb248dm9p ZCAoVmVjdG8KICAgICBWZWN0b3I8V2Vic2l0ZURhdGE6OkVudHJ5PiBlbnRyaWVzOwogCiAjaWYg VVNFKENGVVJMQ0FDSEUpCi0gICAgYXV0byBvcmlnaW5zID0gY2ZVUkxDYWNoZU9yaWdpbnMoKTsK ICAgICBmb3IgKGF1dG8mIG9yaWdpbiA6IGNmVVJMQ2FjaGVPcmlnaW5zKCkpCiAgICAgICAgIGVu dHJpZXMuYXBwZW5kKFdlYnNpdGVEYXRhOjpFbnRyeSB7IFdURjo6bW92ZShvcmlnaW4pLCBXZWJz aXRlRGF0YVR5cGVEaXNrQ2FjaGUgfSk7CiAjZW5kaWYKQEAgLTM2Niw2ICszNjUsNTIgQEAgdm9p ZCBOZXR3b3JrUHJvY2Vzczo6ZGVsZXRlV2Vic2l0ZURhdGEoU2Vzc2lvbklEIHNlc3Npb25JRCwg dWludDY0X3Qgd2Vic2l0ZURhdGEKICAgICBjb21wbGV0aW9uSGFuZGxlcigpOwogfQogCitzdGF0 aWMgdm9pZCBjbGVhckRpc2tDYWNoZUVudHJpZXMoY29uc3QgVmVjdG9yPFNlY3VyaXR5T3JpZ2lu RGF0YT4mIG9yaWdpbnMsIHN0ZDo6ZnVuY3Rpb248dm9pZCAoKT4gY29tcGxldGlvbkhhbmRsZXIp Cit7CisjaWYgRU5BQkxFKE5FVFdPUktfQ0FDSEUpCisgICAgaWYgKE5ldHdvcmtDYWNoZTo6c2lu Z2xldG9uKCkuaXNFbmFibGVkKCkpIHsKKyAgICAgICAgYXV0byogb3JpZ2luc1RvRGVsZXRlID0g bmV3IEhhc2hTZXQ8UmVmUHRyPFNlY3VyaXR5T3JpZ2luPj4oKTsKKworICAgICAgICBmb3IgKGF1 dG8mIG9yaWdpbiA6IG9yaWdpbnMpCisgICAgICAgICAgICBvcmlnaW5zVG9EZWxldGUtPmFkZChv cmlnaW4uc2VjdXJpdHlPcmlnaW4oKSk7CisKKyAgICAgICAgYXV0byogY2FjaGVLZXlzVG9EZWxl dGUgPSBuZXcgVmVjdG9yPE5ldHdvcmtDYWNoZTo6S2V5PjsKKworICAgICAgICBOZXR3b3JrQ2Fj aGU6OnNpbmdsZXRvbigpLnRyYXZlcnNlKFtjb21wbGV0aW9uSGFuZGxlciwgb3JpZ2luc1RvRGVs ZXRlLCBjYWNoZUtleXNUb0RlbGV0ZV0oY29uc3QgTmV0d29ya0NhY2hlOjpFbnRyeSAqZW50cnkp IHsKKworICAgICAgICAgICAgaWYgKGVudHJ5KSB7CisgICAgICAgICAgICAgICAgaWYgKG9yaWdp bnNUb0RlbGV0ZS0+Y29udGFpbnMoU2VjdXJpdHlPcmlnaW46OmNyZWF0ZShlbnRyeS0+cmVzcG9u c2UudXJsKCkpKSkKKyAgICAgICAgICAgICAgICAgICAgY2FjaGVLZXlzVG9EZWxldGUtPmFwcGVu ZChlbnRyeS0+c3RvcmFnZUVudHJ5LmtleSk7CisgICAgICAgICAgICAgICAgcmV0dXJuOworICAg ICAgICAgICAgfQorCisgICAgICAgICAgICBkZWxldGUgb3JpZ2luc1RvRGVsZXRlOworCisgICAg ICAgICAgICBmb3IgKGF1dG8mIGtleSA6ICpjYWNoZUtleXNUb0RlbGV0ZSkKKyAgICAgICAgICAg ICAgICBOZXR3b3JrQ2FjaGU6OnNpbmdsZXRvbigpLnJlbW92ZShrZXkpOworCisgICAgICAgICAg ICBkZWxldGUgY2FjaGVLZXlzVG9EZWxldGU7CisKKyAgICAgICAgICAgIFJ1bkxvb3A6Om1haW4o KS5kaXNwYXRjaChjb21wbGV0aW9uSGFuZGxlcik7CisgICAgICAgICAgICByZXR1cm47CisgICAg ICAgIH0pOworCisgICAgICAgIHJldHVybjsKKyAgICB9CisjZW5kaWYKKworI2lmIFVTRShDRlVS TENBQ0hFKQorICAgIGF1dG8gaG9zdE5hbWVzID0gYWRvcHRDRihDRkFycmF5Q3JlYXRlTXV0YWJs ZShrQ0ZBbGxvY2F0b3JEZWZhdWx0LCAwLCAma0NGVHlwZUFycmF5Q2FsbEJhY2tzKSk7CisgICAg Zm9yIChhdXRvJiBvcmlnaW4gOiBvcmlnaW5zKQorICAgICAgICBDRkFycmF5QXBwZW5kVmFsdWUo aG9zdE5hbWVzLmdldCgpLCBvcmlnaW4uaG9zdC5jcmVhdGVDRlN0cmluZygpLmdldCgpKTsKKwor ICAgIENGU2hvdyhob3N0TmFtZXMuZ2V0KCkpOworICAgIFdlYlJlc291cmNlQ2FjaGVNYW5hZ2Vy OjpjbGVhckNGVVJMQ2FjaGVGb3JIb3N0TmFtZXMoaG9zdE5hbWVzLmdldCgpKTsKKyNlbmRpZgor CisgICAgUnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKFdURjo6bW92ZShjb21wbGV0aW9uSGFuZGxl cikpOworfQorCiB2b2lkIE5ldHdvcmtQcm9jZXNzOjpkZWxldGVXZWJzaXRlRGF0YUZvck9yaWdp bnMoU2Vzc2lvbklEIHNlc3Npb25JRCwgdWludDY0X3Qgd2Vic2l0ZURhdGFUeXBlcywgY29uc3Qg VmVjdG9yPFNlY3VyaXR5T3JpZ2luRGF0YT4mIG9yaWdpbnMsIGNvbnN0IFZlY3RvcjxTdHJpbmc+ JiBjb29raWVIb3N0TmFtZXMsIHVpbnQ2NF90IGNhbGxiYWNrSUQpCiB7CiAgICAgaWYgKHdlYnNp dGVEYXRhVHlwZXMgJiBXZWJzaXRlRGF0YVR5cGVDb29raWVzKSB7CkBAIC0zNzksNiArNDI0LDEx IEBAIHZvaWQgTmV0d29ya1Byb2Nlc3M6OmRlbGV0ZVdlYnNpdGVEYXRhRm9yT3JpZ2lucyhTZXNz aW9uSUQgc2Vzc2lvbklELCB1aW50NjRfdCB3CiAgICAgICAgIHBhcmVudFByb2Nlc3NDb25uZWN0 aW9uKCktPnNlbmQoTWVzc2FnZXM6Ok5ldHdvcmtQcm9jZXNzUHJveHk6OkRpZERlbGV0ZVdlYnNp dGVEYXRhRm9yT3JpZ2lucyhjYWxsYmFja0lEKSwgMCk7CiAgICAgfTsKIAorICAgIGlmICgod2Vi c2l0ZURhdGFUeXBlcyAmIFdlYnNpdGVEYXRhVHlwZURpc2tDYWNoZSkgJiYgIXNlc3Npb25JRC5p c0VwaGVtZXJhbCgpKSB7CisgICAgICAgIGNsZWFyRGlza0NhY2hlRW50cmllcyhvcmlnaW5zLCBX VEY6Om1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwog ICAgIGNvbXBsZXRpb25IYW5kbGVyKCk7CiB9CiAK