142876 2015-03-19 13:10:46 -0700 [GTK] Search for the Wayland dependency when enabling Wayland target 2015-03-20 02:24:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan cgarcia mrobinson oldest_to_newest 1078602 0 zan 2015-03-19 13:10:46 -0700 [GTK] Search for the Wayland dependency when enabling Wayland target 1078603 1 249054 zan 2015-03-19 13:12:35 -0700 Created attachment 249054 Patch 1078608 2 249054 mrobinson 2015-03-19 13:20:23 -0700 Comment on attachment 249054 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249054&action=review > ChangeLog:9 > + requirement of either the GTK+ ord GDK pkg-config files, so we have to Nit: ord -> or > Source/cmake/OptionsGTK.cmake:82 > +if (ENABLE_WAYLAND_TARGET) > + find_package(Wayland REQUIRED) > +endif () > + Don't we need to add the Wayland libraries to the linker flags and include directories to the compiler somewhere as well? 1078787 3 249054 zan 2015-03-20 01:20:13 -0700 Comment on attachment 249054 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249054&action=review >> Source/cmake/OptionsGTK.cmake:82 >> + > > Don't we need to add the Wayland libraries to the linker flags and include directories to the compiler somewhere as well? They're already listed in Source/WebCore/PlatformGTK.cmake. 1078809 4 zan 2015-03-20 02:24:19 -0700 Committed r181793: <http://trac.webkit.org/changeset/181793> 249054 2015-03-19 13:12:35 -0700 2015-03-20 01:38:20 -0700 Patch bug-142876-20150319131511.patch text/plain 1295 zan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTc1 NCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAz LTE5ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL XSBTZWFyY2ggZm9yIHRoZSBXYXlsYW5kIGRlcGVuZGVuY3kgd2hlbiBlbmFibGluZyBXYXlsYW5k IHRhcmdldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQyODc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZTogVGhlIFdheWxhbmQgZGVwZW5kZW5jeSBp c24ndCBhIHB1YmxpYworICAgICAgICByZXF1aXJlbWVudCBvZiBlaXRoZXIgdGhlIEdUSysgb3Jk IEdESyBwa2ctY29uZmlnIGZpbGVzLCBzbyB3ZSBoYXZlIHRvCisgICAgICAgIHNlYXJjaCBmb3Ig aXQgb3Vyc2VsdmVzIHdoZW4gV2ViS2l0R1RLKyBoYXMgYmVlbiBjb25maWd1cmVkIHRvIHN1cHBv cnQKKyAgICAgICAgdGhlIFdheWxhbmQgd2luZG93aW5nIHRhcmdldC4KKwogMjAxNS0wMy0xOSAg Q3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtHVEtdIEZp eCBpbnNwZWN0b3IgdXNlcmludGVyZmFjZSByZWxhdGVkIGluY3JlbWVudGFsIGJ1aWxkIGlzc3Vl CkluZGV4OiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQkocmV2aXNpb24gMTgxNzU0KQorKysgU291cmNlL2Nt YWtlL09wdGlvbnNHVEsuY21ha2UJKHdvcmtpbmcgY29weSkKQEAgLTc2LDYgKzc2LDEwIEBAIGlm IChFTkFCTEVfWDExX1RBUkdFVCkKICAgICBlbmRpZiAoKQogZW5kaWYgKCkKIAoraWYgKEVOQUJM RV9XQVlMQU5EX1RBUkdFVCkKKyAgICBmaW5kX3BhY2thZ2UoV2F5bGFuZCBSRVFVSVJFRCkKK2Vu ZGlmICgpCisKIFdFQktJVF9PUFRJT05fQkVHSU4oKQogV0VCS0lUX09QVElPTl9ERUZJTkUoRU5B QkxFX1BMVUdJTl9QUk9DRVNTX0dUSzIgIldoZXRoZXIgdG8gYnVpbGQgV2ViS2l0UGx1Z2luUHJv Y2VzczIgdG8gbG9hZCBHVEsyIGJhc2VkIHBsdWdpbnMuIiBPTikKIAo=