14287 2007-06-21 11:44:12 -0700 Don't add a null icon to the icon cache for every page without a favicon 2007-06-21 13:20:55 -0700 1 1 1 Unclassified WebKit WebCore Misc. 523.x (Safari 3) All Linux RESOLVED INVALID P2 Normal --- 0 manyoso webkit-unassigned staikos oldest_to_newest 6876 0 manyoso 2007-06-21 11:44:12 -0700 Currently, the iconloader adds an icon to the cache whenever it hits an error page and it also adds a null icon to the cache for every page that doesn't have a favicon. This makes sure to add an icon to the cache only when actual data exists. 6875 1 15165 manyoso 2007-06-21 11:45:03 -0700 Created attachment 15165 Fix for this bug 6874 2 15165 oliver 2007-06-21 11:55:18 -0700 Comment on attachment 15165 Fix for this bug Ok, this looks good, but i strongly suspect this will cause a perf regression. I suspect we cache null favicons to prevent us repeatedly trying to fetch a favicon from servers that don't have one. 6873 3 15165 ggaren 2007-06-21 12:00:18 -0700 Comment on attachment 15165 Fix for this bug We track these icons to avoid redundant network requests, which hurt performance. 6857 4 beidson 2007-06-21 13:20:55 -0700 This behavior is intentional. We track pages that don't have icons to prevent pinging the page for its icon every time. There's expiration-date behavior here so we would re-request the icon once a day or once a week (I forget which), and we also re-request the icon if the user manually reloads the page. Closing as invalid... 15165 2007-06-21 11:45:03 -0700 2007-06-21 12:00:18 -0700 Fix for this bug fix-non-existent-favicon.patch text/plain 1422 manyoso SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzcxNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTEgQEAKKzIwMDctMDYtMjEgIEFkYW0gVHJlYXQgPGFkYW1Ac3RhaWtvcy5uZXQ+ CisKKyAgICAgICAgRG9uJ3QgYWRkIGEgbm9uLWV4aXN0ZW50IGljb24gdG8gdGhlIGljb25EYXRh YmFzZQorCQl3aGVuZXZlciB3ZSBlbmNvdW50ZXIgYSBwYWdlIHdpdGhvdXQgYSBmYXZpY29uLgor CisgICAgICAgICogbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpJY29uTG9hZGVyOjpmaW5pc2hMb2FkaW5nKToKKwogMjAwNy0wNi0yMSAgQW5kcmV3IFdlbGxp bmd0b24gIDxwcm90b25Ad2lyZXRhcHBlZC5uZXQ+CiAKICAgICAgICAgTWFjIGJ1aWxkIGZpeC4K SW5kZXg6IFdlYkNvcmUvbG9hZGVyL2ljb24vSWNvbkxvYWRlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uTG9hZGVyLmNwcAkocmV2aXNpb24gMjM3MTMpCisrKyBX ZWJDb3JlL2xvYWRlci9pY29uL0ljb25Mb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzQs NyArMTM0LDcgQEAgdm9pZCBJY29uTG9hZGVyOjpmaW5pc2hMb2FkaW5nKGNvbnN0IEtVUgogICAg IC8vIGNhbmNlbGxlZC9mYWlsZWQgdHdpY2UuICBSZXByb2R1Y2liaWxpdHkgb2YgdGhpcyBwaGVu b21lbm9uIGlzIHVua25vd24sIHNvIHdlJ2QgbGlrZSB0byBjYXRjaCB0aGlzIGNhc2UgaW4gZGVi dWcgYnVpbGRzLAogICAgIC8vIGJ1dCBtdXN0IGhhbmRsZSBpdCBncmFjZWZ1bGx5IGluIHJlbGVh c2UKICAgICBBU1NFUlQobV9yZXNvdXJjZUxvYWRlcik7Ci0gICAgaWYgKCFpY29uVVJMLmlzRW1w dHkoKSAmJiBtX3Jlc291cmNlTG9hZGVyKSB7CisgICAgaWYgKCFpY29uVVJMLmlzRW1wdHkoKSAm JiBtX3Jlc291cmNlTG9hZGVyICYmIG1fcmVzb3VyY2VMb2FkZXItPnJlc291cmNlRGF0YSgpKSB7 CiAgICAgICAgIGljb25EYXRhYmFzZSgpLT5zZXRJY29uRGF0YUZvckljb25VUkwobV9yZXNvdXJj ZUxvYWRlci0+cmVzb3VyY2VEYXRhKCksIGljb25VUkwudXJsKCkpOwogICAgICAgICBMT0coSWNv bkRhdGFiYXNlLCAiSWNvbkxvYWRlcjo6ZmluaXNoTG9hZGluZygpIC0gQ29tbWl0dGluZyBpY29u VVJMICVzIHRvIGRhdGFiYXNlIiwgaWNvblVSTC51cmwoKS5hc2NpaSgpKTsKICAgICAgICAgbV9m cmFtZS0+bG9hZGVyKCktPmNvbW1pdEljb25VUkxUb0ljb25EYXRhYmFzZShpY29uVVJMKTsK