142862 2015-03-19 00:10:49 -0700 ES6 Classes: Runtime error in JIT'd class calling super() with arguments and superclass has default constructor 2015-03-27 20:10:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 140491 1 joepeck rniwa benjamin fpizlo ggaren joepeck rniwa webkit-bug-importer oldest_to_newest 1078476 0 joepeck 2015-03-19 00:10:49 -0700 * SUMMARY Runtime error in JIT'd class calling super() with arguments and superclass has default constructor. Doesn't happen if just called a few times. * TEST <script> var A = class A { }; var B = class B extends A { }; var C = class C extends B { constructor() { super(); } }; (function() { var x; for (var i = 0; i < 1e5; ++i) x = new C(false); // NOTE: argument is important console.log(x); })(); </script> * ACTUAL [Error] TypeError: undefined is not a constructor (evaluating 'super(...arguments)') * EXPECTED => no exceptions. * NOTES - adding a "constructor() { super(); }" to class B this works. - if the inspector is open this works, so the inspector likely prevents reaching a certain JIT tier 1078477 1 249021 joepeck 2015-03-19 00:11:28 -0700 Created attachment 249021 [TEST] Reduction Insect the test page. If you see an error, something incorrect happened! 1078478 2 joepeck 2015-03-19 00:15:31 -0700 (In reply to comment #1) > Created attachment 249021 [details] > [TEST] Reduction > > Inspect the test page. If you see an error, something incorrect happened! Of course this means to reproduce the error you have to close the inspector, reload the page, then open the inspector. 1078484 3 rniwa 2015-03-19 00:45:15 -0700 (In reply to comment #2) > (In reply to comment #1) > > Created attachment 249021 [details] > > [TEST] Reduction > > > > Inspect the test page. If you see an error, something incorrect happened! > > Of course this means to reproduce the error you have to close the inspector, > reload the page, then open the inspector. It looks like this is a bug in DFG. Disabling DFG JIT also fixes the bug. 1078655 4 rniwa 2015-03-19 15:39:20 -0700 var A = class A { }; var B = class B extends A { super(...arguments) }; var C = class C extends B { constructor() { super(); } }; will also fail but forcing B to be not inlined will fix the bug so it looks like we're not inlining B in DFG correctly. 1078656 5 webkit-bug-importer 2015-03-19 15:39:37 -0700 <rdar://problem/20231235> 1080860 6 rniwa 2015-03-27 19:35:17 -0700 Looks like this has been fixed by Phil's mega patch for arguments. 1080861 7 249639 rniwa 2015-03-27 19:39:18 -0700 Created attachment 249639 Adds a test 1080864 8 249641 rniwa 2015-03-27 19:42:19 -0700 Created attachment 249641 Removed the workaround in Web Inspector 1080868 9 rniwa 2015-03-27 20:00:53 -0700 Will land the patch one more test per Ben's in-person comment. 1080872 10 rniwa 2015-03-27 20:10:03 -0700 Committed r182100: <http://trac.webkit.org/changeset/182100> 249021 2015-03-19 00:11:28 -0700 2015-03-19 00:11:28 -0700 [TEST] Reduction reduction.html text/html 271 joepeck PHNjcmlwdD4KdmFyIEEgPSBjbGFzcyBBIHsgfTsKdmFyIEIgPSBjbGFzcyBCIGV4dGVuZHMgQSB7 IH07CnZhciBDID0gY2xhc3MgQyBleHRlbmRzIEIgeyBjb25zdHJ1Y3RvcigpIHsgc3VwZXIoKTsg fSB9OwoKKGZ1bmN0aW9uKCkgewogICAgdmFyIHg7CiAgICBmb3IgKHZhciBpID0gMDsgaSA8IDFl NTsgKytpKQogICAgICAgIHggPSBuZXcgQyhmYWxzZSk7IC8vIE5PVEU6IGFyZ3VtZW50IGlzIGlt cG9ydGFudAogICAgY29uc29sZS5sb2coeCk7Cn0pKCk7Cjwvc2NyaXB0Pg== 249639 2015-03-27 19:39:18 -0700 2015-03-27 19:42:16 -0700 Adds a test bug-142862-20150327193838.patch text/plain 1399 rniwa SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgyMDk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE1LTAzLTI3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAg IEVTNiBDbGFzc2VzOiBSdW50aW1lIGVycm9yIGluIEpJVCdkIGNsYXNzIGNhbGxpbmcgc3VwZXIo KSB3aXRoIGFyZ3VtZW50cyBhbmQgc3VwZXJjbGFzcyBoYXMgZGVmYXVsdCBjb25zdHJ1Y3Rvcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyODYyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVz dCB0aGF0IHVzZWQgdG8gZmFpbCBpbiBERkcgbm93IHRoYXQgdGhlIGJ1ZyBoYXMgYmVlbiBmaXhl ZCBieSByMTgxOTkzLgorCisgICAgICAgICogdGVzdHMvc3RyZXNzL2NsYXNzLXN5bnRheC1kZXJp dmVkLWRlZmF1bHQtY29uc3RydWN0b3IuanM6IEFkZGVkLgorCiAyMDE1LTAzLTI3ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBmbGFrZXkgZGZnLWlu dDhhcnJheS5qcyBhbmQgZGZnLWludDE2YXJyYXkuanMgdGVzdHMgZm9yIEFSTTY0CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2NsYXNzLXN5bnRheC1kZXJpdmVkLWRl ZmF1bHQtY29uc3RydWN0b3IuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L3Rlc3RzL3N0cmVzcy9jbGFzcy1zeW50YXgtZGVyaXZlZC1kZWZhdWx0LWNvbnN0cnVjdG9yLmpz CShyZXZpc2lvbiAwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9jbGFz cy1zeW50YXgtZGVyaXZlZC1kZWZhdWx0LWNvbnN0cnVjdG9yLmpzCSh3b3JraW5nIGNvcHkpCkBA IC0wLDAgKzEsMTAgQEAKKwordmFyIEEgPSBjbGFzcyBBIHsgfTsKK3ZhciBCID0gY2xhc3MgQiBl eHRlbmRzIEEgeyB9OwordmFyIEMgPSBjbGFzcyBDIGV4dGVuZHMgQiB7IGNvbnN0cnVjdG9yKCkg eyBzdXBlcigpOyB9IH07CisKKyhmdW5jdGlvbigpIHsKKyAgICB2YXIgeDsKKyAgICBmb3IgKHZh ciBpID0gMDsgaSA8IDFlNTsgKytpKQorICAgICAgICB4ID0gbmV3IEMoZmFsc2UpOyAvLyBOT1RF OiBhcmd1bWVudCBpcyBpbXBvcnRhbnQKK30pKCk7Cg== 249641 2015-03-27 19:42:19 -0700 2015-03-27 19:47:57 -0700 Removed the workaround in Web Inspector bug-142862-20150327194140.patch text/plain 5047 rniwa SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgyMDk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE1LTAzLTI3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAg IEVTNiBDbGFzc2VzOiBSdW50aW1lIGVycm9yIGluIEpJVCdkIGNsYXNzIGNhbGxpbmcgc3VwZXIo KSB3aXRoIGFyZ3VtZW50cyBhbmQgc3VwZXJjbGFzcyBoYXMgZGVmYXVsdCBjb25zdHJ1Y3Rvcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyODYyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVz dCB0aGF0IHVzZWQgdG8gZmFpbCBpbiBERkcgbm93IHRoYXQgdGhlIGJ1ZyBoYXMgYmVlbiBmaXhl ZCBieSByMTgxOTkzLgorCisgICAgICAgICogdGVzdHMvc3RyZXNzL2NsYXNzLXN5bnRheC1kZXJp dmVkLWRlZmF1bHQtY29uc3RydWN0b3IuanM6IEFkZGVkLgorCiAyMDE1LTAzLTI3ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBmbGFrZXkgZGZnLWlu dDhhcnJheS5qcyBhbmQgZGZnLWludDE2YXJyYXkuanMgdGVzdHMgZm9yIEFSTTY0CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2NsYXNzLXN5bnRheC1kZXJpdmVkLWRl ZmF1bHQtY29uc3RydWN0b3IuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L3Rlc3RzL3N0cmVzcy9jbGFzcy1zeW50YXgtZGVyaXZlZC1kZWZhdWx0LWNvbnN0cnVjdG9yLmpz CShyZXZpc2lvbiAwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9jbGFz cy1zeW50YXgtZGVyaXZlZC1kZWZhdWx0LWNvbnN0cnVjdG9yLmpzCSh3b3JraW5nIGNvcHkpCkBA IC0wLDAgKzEsMTAgQEAKKwordmFyIEEgPSBjbGFzcyBBIHsgfTsKK3ZhciBCID0gY2xhc3MgQiBl eHRlbmRzIEEgeyB9OwordmFyIEMgPSBjbGFzcyBDIGV4dGVuZHMgQiB7IGNvbnN0cnVjdG9yKCkg eyBzdXBlcigpOyB9IH07CisKKyhmdW5jdGlvbigpIHsKKyAgICB2YXIgeDsKKyAgICBmb3IgKHZh ciBpID0gMDsgaSA8IDFlNTsgKytpKQorICAgICAgICB4ID0gbmV3IEMoZmFsc2UpOyAvLyBOT1RF OiBhcmd1bWVudCBpcyBpbXBvcnRhbnQKK30pKCk7CkluZGV4OiBTb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VM b2cJKHJldmlzaW9uIDE4MjA5NykKKysrIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAxNS0wMy0yNyAgUnlvc3VrZSBOaXdh ICA8cm5pd2FAd2Via2l0Lm9yZz4KKworICAgICAgICBFUzYgQ2xhc3NlczogUnVudGltZSBlcnJv ciBpbiBKSVQnZCBjbGFzcyBjYWxsaW5nIHN1cGVyKCkgd2l0aCBhcmd1bWVudHMgYW5kIHN1cGVy Y2xhc3MgaGFzIGRlZmF1bHQgY29uc3RydWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Mjg2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQgdGhlIHdvcmthcm91bmQgZm9yIHRoZSBidWcg c2luY2UgaXQgaGFzIGJlZW4gZml4ZWQgYnkgcjE4MTk5My4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvQmFzZS9PYmplY3QuanM6CisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvRGVi dWdnZXJEYXNoYm9hcmQuanM6CisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvTmV0d29y a1RpbWVsaW5lLmpzOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL1JlcGxheURhc2hi b2FyZC5qczoKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9SZXZpc2lvbi5qczoKKwog MjAxNS0wMy0yNyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IFVuY2F1Z2h0IEV4Y2VwdGlvbnMgd2l0aCBDb250ZXh0IE1lbnVz CkluZGV4OiBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL09iamVjdC5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNl L09iamVjdC5qcwkocmV2aXNpb24gMTgyMDk3KQorKysgU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQmFzZS9PYmplY3QuanMJKHdvcmtpbmcgY29weSkKQEAgLTI1LDExICsyNSw2 IEBACiAKIFdlYkluc3BlY3Rvci5PYmplY3QgPSBjbGFzcyBPYmplY3QKIHsKLSAgICBjb25zdHJ1 Y3RvcigpCi0gICAgewotICAgICAgICAvLyBGSVhNRTogUmVtb3ZlIG9uY2UgPGh0dHBzOi8vd2Vi a2l0Lm9yZy9iLzE0Mjg2Mj4gaXMgZml4ZWQuCi0gICAgfQotCiAgICAgLy8gU3RhdGljCiAKICAg ICBzdGF0aWMgYWRkRXZlbnRMaXN0ZW5lcihldmVudFR5cGUsIGxpc3RlbmVyLCB0aGlzT2JqZWN0 KQpJbmRleDogU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RlYnVn Z2VyRGFzaGJvYXJkLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL01vZGVscy9EZWJ1Z2dlckRhc2hib2FyZC5qcwkocmV2aXNpb24gMTgyMDk3KQor KysgU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0RlYnVnZ2VyRGFz aGJvYXJkLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yNSw5ICsyNSw0IEBACiAKIFdlYkluc3BlY3Rv ci5EZWJ1Z2dlckRhc2hib2FyZCA9IGNsYXNzIERlYnVnZ2VyRGFzaGJvYXJkIGV4dGVuZHMgV2Vi SW5zcGVjdG9yLk9iamVjdAogewotICAgIGNvbnN0cnVjdG9yKCkKLSAgICB7Ci0gICAgICAgIC8v IEZJWE1FOiBSZW1vdmUgb25jZSA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTQyODYyPiBpcyBmaXhl ZC4KLSAgICAgICAgc3VwZXIoKTsKLSAgICB9CiB9OwpJbmRleDogU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL05ldHdvcmtUaW1lbGluZS5qcwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvTmV0d29ya1RpbWVs aW5lLmpzCShyZXZpc2lvbiAxODIwOTcpCisrKyBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Nb2RlbHMvTmV0d29ya1RpbWVsaW5lLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yNSwx MiArMjUsNiBAQAogCiBXZWJJbnNwZWN0b3IuTmV0d29ya1RpbWVsaW5lID0gY2xhc3MgTmV0d29y a1RpbWVsaW5lIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlRpbWVsaW5lCiB7Ci0gICAgY29uc3RydWN0 b3IodHlwZSkKLSAgICB7Ci0gICAgICAgIC8vIEZJWE1FOiBSZW1vdmUgb25jZSA8aHR0cHM6Ly93 ZWJraXQub3JnL2IvMTQyODYyPiBpcyBmaXhlZC4KLSAgICAgICAgc3VwZXIodHlwZSk7Ci0gICAg fQotCiAgICAgLy8gUHVibGljCiAKICAgICByZWNvcmRGb3JSZXNvdXJjZShyZXNvdXJjZSkKSW5k ZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9SZXBsYXlEYXNo Ym9hcmQuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvTW9kZWxzL1JlcGxheURhc2hib2FyZC5qcwkocmV2aXNpb24gMTgyMDk3KQorKysgU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1JlcGxheURhc2hib2FyZC5qcwko d29ya2luZyBjb3B5KQpAQCAtMjUsOSArMjUsNCBAQAogCiBXZWJJbnNwZWN0b3IuUmVwbGF5RGFz aGJvYXJkID0gY2xhc3MgUmVwbGF5RGFzaGJvYXJkIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVj dAogewotICAgIGNvbnN0cnVjdG9yKCkKLSAgICB7Ci0gICAgICAgIC8vIEZJWE1FOiBSZW1vdmUg b25jZSA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTQyODYyPiBpcyBmaXhlZC4KLSAgICAgICAgc3Vw ZXIoKTsKLSAgICB9CiB9OwpJbmRleDogU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvTW9kZWxzL1JldmlzaW9uLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL01vZGVscy9SZXZpc2lvbi5qcwkocmV2aXNpb24gMTgyMDk3KQorKysg U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1JldmlzaW9uLmpzCSh3 b3JraW5nIGNvcHkpCkBAIC0yNSwxMiArMjUsNiBAQAogCiBXZWJJbnNwZWN0b3IuUmV2aXNpb24g PSBjbGFzcyBSZXZpc2lvbiBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKIHsKLSAgICBjb25z dHJ1Y3RvcigpCi0gICAgewotICAgICAgICAvLyBGSVhNRTogUmVtb3ZlIG9uY2UgPGh0dHBzOi8v d2Via2l0Lm9yZy9iLzE0Mjg2Mj4gaXMgZml4ZWQuCi0gICAgICAgIHN1cGVyKCk7Ci0gICAgfQot CiAgICAgLy8gUHVibGljCiAKICAgICBhcHBseSgpCg==