142859 2015-03-18 20:40:53 -0700 [GTK] Fix build break after r181720 2015-03-18 23:18:20 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 142805 1 hs85.jeong hs85.jeong clopez commit-queue darin esprehn+autocc glenn kondapallykalyan ossy rego sabouhallawa oldest_to_newest 1078442 0 hs85.jeong 2015-03-18 20:40:53 -0700 ../../Source/WebCore/rendering/RenderImage.cpp: In member function ‘virtual void WebCore::RenderImage::styleDidChange(WebCore::StyleDifference, const WebCore::RenderStyle*)’: ../../Source/WebCore/rendering/RenderImage.cpp:225:57: error: expected ‘)’ before ‘;’ token repaintOrMarkForLayout(ImageSizeChangeForAltText; Fix typo. 1078444 1 249012 hs85.jeong 2015-03-18 20:44:16 -0700 Created attachment 249012 Patch 1078464 2 249012 ossy 2015-03-18 23:09:45 -0700 Comment on attachment 249012 Patch It's not exactly related to GTK, but !ENABLE(CSS_IMAGE_RESOLUTION). But the fix is correct, r=me. 1078467 3 ossy 2015-03-18 23:11:10 -0700 already fixed by anyone else - http://trac.webkit.org/changeset/181729 1078468 4 ossy 2015-03-18 23:12:31 -0700 Hunseop, please add a comment to the original bug too next time, because folks won't notice that somebody already fixed the build. 1078470 5 ossy 2015-03-18 23:18:20 -0700 (In reply to comment #4) > Hunseop, please add a comment to the original bug too next time, > because folks won't notice that somebody already fixed the build. And you can ask for review on #webkit immediately for important buildfix, feel free to ping the author and the reviewer of the original change or a random reviewer on #webkit, and then ask them to commit it too manually, it is much more faster than waiting for commit queue. 249012 2015-03-18 20:44:16 -0700 2015-03-18 23:09:45 -0700 Patch bug-142859-20150319124348.patch text/plain 1530 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWVjMWQ1NWM2MTJhNzkx MDQzZmFiMGJiNDVlOWI4M2VkZDYzYjk0Ni4uOTE1MWExNDI4MGIxMzc1YzU1NjM2Nzg0OGFlMDFh ZTJlZTg5NDMzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTE4ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbR1RLXSBGaXgg YnVpbGQgYnJlYWsgYWZ0ZXIgcjE4MTcyMCAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0Mjg1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeCB0eXBvLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ckltYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckltYWdlOjpzdHlsZURpZENoYW5n ZSk6CisKIDIwMTUtMDMtMTggIFNhaWQgQWJvdS1IYWxsYXdhICA8c2Fib3VoYWxsYXdhQGFwcGxl LmNvbT4KIAogICAgICAgICBTd2l0Y2hpbmcgYmV0d2VlbiB0d28gU1ZHIGltYWdlcyB3aXRoIG5v IGludHJpbnNpYyBzaXplcyBjYXVzZXMgdGhlbSB0byBnZXQgdGhlIGRlZmF1bHQgU1ZHIHNpemUg aW5zdGVhZCBvZiB0aGUgY29udGFpbmVyIHNpemUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckltYWdlLmNwcAppbmRleCBjM2NkNzQyNTlhOGM4YWJlMTc3ODZlMjViYzgwODU3ZjYxMGQ1 NDEyLi5kNjFkMTkwYzJmMTY2MzI0MjI0Mzg0NjQ3OWI0ODk2N2M4ZWFjODc1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHAKQEAgLTIyMiw3ICsyMjIsNyBAQCB2b2lk IFJlbmRlckltYWdlOjpzdHlsZURpZENoYW5nZShTdHlsZURpZmZlcmVuY2UgZGlmZiwgY29uc3Qg UmVuZGVyU3R5bGUqIG9sZFN0eQogICAgICAgICAmJiAob2xkU3R5bGUtPmltYWdlUmVzb2x1dGlv bigpICE9IHN0eWxlKCkuaW1hZ2VSZXNvbHV0aW9uKCkKICAgICAgICAgICAgIHx8IG9sZFN0eWxl LT5pbWFnZVJlc29sdXRpb25TbmFwKCkgIT0gc3R5bGUoKS5pbWFnZVJlc29sdXRpb25TbmFwKCkK ICAgICAgICAgICAgIHx8IG9sZFN0eWxlLT5pbWFnZVJlc29sdXRpb25Tb3VyY2UoKSAhPSBzdHls ZSgpLmltYWdlUmVzb2x1dGlvblNvdXJjZSgpKSkKLSAgICAgICAgcmVwYWludE9yTWFya0Zvckxh eW91dChJbWFnZVNpemVDaGFuZ2VGb3JBbHRUZXh0OworICAgICAgICByZXBhaW50T3JNYXJrRm9y TGF5b3V0KEltYWdlU2l6ZUNoYW5nZUZvckFsdFRleHQpOwogI2VuZGlmCiB9CiAK