142851 2015-03-18 17:35:08 -0700 WeakGCMap pruning callback doesn't need to be a separate function. 2015-03-18 20:35:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 kling kling oldest_to_newest 1078386 0 kling 2015-03-18 17:35:08 -0700 Looking over WeakGCMap again, I realized that pruneStaleEntries() doesn't need to be a separate function, we can just fold it into the lambda we register with the heap. 1078387 1 248995 kling 2015-03-18 17:37:26 -0700 Created attachment 248995 Patch 1078441 2 248995 kling 2015-03-18 20:35:50 -0700 Comment on attachment 248995 Patch This fails on Windows :( c:\cygwin\home\buildbot\webkit\source\javascriptcore\runtime\WeakGCMapInlines.h(39): error C2899: typename cannot be used outside a template declaration 248995 2015-03-18 17:37:26 -0700 2015-03-18 20:35:50 -0700 Patch bug-142851.diff text/plain 2376 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDU2NTIwMTYuLjRlM2M4ZGEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTAzLTE4ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBXZWFrR0NNYXAgcHJ1bmluZyBjYWxsYmFj ayBkb2Vzbid0IG5lZWQgdG8gYmUgYSBzZXBhcmF0ZSBmdW5jdGlvbi4KKyAgICAgICAgPGh0dHBz Oi8vd2Via2l0Lm9yZy9iLzE0Mjg1MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGb2xkIFdlYWtHQ01hcDo6cHJ1bmVTdGFsZUVudHJpZXMoKSBpbnRv IHRoZSBsYW1iZGEgdGhhdCB3ZSByZWdpc3RlciB3aXRoIHRoZSBHQyBoZWFwLgorICAgICAgICBU aGlzIGF2b2lkcyBvbmUgZm9yY2VkIG91dC1vZi1saW5lIGNhbGwgcGVyIG1hcCBkdXJpbmcgZnVs bCBjb2xsZWN0aW9ucy4KKworICAgICAgICAqIHJ1bnRpbWUvV2Vha0dDTWFwLmg6CisgICAgICAg ICogcnVudGltZS9XZWFrR0NNYXBJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OldlYWtHQ01hcDo6 cHJ1bmVTdGFsZUVudHJpZXMpOiBEZWxldGVkLgorICAgICAgICAoSlNDOjpXZWFrR0NNYXA6Oldl YWtHQ01hcCk6IERvIHRoZSBwcnVuaW5nIGRpcmVjdGx5IGluc2lkZSB0aGUgbGFtYmRhLgorCiAy MDE1LTAzLTE3ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgogCiAgICAg ICAgIFtFRkxdIEV4cG9zZSBKYXZhU2NyaXB0IGJpbmRpbmcgaW50ZXJmYWNlIHRocm91Z2ggZXdr X2V4dGVuc2lvbgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2Vh a0dDTWFwLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9XZWFrR0NNYXAuaAppbmRl eCBmZDFmYTZlLi4xZjM1MzkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9XZWFrR0NNYXAuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9XZWFr R0NNYXAuaApAQCAtODksOCArODksNiBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBmaW5kKGtl eSkgIT0gbV9tYXAuZW5kKCk7CiAgICAgfQogCi0gICAgdm9pZCBwcnVuZVN0YWxlRW50cmllcygp OwotCiBwcml2YXRlOgogICAgIEhhc2hNYXBUeXBlIG1fbWFwOwogICAgIFZNJiBtX3ZtOwpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2Vha0dDTWFwSW5saW5lcy5o IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2Vha0dDTWFwSW5saW5lcy5oCmluZGV4 IGI5MGFjYzAuLjIyOWNhMTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1dlYWtHQ01hcElubGluZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9XZWFrR0NNYXBJbmxpbmVzLmgKQEAgLTM2LDcgKzM2LDkgQEAgaW5saW5lIFdlYWtHQ01hcDxL ZXlBcmcsIFZhbHVlQXJnLCBIYXNoQXJnLCBLZXlUcmFpdHNBcmc+OjpXZWFrR0NNYXAoVk0mIHZt KQogICAgIDogbV92bSh2bSkKIHsKICAgICB2bS5oZWFwLnJlZ2lzdGVyV2Vha0dDTWFwKHRoaXMs IFt0aGlzXSgpIHsKLSAgICAgICAgcHJ1bmVTdGFsZUVudHJpZXMoKTsKKyAgICAgICAgbV9tYXAu cmVtb3ZlSWYoW10odHlwZW5hbWUgSGFzaE1hcFR5cGU6OktleVZhbHVlUGFpclR5cGUmIGVudHJ5 KSB7CisgICAgICAgICAgICByZXR1cm4gIWVudHJ5LnZhbHVlOworICAgICAgICB9KTsKICAgICB9 KTsKIH0KIApAQCAtNDYsMTQgKzQ4LDYgQEAgaW5saW5lIFdlYWtHQ01hcDxLZXlBcmcsIFZhbHVl QXJnLCBIYXNoQXJnLCBLZXlUcmFpdHNBcmc+Ojp+V2Vha0dDTWFwKCkKICAgICBtX3ZtLmhlYXAu dW5yZWdpc3RlcldlYWtHQ01hcCh0aGlzKTsKIH0KIAotdGVtcGxhdGU8dHlwZW5hbWUgS2V5QXJn LCB0eXBlbmFtZSBWYWx1ZUFyZywgdHlwZW5hbWUgSGFzaEFyZywgdHlwZW5hbWUgS2V5VHJhaXRz QXJnPgotTkVWRVJfSU5MSU5FIHZvaWQgV2Vha0dDTWFwPEtleUFyZywgVmFsdWVBcmcsIEhhc2hB cmcsIEtleVRyYWl0c0FyZz46OnBydW5lU3RhbGVFbnRyaWVzKCkKLXsKLSAgICBtX21hcC5yZW1v dmVJZihbXSh0eXBlbmFtZSBIYXNoTWFwVHlwZTo6S2V5VmFsdWVQYWlyVHlwZSYgZW50cnkpIHsK LSAgICAgICAgcmV0dXJuICFlbnRyeS52YWx1ZTsKLSAgICB9KTsKLX0KLQogfSAvLyBuYW1lc3Bh Y2UgSlNDCiAKICNlbmRpZiAvLyBXZWFrR0NNYXBJbmxpbmVzX2gK