142850 2015-03-18 17:23:04 -0700 [Win] Activate tests on Windows EWS 2024-07-10 16:59:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham ap bfulgham commit-queue fujii glenn ossy webkit-bug-importer oldest_to_newest 1078383 0 bfulgham 2015-03-18 17:23:04 -0700 We have a working EWS system for Windows. Let's turn on tests so we encounter fewer test failures! 1078384 1 248993 bfulgham 2015-03-18 17:23:48 -0700 Created attachment 248993 Patch 1078390 2 ossy 2015-03-18 17:43:35 -0700 What is the testing time of the Win EWS? If the tree is red, it will build and run tests twice: build and run tests with patch + build and run tests without patch to make sure if the test failures comes from the patch or the trunk. If there is a flakey test, it will build three times. Nowadays everybody (including Apple employees) ignores test results on Apple Windows and Apple employees regularly break the Windows build against the red EWS bubble and don't fix the broken build after landing the patch. I think after slowing down the Windows EWS drastically, folks won't wait for the EWS bubble and will land patch before it finished. Now at least they can see the red bubble in time if they take notice of Windows port. 1078392 3 248993 ossy 2015-03-18 17:45:48 -0700 Comment on attachment 248993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248993&action=review > Tools/Scripts/webkitpy/common/config/ews.json:17 > + "watchers": [ > + "bfulgham@apple.com" Is watchers still used for anything? I think it is unused since EWS can't comment bugs and set cq- on failure. ( because folks don't want to get "SPAM", they want to be able break the world without any notification :) ) 1078393 4 ossy 2015-03-18 17:52:29 -0700 (In reply to comment #3) > Comment on attachment 248993 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248993&action=review > > > Tools/Scripts/webkitpy/common/config/ews.json:17 > > + "watchers": [ > > + "bfulgham@apple.com" > > Is watchers still used for anything? I think it is unused since EWS can't > comment bugs and set cq- on failure. > ( because folks don't want to get "SPAM", they want to be able break the > world without any notification :) ) I was wrong, it still comments bug on test failures and cc the watchers, but not on build and style failures. ( I can imagine the angry webkit-dev mails: "Stop bugzilla SPAMs in case of Windows test failures" :)) ) 1078432 5 248993 ap 2015-03-18 20:26:12 -0700 Comment on attachment 248993 Patch Ossy, an exciting new development is that Windows tests are all green, and have been maintained for the last couple of weeks. So, it seems reasonable to try and make that stick. 1078463 6 ossy 2015-03-18 23:07:15 -0700 (In reply to comment #5) > Comment on attachment 248993 [details] > Patch > > Ossy, an exciting new development is that Windows tests are all green, and > have been maintained for the last couple of weeks. So, it seems reasonable > to try and make that stick. Yes, I see that Brent is actively working on keeping the bot green. I just noticed that I'm very skeptic about it, because the majority of the folks don't care about the Windows bot at al. If somebody ignores the red bubble which signals build failure, I don't think if the same person will care about test failures in the future, except the boss emphasizes it is mandatory and not optional policy. I chekced, the testing time is ~37 mins on the Win buildbot now, only one failing test on the tree would increase the cycle time with ~74 mins, only one flakey (after retry or timeout or crash) with ~111 mins plus the build times. But let's see, I always supported the full green tree policy in the past. 1078549 7 bfulgham 2015-03-19 09:43:30 -0700 Committed r181748: <http://trac.webkit.org/changeset/181748> 1078614 8 ossy 2015-03-19 13:28:56 -0700 (In reply to comment #7) > Committed r181748: <http://trac.webkit.org/changeset/181748> Windows EWS doesn't work, because apache isn't installed: http://webkit-queues.appspot.com/results/6371421504667648 1078635 9 bfulgham 2015-03-19 14:25:49 -0700 Rats! I'm running down to the lab right now to fix that. Thanks for catching that! 1078735 10 ap 2015-03-19 21:02:51 -0700 httpd seems to still be broken, should we roll out for now? 1078764 11 bfulgham 2015-03-19 23:26:16 -0700 (In reply to comment #10) > httpd seems to still be broken, should we roll out for now? No. It's working now, but may take a bit for all the bits to reflect this. -Brent 1078774 12 ossy 2015-03-20 00:44:22 -0700 http tests work, but others are still flakey 1078863 13 bfulgham 2015-03-20 08:56:25 -0700 I'm going to roll this out because tests seem to be failing, even though they work fine on the main test bots. Something must be misconfigured. 1078864 14 bfulgham 2015-03-20 08:59:27 -0700 Temporarily rolled out in r181801 <http://trac.webkit.org/changeset/181801>. 1079281 15 ossy 2015-03-23 05:41:28 -0700 reopen 2045654 16 fujii 2024-07-10 16:58:05 -0700 bug 269676 resolves this. 2045655 17 webkit-bug-importer 2024-07-10 16:59:15 -0700 <rdar://problem/131498099> 248993 2015-03-18 17:23:48 -0700 2015-03-18 20:26:12 -0700 Patch bug-142850-20150318172316.patch text/plain 1084 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MTcxNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTAzLTE4ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFtXaW5dIEFjdGl2YXRlIHRlc3RzIG9uIEVXUworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyODUwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9jb25maWcvZXdzLmpzb246IEFkZCBtZSBhcworICAgICAgICB0aGUgRVdTIGJvdCB3YXRjaGVy LCBhbmQgYWN0aXZhdGUgdGVzdHMuCisKIDIwMTUtMDMtMTggIERhbmEgQnVya2FydCAgPGRidXJr YXJ0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgZXh0cmFuZW91cyBpbXBvcnQgdG8gZml4 IHRoZSBidWlsZC4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9l d3MuanNvbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25m aWcvZXdzLmpzb24JKHJldmlzaW9uIDE4MTcxMCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2NvbmZpZy9ld3MuanNvbgkod29ya2luZyBjb3B5KQpAQCAtMTIsNyArMTIsMTEgQEAK ICAgICAgICAgXQogICAgIH0sCiAgICAgIldpbiBFV1MiOiB7Ci0gICAgICAgICJwb3J0IjogIndp biIKKyAgICAgICAgInBvcnQiOiAid2luIiwKKyAgICAgICAgIndhdGNoZXJzIjogWworICAgICAg ICAgICAgImJmdWxnaGFtQGFwcGxlLmNvbSIKKyAgICAgICAgXSwKKyAgICAgICAgInJ1blRlc3Rz IjogdHJ1ZQogICAgIH0sCiAgICAgImlPUyBFV1MiOiB7CiAgICAgICAgICJwb3J0IjogImlvcyIs Cg==