142849 2015-03-18 17:16:31 -0700 [GTK] Fix inspector userinterface related incremental build issue 2015-03-25 01:34:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy cgarcia clopez commit-queue dbates gyuyoung.kim jh718.park joepeck mrobinson nvasilyev ossy pnormand rego oldest_to_newest 1078379 0 ossy 2015-03-18 17:16:31 -0700 Nowadays the GTK buildbot and EWS fails regularly with an inspector userinterface related incremental build issue. The problem is that cmake should rerun to regenerate dependency when inspector userinterface changes, but it doesn't run. build error after r181704: ninja: error: '../../Source/WebInspectorUI/UserInterface/Views/ScopeVariableTreeElement.js', needed by 'DerivedSources/webkit2gtk/InspectorGResourceBundle.xml', missing and no known rule to make it build error after r181517: ninja: error: '../../Source/WebInspectorUI/UserInterface/Views/ConsoleMessageImpl.js', needed by 'DerivedSources/webkit2gtk/InspectorGResourceBundle.xml', missing and no known rule to make it False positive incrementail build issues which needs manual fix by bot maintainers can be annoying and we should avoid them. I think we should simply rereun cmake always when this directory changes. 1078380 1 248991 ossy 2015-03-18 17:18:00 -0700 Created attachment 248991 Patch 1078471 2 ossy 2015-03-18 23:22:35 -0700 GTK bots and EWS are stucked again due to this bug: ninja: error: '../../Source/WebInspectorUI/UserInterface/Views/ObjectPropertiesSection.js', needed by 'DerivedSources/webkit2gtk/InspectorGResourceBundle.xml', missing and no known rule to make it 1078472 3 ossy 2015-03-18 23:25:42 -0700 (note: r162545 used this idea for Options<EFL|GTK>.cmake and OptionsCommon.cmake) 1078475 4 249020 ossy 2015-03-18 23:37:52 -0700 Created attachment 249020 Patch with reverting the previous whitespace workaround 1078483 5 249020 cgarcia 2015-03-19 00:35:42 -0700 Comment on attachment 249020 Patch Let's try this way, thanks ossy! 1078490 6 249020 commit-queue 2015-03-19 01:19:57 -0700 Comment on attachment 249020 Patch Clearing flags on attachment: 249020 Committed r181735: <http://trac.webkit.org/changeset/181735> 1078491 7 commit-queue 2015-03-19 01:20:01 -0700 All reviewed patches have been landed. Closing bug. 1079898 8 jh718.park 2015-03-25 01:34:05 -0700 I think there is an insignificant variable name typo in this patch. inspectorUserInterfaceDircetory -> inspectorUserInterfaceDirectory. 248991 2015-03-18 17:18:00 -0700 2015-03-18 23:37:44 -0700 Patch bug-142849-20150318171727.patch text/plain 1242 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNzA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDM5NWE3OTcwMjg4ZWQyMzlmY2FiZmFiY2M3MWExYWI1 NzdhZTYxZS4uZTQyNGFlNTgyOTExMmE1ZTY3NjFlMmU4YTA4NWI1ZjJlY2FkNjhkYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTAzLTE4ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW0dUS10gRml4IGluc3BlY3RvciB1c2VyaW50ZXJmYWNlIHJlbGF0ZWQgaW5jcmVt ZW50YWwgYnVpbGQgaXNzdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0Mjg0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoc2hvdWxkUmVtb3Zl Q01ha2VDYWNoZSk6CisKIDIwMTUtMDMtMTggIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KIAogICAgICAgICBwcmVwYXJlLUNoYW5nZUxvZyBkb2Vzbid0IHVuZGVyc3RhbmQgQyBzdHJp bmcgbGl0ZXJhbHMgc3BsaXQgYWNyb3NzIG11bHRpcGxlIGxpbmVzIHdpdGggXApkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtCmluZGV4IDY0NDJhYjU2YWRiNTdjMTU0YjZkYmRmYzBkZGE3NjdiNDVmMWRlMDMuLmEwYzI1 NzMzYjY5ZTA3YTI2OTVmZGU0MzI5MjJjOTkxYTE4NDE4Y2EgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAg LTE3ODAsNiArMTc4MCwxMSBAQCBzdWIgc2hvdWxkUmVtb3ZlQ01ha2VDYWNoZShAKQogICAgICAg ICByZXR1cm4gMTsKICAgICB9CiAKKyAgICBteSAkaW5zcGVjdG9yVXNlckludGVyZmFjZURpcmNl dG9yeSA9IEZpbGU6OlNwZWMtPmNhdGRpcihzb3VyY2VEaXIoKSwgIlNvdXJjZSIsICJXZWJJbnNw ZWN0b3JVSSIsICJVc2VySW50ZXJmYWNlIik7CisgICAgaWYgKCRjYWNoZUZpbGVNb2RpZmllZFRp bWUgPCBzdGF0KCRpbnNwZWN0b3JVc2VySW50ZXJmYWNlRGlyY2V0b3J5KS0+bXRpbWUpIHsKKyAg ICAgICAgcmV0dXJuIDE7CisgICAgfQorCiAgICAgcmV0dXJuIDA7CiB9CiAK 249020 2015-03-18 23:37:52 -0700 2015-03-19 01:19:57 -0700 Patch bug-142849-20150318233720.patch text/plain 2284 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNzMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDE4YzNk YjU5YWE4MDY1Mzk3ZTUyZDk1NmZlYTQ2YzM5YjU2NDA2NzAuLjM1NjNhZmIwZGMzNDMyZjlkM2Rj YjU4MzI2MTk3NmIzMjhmYTliMmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC00NDgsNCArNDQ4 LDMgQEAgaWYgKENNQUtFX01BSk9SX1ZFUlNJT04gTEVTUyAzKQogICAgICAgICBGSUxFX1BFUk1J U1NJT05TIE9XTkVSX1JFQUQgT1dORVJfV1JJVEUgT1dORVJfRVhFQ1VURSBHUk9VUF9SRUFEIEdS T1VQX0VYRUNVVEUKICAgICApCiBlbmRpZiAoKQotCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VM b2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmZjOTY0NmE2OGQ1ZmEzMTJlNjRmNjAwOGI3N2Jl N2Q1MGMxNDg4Ny4uNmRhMDRiMWEyMDYzN2FiZWQxMzQ5YjgwMzAxMjljOGEwOThjNjY3ZCAxMDA2 NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDE1LTAzLTE4ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+ CisKKyAgICAgICAgW0dUS10gRml4IGluc3BlY3RvciB1c2VyaW50ZXJmYWNlIHJlbGF0ZWQgaW5j cmVtZW50YWwgYnVpbGQgaXNzdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0Mjg0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoc2hvdWxkUmVt b3ZlQ01ha2VDYWNoZSk6CisKIDIwMTUtMDMtMTggIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0 ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbQ29udGVudEV4dGVuc2lvbnNdIFByZXBhcmUg Zm9yIGNvbXBpbGluZyBzdHlsZXNoZWV0cyBvZiBzZWxlY3RvcnMgdG8gYmUgdXNlZCBvbiBldmVy eSBwYWdlLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDY0NDJhYjU2YWRiNTdjMTU0YjZkYmRmYzBkZGE3 NjdiNDVmMWRlMDMuLmEwYzI1NzMzYjY5ZTA3YTI2OTVmZGU0MzI5MjJjOTkxYTE4NDE4Y2EgMTAw NzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdGRpcnMucG0KQEAgLTE3ODAsNiArMTc4MCwxMSBAQCBzdWIgc2hvdWxkUmVtb3ZlQ01h a2VDYWNoZShAKQogICAgICAgICByZXR1cm4gMTsKICAgICB9CiAKKyAgICBteSAkaW5zcGVjdG9y VXNlckludGVyZmFjZURpcmNldG9yeSA9IEZpbGU6OlNwZWMtPmNhdGRpcihzb3VyY2VEaXIoKSwg IlNvdXJjZSIsICJXZWJJbnNwZWN0b3JVSSIsICJVc2VySW50ZXJmYWNlIik7CisgICAgaWYgKCRj YWNoZUZpbGVNb2RpZmllZFRpbWUgPCBzdGF0KCRpbnNwZWN0b3JVc2VySW50ZXJmYWNlRGlyY2V0 b3J5KS0+bXRpbWUpIHsKKyAgICAgICAgcmV0dXJuIDE7CisgICAgfQorCiAgICAgcmV0dXJuIDA7 CiB9CiAKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAxYmI0YTYxYzgy ZTdlNGJlYTQ1MzYxNzRmNGU1ZWIyNGE5MTU3ZDI2Li45NTFhYWJmNjUzOTIyYzVkNDBlZWQ1OGRh ZjJiNDRmZTQyZjdkMDI2IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTQgQEAKIDIwMTUtMDMtMTggIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KIAorICAgICAgICBbR1RLXSBGaXggaW5zcGVjdG9yIHVzZXJpbnRlcmZhY2UgcmVs YXRlZCBpbmNyZW1lbnRhbCBidWlsZCBpc3N1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyODQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZTogUmV2 ZXJ0IHIxODE3MzMuCisKKzIwMTUtMDMtMTggIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KKwogICAgICAgICBVbnJldmlld2VkLCBraWNrIHRoZSBHVEsgYm90cyB0byByZWdl bmVyYXRlIG1ha2VmaWxlLgogCiAgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21h a2U6Cg==