142821 2015-03-18 05:21:59 -0700 [GTK][WK2] The WebKit network disk cache is not enabled 2015-05-06 02:14:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 143872 144251 144542 1 chavarria1991 webkit-unassigned cdumez cgarcia chavarria1991 clopez koivisto mcatanzaro ossy svillar zan oldest_to_newest 1078168 0 chavarria1991 2015-03-18 05:21:59 -0700 The http/tests/cache/disk-cache-validation.html layout test is failing on GTK+ since r179449 (http://trac.webkit.org/changeset/179449). This test enables the tests for cache funcionality. The output is the following: FAIL: Timed out waiting for notifyDone to be called 1079421 1 cdumez 2015-03-23 14:18:06 -0700 *** Bug 141702 has been marked as a duplicate of this bug. *** 1079423 2 cdumez 2015-03-23 14:18:24 -0700 *** Bug 141703 has been marked as a duplicate of this bug. *** 1079425 3 cdumez 2015-03-23 14:18:47 -0700 *** Bug 142818 has been marked as a duplicate of this bug. *** 1079428 4 cdumez 2015-03-23 14:20:39 -0700 Will consolidate the GTK TestExpectations via https://bugs.webkit.org/show_bug.cgi?id=142979. 1079925 5 clopez 2015-03-25 04:49:22 -0700 Mac has recently enabled NETWORK_CACHE (See bug 30322) by default on r179449 <ttp://trac.webkit.org/changeset/179449> Should GTK also enable it? 1079926 6 cgarcia 2015-03-25 04:53:06 -0700 (In reply to comment #5) > Mac has recently enabled NETWORK_CACHE (See bug 30322) by default on r179449 > <ttp://trac.webkit.org/changeset/179449> > > Should GTK also enable it? We first need to implement it :-) We also need to figure out what to do with the single web process model, I guess we could keep using the soup cache in the web process and the WebKit cache in the network process. Or we could make the single web process model become a multiple web process model with limit = 1, and the network process will always be used. 1079929 7 mcatanzaro 2015-03-25 05:36:28 -0700 (In reply to comment #6) > Or we could > make the single web process model become a multiple web process model with > limit = 1, and the network process will always be used. Note that a properly-sandboxed web process would not have any access to the network, so mandatory network process is something we'd come to eventually anyway. (Also, it would make Apple happy, but you know that.) 1079930 8 zan 2015-03-25 05:37:15 -0700 These are the slides from Antti's talk at the WK Contributors Meeting. https://trac.webkit.org/attachment/wiki/March%202015%20Meeting/Disk%20cache.pdf The main requirements are implementing NetworkCache::IOChannel and NetworkCache::Data. In GLib/GIO this might be possible by using GFile and GMemoryInputStream/GMemoryOutputStream (or whatever best replicates dispatch_io_* and dispatch_data_* APIs). 1079939 9 mcatanzaro 2015-03-25 07:36:42 -0700 (In reply to comment #6) > We first need to implement it :-) We also need to figure out what to do with > the single web process model, I guess we could keep using the soup cache in > the web process and the WebKit cache in the network process. Or we could > make the single web process model become a multiple web process model with > limit = 1, and the network process will always be used. Mandatory network process is something I would be willing to implement, for bug #140075. 1079940 10 cgarcia 2015-03-25 07:43:41 -0700 (In reply to comment #9) > (In reply to comment #6) > > We first need to implement it :-) We also need to figure out what to do with > > the single web process model, I guess we could keep using the soup cache in > > the web process and the WebKit cache in the network process. Or we could > > make the single web process model become a multiple web process model with > > limit = 1, and the network process will always be used. > > Mandatory network process is something I would be willing to implement, for > bug #140075. The question is whether sandboxing will be mandatory as well, or just optional. There are use cases in embedded world where network process, caches, and sandboxing are not needed at all. 1088958 11 cgarcia 2015-04-27 01:24:47 -0700 The initial implementation of the disk cache for soup landed in r183387. It works and all tests pass, but it hasn't been extensively tested yet. It can still be improved by using shareable resources, for example, but the only blocker is bug #144251 (to ensure all cache files are created with a creation time). So, I would like to enable the disk cache as soon as bug #144251 is fixed, so that we can start testing it now (early in the release cycle). 1091724 12 252373 cgarcia 2015-05-05 03:05:01 -0700 Created attachment 252373 Patch No more blockers, we are ready. 1091759 13 252373 mrobinson 2015-05-05 07:39:55 -0700 Comment on attachment 252373 Patch Nice. 1092119 14 cgarcia 2015-05-06 02:14:08 -0700 Committed r183865: <http://trac.webkit.org/changeset/183865> 252373 2015-05-05 03:05:01 -0700 2015-05-05 07:39:55 -0700 Patch wk2-network-cache.diff text/plain 2586 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiZGE1Mjc5Li41MDU4NzJjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTUtMDUt MDUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAg IFtHVEtdW1dLMl0gVGhlIFdlYktpdCBuZXR3b3JrIGRpc2sgY2FjaGUgaXMgbm90IGVuYWJsZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjgyMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuc2tpcCBo dHRwL3Rlc3RzL2NhY2hlL2Rpc2stY2FjaGUgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n dGsvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNS0wNS0wNSAgSm9hbm1hcmllIERpZ2dzICA8amRp Z2dzQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0FUS10gQVg6IGZpZ3VyZSBvdXQgcGxhdGZvcm0g ZGlmZmVyZW5jZSBmb3IgQVRLIHRvIG1ha2UgYWNjZXNzaWJpbGl0eS90YWJsZS1jZWxsLWRpc3Bs YXktYmxvY2suaHRtbCB3b3JrCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsv VGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRp b25zCmluZGV4IGM5MmE2ZDYuLmJjNzQ4MDYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9U ZXN0RXhwZWN0YXRpb25zCkBAIC00ODAsOSArNDgwLDYgQEAgd2Via2l0Lm9yZy9iLzEyODE3MiBm YXN0L2V2ZW50cy90b3VjaC90b3VjaC10YXJnZXQuaHRtbCBbIFRpbWVvdXQgXQogd2Via2l0Lm9y Zy9iLzEyODE3MiBmYXN0L2V2ZW50cy90b3VjaC90b3VjaC10YXJnZXQtbGltaXRlZC5odG1sIFsg Q3Jhc2ggVGltZW91dCBdCiB3ZWJraXQub3JnL2IvMTI4MTcyIGZhc3QvZXZlbnRzL3RvdWNoL3Nl bmQtb25jYW5jZWwtZXZlbnQuaHRtbCBbIFRpbWVvdXQgXQogCi0jIFRoZSBXZWJLaXQgbmV0d29y ayBkaXNrIGNhY2hlIGlzIG5vdCBlbmFibGVkIG9uIHRoZSBHVEsgcG9ydC4KLXdlYmtpdC5vcmcv Yi8xNDI4MjEgaHR0cC90ZXN0cy9jYWNoZS9kaXNrLWNhY2hlIFsgU2tpcCBdCi0KICMgSGlnaERQ SSBzdXBwb3J0IGlzIG5vdCBlbmFibGVkCiB3ZWJraXQub3JnL2IvMTMxMzQ3IGZhc3QvYmFja2dy b3VuZHMvaGlkcGktYml0bWFwLWJhY2tncm91bmQtcmVwZWF0LW9uLXN1YnBpeGVsLXBvc2l0aW9u Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMzEzNDcgZmFzdC9iYWNr Z3JvdW5kcy9oaWRwaS1nZW5lcmF0ZWQtZ3JhZGllbnQtYmFja2dyb3VuZC1vbi1zdWJwaXhlbC1w b3NpdGlvbi5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBQYXNzIF0KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBhNmQ1 NmFlLi43YmI2NDIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTUtMDUtMDUgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCisgICAgICAgIFtHVEtd W1dLMl0gVGhlIFdlYktpdCBuZXR3b3JrIGRpc2sgY2FjaGUgaXMgbm90IGVuYWJsZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjgyMQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuYWJsZSBOZXR3b3Jr Q2FjaGUgZm9yIHRoZSBHVEsrIHBvcnQuCisKKyAgICAgICAgKiBjb25maWcuaDoKKworMjAxNS0w NS0wNSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAg ICAgW1NPVVBdIE5ldHdvcmsgQ2FjaGU6IElPQ2hhbm5lbCBvcGVyYXRpb25zIGFyZSBub3Qgc2Vu dCB0byB0aGUgcmlnaHQgdGhyZWFkCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDQ1NDIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvY29uZmln LmggYi9Tb3VyY2UvV2ViS2l0Mi9jb25maWcuaAppbmRleCBiYzlhYzI5Li4xNmRlYWZiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9jb25maWcuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9jb25m aWcuaApAQCAtODIsNyArODIsNyBAQAogI2VuZGlmCiAKICNpZm5kZWYgRU5BQkxFX05FVFdPUktf Q0FDSEUKLSNpZiBFTkFCTEUoTkVUV09SS19QUk9DRVNTKSAmJiBQTEFURk9STShDT0NPQSkKKyNp ZiBFTkFCTEUoTkVUV09SS19QUk9DRVNTKSAmJiAoUExBVEZPUk0oQ09DT0EpIHx8IFBMQVRGT1JN KEdUSykpCiAjZGVmaW5lIEVOQUJMRV9ORVRXT1JLX0NBQ0hFIDEKICNlbHNlCiAjZGVmaW5lIEVO QUJMRV9ORVRXT1JLX0NBQ0hFIDAK