142816 2015-03-18 00:39:15 -0700 Call CTFontSetRenderingParameters before rendering text 2015-03-18 11:13:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield commit-queue jonlee webkit-bug-importer oldest_to_newest 1078142 0 mmaxfield 2015-03-18 00:39:15 -0700 Call CTFontSetRenderingParameters before rendering text 1078143 1 248920 mmaxfield 2015-03-18 00:40:48 -0700 Created attachment 248920 Patch 1078144 2 mmaxfield 2015-03-18 00:42:08 -0700 <rdar://problem/19446938> 1078192 3 248920 darin 2015-03-18 08:28:10 -0700 Comment on attachment 248920 Patch While this be efficient enough if we are calling it every time we call the show glyphs function? Is there a more optimal way to do this, perhaps only when the font changes? 1078240 4 mmaxfield 2015-03-18 10:25:54 -0700 (In reply to comment #3) > Comment on attachment 248920 [details] > Patch > > While this be efficient enough if we are calling it every time we call the > show glyphs function? Currently, yes. If this ceases to be the case, I'll add a cache. 1078252 5 248920 commit-queue 2015-03-18 11:13:16 -0700 Comment on attachment 248920 Patch Clearing flags on attachment: 248920 Committed r181703: <http://trac.webkit.org/changeset/181703> 1078253 6 commit-queue 2015-03-18 11:13:20 -0700 All reviewed patches have been landed. Closing bug. 248920 2015-03-18 00:40:48 -0700 2015-03-18 11:13:16 -0700 Patch bug-142816-20150318004014.patch text/plain 3578 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjExMzI3MjZlNWJkZTNj YThmNjExZDBkNDU4NDFmZjg1ZmZjZmY5YS4uZmI3MzdmMDg0YTYxNmFhZmZhNGQ1MDQ5MmVhMjcz OTA0YzNjYjAyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAzLTE4ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgQ2FsbCBDVEZv bnRTZXRSZW5kZXJpbmdQYXJhbWV0ZXJzIGJlZm9yZSByZW5kZXJpbmcgdGV4dAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyODE2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvRm9udENhc2NhZGVDb2NvYS5tbToKKyAg ICAgICAgKFdlYkNvcmU6OnNob3dHbHlwaHNXaXRoQWR2YW5jZXMpOgorICAgICAgICAqIHBsYXRm b3JtL3NwaS9jb2NvYS9Db3JlVGV4dFNQSS5oOgorCiAyMDE1LTAzLTE4ICBUaW0gSG9ydG9uICA8 dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgYnVpbGQgYWZ0ZXIg cjE4MTY2MApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29j b2EvRm9udENhc2NhZGVDb2NvYS5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NvY29hL0ZvbnRDYXNjYWRlQ29jb2EubW0KaW5kZXggMzgyYTEwZjY5ZjM0MGNiZjQ1MDg4NTk0 MDJiYjc1YjllZmMwM2MxOS4uOThhYmUwNDRmNjk2NDliYTA0NmEwOWZmN2NjOTk5ZjBmYzYyNTY3 MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvRm9u dENhc2NhZGVDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j b2NvYS9Gb250Q2FzY2FkZUNvY29hLm1tCkBAIC0xNjEsMTggKzE2MSwyNCBAQCBzdGF0aWMgdm9p ZCBzaG93R2x5cGhzV2l0aEFkdmFuY2VzKGNvbnN0IEZsb2F0UG9pbnQmIHBvaW50LCBjb25zdCBG b250KiBmb250LCBDRwogICAgICAgICAgICAgcG9zaXRpb24ueCArPSBhZHZhbmNlc1tpXS53aWR0 aDsKICAgICAgICAgICAgIHBvc2l0aW9uLnkgKz0gYWR2YW5jZXNbaV0uaGVpZ2h0OwogICAgICAg ICB9Ci0gICAgICAgIGlmICghcGxhdGZvcm1EYXRhLmlzQ29sb3JCaXRtYXBGb250KCkpCisgICAg ICAgIGlmICghcGxhdGZvcm1EYXRhLmlzQ29sb3JCaXRtYXBGb250KCkpIHsKKyNpZiBQTEFURk9S TShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPiAxMDEwMDAKKyAgICAg ICAgICAgIENURm9udFNldFJlbmRlcmluZ1BhcmFtZXRlcnMocGxhdGZvcm1EYXRhLmN0Rm9udCgp LCBjb250ZXh0KTsKKyNlbmRpZgogICAgICAgICAgICAgQ0dDb250ZXh0U2hvd0dseXBoc0F0UG9z aXRpb25zKGNvbnRleHQsIGdseXBocywgcG9zaXRpb25zLmRhdGEoKSwgY291bnQpOwotICAgICAg ICBlbHNlCisgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgQ1RGb250RHJhd0dseXBocyhwbGF0 Zm9ybURhdGEuY3RGb250KCksIGdseXBocywgcG9zaXRpb25zLmRhdGEoKSwgY291bnQsIGNvbnRl eHQpOwogICAgICAgICBDR0NvbnRleHRTZXRUZXh0TWF0cml4KGNvbnRleHQsIHNhdmVkTWF0cml4 KTsKICAgICB9IGVsc2UgewotICAgICAgICBpZiAoIXBsYXRmb3JtRGF0YS5pc0NvbG9yQml0bWFw Rm9udCgpKQorICAgICAgICBpZiAoIXBsYXRmb3JtRGF0YS5pc0NvbG9yQml0bWFwRm9udCgpKSB7 CisjaWYgUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID4g MTAxMDAwCisgICAgICAgICAgICBDVEZvbnRTZXRSZW5kZXJpbmdQYXJhbWV0ZXJzKHBsYXRmb3Jt RGF0YS5jdEZvbnQoKSwgY29udGV4dCk7CisjZW5kaWYKICNwcmFnbWEgY2xhbmcgZGlhZ25vc3Rp YyBwdXNoCiAjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgaWdub3JlZCAiLVdkZXByZWNhdGVkLWRl Y2xhcmF0aW9ucyIKICAgICAgICAgICAgIENHQ29udGV4dFNob3dHbHlwaHNXaXRoQWR2YW5jZXMo Y29udGV4dCwgZ2x5cGhzLCBhZHZhbmNlcywgY291bnQpOwogI3ByYWdtYSBjbGFuZyBkaWFnbm9z dGljIHBvcAotICAgICAgICBlbHNlCisgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgQ1RGb250 RHJhd0dseXBocyhwbGF0Zm9ybURhdGEuY3RGb250KCksIGdseXBocywgcG9zaXRpb25zLmRhdGEo KSwgY291bnQsIGNvbnRleHQpOwogICAgIH0KIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3NwaS9jb2NvYS9Db3JlVGV4dFNQSS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vc3BpL2NvY29hL0NvcmVUZXh0U1BJLmgKaW5kZXggZTUyMGVhYzhhN2Y1YTUyMTAxM2YzZmYw ZjNiNzVkYjI2MWJjZTg3MS4uNWJlOTE0NGVmZDJjYjkxODYwMGZjOGZjMGQ0MTI2ZmY5NTk0NTU0 YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3BpL2NvY29hL0NvcmVUZXh0 U1BJLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3BpL2NvY29hL0NvcmVUZXh0U1BJ LmgKQEAgLTY1LDYgKzY1LDkgQEAgQ0dTaXplIENUUnVuR2V0SW5pdGlhbEFkdmFuY2UoQ1RSdW5S ZWYgcnVuKTsKIENUTGluZVJlZiBDVExpbmVDcmVhdGVXaXRoVW5pQ2hhclByb3ZpZGVyKENUVW5p Q2hhclByb3ZpZGVyQ2FsbGJhY2sgcHJvdmlkZSwgQ1RVbmlDaGFyRGlzcG9zZUNhbGxiYWNrIGRp c3Bvc2UsIHZvaWQqIHJlZkNvbik7CiBDVFR5cGVzZXR0ZXJSZWYgQ1RUeXBlc2V0dGVyQ3JlYXRl V2l0aFVuaUNoYXJQcm92aWRlckFuZE9wdGlvbnMoQ1RVbmlDaGFyUHJvdmlkZXJDYWxsYmFjayBw cm92aWRlLCBDVFVuaUNoYXJEaXNwb3NlQ2FsbGJhY2sgZGlzcG9zZSwgdm9pZCogcmVmQ29uLCBD RkRpY3Rpb25hcnlSZWYgb3B0aW9ucyk7CiBib29sIENURm9udEdldFZlcnRpY2FsR2x5cGhzRm9y Q2hhcmFjdGVycyhDVEZvbnRSZWYsIGNvbnN0IFVuaUNoYXIgY2hhcmFjdGVyc1tdLCBDR0dseXBo IGdseXBoc1tdLCBDRkluZGV4IGNvdW50KTsKKyNpZiBQTEFURk9STShNQUMpICYmIF9fTUFDX09T X1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPiAxMDEwMDAKK3ZvaWQgQ1RGb250U2V0UmVuZGVyaW5n UGFyYW1ldGVycyhDVEZvbnRSZWYsIENHQ29udGV4dFJlZik7CisjZW5kaWYKIAogQ1RGb250RGVz Y3JpcHRvclJlZiBDVEZvbnREZXNjcmlwdG9yQ3JlYXRlRm9yVUlUeXBlKENURm9udFVJRm9udFR5 cGUsIENHRmxvYXQgc2l6ZSwgQ0ZTdHJpbmdSZWYgbGFuZ3VhZ2UpOwogQ1RGb250RGVzY3JpcHRv clJlZiBDVEZvbnREZXNjcmlwdG9yQ3JlYXRlV2l0aFRleHRTdHlsZShDRlN0cmluZ1JlZiBzdHls ZSwgQ0ZTdHJpbmdSZWYgc2l6ZSwgQ0ZTdHJpbmdSZWYgbGFuZ3VhZ2UpOwo=