142815 2015-03-18 00:35:59 -0700 prepare-ChangeLog doesn't understand C string literals split across multiple lines with \ 2015-03-18 09:27:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz mitz darin pknight oldest_to_newest 1078141 0 mitz 2015-03-18 00:35:59 -0700 <rdar://problem/20192067> The line continuation sequence (backslash followed by newline) confuses prepare-ChangeLog’s get_function_line_ranges_for_cpp(), causing it to emit false “mismatched quotes” warnings. 1078145 1 248921 mitz 2015-03-18 00:45:22 -0700 Created attachment 248921 Allow strings to continue to the next line 1078228 2 mitz 2015-03-18 09:27:51 -0700 Fixed in <http://trac.webkit.org/r181696>. 248921 2015-03-18 00:45:22 -0700 2015-03-18 08:17:38 -0700 Allow strings to continue to the next line bug-142815-20150318004451.patch text/plain 2628 mitz SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MTY4OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE1LTAzLTE4ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisK KyAgICAgICAgcHJlcGFyZS1DaGFuZ2VMb2cgZG9lc24ndCB1bmRlcnN0YW5kIEMgc3RyaW5nIGxp dGVyYWxzIHNwbGl0IGFjcm9zcyBtdWx0aXBsZSBsaW5lcyB3aXRoIFwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjgxNQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9wcmVwYXJlLUNoYW5n ZUxvZzoKKyAgICAgICAgKGdldF9mdW5jdGlvbl9saW5lX3Jhbmdlc19mb3JfY3BwKTogSWYgdGhl IGxpbmUgZW5kcyB3aXRoIGEgYmFja3NsYXNoIGluc3RlYWQgb2YgYSBtYXRjaGluZworICAgICAg ICBxdW90YXRpb24gbWFyaywgdXNlIG5ldyB2YXJpYWJsZSAkcXVvdGF0aW9uX21hcmsgdG8gcmVt ZW1iZXIgd2hhdCB3ZSBhcmUgbG9va2luZyBmb3IsIGFuZAorICAgICAgICBrZWVwIGNvbnN1bWlu ZyB0aGUgcXVvdGVkIHRleHQgdW50aWwgdGhlIG1hdGNoaW5nIHF1b3RhdGlvbiBtYXJrIGlzIHJl YWNoZWQuIEVtaXQgdGhlCisgICAgICAgIHdhcm5pbmcgb25seSBpZiBhIGxpbmUgZW5kcyB3aXRo b3V0IGEgYmFja3NsYXNoIGJlZm9yZSB0aGUgbWF0Y2hpbmcgcXVvdGF0aW9uIG1hcmsgd2FzIGZv dW5kLgorCiAyMDE1LTAzLTE3ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgogCiAgICAgICAgIEZpeCB0aGUgaU9TIGJ1aWxkLgpJbmRleDogVG9vbHMvU2NyaXB0cy9wcmVw YXJlLUNoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdl TG9nCShyZXZpc2lvbiAxODE1MTApCisrKyBUb29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC02OTcsNiArNjk3LDcgQEAgc3ViIGdldF9mdW5jdGlvbl9saW5l X3Jhbmdlc19mb3JfY3BwKCQkKQogICAgIG15ICRpbl9tYWNybyA9IDA7CiAgICAgbXkgJGluX21l dGhvZF9kZWNsYXJhdGlvbiA9IDA7CiAgICAgbXkgJGluX3BhcmVudGhlc2VzID0gMDsKKyAgICBt eSAkcXVvdGF0aW9uX21hcms7CiAgICAgbXkgJGluX2JyYWNlcyA9IDA7CiAgICAgbXkgJGluX3Rv cGxldmVsX2FycmF5X2JyYWNlID0gMDsKICAgICBteSAkYnJhY2Vfc3RhcnQgPSAwOwpAQCAtNzIz LDYgKzcyNCwxOCBAQCBzdWIgZ2V0X2Z1bmN0aW9uX2xpbmVfcmFuZ2VzX2Zvcl9jcHAoJCQpCiAg ICAgbXkgQGFsbF9uYW1lc3BhY2VzOwogCiAgICAgd2hpbGUgKDwkZmlsZV9oYW5kbGU+KSB7Cisg ICAgICAgICMgSGFuZGxlIGNvbnRpbnVlZCBxdW90ZWQgc3RyaW5nLgorICAgICAgICBpZiAoJHF1 b3RhdGlvbl9tYXJrKSB7CisgICAgICAgICAgICBpZiAoIXMtKFteXFxdfFxcLikqJHF1b3RhdGlv bl9tYXJrLS0pIHsKKyAgICAgICAgICAgICAgICBpZiAoIW0tXFwkLSkgeworICAgICAgICAgICAg ICAgICAgICB3YXJuICJtaXNtYXRjaGVkIHF1b3RlcyBhdCBsaW5lICQuIGluICRmaWxlX25hbWVc biI7CisgICAgICAgICAgICAgICAgICAgIHVuZGVmICRxdW90YXRpb25fbWFyazsKKyAgICAgICAg ICAgICAgICB9CisgICAgICAgICAgICAgICAgbmV4dDsKKyAgICAgICAgICAgIH0KKyAgICAgICAg ICAgIHVuZGVmICRxdW90YXRpb25fbWFyazsKKyAgICAgICAgfQorCiAgICAgICAgICMgSGFuZGxl IGNvbnRpbnVlZCBtdWx0aS1saW5lIGNvbW1lbnQuCiAgICAgICAgIGlmICgkaW5fY29tbWVudCkg ewogICAgICAgICAgICAgbmV4dCB1bmxlc3Mgcy0uKlwqLy0tOwpAQCAtNzUzLDggKzc2NiwxMiBA QCBzdWIgZ2V0X2Z1bmN0aW9uX2xpbmVfcmFuZ2VzX2Zvcl9jcHAoJCQpCiAgICAgICAgICAgICAg ICAgcy0vLy4qLS07CiAgICAgICAgICAgICB9IGVsc2UgeyAjICcgb3IgIgogICAgICAgICAgICAg ICAgIGlmICghcy0kbWF0Y2goW15cXF18XFwuKSo/JG1hdGNoLS0pIHsKLSAgICAgICAgICAgICAg ICAgICAgd2FybiAibWlzbWF0Y2hlZCBxdW90ZXMgYXQgbGluZSAkLiBpbiAkZmlsZV9uYW1lXG4i OwotICAgICAgICAgICAgICAgICAgICBzLSRtYXRjaC4qLS07CisgICAgICAgICAgICAgICAgICAg IGlmICghcy0kbWF0Y2guKlxcJC0tKSB7CisgICAgICAgICAgICAgICAgICAgICAgICB3YXJuICJt aXNtYXRjaGVkIHF1b3RlcyBhdCBsaW5lICQuIGluICRmaWxlX25hbWVcbiI7CisgICAgICAgICAg ICAgICAgICAgICAgICBzLSRtYXRjaC4qLS07CisgICAgICAgICAgICAgICAgICAgIH0gZWxzZSB7 CisgICAgICAgICAgICAgICAgICAgICAgICAkcXVvdGF0aW9uX21hcmsgPSAkbWF0Y2g7CisgICAg ICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAg ICAgIH0K