142811 2015-03-17 22:44:12 -0700 Skip trying to paint overlay scrollbars when there are none or they are clipped out 2015-03-18 09:23:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser bdakin commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser zalan oldest_to_newest 1078116 0 simon.fraser 2015-03-17 22:44:12 -0700 Skip trying to paint overlay scrollbars when there are none or they are clipped out 1078117 1 248912 simon.fraser 2015-03-17 22:45:57 -0700 Created attachment 248912 Patch 1078197 2 248912 darin 2015-03-18 08:34:37 -0700 Comment on attachment 248912 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248912&action=review > Source/WebCore/ChangeLog:14 > + and don't both setting up an empty clip just to paint nothing. both -> bother > Source/WebCore/rendering/RenderLayer.cpp:4784 > for (size_t i = 0; i < layerFragments.size(); ++i) { > const LayerFragment& fragment = layerFragments.at(i); Should use modern for loop. 1078225 3 simon.fraser 2015-03-18 09:23:38 -0700 http://trac.webkit.org/changeset/181695 248912 2015-03-17 22:45:57 -0700 2015-03-18 08:34:37 -0700 Patch bug-142811-20150317224526.patch text/plain 2576 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzYyZTk0MjhjNDgxNjI5 MTFiMzRlNWYyNTIzNmQ4ZTYwMzkxYWM4OS4uNjYxOTJhZDJiMDkxOTkxMzZjYjFlYzYyMGNlNGYx ZDU3NWY1Y2FkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTAzLTE3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFNraXAgdHJ5aW5n IHRvIHBhaW50IG92ZXJsYXkgc2Nyb2xsYmFycyB3aGVuIHRoZXJlIGFyZSBub25lIG9yIHRoZXkg YXJlIGNsaXBwZWQgb3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDI4MTEKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjAyMDA3MjUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBzb21lIGNvbnRlbnQg d2l0aCBsb3RzIG9mIGxheWVycyBhbmQgb3ZlcmZsb3c6c2Nyb2xsLCB3ZSBjb3VsZCBzcGVuZCAy MCUgb2YKKyAgICAgICAgdGhlIHRpbWUgdW5kZXIgcGFpbnRPdmVyZmxvd0NvbnRyb2xzRm9yRnJh Z21lbnRzKCkgc2V0dGluZyB1cCBhbiAoZW1wdHkpIGNsaXAsCisgICAgICAgIGFuZCB0aGVuIHRy eWluZyB0byBkcmF3IHNjcm9sbGJhcnMgdGhhdCB3ZSBkb24ndCBoYXZlLgorICAgICAgICAKKyAg ICAgICAgQXZvaWQgY2FsbGluZyBwYWludE92ZXJmbG93Q29udHJvbHNGb3JGcmFnbWVudHMoKSBp ZiB0aGVyZSBhcmUgbm8gc2Nyb2xsYmFycywKKyAgICAgICAgYW5kIGRvbid0IGJvdGggc2V0dGlu ZyB1cCBhbiBlbXB0eSBjbGlwIGp1c3QgdG8gcGFpbnQgbm90aGluZy4KKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6 cGFpbnRMYXllckNvbnRlbnRzKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpwYWlu dE92ZXJmbG93Q29udHJvbHNGb3JGcmFnbWVudHMpOgorCiAyMDE1LTAzLTE3ICBDaHJpcyBEdW1l eiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY11baU9TXSBzZXRTaGFyZWRUaW1l ckZpcmVJbnRlcnZhbCgpIC8gc3RvcFNoYXJlZFRpbWVyKCkgYXJlIGV4cGVuc2l2ZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggNDU1N2EwOTRhNzg3N2FlYzYy OTNmNjUyZDAxM2QxNDE0MDU3ZDk2NC4uNWJkOGVkZjExNDFiMjA2YjIwMmQ3Yjc2ZTQ0MzM3NTBm YzA3OWFhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC00 MzE5LDcgKzQzMTksNyBAQCB2b2lkIFJlbmRlckxheWVyOjpwYWludExheWVyQ29udGVudHMoR3Jh cGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBMYXllclBhaW50aQogICAgICAgICAgICAgcGFp bnRGbG93VGhyZWFkSWZSZWdpb25Gb3JGcmFnbWVudHMobGF5ZXJGcmFnbWVudHMsIGNvbnRleHQs IGxvY2FsUGFpbnRpbmdJbmZvLCBsb2NhbFBhaW50RmxhZ3MpOwogICAgIH0KIAotICAgIGlmIChp c1BhaW50aW5nT3ZlcmxheVNjcm9sbGJhcnMpCisgICAgaWYgKGlzUGFpbnRpbmdPdmVybGF5U2Ny b2xsYmFycyAmJiBoYXNTY3JvbGxiYXJzKCkpCiAgICAgICAgIHBhaW50T3ZlcmZsb3dDb250cm9s c0ZvckZyYWdtZW50cyhsYXllckZyYWdtZW50cywgY29udGV4dCwgbG9jYWxQYWludGluZ0luZm8p OwogCiAgICAgaWYgKGZpbHRlclBhaW50ZXIpIHsKQEAgLTQ3ODIsNiArNDc4Miw4IEBAIHZvaWQg UmVuZGVyTGF5ZXI6OnBhaW50T3ZlcmZsb3dDb250cm9sc0ZvckZyYWdtZW50cyhjb25zdCBMYXll ckZyYWdtZW50cyYgbGF5ZXJGCiB7CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBsYXllckZy YWdtZW50cy5zaXplKCk7ICsraSkgewogICAgICAgICBjb25zdCBMYXllckZyYWdtZW50JiBmcmFn bWVudCA9IGxheWVyRnJhZ21lbnRzLmF0KGkpOworICAgICAgICBpZiAoZnJhZ21lbnQuYmFja2dy b3VuZFJlY3QuaXNFbXB0eSgpKQorICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgIGNsaXBU b1JlY3QobG9jYWxQYWludGluZ0luZm8sIGNvbnRleHQsIGZyYWdtZW50LmJhY2tncm91bmRSZWN0 KTsKICAgICAgICAgcGFpbnRPdmVyZmxvd0NvbnRyb2xzKGNvbnRleHQsIHJvdW5kZWRJbnRQb2lu dCh0b0xheW91dFBvaW50KGZyYWdtZW50LmxheWVyQm91bmRzLmxvY2F0aW9uKCkgLSByZW5kZXJC b3hMb2NhdGlvbigpICsgbG9jYWxQYWludGluZ0luZm8uc3VicGl4ZWxBY2N1bXVsYXRpb24pKSwK ICAgICAgICAgICAgIHNuYXBwZWRJbnRSZWN0KGZyYWdtZW50LmJhY2tncm91bmRSZWN0LnJlY3Qo KSksIHRydWUpOwo=