142800 2015-03-17 16:14:51 -0700 Web Inspector: Hide Frames Timeline if the backend doesn't support it 2015-04-11 19:24:29 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck mattbaker commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1078015 0 joepeck 2015-03-17 16:14:51 -0700 * SUMMARY Hide Frames Timeline if the backend doesn't support it. * STEPS TO REPRODUCE 1. Inspect an iOS 8 device 2. Show Timelines => Frames Timeline is listed, but it will always be blank and waste space 1083697 1 webkit-bug-importer 2015-04-08 12:41:37 -0700 <rdar://problem/20470455> 1084561 2 250579 mattbaker 2015-04-11 13:05:16 -0700 Created attachment 250579 [PATCH] Proposed Fix 1084599 3 250579 commit-queue 2015-04-11 19:24:25 -0700 Comment on attachment 250579 [PATCH] Proposed Fix Clearing flags on attachment: 250579 Committed r182665: <http://trac.webkit.org/changeset/182665> 1084600 4 commit-queue 2015-04-11 19:24:29 -0700 All reviewed patches have been landed. Closing bug. 250579 2015-04-11 13:05:16 -0700 2015-04-11 19:24:25 -0700 [PATCH] Proposed Fix bug-142800-20150411130423.patch text/plain 6076 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 MTYxMzEzZTg2MDU0MmI2MjJlMGFkMDM4ODNiYzIwZjhlNTJmNzcwLi4xYTZmYmVmNmYyNGQ0Y2I4 YmE5Mzg0YjJkODlhZTM1OTA2Y2I1MWU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyNiBAQAogMjAxNS0wNC0xMSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSGlkZSBGcmFtZXMgVGltZWxpbmUgaWYgdGhlIGJh Y2tlbmQgZG9lc24ndCBzdXBwb3J0IGl0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDI4MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGYWxsYmFjayB0byBzaG93aW5nIHRoZSBsYXlvdXQgdGltZWxpbmUg aWYgdGhlIGJhY2tlbmQgZG9lc24ndCBzdXBwb3J0IHRoZSByZW5kZXJpbmcgZnJhbWVzIHRpbWVs aW5lLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFn ZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVNYW5hZ2VyLnNob3VsZFNob3dW aWV3Rm9yVGltZWxpbmUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lTWFuYWdlci5w cm90b3R5cGUuX2xvYWROZXdSZWNvcmRpbmcpOgorICAgICAgICBBZGRlZCBpT1MgOCBjb21wYXRp YmlsaXR5IGNoZWNrIGZvciBSZW5kZXJpbmdGcmFtZSB0aW1lbGluZSByZWNvcmQgdHlwZS4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0VGltZWxpbmVEYXRhR3JpZE5vZGUu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTGF5b3V0VGltZWxpbmVEYXRhR3JpZE5vZGUucHJv dG90eXBlLmdldCBkYXRhKToKKyAgICAgICAgUmVzdG9yZWQgZmllbGRzIHVzZWQgYnkgTGF5b3V0 IHRpbWVsaW5lIHZpZXcuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0xheW91dFRp bWVsaW5lVmlldy5qczoKKyAgICAgICAgVXBkYXRlZCB0byBiZSBjb21wYXRpYmxlIHdpdGggYm90 aCBSZW5kZXJpbmdGcmFtZSBhbmQgTGF5b3V0IHRpbWVsaW5lIHZpZXdzLgorCisyMDE1LTA0LTEx ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVj dG9yOiBjcmVhdGUgY29udGVudCB2aWV3IGFuZCBkZXRhaWxzIHNpZGViYXIgZm9yIEZyYW1lcyB0 aW1lbGluZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQzNTMzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdlci5qcwppbmRleCBlYzY3MDIw YjBmMTBiOWQzMzRjY2JjZjA5OTMyODgxNTAxNWJlMjcyLi5iMDRiNzAwMWUyNGQyNmRkM2NjNjg4 ZWYxOWI1ODM5NTczZmYwMWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvVGltZWxpbmVNYW5hZ2VyLmpz CkBAIC01NCw2ICs1NCwxMiBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVNYW5hZ2VyID0gY2xhc3Mg VGltZWxpbmVNYW5hZ2VyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogCiAgICAgc3RhdGlj IHNob3VsZFNob3dWaWV3Rm9yVGltZWxpbmUodGltZWxpbmUpCiAgICAgeworICAgICAgICAvLyBD T01QQVRJQklMSVRZIChpT1MgOCk6IFRpbWVsaW5lQWdlbnQuRXZlbnRUeXBlLlJlbmRlcmluZ0Zy YW1lIGRpZCBub3QgZXhpc3QsCisgICAgICAgIC8vIGZhbGxiYWNrIHRvIGRpc3BsYXlpbmcgYWxs IG90aGVyIHRpbWVsaW5lcy4KKyAgICAgICAgaWYgKCFUaW1lbGluZUFnZW50LkV2ZW50VHlwZS5S ZW5kZXJpbmdGcmFtZSkKKyAgICAgICAgICAgIHJldHVybiB0aW1lbGluZS50eXBlICE9PSBXZWJJ bnNwZWN0b3IuVGltZWxpbmVSZWNvcmQuVHlwZS5SZW5kZXJpbmdGcmFtZTsKKworICAgICAgICAv LyBEb24ndCBzaG93IHRoZSBMYXlvdXQgdGltZWxpbmUgdmlldyB3aGVuIHRoZSBSZW5kZXJpbmdG cmFtZSB0aW1lbGluZSBleGlzdHMuCiAgICAgICAgIHJldHVybiB0aW1lbGluZS50eXBlICE9PSBX ZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmQuVHlwZS5MYXlvdXQ7CiAgICAgfQogCkBAIC00Mjks NyArNDM1LDExIEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZU1hbmFnZXIgPSBjbGFzcyBUaW1lbGlu ZU1hbmFnZXIgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAgICAgICAgIHZhciBpZGVudGlm aWVyID0gdGhpcy5fbmV4dFJlY29yZGluZ0lkZW50aWZpZXIrKzsKICAgICAgICAgdmFyIG5ld1Jl Y29yZGluZyA9IG5ldyBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmcoaWRlbnRpZmllciwg V2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJUaW1lbGluZSBSZWNvcmRpbmcgJWQiKS5mb3JtYXQoaWRl bnRpZmllcikpOwogICAgICAgICBuZXdSZWNvcmRpbmcuYWRkVGltZWxpbmUoV2ViSW5zcGVjdG9y LlRpbWVsaW5lLmNyZWF0ZShXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmQuVHlwZS5OZXR3b3Jr LCBuZXdSZWNvcmRpbmcpKTsKLSAgICAgICAgbmV3UmVjb3JkaW5nLmFkZFRpbWVsaW5lKFdlYklu c3BlY3Rvci5UaW1lbGluZS5jcmVhdGUoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkLlR5cGUu UmVuZGVyaW5nRnJhbWUsIG5ld1JlY29yZGluZykpOworCisgICAgICAgIC8vIENPTVBBVElCSUxJ VFkgKGlPUyA4KTogVGltZWxpbmVBZ2VudC5FdmVudFR5cGUuUmVuZGVyaW5nRnJhbWUgZGlkIG5v dCBleGlzdC4KKyAgICAgICAgaWYgKFRpbWVsaW5lQWdlbnQuRXZlbnRUeXBlLlJlbmRlcmluZ0Zy YW1lKQorICAgICAgICAgICAgbmV3UmVjb3JkaW5nLmFkZFRpbWVsaW5lKFdlYkluc3BlY3Rvci5U aW1lbGluZS5jcmVhdGUoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkLlR5cGUuUmVuZGVyaW5n RnJhbWUsIG5ld1JlY29yZGluZykpOworCiAgICAgICAgIG5ld1JlY29yZGluZy5hZGRUaW1lbGlu ZShXZWJJbnNwZWN0b3IuVGltZWxpbmUuY3JlYXRlKFdlYkluc3BlY3Rvci5UaW1lbGluZVJlY29y ZC5UeXBlLkxheW91dCwgbmV3UmVjb3JkaW5nKSk7CiAgICAgICAgIG5ld1JlY29yZGluZy5hZGRU aW1lbGluZShXZWJJbnNwZWN0b3IuVGltZWxpbmUuY3JlYXRlKFdlYkluc3BlY3Rvci5UaW1lbGlu ZVJlY29yZC5UeXBlLlNjcmlwdCwgbmV3UmVjb3JkaW5nKSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xheW91dFRpbWVsaW5lRGF0YUdy aWROb2RlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5 b3V0VGltZWxpbmVEYXRhR3JpZE5vZGUuanMKaW5kZXggMzYwMWYwNTQxYjU2Mzk2NGYwNDc3YWY2 Yzg2YTdlZTdhYTIxYmVlMC4uNDg1ODUzM2EzN2E4ZWVkMTE3YzQ3ZGEwZTk0NTI5ZTBiNWQ4Y2Q4 YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv TGF5b3V0VGltZWxpbmVEYXRhR3JpZE5vZGUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0VGltZWxpbmVEYXRhR3JpZE5vZGUuanMKQEAgLTU1 LDcgKzU1LDcgQEAgV2ViSW5zcGVjdG9yLkxheW91dFRpbWVsaW5lRGF0YUdyaWROb2RlLnByb3Rv dHlwZSA9IHsKIAogICAgIGdldCBkYXRhKCkKICAgICB7Ci0gICAgICAgIHJldHVybiB7ZXZlbnRU eXBlOiB0aGlzLl9yZWNvcmQuZXZlbnRUeXBlLCBzdGFydFRpbWU6IHRoaXMuX3JlY29yZC5zdGFy dFRpbWUsIHRvdGFsVGltZTogdGhpcy5fcmVjb3JkLmR1cmF0aW9uLCBsb2NhdGlvbjogdGhpcy5f cmVjb3JkLmluaXRpYXRvckNhbGxGcmFtZX07CisgICAgICAgIHJldHVybiB7ZXZlbnRUeXBlOiB0 aGlzLl9yZWNvcmQuZXZlbnRUeXBlLCB3aWR0aDogdGhpcy5fcmVjb3JkLndpZHRoLCBoZWlnaHQ6 IHRoaXMuX3JlY29yZC5oZWlnaHQsIGFyZWE6IHRoaXMuX3JlY29yZC53aWR0aCAqIHRoaXMuX3Jl Y29yZC5oZWlnaHQsIHN0YXJ0VGltZTogdGhpcy5fcmVjb3JkLnN0YXJ0VGltZSwgdG90YWxUaW1l OiB0aGlzLl9yZWNvcmQuZHVyYXRpb24sIGxvY2F0aW9uOiB0aGlzLl9yZWNvcmQuaW5pdGlhdG9y Q2FsbEZyYW1lfTsKICAgICB9LAogCiAgICAgY3JlYXRlQ2VsbENvbnRlbnQ6IGZ1bmN0aW9uKGNv bHVtbklkZW50aWZpZXIsIGNlbGwpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9MYXlvdXRUaW1lbGluZVZpZXcuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9MYXlvdXRUaW1lbGluZVZpZXcuanMKaW5kZXgg MDViNDZkNWE4NWM5OWM3ZWVjMjdkOWM3ZThlN2M4MDIxMzU3NDEwNS4uYTAxMmFjN2E1OWVhNzg5 ODEwMmJhNzQwYmYxYzYyMDM2N2YyYmY1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0VGltZWxpbmVWaWV3LmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xheW91dFRpbWVsaW5lVmlldy5q cwpAQCAtMzQsNyArMzQsNyBAQCBXZWJJbnNwZWN0b3IuTGF5b3V0VGltZWxpbmVWaWV3ID0gZnVu Y3Rpb24odGltZWxpbmUpCiAgICAgdGhpcy5uYXZpZ2F0aW9uU2lkZWJhclRyZWVPdXRsaW5lLmVs ZW1lbnQuY2xhc3NMaXN0LmFkZChXZWJJbnNwZWN0b3IuTmF2aWdhdGlvblNpZGViYXJQYW5lbC5I aWRlRGlzY2xvc3VyZUJ1dHRvbnNTdHlsZUNsYXNzTmFtZSk7CiAgICAgdGhpcy5uYXZpZ2F0aW9u U2lkZWJhclRyZWVPdXRsaW5lLmVsZW1lbnQuY2xhc3NMaXN0LmFkZChXZWJJbnNwZWN0b3IuTGF5 b3V0VGltZWxpbmVWaWV3LlRyZWVPdXRsaW5lU3R5bGVDbGFzc05hbWUpOwogCi0gICAgdmFyIGNv bHVtbnMgPSB7ZXZlbnRUeXBlOiB7fSwgaW5pdGlhdG9yQ2FsbEZyYW1lOiB7fSwgd2lkdGg6IHt9 LCBoZWlnaHQ6IHt9LCBzdGFydFRpbWU6IHt9LCBkdXJhdGlvbjoge319OworICAgIHZhciBjb2x1 bW5zID0ge2V2ZW50VHlwZToge30sIGluaXRpYXRvckNhbGxGcmFtZToge30sIHdpZHRoOiB7fSwg aGVpZ2h0OiB7fSwgc3RhcnRUaW1lOiB7fSwgdG90YWxUaW1lOiB7fX07CiAKICAgICBjb2x1bW5z LmV2ZW50VHlwZS50aXRsZSA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiVHlwZSIpOwogICAgIGNv bHVtbnMuZXZlbnRUeXBlLndpZHRoID0gIjE1JSI7CkBAIC02MSw5ICs2MSw5IEBAIFdlYkluc3Bl Y3Rvci5MYXlvdXRUaW1lbGluZVZpZXcgPSBmdW5jdGlvbih0aW1lbGluZSkKICAgICBjb2x1bW5z LnN0YXJ0VGltZS53aWR0aCA9ICI4JSI7CiAgICAgY29sdW1ucy5zdGFydFRpbWUuYWxpZ25lZCA9 ICJyaWdodCI7CiAKLSAgICBjb2x1bW5zLmR1cmF0aW9uLnRpdGxlID0gV2ViSW5zcGVjdG9yLlVJ U3RyaW5nKCJEdXJhdGlvbiIpOwotICAgIGNvbHVtbnMuZHVyYXRpb24ud2lkdGggPSAiOCUiOwot ICAgIGNvbHVtbnMuZHVyYXRpb24uYWxpZ25lZCA9ICJyaWdodCI7CisgICAgY29sdW1ucy50b3Rh bFRpbWUudGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkR1cmF0aW9uIik7CisgICAgY29s dW1ucy50b3RhbFRpbWUud2lkdGggPSAiOCUiOworICAgIGNvbHVtbnMudG90YWxUaW1lLmFsaWdu ZWQgPSAicmlnaHQiOwogCiAgICAgZm9yICh2YXIgY29sdW1uIGluIGNvbHVtbnMpCiAgICAgICAg IGNvbHVtbnNbY29sdW1uXS5zb3J0YWJsZSA9IHRydWU7Cg==