142794 2015-03-17 15:01:47 -0700 check-webkit-style should allow "bool a : 1" 2015-03-17 15:58:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino commit-queue glenn oldest_to_newest 1077979 0 dino 2015-03-17 15:01:47 -0700 check-webkit-style should allow "bool a : 1" 1077981 1 dino 2015-03-17 15:03:20 -0700 We should allow this type of bitfield in the style checker: bool m_var : 1; At the moment we warn, suggesting we should use unsigned. But we're actually using bool in a lot of places because Visual Studio 8 was the last compiler that wasn't happy, and we're long past that. 1077984 2 248872 dino 2015-03-17 15:07:38 -0700 Created attachment 248872 Patch 1077987 3 248872 bfulgham 2015-03-17 15:14:47 -0700 Comment on attachment 248872 Patch r=me 1078008 4 dino 2015-03-17 15:58:39 -0700 Committed r181669: <http://trac.webkit.org/changeset/181669> 248872 2015-03-17 15:07:38 -0700 2015-03-17 15:14:47 -0700 Patch bug-142794-20150317150708.patch text/plain 3187 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNjYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDMyMDNlOTQ4MThhYWFkOWRjYWZiOTlmNDZlMjAyOGI5 MDU1MWU3Mi4uMmU0OGRlZGVlMGVmODVjMTNiNzQ5ZjkyNzVhYjU0NWI1ZjQ5MDUzMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDE1LTAzLTE3ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAg ICBjaGVjay13ZWJraXQtc3R5bGUgc2hvdWxkIGFsbG93ICJib29sIGEgOiAxIgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyNzk0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugc2hvdWxkIGFsbG93IG1l bWJlciBiaXRmaWVsZHMgb2YgdGhlIGZvcm06CisKKyAgICAgICAgYm9vbCBtX3ZhciA6IDE7CisK KyAgICAgICAgSXQgc2VlbXMgdGhhdCBWaXN1YWwgU3R1ZGlvIDggd2FzIHRoZSBsYXN0IGNvbXBp bGVyIHRoYXQKKyAgICAgICAgd2Fzbid0IGhhcHB5IGFib3V0IG5vdCB1c2luZyB1bnNpZ25lZCBo ZXJlLiBXZSBhbHJlYWR5IGhhdmUKKyAgICAgICAgYWJvdXQgNTAwIGNhc2VzIHdoZXJlIHBlb3Bs ZSB3ZXJlIGlnbm9yaW5nIHRoaXMgcnVsZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwLnB5OgorICAgICAgICAoY2hlY2tfbGFuZ3VhZ2UpOiBBbGxvdyAi Ym9vbCIuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5p dHRlc3QucHk6IEFkZCB0ZXN0cy4KKyAgICAgICAgKENwcFN0eWxlVGVzdC50ZXN0X2VudW1fYml0 ZmllbGRzKToKKyAgICAgICAgKENwcFN0eWxlVGVzdC50ZXN0X3BsYWluX2ludGVncmFsX2JpdGZp ZWxkcyk6CisKIDIwMTUtMDMtMTcgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFibGV0QGNyZi5j YW5vbi5mcj4KIAogICAgICAgICBXM0MgdGVzdCBwYXJzZXIgYW5kIGNvbnZlcnRlciBzaG91bGQg dXNlIHRlc3QgaW1wb3J0ZXIgaG9zdApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2No ZWNrZXJzL2NwcC5weQppbmRleCBmN2Y0ZjI0MDQ4NjAxZTcwOTRmNzE5ZjBkYTlmZGRmMzg4ZjQ3 YzU5Li44MmUyYjc4YWE2OGU0OWY0OTY1NTE0YWI5MDEwMjFhNjY0Yzg5NWU1IDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMzI3Myw3ICszMjcz LDcgQEAgZGVmIGNoZWNrX2xhbmd1YWdlKGZpbGVuYW1lLCBjbGVhbl9saW5lcywgbGluZV9udW1i ZXIsIGZpbGVfZXh0ZW5zaW9uLCBpbmNsdWRlX3MKICAgICBtYXRjaGVkID0gcmUubWF0Y2gocidc cyooKGNvbnN0fG11dGFibGUpXHMrKT8oW2EtekEtWl9dW2EtekEtWjAtOV9dKilccytbYS16QS1a X11bYS16QS1aMC05X10qXHMqOlxzKlxkK1xzKjsnLCBsaW5lKQogICAgIGlmIG1hdGNoZWQ6CiAg ICAgICAgICMgTWFrZSBzdXJlIHRoZSB0eXBlIGlzIGFuIGVudW0gYW5kIG5vdCBhbiBpbnRlZ3Jh bCB0eXBlCi0gICAgICAgIGlmIG5vdCBtYXRjaChyJ2NoYXJ8KHNob3J0KFxzK2ludCk/KXxpbnR8 bG9uZyhccysobG9uZ3xpbnQpKXwoc2lnbmVkfHVuc2lnbmVkKShccytpbnQpPycsIG1hdGNoZWQu Z3JvdXAoMykpOgorICAgICAgICBpZiBub3QgbWF0Y2gocidib29sfGNoYXJ8KHNob3J0KFxzK2lu dCk/KXxpbnR8bG9uZyhccysobG9uZ3xpbnQpKXwoc2lnbmVkfHVuc2lnbmVkKShccytpbnQpPycs IG1hdGNoZWQuZ3JvdXAoMykpOgogICAgICAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICdydW50 aW1lL2VudW1fYml0ZmllbGRzJywgNSwKICAgICAgICAgICAgICAgICAgICdQbGVhc2UgZGVjbGFy ZSBlbnVtIGJpdGZpZWxkcyBhcyB1bnNpZ25lZCBpbnRlZ3JhbCB0eXBlcy4nKQogCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5w eSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5 CmluZGV4IDAxMDljNjc2MTk1OGNlMzVkOTZkODVjYzg2M2IyMGIwOTI5YWU1ZmMuLmZlMzM0NjI1 NWM3NDQ0ODNkNDViMmU1ODgzMzQ3NDhkNzYyNmNmNmUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC0yNTUyLDYg KzI1NTIsNyBAQCBjbGFzcyBDcHBTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAg IHNlbGYuYXNzZXJ0X2xpbnQoJ0FuRW51bSBhIDogMzA7JywgZXJybXNnKQogICAgICAgICBzZWxm LmFzc2VydF9saW50KCdtdXRhYmxlIEFuRW51bSBhIDogMTQ7JywgZXJybXNnKQogICAgICAgICBz ZWxmLmFzc2VydF9saW50KCdjb25zdCBBbkVudW0gYSA6IDY7JywgZXJybXNnKQorICAgICAgICBz ZWxmLmFzc2VydF9saW50KCdib29sIGEgOiAxOycsICcnKQogCiAgICAgIyBJbnRlZ3JhbCBiaXRm aWVsZHMgbXVzdCBiZSBkZWNsYXJlZCB3aXRoIGVpdGhlciBzaWduZWQgb3IgdW5zaWduZWQga2V5 d29yZC4KICAgICBkZWYgdGVzdF9wbGFpbl9pbnRlZ3JhbF9iaXRmaWVsZHMoc2VsZik6CkBAIC0y NTYyLDcgKzI1NjMsNyBAQCBjbGFzcyBDcHBTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAg ICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2NvbnN0IGNoYXIgYSA6IDY7JywgZXJybXNnKQogICAg ICAgICBzZWxmLmFzc2VydF9saW50KCdsb25nIGludCBhIDogMzA7JywgZXJybXNnKQogICAgICAg ICBzZWxmLmFzc2VydF9saW50KCdpbnQgYSA9IDEgPyAwIDogMzA7JywgJycpCi0KKyAgICAgICAg c2VsZi5hc3NlcnRfbGludCgnYm9vbCBhIDogMTsnLCAnJykKIAogY2xhc3MgQ2xlYW5zZWRMaW5l c1Rlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgIGRlZiB0ZXN0X2luaXQoc2VsZik6Cg==