142784 2015-03-17 09:04:51 -0700 [WinCairo] Video position is incorrect when located inside a frame. 2015-03-18 09:18:40 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham ossy peavo oldest_to_newest 1077890 0 peavo 2015-03-17 09:04:51 -0700 We need to take the enclosing frame's position into account, when finding the video position. 1077891 1 248850 peavo 2015-03-17 09:08:29 -0700 Created attachment 248850 Patch 1077896 2 248850 bfulgham 2015-03-17 09:17:05 -0700 Comment on attachment 248850 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248850&action=review This looks good to me. Could you please use "positionInWIndow" instead of "posInWindow" when you land it? > Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:207 > + IntPoint posInWindow(m_lastPaintRect.location()); I think this should be called "positionInWIndow". 1077897 3 peavo 2015-03-17 09:22:10 -0700 (In reply to comment #2) > Comment on attachment 248850 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248850&action=review > > This looks good to me. Could you please use "positionInWIndow" instead of > "posInWindow" when you land it? > > > Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:207 > > + IntPoint posInWindow(m_lastPaintRect.location()); > > I think this should be called "positionInWIndow". Thanks :) Will do. 1077899 4 248850 bfulgham 2015-03-17 09:25:46 -0700 Comment on attachment 248850 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248850&action=review >>> Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:207 >>> + IntPoint posInWindow(m_lastPaintRect.location()); >> >> I think this should be called "positionInWIndow". > > Thanks :) Will do. Of course, I meant "positionInWindow", not "positionInWIndow" ;-) 1077902 5 peavo 2015-03-17 09:36:15 -0700 (In reply to comment #4) > Comment on attachment 248850 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248850&action=review > > >>> Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:207 > >>> + IntPoint posInWindow(m_lastPaintRect.location()); > >> > >> I think this should be called "positionInWIndow". > > > > Thanks :) Will do. > > Of course, I meant "positionInWindow", not "positionInWIndow" ;-) Exactly ;) 1077975 6 peavo 2015-03-17 14:35:22 -0700 Committed r181665: <http://trac.webkit.org/changeset/181665> 1078148 7 ossy 2015-03-18 01:55:14 -0700 (In reply to comment #6) > Committed r181665: <http://trac.webkit.org/changeset/181665> This WinCairo fix broke the WinCairo build, it is so funny. :)) ..\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp(215): error C2664: 'WebCore::IntPoint WebCore::Widget::convertToContainingWindow(const WebCore::IntPoint &) const' : cannot convert argument 1 from 'WebCore::FloatPoint' to 'const WebCore::IntRect &' [C:\cygwin\home\webkitbot\win-cairo-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj] Reason: cannot convert from 'WebCore::FloatPoint' to 'const WebCore::IntRect' No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called c:\cygwin\home\webkitbot\win-cairo-release\build\source\webcore\html\htmlelement.cpp(492): warning C4701: potentially uninitialized local variable 'c' used [C:\cygwin\home\webkitbot\win-cairo-release\build\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj] 1078224 8 peavo 2015-03-18 09:18:40 -0700 (In reply to comment #7) > (In reply to comment #6) > > Committed r181665: <http://trac.webkit.org/changeset/181665> > > This WinCairo fix broke the WinCairo build, it is so funny. :)) > > ..\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp(215): error > C2664: 'WebCore::IntPoint WebCore::Widget::convertToContainingWindow(const > WebCore::IntPoint &) const' : cannot convert argument 1 from > 'WebCore::FloatPoint' to 'const WebCore::IntRect &' > [C:\cygwin\home\webkitbot\win-cairo-release\build\Source\WebCore\WebCore. > vcxproj\WebCore.vcxproj] > Reason: cannot convert from 'WebCore::FloatPoint' to 'const > WebCore::IntRect' > No user-defined-conversion operator available that can perform > this conversion, or the operator cannot be called > c:\cygwin\home\webkitbot\win-cairo- > release\build\source\webcore\html\htmlelement.cpp(492): warning C4701: > potentially uninitialized local variable 'c' used > [C:\cygwin\home\webkitbot\win-cairo-release\build\Source\WebCore\WebCore. > vcxproj\WebCore.vcxproj] Sorry for this, committed fix in <http://trac.webkit.org/changeset/181694> 248850 2015-03-17 09:08:29 -0700 2015-03-17 09:17:05 -0700 Patch bug-142784-20150317170750.patch text/plain 2274 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTY1MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTE3ICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIFZpZGVv IHBvc2l0aW9uIGlzIGluY29ycmVjdCB3aGVuIGxvY2F0ZWQgaW5zaWRlIGEgZnJhbWUuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI3ODQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBuZWVkIHRvIHRh a2UgdGhlIGVuY2xvc2luZyBmcmFtZSdzIHBvc2l0aW9uIGludG8gYWNjb3VudCwgd2hlbiBmaW5k aW5nIHRoZSB2aWRlbyBwb3NpdGlvbi4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3dp bi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uOjpzZXRTaXplKToKKwogMjAxNS0w My0xNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgICdwYWdlTG9h ZGVkJyBkaWFnbm9zdGljIGxvZ2dpbmcgaXMgdG9vIHZlcmJvc2UKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRp b24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dp bi9NZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb24uY3BwCShyZXZpc2lvbiAxODE0ODMp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vTWVkaWFQbGF5ZXJQcml2 YXRlTWVkaWFGb3VuZGF0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjA0LDE4ICsyMDQsMjEg QEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OgogICAgICAgICByZXR1 cm47CiAKICAgICBMYXlvdXRTaXplIHNjcm9sbE9mZnNldDsKKyAgICBJbnRQb2ludCBwb3NJbldp bmRvdyhtX2xhc3RQYWludFJlY3QubG9jYXRpb24oKSk7CiAKICAgICBGcmFtZVZpZXcqIHZpZXcg PSBudWxscHRyOwogICAgIGlmIChtX3BsYXllciAmJiBtX3BsYXllci0+Y2FjaGVkUmVzb3VyY2VM b2FkZXIoKSAmJiBtX3BsYXllci0+Y2FjaGVkUmVzb3VyY2VMb2FkZXIoKS0+ZG9jdW1lbnQoKSkK ICAgICAgICAgdmlldyA9IG1fcGxheWVyLT5jYWNoZWRSZXNvdXJjZUxvYWRlcigpLT5kb2N1bWVu dCgpLT52aWV3KCk7Ci0gICAgaWYgKHZpZXcpCisKKyAgICBpZiAodmlldykgewogICAgICAgICBz Y3JvbGxPZmZzZXQgPSB2aWV3LT5zY3JvbGxPZmZzZXRGb3JGaXhlZFBvc2l0aW9uKCk7CisgICAg ICAgIHBvc0luV2luZG93ID0gdmlldy0+Y29udmVydFRvQ29udGFpbmluZ1dpbmRvdyhtX2xhc3RQ YWludFJlY3QubG9jYXRpb24oKSk7CisgICAgfQogCi0gICAgaW50IHhQb3MgPSAtc2Nyb2xsT2Zm c2V0LndpZHRoKCkudG9JbnQoKSArIG1fbGFzdFBhaW50UmVjdC54KCk7Ci0gICAgaW50IHlQb3Mg PSAtc2Nyb2xsT2Zmc2V0LmhlaWdodCgpLnRvSW50KCkgKyBtX2xhc3RQYWludFJlY3QueSgpOwor ICAgIHBvc0luV2luZG93Lm1vdmUoLXNjcm9sbE9mZnNldC53aWR0aCgpLnRvSW50KCksIC1zY3Jv bGxPZmZzZXQuaGVpZ2h0KCkudG9JbnQoKSk7CiAKICAgICBpZiAobV9od25kVmlkZW8gJiYgIW1f bGFzdFBhaW50UmVjdC5pc0VtcHR5KCkpCi0gICAgICAgIDo6TW92ZVdpbmRvdyhtX2h3bmRWaWRl bywgeFBvcywgeVBvcywgbV9zaXplLndpZHRoKCksIG1fc2l6ZS5oZWlnaHQoKSwgRkFMU0UpOwor ICAgICAgICA6Ok1vdmVXaW5kb3cobV9od25kVmlkZW8sIHBvc0luV2luZG93LngoKSwgcG9zSW5X aW5kb3cueSgpLCBtX3NpemUud2lkdGgoKSwgbV9zaXplLmhlaWdodCgpLCBGQUxTRSk7CiAKICAg ICBSRUNUIHJjID0geyAwLCAwLCBtX3NpemUud2lkdGgoKSwgbV9zaXplLmhlaWdodCgpIH07CiAg ICAgbV92aWRlb0Rpc3BsYXktPlNldFZpZGVvUG9zaXRpb24obnVsbHB0ciwgJnJjKTsK