142780 2015-03-17 03:30:01 -0700 [GTK] Wrong transfer annotations used in GObject DOM bindings 2015-03-17 05:22:47 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo mcrha svillar oldest_to_newest 1077849 0 cgarcia 2015-03-17 03:30:01 -0700 We are using transfer none for all methods returning a GObject DOM Object. That's not true. Only objects derived by Node are automatically released by the DOM object cache and can be transfer none. All other objects are added to the cache only to avoid creating the same wrapper twice for the same core object, but caller should release the returned reference. See also bug #118788 1077850 1 248841 cgarcia 2015-03-17 03:33:11 -0700 Created attachment 248841 Patch 1077872 2 cgarcia 2015-03-17 05:22:47 -0700 Committed r181643: <http://trac.webkit.org/changeset/181643> 248841 2015-03-17 03:33:11 -0700 2015-03-17 05:13:16 -0700 Patch wkdom-transfers.diff text/plain 5617 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1YjliN2FlLi4wNjY1NWMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTUtMDMtMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFdyb25nIHRyYW5zZmVyIGFubm90YXRpb25zIHVzZWQgaW4gR09i amVjdCBET00gYmluZGluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0Mjc4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdlIGFyZSB1c2luZyB0cmFuc2ZlciBub25lIGZvciBhbGwgbWV0aG9kcyByZXR1 cm5pbmcgYSBHT2JqZWN0IERPTQorICAgICAgICBPYmplY3QuIFRoYXQncyBub3QgdHJ1ZS4gT25s eSBvYmplY3RzIGRlcml2ZWQgZnJvbSBOb2RlIGFyZQorICAgICAgICBhdXRvbWF0aWNhbGx5IHJl bGVhc2VkIGJ5IHRoZSBET00gb2JqZWN0IGNhY2hlIGFuZCBjYW4gYmUgdHJhbnNmZXIKKyAgICAg ICAgbm9uZS4gQWxsIG90aGVyIG9iamVjdHMgYXJlIGFkZGVkIHRvIHRoZSBjYWNoZSBvbmx5IHRv IGF2b2lkCisgICAgICAgIGNyZWF0aW5nIHRoZSBzYW1lIHdyYXBwZXIgdHdpY2UgZm9yIHRoZSBz YW1lIGNvcmUgb2JqZWN0LCBidXQKKyAgICAgICAgY2FsbGVyIHNob3VsZCByZWxlYXNlIHRoZSBy ZXR1cm5lZCByZWZlcmVuY2UuCisKKyAgICAgICAgKiBiaW5kaW5ncy9nb2JqZWN0L1dlYktpdERP TUN1c3RvbVVuc3RhYmxlLmg6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJh dG9yR09iamVjdC5wbToKKyAgICAgICAgKEdldFRyYW5zZmVyVHlwZUZvclJldHVyblR5cGUpOgor ICAgICAgICAoR2VuZXJhdGVGdW5jdGlvbik6CisKIDIwMTUtMDMtMTYgIFJ5b3N1a2UgTml3YSAg PHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRW5hYmxlIEVTNiBjbGFzc2VzIGJ5IGRlZmF1 bHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9N Q3VzdG9tVW5zdGFibGUuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0 RE9NQ3VzdG9tVW5zdGFibGUuaAppbmRleCBjZTE2OTVkLi41MTM1OTQ3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3RvbVVuc3RhYmxlLmgK KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0b21VbnN0 YWJsZS5oCkBAIC0yOSw3ICsyOSw3IEBAIEdfQkVHSU5fREVDTFMKICAqIHdlYmtpdF9kb21fZG9t X3dpbmRvd19nZXRfd2Via2l0X25hbWVzcGFjZToKICAqIEBzZWxmOiBBICNXZWJLaXRET01ET01X aW5kb3cKICAqCi0gKiBSZXR1cm5zOiAodHJhbnNmZXIgbm9uZSk6IEEgI1dlYktpdERPTVdlYktp dE5hbWVzcGFjZQorICogUmV0dXJuczogKHRyYW5zZmVyIGZ1bGwpOiBBICNXZWJLaXRET01XZWJL aXROYW1lc3BhY2UKICAqCiAgKiBTdGFiaWxpdHk6IFVuc3RhYmxlCiAgKiBTaW5jZTogMi44CkBA IC00Miw3ICs0Miw3IEBAIHdlYmtpdF9kb21fZG9tX3dpbmRvd19nZXRfd2Via2l0X25hbWVzcGFj ZShXZWJLaXRET01ET01XaW5kb3cqIHNlbGYpOwogICogQHNlbGY6IEEgI1dlYktpdERPTVVzZXJN ZXNzYWdlSGFuZGxlcnNOYW1lc3BhY2UKICAqIEBuYW1lOiBhICNnY2hhcgogICoKLSAqIFJldHVy bnM6ICh0cmFuc2ZlciBub25lKTogQSAjV2ViS2l0RE9NVXNlck1lc3NhZ2VIYW5kbGVyCisgKiBS ZXR1cm5zOiAodHJhbnNmZXIgZnVsbCk6IEEgI1dlYktpdERPTVVzZXJNZXNzYWdlSGFuZGxlcgog ICoKICAqIFN0YWJpbGl0eTogVW5zdGFibGUKICAqIFNpbmNlOiAyLjgKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0gYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCmlu ZGV4IGM4NjM2MmUuLjJlOTQxMGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQpAQCAtNDksNiArNDksMjkgQEAg bXkgJWJhc2VUeXBlSGFzaCA9ICgiT2JqZWN0IiA9PiAxLCAiTm9kZSIgPT4gMSwgIk5vZGVMaXN0 IiA9PiAxLCAiTmFtZWROb2RlTWFwIgogICAgICAgICAgICAgICAgICAgICAiTm9kZUl0ZXJhdG9y IiA9PiAxLCAiVHJlZVdhbGtlciIgPT4gMSwgIkFic3RyYWN0VmlldyIgPT4gMSwgIkJsb2IiID0+ IDEsICJET01Ub2tlbkxpc3QiID0+IDEsCiAgICAgICAgICAgICAgICAgICAgICJIVE1MQ29sbGVj dGlvbiIgPT4gMSwgIlRleHRUcmFja0N1ZSIgPT4gMSk7CiAKKyMgT25seSBvYmplY3RzIGRlcml2 ZWQgZnJvbSBOb2RlIGFyZSByZWxlYXNlZCBieSB0aGUgRE9NIG9iamVjdCBjYWNoZSBhbmQgY2Fu IGJlCisjIHRyYW5zZmVyIG5vbmUuIElkZWFsbHkgd2UgY291bGQgdXNlIEdldEJhc2VDbGFzcyB3 aXRoIHRoZSBwYXJlbnQgdHlwZSB0byBjaGVjaworIyB3aGV0aGVyIGl0J3MgTm9kZSwgYnV0IHVu Zm9ydHVuYXRlbHkgd2Ugb25seSBoYXZlIHRoZSBuYW1lIG9mIHRoZSByZXR1cm4gdHlwZSwKKyMg YW5kIHdlIGNhbid0IGtub3cgaXRzIHBhcmVudCBiYXNlIGNsYXNzLiBTaW5jZSB0aGVyZSBhcmUg ZmV3ZXIgY2xhc3NlcyBpbiB0aGUKKyMgQVBJIHRoYXQgYXJlIG5vdCBkZXJpdmVkIGZyb20gTm9k ZSwgd2Ugd2lsbCBsaXN0IHRoZW0gaGVyZSB0byBkZWNpZGUgdGhlCisjIHRyYW5zZmVyIHR5cGUu CitteSAldHJhbnNmZXJGdWxsVHlwZUhhc2ggPSAoIkF1ZGlvVHJhY2siID0+IDEsICJBdWRpb1Ry YWNrTGlzdCIgPT4gMSwgIkJhclByb3AiID0+IDEsICJCYXR0ZXJ5TWFuYWdlciIgPT4gMSwKKyAg ICAiQ1NTUnVsZUxpc3QiID0+IDEsICJDU1NTdHlsZURlY2xhcmF0aW9uIiA9PiAxLCAiQ1NTU3R5 bGVTaGVldCIgPT4gMSwKKyAgICAiRE9NQXBwbGljYXRpb25DYWNoZSIgPT4gMSwgIkRPTU1pbWVU eXBlIiA9PiAxLCAiRE9NTWltZVR5cGVBcnJheSIgPT4gMSwgIkRPTU5hbWVkRmxvd0NvbGxlY3Rp b24iID0+IDEsCisgICAgIkRPTVBsdWdpbiIgPT4gMSwgIkRPTVBsdWdpbkFycmF5IiA9PiAxLCAi RE9NU2VjdXJpdHlQb2xpY3kiID0+IDEsCisgICAgIkRPTVNlbGVjdGlvbiIgPT4gMSwgIkRPTVNl dHRhYmxlVG9rZW5MaXN0IiA9PiAxLCAiRE9NU3RyaW5nTGlzdCIgPT4gMSwKKyAgICAiRE9NV2lu ZG93IiA9PiAxLCAiRE9NV2luZG93Q1NTIiA9PiAxLCAiRXZlbnRUYXJnZXQiID0+IDEsCisgICAg IkZpbGUiID0+IDEsICJGaWxlTGlzdCIgPT4gMSwgIkdhbWVwYWQiID0+IDEsICJHYW1lcGFkTGlz dCIgPT4gMSwKKyAgICAiR2VvbG9jYXRpb24iID0+IDEsICJIVE1MT3B0aW9uc0NvbGxlY3Rpb24i ID0+IDEsICJIaXN0b3J5IiA9PiAxLAorICAgICJLZXlib2FyZEV2ZW50IiA9PiAxLCAiTWVkaWFF cnJvciIgPT4gMSwgIk1lZGlhQ29udHJvbGxlciIgPT4gMSwKKyAgICAiTW91c2VFdmVudCIgPT4g MSwgIk1lZGlhUXVlcnlMaXN0IiA9PiAxLCAiTmF2aWdhdG9yIiA9PiAxLCAiTm9kZUZpbHRlciIg PT4gMSwKKyAgICAiUGVyZm9ybWFuY2UiID0+IDEsICJQZXJmb3JtYW5jZUVudHJ5IiA9PiAxLCAi UGVyZm9ybWFuY2VFbnRyeUxpc3QiID0+IDEsICJQZXJmb3JtYW5jZU5hdmlnYXRpb24iID0+IDEs ICJQZXJmb3JtYW5jZVRpbWluZyIgPT4gMSwKKyAgICAiUmFuZ2UiID0+IDEsICJTY3JlZW4iID0+ IDEsICJTcGVlY2hTeW50aGVzaXMiID0+IDEsICJTcGVlY2hTeW50aGVzaXNWb2ljZSIgPT4gMSwK KyAgICAiU3RvcmFnZSIgPT4gMSwgIlN0eWxlTWVkaWEiID0+IDEsICJUZXh0VHJhY2siID0+IDEs ICJUZXh0VHJhY2tDdWVMaXN0IiA9PiAxLAorICAgICJUaW1lUmFuZ2VzIiA9PiAxLCAiVG91Y2gi ID0+IDEsICJVSUV2ZW50IiA9PiAxLCAiVXNlck1lc3NhZ2VIYW5kbGVyIiA9PiAxLCAiVXNlck1l c3NhZ2VIYW5kbGVyc05hbWVzcGFjZSIgPT4gMSwKKyAgICAiVmFsaWRpdHlTdGF0ZSIgPT4gMSwg IlZpZGVvVHJhY2siID0+IDEsICJXZWJLaXROYW1lZEZsb3ciID0+IDEsCisgICAgIldlYktpdE5h bWVzcGFjZSIgPT4gMSwgIldlYktpdFBvaW50IiA9PiAxLCAiV2hlZWxFdmVudCIgPT4gMSwgIlhQ YXRoTlNSZXNvbHZlciIgPT4gMSk7CisKICMgTGlzdCBvZiBmdW5jdGlvbiBwYXJhbWV0ZXJzIHRo YXQgYXJlIGFsbG93ZWQgdG8gYmUgTlVMTAogbXkgJGNhbkJlTnVsbFBhcmFtcyA9IHsKICAgICAn d2Via2l0X2RvbV9kb2N1bWVudF9jcmVhdGVfYXR0cmlidXRlX25zJyA9PiBbJ25hbWVzcGFjZVVS SSddLApAQCAtOTQ1LDYgKzk2OCwyMCBAQCBzdWIgR2V0RnVuY3Rpb25TaWduYXR1cmVOYW1lIHsK ICAgICByZXR1cm4gIiR7bmFtZX1fdHlwZSI7CiB9CiAKK3N1YiBHZXRUcmFuc2ZlclR5cGVGb3JS ZXR1cm5UeXBlIHsKKyAgICBteSAkcmV0dXJuVHlwZSA9IHNoaWZ0OworCisgICAgIyBOb2RlIGlz IGFsd2F5cyB0cmFuc2ZlciBub25lLgorICAgIHJldHVybiAibm9uZSIgaWYgJHJldHVyblR5cGUg ZXEgIk5vZGUiOworCisgICAgIyBBbnkgYmFzZSBjbGFzcyBidXQgTm9kZSBpcyB0cmFuc2ZlciBm dWxsLgorICAgIHJldHVybiAiZnVsbCIgaWYgSXNCYXNlVHlwZSgkcmV0dXJuVHlwZSk7CisKKyAg ICAjIEFueSBvdGhlciBjbGFzcyBub3QgZGVyaXZlZCBmcm9tIE5vZGUgaXMgdHJhbnNmZXIgZnVs bC4KKyAgICByZXR1cm4gImZ1bGwiIGlmICR0cmFuc2ZlckZ1bGxUeXBlSGFzaHskcmV0dXJuVHlw ZX07CisgICAgcmV0dXJuICJub25lIjsKK30KKwogc3ViIEdlbmVyYXRlRnVuY3Rpb24gewogICAg IG15ICgkb2JqZWN0LCAkaW50ZXJmYWNlTmFtZSwgJGZ1bmN0aW9uLCAkcHJlZml4LCAkcGFyZW50 Tm9kZSkgPSBAXzsKIApAQCAtMTA0Miw3ICsxMDc5LDggQEAgc3ViIEdlbmVyYXRlRnVuY3Rpb24g ewogICAgIG15ICRoYXNSZXR1cm5UYWcgPSAwOwogICAgICRyZXR1cm5UeXBlTmFtZSA9fiBzL1wq JC8vOwogICAgIGlmICgkcmV0dXJuVmFsdWVJc0dET01UeXBlKSB7Ci0gICAgICAgIHB1c2goQGZ1 bmN0aW9uSGVhZGVyLCAiICogUmV0dXJuczogKHRyYW5zZmVyIG5vbmUpOiBBICMke3JldHVyblR5 cGVOYW1lfSIpOworICAgICAgICBteSAkdHJhbnNmZXJUeXBlID0gR2V0VHJhbnNmZXJUeXBlRm9y UmV0dXJuVHlwZSgkZnVuY3Rpb25TaWdUeXBlKTsKKyAgICAgICAgcHVzaChAZnVuY3Rpb25IZWFk ZXIsICIgKiBSZXR1cm5zOiAodHJhbnNmZXIgJHRyYW5zZmVyVHlwZSk6IEEgIyR7cmV0dXJuVHlw ZU5hbWV9Iik7CiAgICAgICAgICRoYXNSZXR1cm5UYWcgPSAxOwogICAgIH0gZWxzaWYgKCRyZXR1 cm5UeXBlIG5lICJ2b2lkIikgewogICAgICAgICBwdXNoKEBmdW5jdGlvbkhlYWRlciwgIiAqIFJl dHVybnM6IEEgIyR7cmV0dXJuVHlwZU5hbWV9Iik7Cg==