142761 2015-03-16 18:50:53 -0700 [CMake][EFL] Build test tools only for developer mode 2015-03-17 00:57:12 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim mrobinson ossy oldest_to_newest 1077679 0 gyuyoung.kim 2015-03-16 18:50:53 -0700 Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on release mode. 1077681 1 248777 gyuyoung.kim 2015-03-16 18:52:01 -0700 Created attachment 248777 Patch 1077804 2 248777 ossy 2015-03-17 00:35:01 -0700 Comment on attachment 248777 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248777&action=review LGTM > Tools/ChangeLog:8 > + Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on release mode. Using release mode is a little bit confusing here, I prefer production mode for non-developer build. > ChangeLog:8 > + Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on release mode. ditto 1077806 3 gyuyoung.kim 2015-03-17 00:56:15 -0700 Committed r181621: <http://trac.webkit.org/changeset/181621> 1077808 4 gyuyoung.kim 2015-03-17 00:57:12 -0700 (In reply to comment #2) > Comment on attachment 248777 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248777&action=review > > LGTM > > > Tools/ChangeLog:8 > > + Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on release mode. > > Using release mode is a little bit confusing here, I prefer production mode > for non-developer build. > > > ChangeLog:8 > > + Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on release mode. > > ditto Ok, I land this patch after fixing it. 248777 2015-03-16 18:52:01 -0700 2015-03-17 00:35:01 -0700 Patch bug-142761-20150317105131.patch text/plain 5224 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNjAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDQzYzZk ODhkMTU3NzRmMGU1ZWQ3OWY0MGI3ZTZhYjlkZTU4OGRiZjAuLjNjMDJjYzdhOGQ3OGY4OWEwM2I4 ZmVkMmViNmM2NWNhYTA0OWI3ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC01Nyw5ICs1Nywx MSBAQCBXRUJLSVRfT1BUSU9OX0JFR0lOKCkKIGlmIChERVZFTE9QRVJfTU9ERSkKICAgICBzZXQo RU5BQkxFX1RPT0xTIE9OKQogICAgIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO QUJMRV9BUElfVEVTVFMgT04pCisgICAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUo RU5BQkxFX01JTklCUk9XU0VSIE9OKQogZWxzZSAoKQogICAgIHNldChFTkFCTEVfVE9PTFMgT0ZG KQogICAgIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9BUElfVEVTVFMg T0ZGKQorICAgIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NSU5JQlJP V1NFUiBPRkYpCiAgICAgc2V0KFdFQktJVDJfVkVSU0lPTl9TQ1JJUFQgIi1XbCwtLXZlcnNpb24t c2NyaXB0LCR7Q01BS0VfTU9EVUxFX1BBVEh9L2VmbHN5bWJvbHMuZmlsdGVyIikKIGVuZGlmICgp CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlIGIvU291cmNlL2Nt YWtlL09wdGlvbnNHVEsuY21ha2UKaW5kZXggMGU5YWE5YWI4YjkyZDUwOTFkNTM0YTBjMGE2YjVm OWVhZDJmZTc2Ni4uNmNlNjNjY2E0NDdjNzY2ZTY0OWQ4NWMzMzZiNjhkYjQ3YjE2MjZkOSAxMDA2 NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UKKysrIGIvU291cmNlL2NtYWtl L09wdGlvbnNHVEsuY21ha2UKQEAgLTc4LDcgKzc4LDYgQEAgZW5kaWYgKCkKIAogV0VCS0lUX09Q VElPTl9CRUdJTigpCiBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfUExVR0lOX1BST0NFU1Nf R1RLMiAiV2hldGhlciB0byBidWlsZCBXZWJLaXRQbHVnaW5Qcm9jZXNzMiB0byBsb2FkIEdUSzIg YmFzZWQgcGx1Z2lucy4iIE9OKQotV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX01JTklCUk9X U0VSICJXaGV0aGVyIHRvIGVuYWJsZSBNaW5pQnJvd3NlciBjb21waWxhdGlvbi4iIE9GRikKIAog aWYgKChPUEVOR0xfRk9VTkQgT1IgT1BFTkdMRVMyX0ZPVU5EKSBBTkQgKEdMWF9GT1VORCBPUiBF R0xfRk9VTkQpKQogICAgIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9X RUJHTCBPTikKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZSBi L1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZQppbmRleCA4ODcyNjE3MjY0MDgzNDRh YjAyNTJjOWMwZWYxZmM5NzdkMDYzZmJhLi44MDE5NDdiOWIwZGYwMjBmZjQzY2Q5YWEzZDMwYzY3 MjhiMTJhNGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UK KysrIGIvU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlCkBAIC05OCw2ICs5OCw3IEBA IG1hY3JvKFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5B QkxFX01FTU9SWV9TQU1QTEVSICJUb2dnbGUgTWVtb3J5IFNhbXBsZXIgc3VwcG9ydCIgT0ZGKQog ICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9NRVRFUl9FTEVNRU5UICJUb2dnbGUgTWV0 ZXIgVGFnIHN1cHBvcnQiIE9OKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9NSFRN TCAiVG9nZ2xlIE1IVE1MIHN1cHBvcnQiIE9GRikKKyAgICBXRUJLSVRfT1BUSU9OX0RFRklORShF TkFCTEVfTUlOSUJST1dTRVIgIldoZXRoZXIgdG8gZW5hYmxlIE1pbmlCcm93c2VyIGNvbXBpbGF0 aW9uLiIgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9NT1VTRV9DVVJTT1Jf U0NBTEUgIlRvZ2dsZSBTY2FsZWQgbW91c2UgY3Vyc29yIHN1cHBvcnQiIE9GRikKICAgICBXRUJL SVRfT1BUSU9OX0RFRklORShFTkFCTEVfTkFWSUdBVE9SX0NPTlRFTlRfVVRJTFMgIlRvZ2dsZSBO YXZpZ2F0b3IgQ29udGVudCBVdGlscyBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9E RUZJTkUoRU5BQkxFX05BVklHQVRPUl9IV0NPTkNVUlJFTkNZICJUb2dnbGUgTmF2aWdhdG9yIGhh cmR3YXJlIGNvbmN1cnJlbmN5IHN1cHBvcnQiIE9OKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtl Y29uZmlnLmguY21ha2UgYi9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZQppbmRleCAxYTc0NWNh NWNkODlmYjIwMDgyZjc3YmMwMjY4OGE5YjBiNGJkNGI5Li4yMWQzZmNjNWQ5ODNmOTU5NWRlZjM1 MTA1NjhjZGM5ODk2NTI0NmVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFr ZQorKysgYi9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZQpAQCAtODYsNiArODYsNyBAQAogI2Nt YWtlZGVmaW5lMDEgRU5BQkxFX01FTU9SWV9TQU1QTEVSCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVf TUVURVJfRUxFTUVOVAogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX01IVE1MCisjY21ha2VkZWZpbmUw MSBFTkFCTEVfTUlOSUJST1dTRVIKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9NT1VTRV9DVVJTT1Jf U0NBTEUKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9OQVZJR0FUT1JfQ09OVEVOVF9VVElMUwogI2Nt YWtlZGVmaW5lMDEgRU5BQkxFX05BVklHQVRPUl9IV0NPTkNVUlJFTkNZCmRpZmYgLS1naXQgYS9U b29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjIzMjI0ZDIxMTIzMTQwNWZm YWRhYmRmNDQ1ODMxY2NjMTVkYTZlYS4uYjRmOTIzODU2NGM4Y2E0MmEzYTgzMWZjNDkwODlkOWE3 NGQ4ZTQzYiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAzLTE2ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5r aW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0NNYWtlXVtFRkxdIEJ1aWxkIHRlc3QgdG9vbHMg b25seSBmb3IgZGV2ZWxvcGVyIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0Mjc2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIERvIG5vdCBidWlsZCBFRkwgTWluaUJyb3dzZXIsIFdlYktpdFRlc3RS dW5uZXIsIGFuZCBJbWFnZURpZmYgb24gcmVsZWFzZSBtb2RlLgorCisgICAgICAgICogQ01ha2VM aXN0cy50eHQ6CisKIDIwMTUtMDMtMTYgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5j b20+CiAKICAgICAgICAgRml4IHdlYmtpdHB5IHRlc3RzIGFmdGVyIHIxODE1ODUuCmRpZmYgLS1n aXQgYS9Ub29scy9DTWFrZUxpc3RzLnR4dCBiL1Rvb2xzL0NNYWtlTGlzdHMudHh0CmluZGV4IDY0 MGRhNWZhYWRkMGNmMmEwNmE0MWNlODJkYmVhNjkxNGQ3Njg5YTkuLjIzN2M2ZmI1NjM4NWU3YWRl YTllZjI1YTI4NWEwOTkwMDA4NmY2ZWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NNYWtlTGlzdHMudHh0 CisrKyBiL1Rvb2xzL0NNYWtlTGlzdHMudHh0CkBAIC0xLDkgKzEsMTUgQEAKIGlmICgiJHtQT1JU fSIgU1RSRVFVQUwgIkVmbCIpCi0gICAgYWRkX3N1YmRpcmVjdG9yeShXZWJLaXRUZXN0UnVubmVy KQotICAgIGFkZF9zdWJkaXJlY3RvcnkoSW1hZ2VEaWZmKQorICAgIGlmIChERVZFTE9QRVJfTU9E RSkKKyAgICAgIGFkZF9zdWJkaXJlY3RvcnkoV2ViS2l0VGVzdFJ1bm5lcikKKyAgICAgIGFkZF9z dWJkaXJlY3RvcnkoSW1hZ2VEaWZmKQorICAgICAgaWYgKEVOQUJMRV9YMTFfVEFSR0VUKQorICAg ICAgICBhZGRfc3ViZGlyZWN0b3J5KER1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbikK KyAgICAgIGVuZGlmICgpCisgICAgZW5kaWYgKCkKIAotICAgIGFkZF9zdWJkaXJlY3RvcnkoTWlu aUJyb3dzZXIvZWZsKQotICAgIGFkZF9zdWJkaXJlY3RvcnkoRHVtcFJlbmRlclRyZWUvVGVzdE5l dHNjYXBlUGx1Z0luKQorICAgIGlmIChFTkFCTEVfTUlOSUJST1dTRVIpCisgICAgICBhZGRfc3Vi ZGlyZWN0b3J5KE1pbmlCcm93c2VyL2VmbCkKKyAgICBlbmRpZiAoKQogZWxzZWlmICgiJHtQT1JU fSIgU1RSRVFVQUwgIkdUSyIpCiAgICAgaWYgKERFVkVMT1BFUl9NT0RFKQogICAgICAgYWRkX3N1 YmRpcmVjdG9yeShXZWJLaXRUZXN0UnVubmVyKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hh bmdlTG9nCmluZGV4IGI0NjExY2NiYjJmYzVlZjExNTk4ZTJlMWQ3NThiY2MwZjZkYjg4MDEuLjJm NzdiMTUxZWFiZDU5ODdkZDhlZTQ0MjYwNjgxMGQ0M2E5YWVjNjggMTAwNjQ0Ci0tLSBhL0NoYW5n ZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAxNS0wMy0xNiAgR3l1eW91 bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCisgICAgICAgIFtDTWFrZV1bRUZM XSBCdWlsZCB0ZXN0IHRvb2xzIG9ubHkgZm9yIGRldmVsb3BlciBtb2RlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI3NjEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3QgYnVpbGQgRUZMIE1pbmlC cm93c2VyLCBXZWJLaXRUZXN0UnVubmVyLCBhbmQgSW1hZ2VEaWZmIG9uIHJlbGVhc2UgbW9kZS4K KworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlOgorICAgICAgICAqIFNv dXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOiBNb3ZlIEVOQUJMRV9NSU5JQlJPV1NFUiB0byBj b21tb24gcGxhY2UuCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtl OiBEZWZpbmUgRU5BQkxFX01JTklCUk9XU0VSIHZhcmlhYmxlLgorICAgICAgICAqIFNvdXJjZS9j bWFrZWNvbmZpZy5oLmNtYWtlOgorCisyMDE1LTAzLTE2ICBHeXV5b3VuZyBLaW0gIDxneXV5b3Vu Zy5raW1Ac2Ftc3VuZy5jb20+CisKICAgICAgICAgW0NNYWtlXVtFRkxdIFJlYXJyYW5nZSBPcHRp b25FRkwuY21ha2UgdG8gaW1wcm92ZSByZWFkYWJpbGl0eSAKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjcyMgogCg==