142744 2015-03-16 13:48:45 -0700 Expose WK2 preference for Animation Triggers runtime flag 2015-03-16 17:11:52 -0700 1 1 1 Unclassified WebKit Animations 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino andersca dino ossy webkit-bug-importer oldest_to_newest 1077547 0 dino 2015-03-16 13:48:45 -0700 We need a WK2 preference for the runtime flag. 1077548 1 webkit-bug-importer 2015-03-16 13:49:50 -0700 <rdar://problem/20178288> 1077559 2 248748 dino 2015-03-16 14:19:15 -0700 Created attachment 248748 Patch 1077564 3 dino 2015-03-16 14:26:18 -0700 Committed r181578: <http://trac.webkit.org/changeset/181578> 1077604 4 248748 ossy 2015-03-16 15:45:17 -0700 Comment on attachment 248748 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248748&action=review > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:620 > +void InjectedBundle::setCSSAnimationTriggersEnabled(bool enabled) > +{ > +#if ENABLE(CSS_REGIONS) > + RuntimeEnabledFeatures::sharedFeatures().setAnimationTriggersEnabled(enabled); > +#else > + UNUSED_PARAM(enabled); > +#endif > +} CSS_REGIONS ??? This is so ugly typo. That's why it broke the EFL and GTK builds. I know you are allowed to do it ... but I can't understand why was it needed ... 1077606 5 ossy 2015-03-16 15:46:58 -0700 Typo fix landed in http://trac.webkit.org/changeset/181582 1077609 6 ossy 2015-03-16 15:48:54 -0700 One more fix landed in http://trac.webkit.org/changeset/181584 1077652 7 dino 2015-03-16 17:11:52 -0700 Thanks Ossy, and apologies. 248748 2015-03-16 14:19:15 -0700 2015-03-16 14:21:41 -0700 Patch bug-142744-20150316141845.patch text/plain 7214 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjdhYTdmODIzYjBjYjk4 MWRkYTdhM2Q0MmZkZDU3NjYwZGU1NjRmZS4uZWY2YjRjZDJlMWVkYjEyMmUzMDQ4ZDgzOThmYTIx Mzg5OTJiYTU3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE1LTAzLTE2ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBFeHBvc2UgV0syIHByZWZlcmVu Y2UgZm9yIEFuaW1hdGlvbiBUcmlnZ2VycyBydW50aW1lIGZsYWcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Mjc0NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cG9zZSBDU1NBbmltYXRpb25UcmlnZ2Vy c0VuYWJsZWQsIGxpbmtpbmcgaXQgdG8gdGhlIHJ1bnRpbWUgZW5hYmxlZAorICAgICAgICBmZWF0 dXJlIGZsYWcuCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5o OgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzLmNwcDoKKyAgICAgICAg KFdLUHJlZmVyZW5jZXNTZXRDU1NBbmltYXRpb25UcmlnZ2Vyc0VuYWJsZWQpOgorICAgICAgICAo V0tQcmVmZXJlbmNlc0dldENTU0FuaW1hdGlvblRyaWdnZXJzRW5hYmxlZCk6CisgICAgICAgICog VUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXNSZWZQcml2YXRlLmg6CisgICAgICAgICogV2Vi UHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHA6CisgICAgICAgIChXZWJL aXQ6OkluamVjdGVkQnVuZGxlOjpvdmVycmlkZUJvb2xQcmVmZXJlbmNlRm9yVGVzdFJ1bm5lcik6 CisgICAgICAgIChXZWJLaXQ6OkluamVjdGVkQnVuZGxlOjpzZXRDU1NBbmltYXRpb25UcmlnZ2Vy c0VuYWJsZWQpOgorICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRC dW5kbGUuaDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYlBhZ2U6OnVwZGF0ZVByZWZlcmVuY2VzKToKKwogMjAxNS0wMy0xNiAg Q29ucmFkIFNodWx0eiAgPGNvbnJhZF9zaHVsdHpAYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93 IGNsaWVudHMgdG8gc2VsZWN0aXZlbHkgZGlzYWJsZSBwbHVnLWlucwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmaW5pdGlvbnMuaCBiL1NvdXJjZS9X ZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmgKaW5kZXggZTU4MjFhMmUz MGIzY2I1NDNiOTI1NWE0ZmMxMTBjNzQ4ZmI3MWFhYS4uNzZjM2YyYmUxNzM3MWE4ZTkwNDQxZmNh YTc4ZWZkODk2NDIyY2ZkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlBy ZWZlcmVuY2VzRGVmaW5pdGlvbnMuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJl ZmVyZW5jZXNEZWZpbml0aW9ucy5oCkBAIC0xMDYsNiArMTA2LDcgQEAKICAgICBtYWNybyhXZWJH TEVuYWJsZWQsIHdlYkdMRW5hYmxlZCwgQm9vbCwgYm9vbCwgdHJ1ZSkgXAogICAgIG1hY3JvKEZv cmNlU29mdHdhcmVXZWJHTFJlbmRlcmluZywgZm9yY2VTb2Z0d2FyZVdlYkdMUmVuZGVyaW5nLCBC b29sLCBib29sLCBmYWxzZSkgXAogICAgIG1hY3JvKEFjY2VsZXJhdGVkMmRDYW52YXNFbmFibGVk LCBhY2NlbGVyYXRlZDJkQ2FudmFzRW5hYmxlZCwgQm9vbCwgYm9vbCwgZmFsc2UpIFwKKyAgICBt YWNybyhDU1NBbmltYXRpb25UcmlnZ2Vyc0VuYWJsZWQsIGNzc0FuaW1hdGlvblRyaWdnZXJzRW5h YmxlZCwgQm9vbCwgYm9vbCwgdHJ1ZSkgXAogICAgIG1hY3JvKENTU1JlZ2lvbnNFbmFibGVkLCBj c3NSZWdpb25zRW5hYmxlZCwgQm9vbCwgYm9vbCwgdHJ1ZSkgXAogICAgIG1hY3JvKENTU0NvbXBv c2l0aW5nRW5hYmxlZCwgY3NzQ29tcG9zaXRpbmdFbmFibGVkLCBCb29sLCBib29sLCB0cnVlKSBc CiAgICAgbWFjcm8oRm9yY2VGVFBEaXJlY3RvcnlMaXN0aW5ncywgZm9yY2VGVFBEaXJlY3RvcnlM aXN0aW5ncywgQm9vbCwgYm9vbCwgZmFsc2UpIFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzLmNwcAppbmRleCAyYThhZDZlYjJkMDg0MWE4YmFiOTM1 OTNhMTUwOTdmZDI2MTU1NzA2Li44MzBkZjA4ZTkzYWI2ZGJkYjAxM2Q3MjExMjg3YmIyMDA0NDJh NmMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJl bmNlcy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5j ZXMuY3BwCkBAIC00NzksNiArNDc5LDE2IEBAIGJvb2wgV0tQcmVmZXJlbmNlc0dldEFjY2VsZXJh dGVkMkRDYW52YXNFbmFibGVkKFdLUHJlZmVyZW5jZXNSZWYgcHJlZmVyZW5jZXNSZWYpCiAgICAg cmV0dXJuIHRvSW1wbChwcmVmZXJlbmNlc1JlZiktPmFjY2VsZXJhdGVkMmRDYW52YXNFbmFibGVk KCk7CiB9CiAKK3ZvaWQgV0tQcmVmZXJlbmNlc1NldENTU0FuaW1hdGlvblRyaWdnZXJzRW5hYmxl ZChXS1ByZWZlcmVuY2VzUmVmIHByZWZlcmVuY2VzUmVmLCBib29sIGZsYWcpCit7CisgICAgdG9J bXBsKHByZWZlcmVuY2VzUmVmKS0+c2V0Q1NTQW5pbWF0aW9uVHJpZ2dlcnNFbmFibGVkKGZsYWcp OworfQorCitib29sIFdLUHJlZmVyZW5jZXNHZXRDU1NBbmltYXRpb25UcmlnZ2Vyc0VuYWJsZWQo V0tQcmVmZXJlbmNlc1JlZiBwcmVmZXJlbmNlc1JlZikKK3sKKyAgICByZXR1cm4gdG9JbXBsKHBy ZWZlcmVuY2VzUmVmKS0+Y3NzQW5pbWF0aW9uVHJpZ2dlcnNFbmFibGVkKCk7Cit9CisKIHZvaWQg V0tQcmVmZXJlbmNlc1NldENTU1JlZ2lvbnNFbmFibGVkKFdLUHJlZmVyZW5jZXNSZWYgcHJlZmVy ZW5jZXNSZWYsIGJvb2wgZmxhZykKIHsKICAgICB0b0ltcGwocHJlZmVyZW5jZXNSZWYpLT5zZXRD U1NSZWdpb25zRW5hYmxlZChmbGFnKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzUmVmUHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXNSZWZQcml2YXRlLmgKaW5kZXggZTEyYmM0ZTQwOGFl ZGE5ZjVlZGYzNzgwN2MwODMzODEwZDI2ZDA2MC4uYzU3NGJlNjI5MDMwNjkwZmYzM2E3OGRlZTdm YjM2ZjFjNDAwYzA2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D L1dLUHJlZmVyZW5jZXNSZWZQcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9DL1dLUHJlZmVyZW5jZXNSZWZQcml2YXRlLmgKQEAgLTEwOCw2ICsxMDgsMTAgQEAgV0tf RVhQT1JUIHZvaWQgV0tQcmVmZXJlbmNlc1NldEFjY2VsZXJhdGVkMkRDYW52YXNFbmFibGVkKFdL UHJlZmVyZW5jZXNSZWYsIGJvb2wKIFdLX0VYUE9SVCBib29sIFdLUHJlZmVyZW5jZXNHZXRBY2Nl bGVyYXRlZDJEQ2FudmFzRW5hYmxlZChXS1ByZWZlcmVuY2VzUmVmKTsKIAogLy8gRGVmYXVsdHMg dG8gdHJ1ZQorV0tfRVhQT1JUIHZvaWQgV0tQcmVmZXJlbmNlc1NldENTU0FuaW1hdGlvblRyaWdn ZXJzRW5hYmxlZChXS1ByZWZlcmVuY2VzUmVmLCBib29sIGZsYWcpOworV0tfRVhQT1JUIGJvb2wg V0tQcmVmZXJlbmNlc0dldENTU0FuaW1hdGlvblRyaWdnZXJzRW5hYmxlZChXS1ByZWZlcmVuY2Vz UmVmKTsKKworLy8gRGVmYXVsdHMgdG8gdHJ1ZQogV0tfRVhQT1JUIHZvaWQgV0tQcmVmZXJlbmNl c1NldENTU1JlZ2lvbnNFbmFibGVkKFdLUHJlZmVyZW5jZXNSZWYsIGJvb2wgZmxhZyk7CiBXS19F WFBPUlQgYm9vbCBXS1ByZWZlcmVuY2VzR2V0Q1NTUmVnaW9uc0VuYWJsZWQoV0tQcmVmZXJlbmNl c1JlZik7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRC dW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Jbmpl Y3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAKaW5kZXggZThhZjNiZWFmZjMwZTJjZGU5M2Y2 Zjc1NjViYzhjZGI4MGVkOWJhMC4uN2UzMmVkZjhlOTQ5OGVjYTM1MDZjYzU0MDMyZWYzN2M1NWFk YzNmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRs ZS9JbmplY3RlZEJ1bmRsZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Jbmpl Y3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAKQEAgLTE3Myw2ICsxNzMsMTEgQEAgdm9pZCBJ bmplY3RlZEJ1bmRsZTo6b3ZlcnJpZGVCb29sUHJlZmVyZW5jZUZvclRlc3RSdW5uZXIoV2ViUGFn ZUdyb3VwUHJveHkqIHBhZ2UKICAgICB9CiAjZW5kaWYKIAorI2lmIEVOQUJMRShDU1NfQU5JTUFU SU9OU19MRVZFTF8yKQorICAgIGlmIChwcmVmZXJlbmNlID09ICJXZWJLaXRDU1NBbmltYXRpb25U cmlnZ2Vyc0VuYWJsZWQiKQorICAgICAgICBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRG ZWF0dXJlcygpLnNldEFuaW1hdGlvblRyaWdnZXJzRW5hYmxlZChlbmFibGVkKTsKKyNlbmRpZgor CiAjaWYgRU5BQkxFKENTU19SRUdJT05TKQogICAgIGlmIChwcmVmZXJlbmNlID09ICJXZWJLaXRD U1NSZWdpb25zRW5hYmxlZCIpCiAgICAgICAgIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNoYXJl ZEZlYXR1cmVzKCkuc2V0Q1NTUmVnaW9uc0VuYWJsZWQoZW5hYmxlZCk7CkBAIC02MDUsNiArNjEw LDE1IEBAIHZvaWQgSW5qZWN0ZWRCdW5kbGU6OnNldFNlcmlhbExvYWRpbmdFbmFibGVkKGJvb2wg ZW5hYmxlZCkKICAgICByZXNvdXJjZUxvYWRTY2hlZHVsZXIoKS0+c2V0U2VyaWFsTG9hZGluZ0Vu YWJsZWQoZW5hYmxlZCk7CiB9CiAKK3ZvaWQgSW5qZWN0ZWRCdW5kbGU6OnNldENTU0FuaW1hdGlv blRyaWdnZXJzRW5hYmxlZChib29sIGVuYWJsZWQpCit7CisjaWYgRU5BQkxFKENTU19SRUdJT05T KQorICAgIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNoYXJlZEZlYXR1cmVzKCkuc2V0QW5pbWF0 aW9uVHJpZ2dlcnNFbmFibGVkKGVuYWJsZWQpOworI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0oZW5h YmxlZCk7CisjZW5kaWYKK30KKwogdm9pZCBJbmplY3RlZEJ1bmRsZTo6c2V0Q1NTUmVnaW9uc0Vu YWJsZWQoYm9vbCBlbmFibGVkKQogewogI2lmIEVOQUJMRShDU1NfUkVHSU9OUykKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5k bGUuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRC dW5kbGUuaAppbmRleCA4ODM0NjU4NmQ2ZWU2NTlkZDEzNDNiZjExMmVmMTg5OWRiNTMyZjdjLi44 YWZlMjRmYzhjNzk3ODMyN2EwMzQ2N2FiNDg3YWQ3NDk5NGY2M2UwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmgKKysr IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRs ZS5oCkBAIC0xNjMsNiArMTYzLDcgQEAgcHVibGljOgogCiAgICAgdm9pZCBzZXRUYWJLZXlDeWNs ZXNUaHJvdWdoRWxlbWVudHMoV2ViUGFnZSosIGJvb2wgZW5hYmxlZCk7CiAgICAgdm9pZCBzZXRT ZXJpYWxMb2FkaW5nRW5hYmxlZChib29sKTsKKyAgICB2b2lkIHNldENTU0FuaW1hdGlvblRyaWdn ZXJzRW5hYmxlZChib29sKTsKICAgICB2b2lkIHNldENTU1JlZ2lvbnNFbmFibGVkKGJvb2wpOwog ICAgIHZvaWQgc2V0Q1NTQ29tcG9zaXRpbmdFbmFibGVkKGJvb2wpOwogICAgIHZvaWQgZGlzcGF0 Y2hQZW5kaW5nTG9hZFJlcXVlc3RzKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5jcHAKaW5kZXggOGYzZmJhNWQ3ZDg3YWJjN2Q5NjNkNzgxMmNmOGJhMjYx NzAzYWFlZi4uY2FjNTUyMDU5MTUwNGE3MzM4MjkwNmJjMzY0NTU5OTFkMmNmZjdmNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcApAQCAtMjY5Niw2 ICsyNjk2LDcgQEAgdm9pZCBXZWJQYWdlOjp1cGRhdGVQcmVmZXJlbmNlcyhjb25zdCBXZWJQcmVm ZXJlbmNlc1N0b3JlJiBzdG9yZSkKICAgICAKICAgICBzZXR0aW5ncy5zZXRBZ2dyZXNzaXZlVGls ZVJldGVudGlvbkVuYWJsZWQoc3RvcmUuZ2V0Qm9vbFZhbHVlRm9yS2V5KFdlYlByZWZlcmVuY2Vz S2V5OjphZ2dyZXNzaXZlVGlsZVJldGVudGlvbkVuYWJsZWRLZXkoKSkpOwogICAgIHNldHRpbmdz LnNldFRlbXBvcmFyeVRpbGVDb2hvcnRSZXRlbnRpb25FbmFibGVkKHN0b3JlLmdldEJvb2xWYWx1 ZUZvcktleShXZWJQcmVmZXJlbmNlc0tleTo6dGVtcG9yYXJ5VGlsZUNvaG9ydFJldGVudGlvbkVu YWJsZWRLZXkoKSkpOworICAgIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNoYXJlZEZlYXR1cmVz KCkuc2V0QW5pbWF0aW9uVHJpZ2dlcnNFbmFibGVkKHN0b3JlLmdldEJvb2xWYWx1ZUZvcktleShX ZWJQcmVmZXJlbmNlc0tleTo6Y3NzQW5pbWF0aW9uVHJpZ2dlcnNFbmFibGVkS2V5KCkpKTsKICAg ICBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJlcygpLnNldENTU1JlZ2lvbnNF bmFibGVkKHN0b3JlLmdldEJvb2xWYWx1ZUZvcktleShXZWJQcmVmZXJlbmNlc0tleTo6Y3NzUmVn aW9uc0VuYWJsZWRLZXkoKSkpOwogICAgIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNoYXJlZEZl YXR1cmVzKCkuc2V0Q1NTQ29tcG9zaXRpbmdFbmFibGVkKHN0b3JlLmdldEJvb2xWYWx1ZUZvcktl eShXZWJQcmVmZXJlbmNlc0tleTo6Y3NzQ29tcG9zaXRpbmdFbmFibGVkS2V5KCkpKTsKICAgICBz ZXR0aW5ncy5zZXRXZWJHTEVuYWJsZWQoc3RvcmUuZ2V0Qm9vbFZhbHVlRm9yS2V5KFdlYlByZWZl cmVuY2VzS2V5Ojp3ZWJHTEVuYWJsZWRLZXkoKSkpOwo=