142730 2015-03-16 10:29:44 -0700 Potentially uninitialized Inspector values 2015-03-16 11:24:25 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1077446 0 bfulgham 2015-03-16 10:29:44 -0700 In an effort to locate and resolve some WebInspector crashes I'm seeing on Windows, I wanted to clean up some of the warning MSVC and its analyzer are complaining about. The 'InspectorObjectBase::getInteger' can return false without setting its return value to anything. This leaves arguments in a potentially uninitialized state: source\webcore\inspector\inspectordomagent.cpp(119): warning C4701: potentially uninitialized local variable 'g' used source\webcore\inspector\inspectordomagent.cpp(119): warning C4701: potentially uninitialized local variable 'b' used 1077448 1 webkit-bug-importer 2015-03-16 10:30:05 -0700 <rdar://problem/20174405> 1077450 2 248731 bfulgham 2015-03-16 10:32:31 -0700 Created attachment 248731 Patch 1077486 3 248731 joepeck 2015-03-16 11:20:35 -0700 Comment on attachment 248731 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248731&action=review r=me > Source/WebCore/inspector/InspectorDOMAgent.cpp:117 > - double a; > + double a = 0; Maybe "1" would be a better default. 1077487 4 248731 bfulgham 2015-03-16 11:22:29 -0700 Comment on attachment 248731 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248731&action=review >> Source/WebCore/inspector/InspectorDOMAgent.cpp:117 >> + double a = 0; > > Maybe "1" would be a better default. Good point! I'll fix that. 1077489 5 bfulgham 2015-03-16 11:24:25 -0700 Committed r181568: <http://trac.webkit.org/changeset/181568> 248731 2015-03-16 10:32:31 -0700 2015-03-16 11:20:35 -0700 Patch bug-142730-20150316104058.patch text/plain 1376 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTU2MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE1LTAzLTE2ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFBvdGVudGlhbGx5IHVuaW5p dGlhbGl6ZWQgSW5zcGVjdG9yIHZhbHVlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQyNzMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6cGFyc2VDb2xvcik6IE1ha2Ugc3VyZSBjb2xvciB2YWx1ZXMgYXJlIGdp dmVuIGFuIGluaXRpYWwgdmFsdWUuCisKIDIwMTUtMDMtMTYgIENvbnJhZCBTaHVsdHogIDxjb25y YWRfc2h1bHR6QGFwcGxlLmNvbT4KIAogICAgICAgICBBbGxvdyBjbGllbnRzIHRvIHNlbGVjdGl2 ZWx5IGRpc2FibGUgcGx1Zy1pbnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JET01BZ2VudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvckRPTUFnZW50LmNwcAkocmV2aXNpb24gMTgxNTYxKQorKysgU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA4 LDEzICsxMDgsMTMgQEAgc3RhdGljIENvbG9yIHBhcnNlQ29sb3IoY29uc3QgUmVmUHRyPElucwog ICAgIGlmICghY29sb3JPYmplY3QpCiAgICAgICAgIHJldHVybiBDb2xvcjo6dHJhbnNwYXJlbnQ7 CiAKLSAgICBpbnQgcjsKLSAgICBpbnQgZzsKLSAgICBpbnQgYjsKKyAgICBpbnQgciA9IDA7Cisg ICAgaW50IGcgPSAwOworICAgIGludCBiID0gMDsKICAgICBpZiAoIWNvbG9yT2JqZWN0LT5nZXRJ bnRlZ2VyKCJyIiwgcikgfHwgIWNvbG9yT2JqZWN0LT5nZXRJbnRlZ2VyKCJnIiwgZykgfHwgIWNv bG9yT2JqZWN0LT5nZXRJbnRlZ2VyKCJiIiwgYikpCiAgICAgICAgIHJldHVybiBDb2xvcjo6dHJh bnNwYXJlbnQ7CiAKLSAgICBkb3VibGUgYTsKKyAgICBkb3VibGUgYSA9IDA7CiAgICAgaWYgKCFj b2xvck9iamVjdC0+Z2V0RG91YmxlKCJhIiwgYSkpCiAgICAgICAgIHJldHVybiBDb2xvcihyLCBn LCBiKTsKIAo=