142727 2015-03-16 10:13:59 -0700 'pageLoaded' diagnostic logging is too verbose 2015-03-17 08:49:13 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez commit-queue eric.carlson japhet jer.noble oldest_to_newest 1077435 0 cdumez 2015-03-16 10:13:59 -0700 'pageLoaded' diagnostic logging is too verbose: - It logs once per sub-frame instead of once per main frame - it does not sample and the event is frequent Radar: <rdar://problem/18937048> 1077437 1 248728 cdumez 2015-03-16 10:17:11 -0700 Created attachment 248728 Patch 1077886 2 248728 commit-queue 2015-03-17 08:49:08 -0700 Comment on attachment 248728 Patch Clearing flags on attachment: 248728 Committed r181649: <http://trac.webkit.org/changeset/181649> 1077887 3 commit-queue 2015-03-17 08:49:13 -0700 All reviewed patches have been landed. Closing bug. 248728 2015-03-16 10:17:11 -0700 2015-03-17 08:49:08 -0700 Patch bug-142727-20150316101642.patch text/plain 1934 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTFmMzQ2ODJhNTdjODI4 N2ZlMjM4OTc1NjBmYzllZjNmNzRhMTViZS4uNmY2ZTQ5OTkwMjZlMDBkNTY1YzUxZDEyZjYxNDEy NzRmMmUzM2UyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTAzLTE2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgJ3BhZ2VMb2FkZWQnIGRpYWdu b3N0aWMgbG9nZ2luZyBpcyB0b28gdmVyYm9zZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyNzI3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xODkz NzA0OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBN YWtlICdwYWdlTG9hZGVkJyBkaWFnbm9zdGljIGxvZ2dpbmcgbGVzcyB2ZXJib3NlOgorICAgICAg ICAtIExvZyBvbmNlIHBlciBtYWluIGZyYW1lIGluc3RlYWQgb2Ygb25jZSBmb3Igc3ViZnJhbWUK KyAgICAgICAgLSBBcHBseSBzYW1wbGluZworCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpjaGVja0xvYWRDb21wbGV0ZUZv clRoaXNGcmFtZSk6CisKIDIwMTUtMDMtMTYgIE1heCBTdGVwaW4gIDxtYXhzdGVwaW5AZ21haWwu Y29tPgogCiAgICAgICAgIEFkZCBBUE5HIHN1cHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVM b2FkZXIuY3BwCmluZGV4IDU4NzAyZThkM2I2Yjg1MzQ5MDNiNjVlZTExNDUyZDk5MzRhMzQ3ODYu LjdjOTg0ZjBjMDZlMGUzNzQ3NTYyMTRiNTRiOTlmZDYxYTA3OTAwNzYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv bG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApAQCAtMjI2OSw4ICsyMjY5LDggQEAgdm9pZCBGcmFtZUxv YWRlcjo6Y2hlY2tMb2FkQ29tcGxldGVGb3JUaGlzRnJhbWUoKQogICAgICAgICAgICAgaWYgKEFY T2JqZWN0Q2FjaGUqIGNhY2hlID0gbV9mcmFtZS5kb2N1bWVudCgpLT5leGlzdGluZ0FYT2JqZWN0 Q2FjaGUoKSkKICAgICAgICAgICAgICAgICBjYWNoZS0+ZnJhbWVMb2FkaW5nRXZlbnROb3RpZmlj YXRpb24oJm1fZnJhbWUsIGxvYWRpbmdFdmVudCk7CiAKLSAgICAgICAgICAgIGlmIChwYWdlKQot ICAgICAgICAgICAgICAgIHBhZ2UtPm1haW5GcmFtZSgpLmRpYWdub3N0aWNMb2dnaW5nQ2xpZW50 KCkubG9nRGlhZ25vc3RpY01lc3NhZ2VXaXRoUmVzdWx0KERpYWdub3N0aWNMb2dnaW5nS2V5czo6 cGFnZUxvYWRlZEtleSgpLCBlbXB0eVN0cmluZygpLCBlcnJvci5pc051bGwoKSA/IERpYWdub3N0 aWNMb2dnaW5nUmVzdWx0UGFzcyA6IERpYWdub3N0aWNMb2dnaW5nUmVzdWx0RmFpbCwgU2hvdWxk U2FtcGxlOjpObyk7CisgICAgICAgICAgICBpZiAocGFnZSAmJiBtX2ZyYW1lLmlzTWFpbkZyYW1l KCkpCisgICAgICAgICAgICAgICAgcGFnZS0+bWFpbkZyYW1lKCkuZGlhZ25vc3RpY0xvZ2dpbmdD bGllbnQoKS5sb2dEaWFnbm9zdGljTWVzc2FnZVdpdGhSZXN1bHQoRGlhZ25vc3RpY0xvZ2dpbmdL ZXlzOjpwYWdlTG9hZGVkS2V5KCksIGVtcHR5U3RyaW5nKCksIGVycm9yLmlzTnVsbCgpID8gRGlh Z25vc3RpY0xvZ2dpbmdSZXN1bHRQYXNzIDogRGlhZ25vc3RpY0xvZ2dpbmdSZXN1bHRGYWlsLCBT aG91bGRTYW1wbGU6Olllcyk7CiAKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQo=