142717 2015-03-15 18:24:27 -0700 [EFL][GTK] Fix build break after r181514 2015-03-15 19:28:10 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hs85.jeong hs85.jeong gyuyoung.kim lucas.de.marchi simon.fraser oldest_to_newest 1077296 0 hs85.jeong 2015-03-15 18:24:27 -0700 ../../Source/WebCore/html/HTMLInputElement.cpp: In member function 'void WebCore::HTMLInputElement::runPostTypeUpdateTasks()': ../../Source/WebCore/html/HTMLInputElement.cpp:521:52: error: no matching function for call to 'WebCore::Document::didAddTouchEventHandler(WebCore::HTMLInputElement* const)' ../../Source/WebCore/html/HTMLInputElement.cpp:521:52: note: candidate is: In file included from ../../Source/WebCore/dom/Element.h:29:0, from ../../Source/WebCore/dom/StyledElement.h:31, from ../../Source/WebCore/html/HTMLElement.h:26, from ../../Source/WebCore/html/LabelableElement.h:34, from ../../Source/WebCore/html/HTMLFormControlElement.h:28, from ../../Source/WebCore/html/HTMLFormControlElementWithState.h:27, from ../../Source/WebCore/html/HTMLTextFormControlElement.h:28, from ../../Source/WebCore/html/HTMLInputElement.h:29, from ../../Source/WebCore/html/HTMLInputElement.cpp:30: ../../Source/WebCore/html/HTMLInputElement.cpp:523:55: error: no matching function for call to 'WebCore::Document::didRemoveTouchEventHandler(WebCore::HTMLInputElement* const)' ../../Source/WebCore/html/HTMLInputElement.cpp:523:55: note: candidate is: In file included from ../../Source/WebCore/dom/Element.h:29:0, from ../../Source/WebCore/dom/StyledElement.h:31, from ../../Source/WebCore/html/HTMLElement.h:26, from ../../Source/WebCore/html/LabelableElement.h:34, from ../../Source/WebCore/html/HTMLFormControlElement.h:28, from ../../Source/WebCore/html/HTMLFormControlElementWithState.h:27, from ../../Source/WebCore/html/HTMLTextFormControlElement.h:28, from ../../Source/WebCore/html/HTMLInputElement.h:29, from ../../Source/WebCore/html/HTMLInputElement.cpp:30: ../../Source/WebCore/html/HTMLInputElement.cpp:1518:48: error: no matching function for call to 'WebCore::Document::didAddTouchEventHandler(WebCore::HTMLInputElement* const)' ../../Source/WebCore/html/HTMLInputElement.cpp:1518:48: note: candidate is: In file included from ../../Source/WebCore/dom/Element.h:29:0, from ../../Source/WebCore/dom/StyledElement.h:31, from ../../Source/WebCore/html/HTMLElement.h:26, from ../../Source/WebCore/html/LabelableElement.h:34, from ../../Source/WebCore/html/HTMLFormControlElement.h:28, from ../../Source/WebCore/html/HTMLFormControlElementWithState.h:27, from ../../Source/WebCore/html/HTMLTextFormControlElement.h:28, from ../../Source/WebCore/html/HTMLInputElement.h:29, from ../../Source/WebCore/html/HTMLInputElement.cpp:30: ../../Source/WebCore/dom/Document.cpp: In member function 'void WebCore::Document::didAddTouchEventHandler(WebCore::Node&)': ../../Source/WebCore/dom/Document.cpp:6018:45: error: no matching function for call to 'WebCore::Document::didAddTouchEventHandler(WebCore::Document* const)' ../../Source/WebCore/dom/Document.cpp:6018:45: note: candidate is: ../../Source/WebCore/dom/Document.cpp:6011:6: note: void WebCore::Document::didAddTouchEventHandler(WebCore::Node&) ../../Source/WebCore/dom/Document.cpp:6011:6: note: no known conversion for argument 1 from 'WebCore::Document* const' to 'WebCore::Node&' ../../Source/WebCore/dom/Document.cpp: In member function 'void WebCore::Document::didRemoveTouchEventHandler(WebCore::Node&)': ../../Source/WebCore/dom/Document.cpp:6038:48: error: no matching function for call to 'WebCore::Document::didRemoveTouchEventHandler(WebCore::Document* const)' ../../Source/WebCore/dom/Document.cpp:6038:48: note: candidate is: ../../Source/WebCore/dom/Document.cpp:6030:6: note: void WebCore::Document::didRemoveTouchEventHandler(WebCore::Node&) ../../Source/WebCore/dom/Document.cpp:6030:6: note: no known conversion for argument 1 from 'WebCore::Document* const' to 'WebCore::Node&' 1077297 1 248695 hs85.jeong 2015-03-15 18:28:44 -0700 Created attachment 248695 Patch 1077304 2 gyuyoung.kim 2015-03-15 19:08:57 -0700 r181514 passed to EFL EWS on Bug 142713. I wonder why EFL bot is broken. 1077305 3 gyuyoung.kim 2015-03-15 19:26:01 -0700 (In reply to comment #2) > r181514 passed to EFL EWS on Bug 142713. I wonder why EFL bot is broken. Looks like simon just fixes this break - https://trac.webkit.org/r181519 1077307 4 248695 simon.fraser 2015-03-15 19:28:04 -0700 Comment on attachment 248695 Patch Thanks. Committed in https://trac.webkit.org/r181519 and https://trac.webkit.org/r181520. 248695 2015-03-15 18:28:44 -0700 2015-03-15 19:28:04 -0700 Patch bug-142717-20150316102813.patch text/plain 3074 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjgyMTdlZDM3Mjg1NzQ2 ZjkwNTNlYjYwYjYzY2I0YzE4ZTNkNDU0ZS4uZGVjNzhjNDViMDlmYTlmOWY4Mjg2YTM3YTZkZmEz MTU1MzdiZDZhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAzLTE1ICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtHVEtd IEZpeCBidWlsZCBicmVhayBhZnRlciByMTgxNTE0IAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyNzE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RG9jdW1lbnQ6OmRpZEFkZFRvdWNoRXZlbnRIYW5kbGVyKToKKyAgICAgICAgKFdlYkNv cmU6OkRvY3VtZW50OjpkaWRSZW1vdmVUb3VjaEV2ZW50SGFuZGxlcik6CisgICAgICAgICogaHRt bC9IVE1MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1l bnQ6OnJ1blBvc3RUeXBlVXBkYXRlVGFza3MpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0 RWxlbWVudDo6ZGlkTW92ZVRvTmV3RG9jdW1lbnQpOgorCiAyMDE1LTAzLTE1ICBTaW1vbiBGcmFz ZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlZHVjZSB0aGUgc2lkZS1l ZmZlY3RzIG9mIGFuaW1hdGlvbnMgdHVybmluZyBvZmYgb3ZlcmxhcCB0ZXN0aW5nCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmNwcAppbmRleCBlYzI0MmY3YjJiYTllYjA5N2IwOTlhODliZjI3YTVjMmQ0NzRl NTk3Li4xMTYxODAxYzc1ZDRlNGY3MWJhMjA0YWNiZmEzZjc4OWQwZGM3ZjZjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAKQEAgLTYwMTUsNyArNjAxNSw3IEBAIHZvaWQgRG9jdW1lbnQ6OmRpZEFk ZFRvdWNoRXZlbnRIYW5kbGVyKE5vZGUmIGhhbmRsZXIpCiAgICAgICAgIG1fdG91Y2hFdmVudFRh cmdldHMgPSBzdGQ6Om1ha2VfdW5pcXVlPFRvdWNoRXZlbnRUYXJnZXRTZXQ+KCk7CiAgICAgbV90 b3VjaEV2ZW50VGFyZ2V0cy0+YWRkKCZoYW5kbGVyKTsKICAgICBpZiAoRG9jdW1lbnQqIHBhcmVu dCA9IHBhcmVudERvY3VtZW50KCkpIHsKLSAgICAgICAgcGFyZW50LT5kaWRBZGRUb3VjaEV2ZW50 SGFuZGxlcih0aGlzKTsKKyAgICAgICAgcGFyZW50LT5kaWRBZGRUb3VjaEV2ZW50SGFuZGxlcigq dGhpcyk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgaWYgKFBhZ2UqIHBhZ2UgPSB0aGlz LT5wYWdlKCkpIHsKQEAgLTYwMzUsNyArNjAzNSw3IEBAIHZvaWQgRG9jdW1lbnQ6OmRpZFJlbW92 ZVRvdWNoRXZlbnRIYW5kbGVyKE5vZGUmIGhhbmRsZXIpCiAgICAgQVNTRVJUKG1fdG91Y2hFdmVu dFRhcmdldHMtPmNvbnRhaW5zKGhhbmRsZXIpKTsKICAgICBtX3RvdWNoRXZlbnRUYXJnZXRzLT5y ZW1vdmUoJmhhbmRsZXIpOwogICAgIGlmIChEb2N1bWVudCogcGFyZW50ID0gcGFyZW50RG9jdW1l bnQoKSkgewotICAgICAgICBwYXJlbnQtPmRpZFJlbW92ZVRvdWNoRXZlbnRIYW5kbGVyKHRoaXMp OworICAgICAgICBwYXJlbnQtPmRpZFJlbW92ZVRvdWNoRXZlbnRIYW5kbGVyKCp0aGlzKTsKICAg ICAgICAgcmV0dXJuOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MSW5wdXRFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVu dC5jcHAKaW5kZXggMDYxNjQxZGExZmVmOGNiNDRiMWU3ZTFiNWFiZDQ5YTBmNTFjYmM1NS4uYTJm N2QyYzM1YmU3YzdmMzlkNTgwMTdjMmM3MTIxMzkyYmMxZGNkZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCkBAIC01MTgsOSArNTE4LDkgQEAgaW5saW5lIHZvaWQg SFRNTElucHV0RWxlbWVudDo6cnVuUG9zdFR5cGVVcGRhdGVUYXNrcygpCiAgICAgYm9vbCBoYXNU b3VjaEV2ZW50SGFuZGxlciA9IG1faW5wdXRUeXBlLT5oYXNUb3VjaEV2ZW50SGFuZGxlcigpOwog ICAgIGlmIChoYXNUb3VjaEV2ZW50SGFuZGxlciAhPSBtX2hhc1RvdWNoRXZlbnRIYW5kbGVyKSB7 CiAgICAgICAgIGlmIChoYXNUb3VjaEV2ZW50SGFuZGxlcikKLSAgICAgICAgICAgIGRvY3VtZW50 KCkuZGlkQWRkVG91Y2hFdmVudEhhbmRsZXIodGhpcyk7CisgICAgICAgICAgICBkb2N1bWVudCgp LmRpZEFkZFRvdWNoRXZlbnRIYW5kbGVyKCp0aGlzKTsKICAgICAgICAgZWxzZQotICAgICAgICAg ICAgZG9jdW1lbnQoKS5kaWRSZW1vdmVUb3VjaEV2ZW50SGFuZGxlcih0aGlzKTsKKyAgICAgICAg ICAgIGRvY3VtZW50KCkuZGlkUmVtb3ZlVG91Y2hFdmVudEhhbmRsZXIoKnRoaXMpOwogICAgICAg ICBtX2hhc1RvdWNoRXZlbnRIYW5kbGVyID0gaGFzVG91Y2hFdmVudEhhbmRsZXI7CiAgICAgfQog I2VuZGlmCkBAIC0xNTE1LDcgKzE1MTUsNyBAQCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OmRpZE1v dmVUb05ld0RvY3VtZW50KERvY3VtZW50KiBvbGREb2N1bWVudCkKIAogI2lmIEVOQUJMRShUT1VD SF9FVkVOVFMpCiAgICAgaWYgKG1faGFzVG91Y2hFdmVudEhhbmRsZXIpCi0gICAgICAgIGRvY3Vt ZW50KCkuZGlkQWRkVG91Y2hFdmVudEhhbmRsZXIodGhpcyk7CisgICAgICAgIGRvY3VtZW50KCku ZGlkQWRkVG91Y2hFdmVudEhhbmRsZXIoKnRoaXMpOwogI2VuZGlmCiAKICAgICBIVE1MVGV4dEZv cm1Db250cm9sRWxlbWVudDo6ZGlkTW92ZVRvTmV3RG9jdW1lbnQob2xkRG9jdW1lbnQpOwo=