142709 2015-03-15 00:01:49 -0700 Update Map/Set to treat -0 and 0 as the same value 2015-03-16 08:46:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue ggaren ossy oldest_to_newest 1077229 0 joepeck 2015-03-15 00:01:49 -0700 * SUMMARY MDN says "In earlier versions of the ECMAScript 6 draft -0 and +0 were considered distinct (even though -0 === +0), this has been changed in later versions". JSC is still treating -0 and 0 as distinct keys. Firefox and Chrome treat -0/0 the same. We should update. ES6 May 14, 2013 Draft ChangeLog notes: http://wiki.ecmascript.org/doku.php?id=harmony:specification_drafts http://wiki.ecmascript.org/doku.php?id=harmony:older_es6_drafts Added SameValueZero abstraction operation that considers -0 and +0 to be the same value. SameValueZero is only used by Map/Set operations. 1077230 1 248675 joepeck 2015-03-15 00:04:19 -0700 Created attachment 248675 [PATCH] Proposed Fix 1077412 2 248675 ossy 2015-03-16 08:02:36 -0700 Comment on attachment 248675 [PATCH] Proposed Fix LGTM 1077415 3 248675 commit-queue 2015-03-16 08:46:29 -0700 Comment on attachment 248675 [PATCH] Proposed Fix Clearing flags on attachment: 248675 Committed r181556: <http://trac.webkit.org/changeset/181556> 1077416 4 commit-queue 2015-03-16 08:46:33 -0700 All reviewed patches have been landed. Closing bug. 248675 2015-03-15 00:04:19 -0700 2015-03-16 08:46:29 -0700 [PATCH] Proposed Fix bug-142709-20150315000351.patch text/plain 6302 joepeck U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 YTY5Zjk0MTJmNzc3ZDYxNGI1ZmI0OGY3MGMyNWRjYzFhNTQzMDZiLi43NDZkNmU0MDgzOTQxNTZm NDgwOWIwMzJhYmE2OWQ3NDBjNjYwZjM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNS0wMy0xNSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFVwZGF0ZSBNYXAvU2V0IHRvIHRyZWF0IC0wIGFuZCAwIGFzIHRoZSBz YW1lIHZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDI3MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHJ1bnRpbWUvTWFwRGF0YS5oOgorICAgICAgICAoSlNDOjpNYXBEYXRhSW1wbDxFbnRyeT46 OktleVR5cGU6OktleVR5cGUpOgorICAgICAgICBObyBsb25nZXIgc3BlY2lhbCBjYXNlIC0wLiBJ dCB3aWxsIGJlIHRyZWF0ZWQgYXMgdGhlIHNhbWUgYXMgMC4KKwogMjAxNS0wMy0xNCAgSm9zZXBo IFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IEJldHRlciBoYW5kbGUgZGlzcGxheWluZyAtMApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvTWFwRGF0YS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv TWFwRGF0YS5oCmluZGV4IDFmODk1NzBiODM4MzNlNWFlODNkYzRiZTI5YjM4ODcxMGY4NDY0Mzgu LjZmM2JhYzJjZTUwODM3MmQ1MmFlNGIyM2JmN2MwZTE1M2U5MjI1MWQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcERhdGEuaAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9NYXBEYXRhLmgKQEAgLTE1Miw3ICsxNTIsNyBAQCBBTFdBWVNfSU5M SU5FIE1hcERhdGFJbXBsPEVudHJ5Pjo6S2V5VHlwZTo6S2V5VHlwZShKU1ZhbHVlIHYpCiAgICAg ICAgIHJldHVybjsKICAgICB9CiAgICAgZG91YmxlIGQgPSB2LmFzRG91YmxlKCk7Ci0gICAgaWYg KHN0ZDo6aXNuYW4oZCkgfHwgKHN0ZDo6c2lnbmJpdChkKSAmJiBkID09IDAuMCkpIHsKKyAgICBp ZiAoc3RkOjppc25hbihkKSkgewogICAgICAgICB2YWx1ZSA9IHY7CiAgICAgICAgIHJldHVybjsK ICAgICB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggMjc1MDNmZTc4NjkxNGMwNjY3N2FlZDdjNmJiMDI1OWJlMWJiZTMyMi4u ZWUyNmQ5OWJkOTVmZjBjYWFkNmM2MWZjYzEyNzI2ZGI3ODU0NWRiMSAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDE1LTAzLTE1ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgVXBkYXRlIE1hcC9TZXQgdG8gdHJlYXQgLTAgYW5kIDAgYXMgdGhlIHNhbWUg dmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 MjcwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog anMvYmFzaWMtbWFwLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBqcy9iYXNpYy1zZXQtZXhwZWN0 ZWQudHh0OgorICAgICAgICAqIGpzL3NjcmlwdC10ZXN0cy9iYXNpYy1tYXAuanM6CisgICAgICAg ICoganMvc2NyaXB0LXRlc3RzL2Jhc2ljLXNldC5qczoKKyAgICAgICAgVXBkYXRlIHRlc3RzIG5v dyB0aGF0IC0wIGFuZCAwIGFyZSB0cmVhdGVkIHRoZSBzYW1lLgorCiAyMDE1LTAzLTE0ICBKb3Nl cGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogQmV0dGVyIGhhbmRsZSBkaXNwbGF5aW5nIC0wCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9q cy9iYXNpYy1tYXAtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvanMvYmFzaWMtbWFwLWV4cGVj dGVkLnR4dAppbmRleCA0OGI2ZmNkMWY1MDVlZmM0MjQ2ZWIzYzlmZGM2NjhiODc3ZjliYzdkLi4z NDIyNWY0Mzk1NGI5YzMzODU3N2NhNTJhNDdiNjc4ZDlhM2M2MjNiIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9qcy9iYXNpYy1tYXAtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2pzL2Jh c2ljLW1hcC1leHBlY3RlZC50eHQKQEAgLTM3LDEzICszNywxNCBAQCBQQVNTIE1hcC5wcm90b3R5 cGUuZW50cmllcy5sZW5ndGggaXMgMAogUEFTUyBtYXAuc2l6ZSBpcyAwCiBQQVNTIG1hcC5zZXQo LTAsIDEpIGlzIG1hcAogUEFTUyBtYXAuc2V0KDAsIDIpIGlzIG1hcAorUEFTUyBtYXAuc2l6ZSBp cyAxCiBQQVNTIG1hcC5zZXQoSW5maW5pdHksIDMpIGlzIG1hcAogUEFTUyBtYXAuc2V0KC1JbmZp bml0eSwgNCkgaXMgbWFwCiBQQVNTIG1hcC5zZXQoTmFOLCA1KSBpcyBtYXAKIFBBU1MgbWFwLnNl dCgnMCcsIDYpIGlzIG1hcAogUEFTUyBtYXAuc2V0KDAuMSwgNykgaXMgbWFwCi1QQVNTIG1hcC5z aXplIGlzIDcKLVBBU1MgbWFwLmdldCgtMCkgaXMgMQorUEFTUyBtYXAuc2l6ZSBpcyA2CitQQVNT IG1hcC5nZXQoLTApIGlzIDIKIFBBU1MgbWFwLmdldCgwKSBpcyAyCiBQQVNTIG1hcC5nZXQoSW5m aW5pdHkpIGlzIDMKIFBBU1MgbWFwLmdldCgtSW5maW5pdHkpIGlzIDQKQEAgLTU4LDcgKzU5LDcg QEAgUEFTUyBtYXAuaGFzKE5hTikgaXMgdHJ1ZQogUEFTUyBtYXAuaGFzKCcwJykgaXMgdHJ1ZQog UEFTUyBtYXAuaGFzKDAuMSkgaXMgdHJ1ZQogUEFTUyBtYXAuZGVsZXRlKC0wKSBpcyB0cnVlCi1Q QVNTIG1hcC5kZWxldGUoMCkgaXMgdHJ1ZQorUEFTUyBtYXAuZGVsZXRlKDApIGlzIGZhbHNlCiBQ QVNTIG1hcC5kZWxldGUoSW5maW5pdHkpIGlzIHRydWUKIFBBU1MgbWFwLmRlbGV0ZSgtSW5maW5p dHkpIGlzIHRydWUKIFBBU1MgbWFwLmRlbGV0ZShOYU4pIGlzIHRydWUKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2pzL2Jhc2ljLXNldC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9qcy9iYXNp Yy1zZXQtZXhwZWN0ZWQudHh0CmluZGV4IGUwOThhNGFmZDBkZjYzNmZlNDFhMDE3NTEwYWYxMGQ4 NDdlNTczNzguLmE4ODdjYThlMTllOTMyNzNjMGU5N2QzMzdhNDBhMjE3MjRiYmUyMmIgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2pzL2Jhc2ljLXNldC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0 VGVzdHMvanMvYmFzaWMtc2V0LWV4cGVjdGVkLnR4dApAQCAtNDYsMTIgKzQ2LDEzIEBAIFBBU1Mg U2V0LnByb3RvdHlwZS5lbnRyaWVzLmxlbmd0aCBpcyAwCiBQQVNTIHNldC5zaXplIGlzIDAKIFBB U1Mgc2V0LmFkZCgtMCkgaXMgc2V0CiBQQVNTIHNldC5hZGQoMCkgaXMgc2V0CitQQVNTIHNldC5z aXplIGlzIDEKIFBBU1Mgc2V0LmFkZChJbmZpbml0eSkgaXMgc2V0CiBQQVNTIHNldC5hZGQoLUlu ZmluaXR5KSBpcyBzZXQKIFBBU1Mgc2V0LmFkZChOYU4pIGlzIHNldAogUEFTUyBzZXQuYWRkKCcw JykgaXMgc2V0CiBQQVNTIHNldC5hZGQoMC4xKSBpcyBzZXQKLVBBU1Mgc2V0LnNpemUgaXMgNwor UEFTUyBzZXQuc2l6ZSBpcyA2CiBQQVNTIHNldC5oYXMoLTApIGlzIHRydWUKIFBBU1Mgc2V0Lmhh cygwKSBpcyB0cnVlCiBQQVNTIHNldC5oYXMoSW5maW5pdHkpIGlzIHRydWUKQEAgLTYwLDcgKzYx LDcgQEAgUEFTUyBzZXQuaGFzKE5hTikgaXMgdHJ1ZQogUEFTUyBzZXQuaGFzKCcwJykgaXMgdHJ1 ZQogUEFTUyBzZXQuaGFzKDAuMSkgaXMgdHJ1ZQogUEFTUyBzZXQuZGVsZXRlKC0wKSBpcyB0cnVl Ci1QQVNTIHNldC5kZWxldGUoMCkgaXMgdHJ1ZQorUEFTUyBzZXQuZGVsZXRlKDApIGlzIGZhbHNl CiBQQVNTIHNldC5kZWxldGUoSW5maW5pdHkpIGlzIHRydWUKIFBBU1Mgc2V0LmRlbGV0ZSgtSW5m aW5pdHkpIGlzIHRydWUKIFBBU1Mgc2V0LmRlbGV0ZShOYU4pIGlzIHRydWUKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9iYXNpYy1tYXAuanMgYi9MYXlvdXRUZXN0cy9q cy9zY3JpcHQtdGVzdHMvYmFzaWMtbWFwLmpzCmluZGV4IDJkOTI1ZjNjNWEwMWIzNjNhYWIzZjAx MjgxYzU3ZjU2YzYxMjNmMjkuLjExYTcwZTI5MTlkZjlhZGMyMjhmZTkyMWY3NjFhYzNjOTJmNmM5 NDYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9iYXNpYy1tYXAuanMK KysrIGIvTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL2Jhc2ljLW1hcC5qcwpAQCAtNDEsMTMg KzQxLDE0IEBAIHNob3VsZEJlKCJNYXAucHJvdG90eXBlLmVudHJpZXMubGVuZ3RoIiwgIjAiKQog c2hvdWxkQmUoIm1hcC5zaXplIiwgIjAiKQogc2hvdWxkQmUoIm1hcC5zZXQoLTAsIDEpIiwgIm1h cCIpCiBzaG91bGRCZSgibWFwLnNldCgwLCAyKSIsICJtYXAiKQorc2hvdWxkQmUoIm1hcC5zaXpl IiwgIjEiKQogc2hvdWxkQmUoIm1hcC5zZXQoSW5maW5pdHksIDMpIiwgIm1hcCIpCiBzaG91bGRC ZSgibWFwLnNldCgtSW5maW5pdHksIDQpIiwgIm1hcCIpCiBzaG91bGRCZSgibWFwLnNldChOYU4s IDUpIiwgIm1hcCIpCiBzaG91bGRCZSgibWFwLnNldCgnMCcsIDYpIiwgIm1hcCIpCiBzaG91bGRC ZSgibWFwLnNldCgwLjEsIDcpIiwgIm1hcCIpCi1zaG91bGRCZSgibWFwLnNpemUiLCAiNyIpCi1z aG91bGRCZSgibWFwLmdldCgtMCkiLCAiMSIpCitzaG91bGRCZSgibWFwLnNpemUiLCAiNiIpCitz aG91bGRCZSgibWFwLmdldCgtMCkiLCAiMiIpCiBzaG91bGRCZSgibWFwLmdldCgwKSIsICIyIikK IHNob3VsZEJlKCJtYXAuZ2V0KEluZmluaXR5KSIsICIzIikKIHNob3VsZEJlKCJtYXAuZ2V0KC1J bmZpbml0eSkiLCAiNCIpCkBAIC02NCw3ICs2NSw3IEBAIHNob3VsZEJlVHJ1ZSgibWFwLmhhcygn MCcpIikKIHNob3VsZEJlVHJ1ZSgibWFwLmhhcygwLjEpIikKIAogc2hvdWxkQmVUcnVlKCJtYXAu ZGVsZXRlKC0wKSIpCi1zaG91bGRCZVRydWUoIm1hcC5kZWxldGUoMCkiKQorc2hvdWxkQmVGYWxz ZSgibWFwLmRlbGV0ZSgwKSIpCiBzaG91bGRCZVRydWUoIm1hcC5kZWxldGUoSW5maW5pdHkpIikK IHNob3VsZEJlVHJ1ZSgibWFwLmRlbGV0ZSgtSW5maW5pdHkpIikKIHNob3VsZEJlVHJ1ZSgibWFw LmRlbGV0ZShOYU4pIikKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9i YXNpYy1zZXQuanMgYi9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvYmFzaWMtc2V0LmpzCmlu ZGV4IGE5OWE2NzM5OWFkZDJhMmUyZDcwZTMyYmIzY2FlMDc0ZmQzYWYyZGYuLjk2YTNlNmMxOGIw NzUxNmU3Mjg4YWIxYjg5YjhlNGRhZWI2ZjE1MTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2pz L3NjcmlwdC10ZXN0cy9iYXNpYy1zZXQuanMKKysrIGIvTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRl c3RzL2Jhc2ljLXNldC5qcwpAQCAtNDgsMTIgKzQ4LDEzIEBAIHNob3VsZEJlKCJTZXQucHJvdG90 eXBlLmVudHJpZXMubGVuZ3RoIiwgIjAiKQogc2hvdWxkQmUoInNldC5zaXplIiwgIjAiKQogc2hv dWxkQmUoInNldC5hZGQoLTApIiwgInNldCIpCiBzaG91bGRCZSgic2V0LmFkZCgwKSIsICJzZXQi KQorc2hvdWxkQmUoInNldC5zaXplIiwgIjEiKQogc2hvdWxkQmUoInNldC5hZGQoSW5maW5pdHkp IiwgInNldCIpCiBzaG91bGRCZSgic2V0LmFkZCgtSW5maW5pdHkpIiwgInNldCIpCiBzaG91bGRC ZSgic2V0LmFkZChOYU4pIiwgInNldCIpCiBzaG91bGRCZSgic2V0LmFkZCgnMCcpIiwgInNldCIp CiBzaG91bGRCZSgic2V0LmFkZCgwLjEpIiwgInNldCIpCi1zaG91bGRCZSgic2V0LnNpemUiLCAi NyIpCitzaG91bGRCZSgic2V0LnNpemUiLCAiNiIpCiAKIHNob3VsZEJlVHJ1ZSgic2V0Lmhhcygt MCkiKQogc2hvdWxkQmVUcnVlKCJzZXQuaGFzKDApIikKQEAgLTY0LDcgKzY1LDcgQEAgc2hvdWxk QmVUcnVlKCJzZXQuaGFzKCcwJykiKQogc2hvdWxkQmVUcnVlKCJzZXQuaGFzKDAuMSkiKQogCiBz aG91bGRCZVRydWUoInNldC5kZWxldGUoLTApIikKLXNob3VsZEJlVHJ1ZSgic2V0LmRlbGV0ZSgw KSIpCitzaG91bGRCZUZhbHNlKCJzZXQuZGVsZXRlKDApIikKIHNob3VsZEJlVHJ1ZSgic2V0LmRl bGV0ZShJbmZpbml0eSkiKQogc2hvdWxkQmVUcnVlKCJzZXQuZGVsZXRlKC1JbmZpbml0eSkiKQog c2hvdWxkQmVUcnVlKCJzZXQuZGVsZXRlKE5hTikiKQo=