142708 2015-03-14 23:12:09 -0700 Web Inspector: Better handle displaying -0 2015-03-15 17:17:08 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1077226 0 joepeck 2015-03-14 23:12:09 -0700 * SUMMARY Better handle displaying -0. We currently just display it as 0. * STEPS TO REPRODUCE 1. js> -0 => "0", expected "-0" * NOTES - Firefox / Chrome better handle -0. 1077227 1 webkit-bug-importer 2015-03-14 23:12:22 -0700 <rdar://problem/20165979> 1077228 2 248674 joepeck 2015-03-14 23:37:26 -0700 Created attachment 248674 [PATCH] Proposed Fix 1077280 3 248674 commit-queue 2015-03-15 17:17:04 -0700 Comment on attachment 248674 [PATCH] Proposed Fix Clearing flags on attachment: 248674 Committed r181516: <http://trac.webkit.org/changeset/181516> 1077281 4 commit-queue 2015-03-15 17:17:08 -0700 All reviewed patches have been landed. Closing bug. 248674 2015-03-14 23:37:26 -0700 2015-03-15 17:17:04 -0700 [PATCH] Proposed Fix bug-142708-20150314233659.patch text/plain 7468 joepeck U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 MTNiYjJmZjc2YjRhNWRiNjVkYWYyOTEwZmJkNzI4YzdkNWI1MzhkLi45YTY5Zjk0MTJmNzc3ZDYx NGI1ZmI0OGY3MGMyNWRjYzFhNTQzMDZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNS0wMy0xNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEJldHRlciBoYW5kbGUgZGlzcGxheWluZyAt MAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyNzA4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW9kZWxl ZCBhZnRlciBhIGJsaW5rIGNoYW5nZToKKworICAgICAgICBQYXRjaCBieSA8YWFuZHJleUBjaHJv bWl1bS5vcmc+CisgICAgICAgIERldlRvb2xzOiBEZXZUb29sczogU2hvdyAtMCBmb3IgbmVnYXRp dmUgemVybyBpbiBjb25zb2xlCisgICAgICAgIGh0dHBzOi8vc3JjLmNocm9taXVtLm9yZy92aWV3 dmMvYmxpbms/cmV2aXNpb249MTYyNjA1JnZpZXc9cmV2aXNpb24KKworICAgICAgICAqIGluc3Bl Y3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qczoKKyAgICAgICAgV2hlbiBjcmVhdGluZyBhIGRl c2NyaXB0aW9uIHN0cmluZywgb3IgcHJldmlldyB2YWx1ZSBzdHJpbmcKKyAgICAgICAgZm9yIC0w LCBiZSBzdXJlIHRoZSBzdHJpbmcgaXMgIi0wIiBhbmQgbm90ICIwIi4KKwogMjAxNS0wMy0xNCAg RGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgRmVhdHVyZSBmbGFnIGZv ciBBbmltYXRpb25zIExldmVsIDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzCmluZGV4IDQ0NzM1MjM0ZjRkNWJiMDdk NDcxYWViMTlkZmZlOGFmMzdjNjlkYzYuLjkxMjdlZmYzMDQ4MDJhNTIwNWQwNjFhZDhlZGZmMTA3 MWY3NTI4ZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5q ZWN0ZWRTY3JpcHRTb3VyY2UuanMKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rv ci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcwpAQCAtMzksNiArMzksMTQgQEAgZnVuY3Rpb24gdG9T dHJpbmcob2JqKQogICAgIHJldHVybiBTdHJpbmcob2JqKTsKIH0KIAorZnVuY3Rpb24gdG9TdHJp bmdEZXNjcmlwdGlvbihvYmopCit7CisgICAgaWYgKG9iaiA9PT0gMCAmJiAxIC8gb2JqIDwgMCkK KyAgICAgICAgcmV0dXJuICItMCI7CisKKyAgICByZXR1cm4gdG9TdHJpbmcob2JqKTsKK30KKwog ZnVuY3Rpb24gaXNVSW50MzIob2JqKQogewogICAgIGlmICh0eXBlb2Ygb2JqID09PSAibnVtYmVy IikKQEAgLTQyNCw3ICs0MzIsNyBAQCBJbmplY3RlZFNjcmlwdC5wcm90b3R5cGUgPSB7CiAgICAg ewogICAgICAgICB2YXIgcmVtb3RlT2JqZWN0ID0gdGhpcy5fd3JhcE9iamVjdCh2YWx1ZSwgb2Jq ZWN0R3JvdXApOwogICAgICAgICB0cnkgewotICAgICAgICAgICAgcmVtb3RlT2JqZWN0LmRlc2Ny aXB0aW9uID0gdG9TdHJpbmcodmFsdWUpOworICAgICAgICAgICAgcmVtb3RlT2JqZWN0LmRlc2Ny aXB0aW9uID0gdG9TdHJpbmdEZXNjcmlwdGlvbih2YWx1ZSk7CiAgICAgICAgIH0gY2F0Y2ggKGUp IHt9CiAgICAgICAgIHJldHVybiB7CiAgICAgICAgICAgICB3YXNUaHJvd246IHRydWUsCkBAIC04 OTUsNyArOTAzLDcgQEAgSW5qZWN0ZWRTY3JpcHQuUmVtb3RlT2JqZWN0ID0gZnVuY3Rpb24ob2Jq ZWN0LCBvYmplY3RHcm91cE5hbWUsIGZvcmNlVmFsdWVUeXBlLAogCiAgICAgICAgIC8vIFByb3Zp ZGUgdXNlci1mcmllbmRseSBudW1iZXIgdmFsdWVzLgogICAgICAgICBpZiAodGhpcy50eXBlID09 PSAibnVtYmVyIikKLSAgICAgICAgICAgIHRoaXMuZGVzY3JpcHRpb24gPSBvYmplY3QgKyAiIjsK KyAgICAgICAgICAgIHRoaXMuZGVzY3JpcHRpb24gPSB0b1N0cmluZ0Rlc2NyaXB0aW9uKG9iamVj dCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKQEAgLTEwNTYsNyArMTA2NCw3IEBAIEluamVj dGVkU2NyaXB0LlJlbW90ZU9iamVjdC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAgICAg IHZhbHVlID0gdGhpcy5fYWJicmV2aWF0ZVN0cmluZyh2YWx1ZSwgbWF4TGVuZ3RoLCB0cnVlKTsK ICAgICAgICAgICAgICAgICAgICAgcHJldmlldy5sb3NzbGVzcyA9IGZhbHNlOwogICAgICAgICAg ICAgICAgIH0KLSAgICAgICAgICAgICAgICB0aGlzLl9hcHBlbmRQcm9wZXJ0eVByZXZpZXcocHJl dmlldywgaW50ZXJuYWwsIHtuYW1lLCB0eXBlLCB2YWx1ZTogdG9TdHJpbmcodmFsdWUpfSwgcHJv cGVydGllc1RocmVzaG9sZCk7CisgICAgICAgICAgICAgICAgdGhpcy5fYXBwZW5kUHJvcGVydHlQ cmV2aWV3KHByZXZpZXcsIGludGVybmFsLCB7bmFtZSwgdHlwZSwgdmFsdWU6IHRvU3RyaW5nRGVz Y3JpcHRpb24odmFsdWUpfSwgcHJvcGVydGllc1RocmVzaG9sZCk7CiAgICAgICAgICAgICAgICAg Y29udGludWU7CiAgICAgICAgICAgICB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0MzRlZjhmMjNmM2JkOWNkMDIxZmE3 MGYzODcxNGRlOGRhNTIwMDU0Li4yNzUwM2ZlNzg2OTE0YzA2Njc3YWVkN2M2YmIwMjU5YmUxYmJl MzIyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTUtMDMtMTQgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBCZXR0ZXIgaGFu ZGxlIGRpc3BsYXlpbmcgLTAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0MjcwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZCB0ZXN0cyBmb3IgLTAgaW4gZGlmZmVyZW50IHBsYWNlcy4KKyAgICAgICAg SSBkb24ndCB1bmRlcnN0YW5kIHlldCB3aHkgdGhlIHRlc3Qgc2F5cyAiMCIgZm9yCisgICAgICAg IHRoZSBwcm9wZXJ0eSBwcmV2aWV3cyBvZiAiLTAiLiBFdmVyeXRoaW5nIGJlaGF2ZXMKKyAgICAg ICAgY29ycmVjdGx5LCBidXQgSSBjYW4ndCBzZWUgdG8gbWFrZSB0aGUgdGVzdCBzaG93CisgICAg ICAgIHRoZSByaWdodCB2YWx1ZSBhcHBlYXIgaW4gdGhlIHRlc3QuIFRoYXQgaXMgd29ydGgKKyAg ICAgICAgaW52ZXN0aWdhdGluZyBzZXBhcmF0ZWx5IHRob3VnaC4KKworICAgICAgICAqIGluc3Bl Y3Rvci9tb2RlbC9yZW1vdGUtb2JqZWN0LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBpbnNwZWN0 b3IvbW9kZWwvcmVtb3RlLW9iamVjdC5odG1sOgorCiAyMDE1LTAzLTE0ICBNaWNoYWVsIFNhYm9m ZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIEVTNjogQWRkIGJpbmFyeSBhbmQgb2N0 YWwgbGl0ZXJhbCBzdXBwb3J0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvbW9k ZWwvcmVtb3RlLW9iamVjdC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvbW9k ZWwvcmVtb3RlLW9iamVjdC1leHBlY3RlZC50eHQKaW5kZXggNjM2YmYwODljYTlkMTU5NjFlYWIx OWVjZGIzNmQxOTJiNWZhODcyYS4uYjE1ZjYwYmE2YWIyN2Y3NDIyZTgxZTcwMDdhZjdmOThmMjky M2YxMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL21vZGVsL3JlbW90ZS1vYmpl Y3QtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9tb2RlbC9yZW1vdGUt b2JqZWN0LWV4cGVjdGVkLnR4dApAQCAtNTksNyArNTksNyBAQCBFWFBSRVNTSU9OOiAwCiBFWFBS RVNTSU9OOiAtMAogewogICAiX3R5cGUiOiAibnVtYmVyIiwKLSAgIl9kZXNjcmlwdGlvbiI6ICIw IiwKKyAgIl9kZXNjcmlwdGlvbiI6ICItMCIsCiAgICJfdmFsdWUiOiAwCiB9CiAKQEAgLTEzNiw2 ICsxMzYsMTQgQEAgRVhQUkVTU0lPTjogSW5maW5pdHkKIH0KIAogLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KK0VYUFJFU1NJT046IC1JbmZpbml0 eQoreworICAiX3R5cGUiOiAibnVtYmVyIiwKKyAgIl9kZXNjcmlwdGlvbiI6ICItSW5maW5pdHki LAorICAiX3ZhbHVlIjogbnVsbAorfQorCistLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogRVhQUkVTU0lPTjogJycKIHsKICAgIl90eXBlIjogInN0 cmluZyIsCkBAIC01MzIsMjkgKzU0MCwzOSBAQCBFWFBSRVNTSU9OOiBbXQogfQogCiAtLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQotRVhQUkVTU0lP TjogWzEsIDJdCitFWFBSRVNTSU9OOiBbMCwgLTAsIDEsIDJdCiB7CiAgICJfdHlwZSI6ICJvYmpl Y3QiLAogICAiX3N1YnR5cGUiOiAiYXJyYXkiLAogICAiX29iamVjdElkIjogIjxmaWx0ZXJlZD4i LAogICAiX2Rlc2NyaXB0aW9uIjogIkFycmF5IiwKLSAgIl9zaXplIjogMiwKKyAgIl9zaXplIjog NCwKICAgIl9wcmV2aWV3IjogewogICAgICJfdHlwZSI6ICJvYmplY3QiLAogICAgICJfc3VidHlw ZSI6ICJhcnJheSIsCiAgICAgIl9kZXNjcmlwdGlvbiI6ICJBcnJheSIsCiAgICAgIl9sb3NzbGVz cyI6IHRydWUsCiAgICAgIl9vdmVyZmxvdyI6IGZhbHNlLAotICAgICJfc2l6ZSI6IDIsCisgICAg Il9zaXplIjogNCwKICAgICAiX3Byb3BlcnRpZXMiOiBbCiAgICAgICB7CiAgICAgICAgICJfbmFt ZSI6ICIwIiwKICAgICAgICAgIl90eXBlIjogIm51bWJlciIsCi0gICAgICAgICJfdmFsdWUiOiAi MSIKKyAgICAgICAgIl92YWx1ZSI6ICIwIgogICAgICAgfSwKICAgICAgIHsKICAgICAgICAgIl9u YW1lIjogIjEiLAogICAgICAgICAiX3R5cGUiOiAibnVtYmVyIiwKKyAgICAgICAgIl92YWx1ZSI6 ICIwIgorICAgICAgfSwKKyAgICAgIHsKKyAgICAgICAgIl9uYW1lIjogIjIiLAorICAgICAgICAi X3R5cGUiOiAibnVtYmVyIiwKKyAgICAgICAgIl92YWx1ZSI6ICIxIgorICAgICAgfSwKKyAgICAg IHsKKyAgICAgICAgIl9uYW1lIjogIjMiLAorICAgICAgICAiX3R5cGUiOiAibnVtYmVyIiwKICAg ICAgICAgIl92YWx1ZSI6ICIyIgogICAgICAgfQogICAgIF0sCkBAIC0xNDY2LDYgKzE0ODQsMzgg QEAgRVhQUkVTU0lPTjogKHthOiAxfSkKIH0KIAogLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KK0VYUFJFU1NJT046ICh7YTogMSwgYjogMCwgYzog LTB9KQoreworICAiX3R5cGUiOiAib2JqZWN0IiwKKyAgIl9vYmplY3RJZCI6ICI8ZmlsdGVyZWQ+ IiwKKyAgIl9kZXNjcmlwdGlvbiI6ICJPYmplY3QiLAorICAiX3ByZXZpZXciOiB7CisgICAgIl90 eXBlIjogIm9iamVjdCIsCisgICAgIl9kZXNjcmlwdGlvbiI6ICJPYmplY3QiLAorICAgICJfbG9z c2xlc3MiOiB0cnVlLAorICAgICJfb3ZlcmZsb3ciOiBmYWxzZSwKKyAgICAiX3Byb3BlcnRpZXMi OiBbCisgICAgICB7CisgICAgICAgICJfbmFtZSI6ICJhIiwKKyAgICAgICAgIl90eXBlIjogIm51 bWJlciIsCisgICAgICAgICJfdmFsdWUiOiAiMSIKKyAgICAgIH0sCisgICAgICB7CisgICAgICAg ICJfbmFtZSI6ICJiIiwKKyAgICAgICAgIl90eXBlIjogIm51bWJlciIsCisgICAgICAgICJfdmFs dWUiOiAiMCIKKyAgICAgIH0sCisgICAgICB7CisgICAgICAgICJfbmFtZSI6ICJjIiwKKyAgICAg ICAgIl90eXBlIjogIm51bWJlciIsCisgICAgICAgICJfdmFsdWUiOiAiMCIKKyAgICAgIH0KKyAg ICBdLAorICAgICJfZW50cmllcyI6IG51bGwKKyAgfQorfQorCistLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogRVhQUkVTU0lPTjogKHthOiAxLCBi OiAic3RyaW5nIiwgYzogL3JlZ2V4LywgZDogU3ltYm9sKCdzeW0nKX0pCiB7CiAgICJfdHlwZSI6 ICJvYmplY3QiLApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL21vZGVsL3JlbW90 ZS1vYmplY3QuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9tb2RlbC9yZW1vdGUtb2JqZWN0 Lmh0bWwKaW5kZXggMzUzMWYwY2U0ZTBjNGZjODM1MDRkZDgyYmQ2Y2U5NDE0YzM4MmFlYi4uMjEz NDk0OGZiZWI1ZDBhNWVkMGI5MmFmN2RkMDk0N2I5MGMwMmEzMiAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvaW5zcGVjdG9yL21vZGVsL3JlbW90ZS1vYmplY3QuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvbW9kZWwvcmVtb3RlLW9iamVjdC5odG1sCkBAIC0zNiw2ICszNiw3IEBAIGZ1 bmN0aW9uIHRlc3QoKQogICAgICAgICB7ZXhwcmVzc2lvbjogIk51bWJlci5NSU5fVkFMVUUifSwK ICAgICAgICAge2V4cHJlc3Npb246ICJOYU4ifSwKICAgICAgICAge2V4cHJlc3Npb246ICJJbmZp bml0eSJ9LAorICAgICAgICB7ZXhwcmVzc2lvbjogIi1JbmZpbml0eSJ9LAogCiAgICAgICAgIC8v IFN0cmluZ3MKICAgICAgICAge2V4cHJlc3Npb246ICInJyJ9LApAQCAtNzEsNyArNzIsNyBAQCBm dW5jdGlvbiB0ZXN0KCkKIAogICAgICAgICAvLyBBcnJheQogICAgICAgICB7ZXhwcmVzc2lvbjog IltdIn0sCi0gICAgICAgIHtleHByZXNzaW9uOiAiWzEsIDJdIn0sCisgICAgICAgIHtleHByZXNz aW9uOiAiWzAsIC0wLCAxLCAyXSJ9LAogICAgICAgICB7ZXhwcmVzc2lvbjogIltbMV0sWzJdLFsz XV0ifSwKICAgICAgICAge2V4cHJlc3Npb246ICJbdHJ1ZSwgMSwgMS4yMzQsICdzdHJpbmcnLCAv cmVnZXgvXSJ9LAogICAgICAgICB7ZXhwcmVzc2lvbjogIlt7YToxfSwge2I6Mn0sIHtjOjJ9XSJ9 LApAQCAtODgsNiArODksNyBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAgLy8gT2JqZWN0CiAg ICAgICAgIHtleHByZXNzaW9uOiAiKHt9KSJ9LAogICAgICAgICB7ZXhwcmVzc2lvbjogIih7YTog MX0pIn0sCisgICAgICAgIHtleHByZXNzaW9uOiAiKHthOiAxLCBiOiAwLCBjOiAtMH0pIn0sCiAg ICAgICAgIHtleHByZXNzaW9uOiAiKHthOiAxLCBiOiBcInN0cmluZ1wiLCBjOiAvcmVnZXgvLCBk OiBTeW1ib2woJ3N5bScpfSkifSwKICAgICAgICAge2V4cHJlc3Npb246ICIoe2E6ZnVuY3Rpb24g YSgpe30sIGI6ZnVuY3Rpb24gYigpe30sIGdldCBnZXR0ZXIoKXt9LCBzZXQgc2V0dGVyKHYpe319 KSJ9LAogICAgICAgICB7ZXhwcmVzc2lvbjogImZ1bmN0aW9uIEZvbygpIHt9OyBuZXcgRm9vIn0s Cg==