142706 2015-03-14 21:07:14 -0700 scroll snap points do not properly account for zoomed pages 2015-03-15 12:14:07 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=142705 InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham cmarcelo commit-queue jamesr luiz thorton tonikitoo webkit-bug-importer oldest_to_newest 1077202 0 bfulgham 2015-03-14 21:07:14 -0700 Zooming a page with scroll snap points causes the snap point logic to do the wrong thing. We should be properly dealing with zoomed state when searching for the nearest snap point, and when animating to the target location. 1077205 1 webkit-bug-importer 2015-03-14 21:09:41 -0700 <rdar://problem/20165771> 1077224 2 bfulgham 2015-03-14 22:58:27 -0700 When computing snap point targets, we need to account for the current page zoom. This is currently ignored. 1077225 3 248673 bfulgham 2015-03-14 23:01:21 -0700 Created attachment 248673 Patch 1077248 4 bfulgham 2015-03-15 12:14:07 -0700 Committed r181510: <http://trac.webkit.org/changeset/181510> 248673 2015-03-14 23:01:21 -0700 2015-03-15 12:06:15 -0700 Patch bug-142706-20150314230053.patch text/plain 4372 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTUwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE1LTAzLTE0ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIHNjcm9sbCBzbmFwIHBvaW50 cyBkbyBub3QgcHJvcGVybHkgYWNjb3VudCBmb3Igem9vbWVkIHBhZ2VzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI3MDYKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzIwMTY1NzcxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdoZW4gYSBXZWJWaWV3IGlzIHpvb21lZCAoc3VjaCB0aGF0IGl0IGhhcyBh IG5vbi11bml0eSBwYWdlU2NhbGVGYWN0b3IpLCB3ZSBuZWVkIHRvIGFjY291bnQgZm9yIHRoaXMK KyAgICAgICAgc2NhbGluZyB2YWx1ZSB3aGVuIHNlbGVjdGluZyBvdXIgY29ycmVjdCBzY3JvbGwg c25hcCBwb2ludCB0YXJnZXQsIGFzIHdlbGwgYXMgd2hlbiBzcGVjaWZ5aW5nIHRoZQorICAgICAg ICBwaXhlbCBsb2NhdGlvbiBmb3Igb3VyIGFuaW1hdGlvbiB0byB0YXJnZXQuCisKKyAgICAgICAg KiBwYWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xsaW5nVHJlZUZyYW1lU2Nyb2xsaW5nTm9kZU1hYy5o OgorICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdUcmVlRnJhbWVTY3JvbGxp bmdOb2RlTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nVHJlZUZyYW1lU2Nyb2xs aW5nTm9kZU1hYzo6cGFnZVNjYWxlRmFjdG9yKTogQWRkZWQgbmV3IGRlbGVnYXRlIG1ldGhvZC4K KyAgICAgICAgKiBwbGF0Zm9ybS9jb2NvYS9TY3JvbGxDb250cm9sbGVyLmg6CisgICAgICAgIChX ZWJDb3JlOjpTY3JvbGxDb250cm9sbGVyQ2xpZW50OjpwYWdlU2NhbGVGYWN0b3IpOiBBZGRlZCBu ZXcgZGVmYXVsdCBkZWxlZ2F0ZS4KKyAgICAgICAgKiBwbGF0Zm9ybS9jb2NvYS9TY3JvbGxDb250 cm9sbGVyLm1tOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsQ29udHJvbGxlcjo6YmVnaW5TY3Jv bGxTbmFwQW5pbWF0aW9uKTogQ2FsY3VsYXRlIHRoZSBjb3JyZWN0IHNjcm9sbCB0YXJnZXQKKyAg ICAgICAgYmFzZWQgb24gdGhlIHBhZ2Ugc2NhbGUgZmFjdG9yLgorCiAyMDE1LTAzLTE0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIENsZWFuIHVwIHVz ZSBvZiBmbGFncyBpbiBsb2NhbFRvQ29udGFpbmVyLXR5cGUgZnVuY3Rpb25zCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xsaW5nVHJlZUZyYW1lU2Nyb2xsaW5n Tm9kZU1hYy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21h Yy9TY3JvbGxpbmdUcmVlRnJhbWVTY3JvbGxpbmdOb2RlTWFjLmgJKHJldmlzaW9uIDE4MTUwMikK KysrIFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdUcmVlRnJhbWVT Y3JvbGxpbmdOb2RlTWFjLmgJKHdvcmtpbmcgY29weSkKQEAgLTgyLDYgKzgyLDcgQEAgcHJpdmF0 ZToKICNpZiBFTkFCTEUoQ1NTX1NDUk9MTF9TTkFQKSAmJiBQTEFURk9STShNQUMpCiAgICAgTGF5 b3V0VW5pdCBzY3JvbGxPZmZzZXRPbkF4aXMoU2Nyb2xsRXZlbnRBeGlzKSBjb25zdCBvdmVycmlk ZTsKICAgICB2b2lkIGltbWVkaWF0ZVNjcm9sbE9uQXhpcyhTY3JvbGxFdmVudEF4aXMsIGZsb2F0 IGRlbHRhKSBvdmVycmlkZTsKKyAgICBmbG9hdCBwYWdlU2NhbGVGYWN0b3IoKSBjb25zdCBvdmVy cmlkZTsKICNlbmRpZgogCiAgICAgdm9pZCBsb2dFeHBvc2VkVW5maWxsZWRBcmVhKCk7CkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xsaW5nVHJlZUZyYW1lU2Ny b2xsaW5nTm9kZU1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9s bGluZy9tYWMvU2Nyb2xsaW5nVHJlZUZyYW1lU2Nyb2xsaW5nTm9kZU1hYy5tbQkocmV2aXNpb24g MTgxNTAyKQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbWFjL1Njcm9sbGluZ1Ry ZWVGcmFtZVNjcm9sbGluZ05vZGVNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTU1OCw2ICs1NTgs MTEgQEAgdm9pZCBTY3JvbGxpbmdUcmVlRnJhbWVTY3JvbGxpbmdOb2RlTWFjOgogCiAgICAgaW1t ZWRpYXRlU2Nyb2xsQnkoY2hhbmdlIC0gY3VycmVudFBvc2l0aW9uKTsKIH0KKworZmxvYXQgU2Ny b2xsaW5nVHJlZUZyYW1lU2Nyb2xsaW5nTm9kZU1hYzo6cGFnZVNjYWxlRmFjdG9yKCkgY29uc3QK K3sKKyAgICByZXR1cm4gZnJhbWVTY2FsZUZhY3RvcigpOworfQogI2VuZGlmCiAKIH0gLy8gbmFt ZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1Njcm9s bENvbnRyb2xsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2Nv YS9TY3JvbGxDb250cm9sbGVyLmgJKHJldmlzaW9uIDE4MTUwMikKKysrIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2NvY29hL1Njcm9sbENvbnRyb2xsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtODYs NyArODYsMTEgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzdG9wU2Nyb2xsU25hcFRpbWVy KFNjcm9sbEV2ZW50QXhpcykKICAgICB7CiAgICAgICAgIC8vIE92ZXJyaWRlIHRvIHBlcmZvcm0g Y2xpZW50LXNwZWNpZmljIHNjcm9sbCBzbmFwIHBvaW50IGVuZCBsb2dpYwotICAgICAgICAKKyAg ICB9CisKKyAgICB2aXJ0dWFsIGZsb2F0IHBhZ2VTY2FsZUZhY3RvcigpIGNvbnN0CisgICAgewor ICAgICAgICByZXR1cm4gMS4wZjsKICAgICB9CiAjZW5kaWYKIH07CkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9jb2NvYS9TY3JvbGxDb250cm9sbGVyLm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1Njcm9sbENvbnRyb2xsZXIubW0JKHJldmlzaW9u IDE4MTUwMikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1Njcm9sbENvbnRyb2xs ZXIubW0JKHdvcmtpbmcgY29weSkKQEAgLTY4NCw5ICs2ODQsMTEgQEAgdm9pZCBTY3JvbGxDb250 cm9sbGVyOjpiZWdpblNjcm9sbFNuYXBBbgogICAgIGlmIChzbmFwU3RhdGUubV9zbmFwT2Zmc2V0 cy5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIHByb2plY3RlZFNjcm9sbERlc3Rp bmF0aW9uID0gc3RkOjptaW4oc3RkOjptYXgocHJvamVjdGVkU2Nyb2xsRGVzdGluYXRpb24sIHNu YXBTdGF0ZS5tX3NuYXBPZmZzZXRzLmZpcnN0KCkpLCBzbmFwU3RhdGUubV9zbmFwT2Zmc2V0cy5s YXN0KCkpOworICAgIGZsb2F0IHNjYWxlRmFjdG9yID0gbV9jbGllbnQtPnBhZ2VTY2FsZUZhY3Rv cigpOworICAgIAorICAgIHByb2plY3RlZFNjcm9sbERlc3RpbmF0aW9uID0gc3RkOjptaW4oc3Rk OjptYXgoTGF5b3V0VW5pdChwcm9qZWN0ZWRTY3JvbGxEZXN0aW5hdGlvbiAvIHNjYWxlRmFjdG9y KSwgc25hcFN0YXRlLm1fc25hcE9mZnNldHMuZmlyc3QoKSksIHNuYXBTdGF0ZS5tX3NuYXBPZmZz ZXRzLmxhc3QoKSk7CiAgICAgc25hcFN0YXRlLm1faW5pdGlhbE9mZnNldCA9IG9mZnNldDsKLSAg ICBzbmFwU3RhdGUubV90YXJnZXRPZmZzZXQgPSBjbG9zZXN0U25hcE9mZnNldDxMYXlvdXRVbml0 LCBmbG9hdD4oc25hcFN0YXRlLm1fc25hcE9mZnNldHMsIHByb2plY3RlZFNjcm9sbERlc3RpbmF0 aW9uLCBpbml0aWFsV2hlZWxEZWx0YSk7CisgICAgc25hcFN0YXRlLm1fdGFyZ2V0T2Zmc2V0ID0g c2NhbGVGYWN0b3IgKiBjbG9zZXN0U25hcE9mZnNldDxMYXlvdXRVbml0LCBmbG9hdD4oc25hcFN0 YXRlLm1fc25hcE9mZnNldHMsIHByb2plY3RlZFNjcm9sbERlc3RpbmF0aW9uLCBpbml0aWFsV2hl ZWxEZWx0YSk7CiAgICAgaWYgKHNuYXBTdGF0ZS5tX2luaXRpYWxPZmZzZXQgPT0gc25hcFN0YXRl Lm1fdGFyZ2V0T2Zmc2V0KQogICAgICAgICByZXR1cm47CiAgICAgCg==