142686 2015-03-13 18:37:42 -0700 Object allocation sinking phase shouldn't re-decorate previously sunken allocations on each fixpoint operation 2015-03-13 19:51:36 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 141174 1 fpizlo fpizlo barraclough benjamin ggaren mark.lam mhahnenb mmirman msaboff nrotem oliver saam sam oldest_to_newest 1077092 0 fpizlo 2015-03-13 18:37:42 -0700 When you run the elidable-new-object-roflcopter test, you'll see that there are many repeated PutStructureHints and PutByOffsetHints. These are because we handle already-sunken allocations from previous fixpoint iterations inside the code for handling those allocations we are sinking on *this* fixpoint iteration. This is a mostly benign bug; its main effect is that if the phase does many fixpoint iterations then you'll get a lot of duplicated code. 1077093 1 248631 fpizlo 2015-03-13 18:39:21 -0700 Created attachment 248631 the patch 1077113 2 fpizlo 2015-03-13 19:51:36 -0700 Landed in http://trac.webkit.org/changeset/181495 248631 2015-03-13 18:39:21 -0700 2015-03-13 18:58:04 -0700 the patch blah.patch text/plain 3265 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgxNDkyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE1LTAzLTEzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg T2JqZWN0IGFsbG9jYXRpb24gc2lua2luZyBwaGFzZSBzaG91bGRuJ3QgcmUtZGVjb3JhdGUgcHJl dmlvdXNseSBzdW5rZW4gYWxsb2NhdGlvbnMgb24gZWFjaCBmaXhwb2ludCBvcGVyYXRpb24KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjY4NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgSnVz dCBiZWNhdXNlIHByb21vdGVIZWFwQWNjZXNzKCkgbm90aWZpZXMgdXMgb2YgYW4gZWZmZWN0IHRv IGEgaGVhcCBsb2NhdGlvbiBpbiBhIG5vZGUgZG9lc24ndAorICAgICAgICBtZWFuIHRoYXQgd2Ug c2hvdWxkIGhhbmRsZSBpdCBhcyBpZiBpdCB3YXMgZm9yIG9uZSBvZiBvdXIgc2lua2luZyBjYW5k aWRhdGVzLiBJbnN0ZWFkIHdlIHNob3VsZAorICAgICAgICBwcnVuZSBiYXNlZCBvbiBtX3NpbmtD YW5kaWRhdGVzLgorICAgICAgICAKKyAgICAgICAgVGhpcyBmaXhlcyBhIGJlbmlnbiBidWcgd2hl cmUgd2Ugd291bGQgZ2VuZXJhdGUgYSBsb3Qgb2YgcmVwZWF0ZWQgSVIgZm9yIHNvbWUgcGF0aG9s b2dpY2FsCisgICAgICAgIHRlc3RzLgorCisgICAgICAgICogZGZnL0RGR09iamVjdEFsbG9jYXRp b25TaW5raW5nUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6Ok9iamVjdEFsbG9jYXRpb25T aW5raW5nUGhhc2U6OnByb21vdGVTdW5rZW5GaWVsZHMpOgorCiAyMDE1LTAzLTEzICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIEVuYWJsZSBX SVJFTEVTU19QTEFZQkFDS19UQVJHRVQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHT2JqZWN0QWxsb2NhdGlvblNpbmtpbmdQaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPYmplY3RBbGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcAko cmV2aXNpb24gMTgxNDg0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPYmplY3RB bGxvY2F0aW9uU2lua2luZ1BoYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTgxLDEwICs1ODEs MTIgQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICBwcm9tb3RlSGVhcEFjY2VzcygKICAgICAg ICAgICAgICAgICAgICAgbm9kZSwKICAgICAgICAgICAgICAgICAgICAgWyZdIChQcm9tb3RlZEhl YXBMb2NhdGlvbiBsb2NhdGlvbiwgRWRnZSkgewotICAgICAgICAgICAgICAgICAgICAgICAgbG9j YXRpb25zLmFkZChsb2NhdGlvbik7CisgICAgICAgICAgICAgICAgICAgICAgICBpZiAobV9zaW5r Q2FuZGlkYXRlcy5jb250YWlucyhsb2NhdGlvbi5iYXNlKCkpKQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGxvY2F0aW9ucy5hZGQobG9jYXRpb24pOwogICAgICAgICAgICAgICAgICAgICB9 LAogICAgICAgICAgICAgICAgICAgICBbJl0gKFByb21vdGVkSGVhcExvY2F0aW9uIGxvY2F0aW9u KSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICBsb2NhdGlvbnMuYWRkKGxvY2F0aW9uKTsKKyAg ICAgICAgICAgICAgICAgICAgICAgIGlmIChtX3NpbmtDYW5kaWRhdGVzLmNvbnRhaW5zKGxvY2F0 aW9uLmJhc2UoKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgbG9jYXRpb25zLmFkZChs b2NhdGlvbik7CiAgICAgICAgICAgICAgICAgICAgIH0pOwogICAgICAgICAgICAgfQogICAgICAg ICB9CkBAIC02MzYsNiArNjM4LDggQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICBwcm9tb3Rl SGVhcEFjY2VzcygKICAgICAgICAgICAgICAgICAgICAgbm9kZSwKICAgICAgICAgICAgICAgICAg ICAgWyZdIChQcm9tb3RlZEhlYXBMb2NhdGlvbiBsb2NhdGlvbiwgRWRnZSB2YWx1ZSkgeworICAg ICAgICAgICAgICAgICAgICAgICAgaWYgKCFtX3NpbmtDYW5kaWRhdGVzLmNvbnRhaW5zKGxvY2F0 aW9uLmJhc2UoKSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAg ICAgICAgICAgICAgICAgICAgU1NBQ2FsY3VsYXRvcjo6VmFyaWFibGUqIHZhcmlhYmxlID0gbV9s b2NhdGlvblRvVmFyaWFibGUuZ2V0KGxvY2F0aW9uKTsKICAgICAgICAgICAgICAgICAgICAgICAg IG1fc3NhQ2FsY3VsYXRvci5uZXdEZWYodmFyaWFibGUsIGJsb2NrLCB2YWx1ZS5ub2RlKCkpOwog ICAgICAgICAgICAgICAgICAgICB9LApAQCAtNjg3LDEwICs2OTEsMTIgQEAgcHJpdmF0ZToKICAg ICAgICAgICAgICAgICBwcm9tb3RlSGVhcEFjY2VzcygKICAgICAgICAgICAgICAgICAgICAgbm9k ZSwKICAgICAgICAgICAgICAgICAgICAgWyZdIChQcm9tb3RlZEhlYXBMb2NhdGlvbiBsb2NhdGlv biwgRWRnZSB2YWx1ZSkgewotICAgICAgICAgICAgICAgICAgICAgICAgbV9sb2NhbE1hcHBpbmcu c2V0KGxvY2F0aW9uLCB2YWx1ZS5ub2RlKCkpOworICAgICAgICAgICAgICAgICAgICAgICAgaWYg KG1fc2lua0NhbmRpZGF0ZXMuY29udGFpbnMobG9jYXRpb24uYmFzZSgpKSkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICBtX2xvY2FsTWFwcGluZy5zZXQobG9jYXRpb24sIHZhbHVlLm5vZGUo KSk7CiAgICAgICAgICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAgICAgICAgIFsmXSAoUHJv bW90ZWRIZWFwTG9jYXRpb24gbG9jYXRpb24pIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIG5v ZGUtPnJlcGxhY2VXaXRoKHJlc29sdmUoYmxvY2ssIGxvY2F0aW9uKSk7CisgICAgICAgICAgICAg ICAgICAgICAgICBpZiAobV9zaW5rQ2FuZGlkYXRlcy5jb250YWlucyhsb2NhdGlvbi5iYXNlKCkp KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5vZGUtPnJlcGxhY2VXaXRoKHJlc29sdmUo YmxvY2ssIGxvY2F0aW9uKSk7CiAgICAgICAgICAgICAgICAgICAgIH0pOwogICAgICAgICAgICAg fQogICAgICAgICAgICAgCg==