142649 2015-03-12 18:02:53 -0700 Change the DFG crashLock to use std::atomic. 2015-03-12 20:02:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam benjamin commit-queue fpizlo ggaren mhahnenb mmirman msaboff oldest_to_newest 1076810 0 mark.lam 2015-03-12 18:02:53 -0700 Let's use C++11. 1076813 1 248560 mark.lam 2015-03-12 18:15:47 -0700 Created attachment 248560 the patch. 1076825 2 248560 fpizlo 2015-03-12 19:14:16 -0700 Comment on attachment 248560 the patch. This is broken - the compare_and_exchange will set expected to 1 if it fails. 1076826 3 248560 fpizlo 2015-03-12 19:19:04 -0700 Comment on attachment 248560 the patch. Never mind, I misread the code. I really don't like the API that has expected be a reference. This is just massively broken for most of our uses of CAS (and indeed for most sensible uses of CAS in general...). Can we have a wrapper for std::atomic that has a more sensible API, where expected is not a reference? 1076831 4 248560 commit-queue 2015-03-12 20:02:48 -0700 Comment on attachment 248560 the patch. Clearing flags on attachment: 248560 Committed r181469: <http://trac.webkit.org/changeset/181469> 1076832 5 commit-queue 2015-03-12 20:02:54 -0700 All reviewed patches have been landed. Closing bug. 248560 2015-03-12 18:15:47 -0700 2015-03-12 20:02:48 -0700 the patch. bug-142649.patch text/plain 1445 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgxNDY1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE1LTAzLTEyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD aGFuZ2UgdGhlIERGRyBjcmFzaExvY2sgdG8gdXNlIHN0ZDo6YXRvbWljLgorICAgICAgICA8aHR0 cHM6Ly93ZWJraXQub3JnL2IvMTQyNjQ5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZGZnL0RGR0NvbW1vbi5jcHA6CisgICAgICAgIChKU0M6OkRG Rzo6c3RhcnRDcmFzaGluZyk6CisgICAgICAgIChKU0M6OkRGRzo6aXNDcmFzaGluZyk6CisKIDIw MTUtMDMtMTIgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAg ICAgSW50ZWdyYXRlIE1hcERhdGEgaW50byBKU01hcCBhbmQgSlNTZXQKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHQ29tbW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0NvbW1vbi5jcHAJKHJldmlzaW9uIDE4MTQ1OCkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ29tbW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQs MjEgKzM0LDIwIEBACiAKIG5hbWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgREZHIHsKIAotc3RhdGlj IHVuc2lnbmVkIGNyYXNoTG9jazsKK3N0YXRpYyBzdGQ6OmF0b21pYzx1bnNpZ25lZD4gY3Jhc2hM b2NrOwogCiB2b2lkIHN0YXJ0Q3Jhc2hpbmcoKQogewotI2lmIEVOQUJMRShDT01QQVJFX0FORF9T V0FQKQotICAgIHdoaWxlICghV1RGOjp3ZWFrQ29tcGFyZUFuZFN3YXAoJmNyYXNoTG9jaywgMCwg MSkpCisgICAgdW5zaWduZWQgZXhwZWN0ZWQgPSAwOworICAgIHdoaWxlICghY3Jhc2hMb2NrLmNv bXBhcmVfZXhjaGFuZ2Vfd2VhayhleHBlY3RlZCwgMSwgc3RkOjptZW1vcnlfb3JkZXJfYWNxdWly ZSkpIHsKICAgICAgICAgc3RkOjp0aGlzX3RocmVhZDo6eWllbGQoKTsKLSNlbHNlCi0gICAgY3Jh c2hMb2NrID0gMTsKLSNlbmRpZgorICAgICAgICBleHBlY3RlZCA9IDA7CisgICAgfQogfQogCiBi b29sIGlzQ3Jhc2hpbmcoKQogewotICAgIHJldHVybiAhIWNyYXNoTG9jazsKKyAgICByZXR1cm4g ISFjcmFzaExvY2subG9hZChzdGQ6Om1lbW9yeV9vcmRlcl9hY3F1aXJlKTsKIH0KIAogfSB9IC8v IG5hbWVzcGFjZSBKU0M6OkRGRwo=