142645 2015-03-12 15:19:57 -0700 Disable Yarr JIT for ARMv7k 2015-03-19 14:15:04 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 msaboff msaboff benjamin cmarcelo commit-queue oldest_to_newest 1076766 0 msaboff 2015-03-12 15:19:57 -0700 The Yarr JIT should be disabled for ARMv7k just like the JavaScript JITs. 1076783 1 248553 msaboff 2015-03-12 16:33:59 -0700 Created attachment 248553 Patch 1076804 2 248553 commit-queue 2015-03-12 17:41:17 -0700 Comment on attachment 248553 Patch Clearing flags on attachment: 248553 Committed r181462: <http://trac.webkit.org/changeset/181462> 1076805 3 commit-queue 2015-03-12 17:41:21 -0700 All reviewed patches have been landed. Closing bug. 1076828 4 248553 ggaren 2015-03-12 19:35:20 -0700 Comment on attachment 248553 Patch We believe that ARMv7k is not significantly different from ARMv7. What difference accounts for the YARR JIT being broken? 1076829 5 248553 ggaren 2015-03-12 19:37:23 -0700 Comment on attachment 248553 Patch Or, if the goal is just to match the ENABLE_JIT flag, I'd suggest doing that explicitly: #if !defined(ENABLE_YARR_JIT) && ENABLE(JIT) #define ENABLE_YARR_JIT 1 #endif 1077151 6 msaboff 2015-03-14 08:44:03 -0700 (In reply to comment #5) > Comment on attachment 248553 [details] > Patch > > Or, if the goal is just to match the ENABLE_JIT flag, I'd suggest doing that > explicitly: > > #if !defined(ENABLE_YARR_JIT) && ENABLE(JIT) > #define ENABLE_YARR_JIT 1 > #endif I'll make this change. 1078628 7 msaboff 2015-03-19 14:15:04 -0700 Update committed r181501: <http://trac.webkit.org/changeset/181501> 248553 2015-03-12 16:33:59 -0700 2015-03-12 17:41:17 -0700 Patch 142645.patch text/plain 1586 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxODE0NTYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAzLTEyICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIERpc2FibGUgWWFyciBKSVQgZm9yIEFSTXY3awor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyNjQ1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSB0aGUg c2V0dGluZyBvZiBFTkFCTEVfWUFSUl9KSVQgbWF0Y2ggRU5BQkxFX0pJVCBmb3IgQVJNdjdrLgor CisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTUtMDMtMTIgIENzYWJhIE9zenRyb2dv bsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBbQVJNXVtMaW51eF0gR0Mgc29tZXRp bWVzIHN0dWNrIGluIGFuIGluZmluaXRlIGxvb3AgaWYgcGFyYWxsZWwgR0MgaXMgZW5hYmxlZApJ bmRleDogU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RG L3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiAxODE0MTEpCisrKyBTb3VyY2UvV1RGL3d0Zi9QbGF0 Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC02NTYsMTMgKzY1NiwxOCBAQAogI2VuZGlmCiAjZW5k aWYgLyogIWRlZmluZWQoV1RGX1VTRV9KU1ZBTFVFNjQpICYmICFkZWZpbmVkKFdURl9VU0VfSlNW QUxVRTMyXzY0KSAqLwogCi0vKiBUaGUgSklUIGlzIGVuYWJsZWQgYnkgZGVmYXVsdCBvbiBhbGwg eDg2LCB4ODYtNjQsIEFSTSAmIE1JUFMgcGxhdGZvcm1zIGV4Y2VwdCBBUk12N2sgYW5kIFdpbmRv d3MuICovCisvKiBUaGUgSklUIGlzIGVuYWJsZWQgYnkgZGVmYXVsdCBvbiBhbGwgeDg2LCB4ODYt NjQsIEFSTSAmIE1JUFMgcGxhdGZvcm1zIGV4Y2VwdCBBUk12N2suICovCiAjaWYgIWRlZmluZWQo RU5BQkxFX0pJVCkgXAogICAgICYmIChDUFUoWDg2KSB8fCBDUFUoWDg2XzY0KSB8fCBDUFUoQVJN KSB8fCBDUFUoQVJNNjQpIHx8IENQVShNSVBTKSkgXAogICAgICYmICFDUFUoQVBQTEVfQVJNVjdL KQogI2RlZmluZSBFTkFCTEVfSklUIDEKICNlbmRpZgogCisvKiBEaXNhYmxlIHRoZSBZQVJSIEpJ VCBmb3IgQVJNdjdrICovCisjaWYgIWRlZmluZWQoRU5BQkxFX1lBUlJfSklUKSAmJiBDUFUoQVBQ TEVfQVJNVjdLKQorI2RlZmluZSBFTkFCTEVfWUFSUl9KSVQgMAorI2VuZGlmCisKIC8qIERvIHdl IGhhdmUgTExWTT8gKi8KICNpZiAhZGVmaW5lZChIQVZFX0xMVk0pICYmIE9TKERBUldJTikgJiYg IVBMQVRGT1JNKEVGTCkgJiYgIVBMQVRGT1JNKEdUSykgJiYgRU5BQkxFKEZUTF9KSVQpICYmIChD UFUoWDg2XzY0KSB8fCBDUFUoQVJNNjQpKQogI2RlZmluZSBIQVZFX0xMVk0gMQo=