142640 2015-03-12 13:43:56 -0700 Use std::atomic for CodeBlock::m_visitAggregateHasBeenCalled 2015-03-12 15:15:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam benjamin commit-queue fpizlo ggaren mhahnenb mmirman msaboff oldest_to_newest 1076736 0 mark.lam 2015-03-12 13:43:56 -0700 We used to spin our own compare and swap on a uint8_t. Now that we can use C++11, let's use std::atomic. 1076752 1 248543 mark.lam 2015-03-12 14:03:45 -0700 Created attachment 248543 the patch. 1076757 2 248543 mhahnenb 2015-03-12 14:23:00 -0700 Comment on attachment 248543 the patch. Seems reasonable to me. 1076764 3 248543 commit-queue 2015-03-12 15:15:03 -0700 Comment on attachment 248543 the patch. Clearing flags on attachment: 248543 Committed r181456: <http://trac.webkit.org/changeset/181456> 1076765 4 commit-queue 2015-03-12 15:15:07 -0700 All reviewed patches have been landed. Closing bug. 248543 2015-03-12 14:03:45 -0700 2015-03-12 15:15:03 -0700 the patch. bug-142640.patch text/plain 5276 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgxNDUzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBA CisyMDE1LTAzLTEyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBV c2Ugc3RkOjphdG9taWMgZm9yIENvZGVCbG9jazo6bV92aXNpdEFnZ3JlZ2F0ZUhhc0JlZW5DYWxs ZWQuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNDI2NDA+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgdXNlZCB0byBzcGluIG91ciBv d24gY29tcGFyZSBhbmQgc3dhcCBvbiBhIHVpbnQ4X3QuICBOb3cgdGhhdCB3ZSBjYW4KKyAgICAg ICAgdXNlIEMrKzExLCBsZXQncyB1c2Ugc3RkOjphdG9taWMgaW5zdGVhZC4KKworICAgICAgICAq IGJ5dGVjb2RlL0NvZGVCbG9jay5jcHA6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6dmlzaXRB Z2dyZWdhdGUpOgorICAgICAgICAtIFRoZSBDQVMgaGVyZSBuZWVkcyBzdGQ6Om1lbW9yeV9vcmRl cl9hY3F1aXJlIG9yZGVyaW5nIGJlY2F1c2UgaXQKKyAgICAgICAgICByZXF1aXJlcyBsb2NrIGFj cXVpc2l0aW9uIHNlbWFudGljcyB0byB2aXNpdCB0aGUgQ29kZUJsb2NrLgorCisgICAgICAgICog Ynl0ZWNvZGUvQ29kZUJsb2NrLmg6CisgICAgICAgIChKU0M6OkNvZGVCbG9ja1NldDo6bWFyayk6 CisgICAgICAgICogaGVhcC9Db2RlQmxvY2tTZXQuY3BwOgorICAgICAgICAoSlNDOjpDb2RlQmxv Y2tTZXQ6OmNsZWFyTWFya3NGb3JGdWxsQ29sbGVjdGlvbik6CisgICAgICAgIChKU0M6OkNvZGVC bG9ja1NldDo6Y2xlYXJNYXJrc0ZvckVkZW5Db2xsZWN0aW9uKToKKyAgICAgICAgLSBUaGVzZSBj YW4gZ28gd2l0aCByZWxheGVkIG9yZGVyaW5nIGJlY2F1c2UgdGhleSBhcmUgYWxsIGRvbmUgYmVm b3JlCisgICAgICAgICAgdGhlIEdDIHN0YXJ0cyBwYXJhbGxlbCBtYXJraW5nLgorCiAyMDE1LTAz LTEyICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW2Nt YWtlXSBGaXggdGhlIGluY3JlbWVudGFsIGJ1aWxkIGlzc3VlIHJldmVhbGVkIGJ5IHIxODE0MTkK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCShy ZXZpc2lvbiAxODE0NDYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJs b2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjE5NSwyNiArMjE5NSwxMiBAQCB2b2lkIENvZGVC bG9jazo6dmlzaXRBZ2dyZWdhdGUoU2xvdFZpc2l0CiB7CiAjaWYgRU5BQkxFKFBBUkFMTEVMX0dD KQogICAgIC8vIEkgbWF5IGJlIGFza2VkIHRvIHNjYW4gbXlzZWxmIG1vcmUgdGhhbiBvbmNlLCBh bmQgaXQgbWF5IGV2ZW4gaGFwcGVuIGNvbmN1cnJlbnRseS4KLSAgICAvLyBUbyB0aGlzIGVuZCwg dXNlIGEgQ0FTIGxvb3AgdG8gY2hlY2sgaWYgSSd2ZSBiZWVuIGNhbGxlZCBhbHJlYWR5LiBPbmx5 IG9uZSB0aHJlYWQKLSAgICAvLyBtYXkgcHJvY2VlZCBwYXN0IHRoaXMgcG9pbnQgLSB3aGljaGV2 ZXIgb25lIHdpbnMgdGhlIENBUyByYWNlLgotICAgIHVuc2lnbmVkIG9sZFZhbHVlOwotICAgIGRv IHsKLSAgICAgICAgb2xkVmFsdWUgPSBtX3Zpc2l0QWdncmVnYXRlSGFzQmVlbkNhbGxlZDsKLSAg ICAgICAgaWYgKG9sZFZhbHVlKSB7Ci0gICAgICAgICAgICAvLyBMb29rcyBsaWtlIHNvbWVvbmUg ZWxzZSB3b24hIFJldHVybiBpbW1lZGlhdGVseSB0byBlbnN1cmUgdGhhdCB3ZSBkb24ndAotICAg ICAgICAgICAgLy8gdHJhY2UgdGhlIHNhbWUgQ29kZUJsb2NrIGNvbmN1cnJlbnRseS4gRG9pbmcg c28gaXMgaGF6YXJkb3VzIHNpbmNlIHdlIHdpbGwKLSAgICAgICAgICAgIC8vIGJlIG11dGF0aW5n IHRoZSBzdGF0ZSBvZiBWYWx1ZVByb2ZpbGVzLCB3aGljaCBjb250YWluIEpTVmFsdWVzLCB3aGlj aCBjYW4KLSAgICAgICAgICAgIC8vIGhhdmUgd29yZC10ZWFyaW5nIG9uIDMyLWJpdCwgbGVhZGlu ZyB0byBhd2Vzb21lIHRpbWluZy1kZXBlbmRlbnQgY3Jhc2hlcwotICAgICAgICAgICAgLy8gdGhh dCBhcmUgbmVhcmx5IGltcG9zc2libGUgdG8gdHJhY2sgZG93bi4KLSAgICAgICAgICAgIAotICAg ICAgICAgICAgLy8gQWxzbyBub3RlIHRoYXQgaXQgbXVzdCBiZSBzYWZlIHRvIHJldHVybiBlYXJs eSBhcyBzb29uIGFzIHdlIHNlZSB0aGUKLSAgICAgICAgICAgIC8vIHZhbHVlIHRydWUgKHdlbGws ICh1bnNpZ25lZCkxKSwgc2luY2Ugb25jZSBhIEdDIHRocmVhZCBpcyBpbiB0aGlzIG1ldGhvZAot ICAgICAgICAgICAgLy8gYW5kIGhhcyB3b24gdGhlIENBUyByYWNlIChpLmUuIHdhcyByZXNwb25z aWJsZSBmb3Igc2V0dGluZyB0aGUgdmFsdWUgdHJ1ZSkKLSAgICAgICAgICAgIC8vIGl0IHdpbGwg ZGVmaW5pdGVseSBjb21wbGV0ZSB0aGUgcmVzdCBvZiB0aGlzIG1ldGhvZCBiZWZvcmUgZGVjbGFy aW5nCi0gICAgICAgICAgICAvLyB0ZXJtaW5hdGlvbi4KLSAgICAgICAgICAgIHJldHVybjsKLSAg ICAgICAgfQotICAgIH0gd2hpbGUgKCFXVEY6OndlYWtDb21wYXJlQW5kU3dhcCgmbV92aXNpdEFn Z3JlZ2F0ZUhhc0JlZW5DYWxsZWQsIDAsIDEpKTsKKyAgICAvLyBUbyB0aGlzIGVuZCwgdXNlIGFu IGF0b21pYyBvcGVyYXRpb24gdG8gY2hlY2sgKGFuZCBzZXQpIGlmIEkndmUgYmVlbiBjYWxsZWQg YWxyZWFkeS4KKyAgICAvLyBPbmx5IG9uZSB0aHJlYWQgbWF5IHByb2NlZWQgcGFzdCB0aGlzIHBv aW50IC0gd2hpY2hldmVyIG9uZSB3aW5zIHRoZSBhdG9taWMgc2V0IHJhY2UuCisgICAgYm9vbCBl eHBlY3RlZCA9IGZhbHNlOworICAgIGJvb2wgc2V0QnlNZSA9IG1fdmlzaXRBZ2dyZWdhdGVIYXNC ZWVuQ2FsbGVkLmNvbXBhcmVfZXhjaGFuZ2Vfc3Ryb25nKGV4cGVjdGVkLCB0cnVlLCBzdGQ6Om1l bW9yeV9vcmRlcl9hY3F1aXJlKTsKKyAgICBpZiAoIXNldEJ5TWUpCisgICAgICAgIHJldHVybjsK ICNlbmRpZiAvLyBFTkFCTEUoUEFSQUxMRUxfR0MpCiAgICAgCiAgICAgaWYgKCEhbV9hbHRlcm5h dGl2ZSkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgJ KHJldmlzaW9uIDE4MTQ0NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2Rl QmxvY2suaAkod29ya2luZyBjb3B5KQpAQCAtMTA2NSw3ICsxMDY1LDcgQEAgcHJpdmF0ZToKICAg ICBib29sIG1faXNTdHJpY3RNb2RlOwogICAgIGJvb2wgbV9uZWVkc0FjdGl2YXRpb247CiAgICAg Ym9vbCBtX21heUJlRXhlY3V0aW5nOwotICAgIHVpbnQ4X3QgbV92aXNpdEFnZ3JlZ2F0ZUhhc0Jl ZW5DYWxsZWQ7CisgICAgc3RkOjphdG9taWM8Ym9vbD4gbV92aXNpdEFnZ3JlZ2F0ZUhhc0JlZW5D YWxsZWQ7CiAKICAgICBSZWZQdHI8U291cmNlUHJvdmlkZXI+IG1fc291cmNlOwogICAgIHVuc2ln bmVkIG1fc291cmNlT2Zmc2V0OwpAQCAtMTMwMSw3ICsxMzAxLDcgQEAgaW5saW5lIHZvaWQgQ29k ZUJsb2NrU2V0OjptYXJrKENvZGVCbG9jawogICAgIAogICAgIGNvZGVCbG9jay0+bV9tYXlCZUV4 ZWN1dGluZyA9IHRydWU7CiAgICAgLy8gV2UgbWlnaHQgbm90IGhhdmUgY2xlYXJlZCB0aGUgbWFy a3MgZm9yIHRoaXMgQ29kZUJsb2NrLCBidXQgd2UgbmVlZCB0byB2aXNpdCBpdC4KLSAgICBjb2Rl QmxvY2stPm1fdmlzaXRBZ2dyZWdhdGVIYXNCZWVuQ2FsbGVkID0gZmFsc2U7CisgICAgY29kZUJs b2NrLT5tX3Zpc2l0QWdncmVnYXRlSGFzQmVlbkNhbGxlZC5zdG9yZShmYWxzZSwgc3RkOjptZW1v cnlfb3JkZXJfcmVsYXhlZCk7CiAjaWYgRU5BQkxFKEdHQykKICAgICBtX2N1cnJlbnRseUV4ZWN1 dGluZy5hcHBlbmQoY29kZUJsb2NrKTsKICNlbmRpZgpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2hlYXAvQ29kZUJsb2NrU2V0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaGVhcC9Db2RlQmxvY2tTZXQuY3BwCShyZXZpc2lvbiAxODE0NDYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaGVhcC9Db2RlQmxvY2tTZXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02 NSw3ICs2NSw3IEBAIHZvaWQgQ29kZUJsb2NrU2V0OjpjbGVhck1hcmtzRm9yRnVsbENvbGwKIHsK ICAgICBmb3IgKENvZGVCbG9jayogY29kZUJsb2NrIDogbV9vbGRDb2RlQmxvY2tzKSB7CiAgICAg ICAgIGNvZGVCbG9jay0+bV9tYXlCZUV4ZWN1dGluZyA9IGZhbHNlOwotICAgICAgICBjb2RlQmxv Y2stPm1fdmlzaXRBZ2dyZWdhdGVIYXNCZWVuQ2FsbGVkID0gZmFsc2U7CisgICAgICAgIGNvZGVC bG9jay0+bV92aXNpdEFnZ3JlZ2F0ZUhhc0JlZW5DYWxsZWQuc3RvcmUoZmFsc2UsIHN0ZDo6bWVt b3J5X29yZGVyX3JlbGF4ZWQpOwogICAgIH0KIAogICAgIC8vIFdlIHByb21vdGUgYWZ0ZXIgd2Ug Y2xlYXIgbWFya3Mgb24gdGhlIG9sZCBnZW5lcmF0aW9uIENvZGVCbG9ja3MgYmVjYXVzZQpAQCAt ODIsNyArODIsNyBAQCB2b2lkIENvZGVCbG9ja1NldDo6Y2xlYXJNYXJrc0ZvckVkZW5Db2xsCiAg ICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgZXhlY3V0YWJsZS0+Zm9yRWFjaENvZGVCbG9j ayhbXShDb2RlQmxvY2sqIGNvZGVCbG9jaykgewogICAgICAgICAgICAgY29kZUJsb2NrLT5tX21h eUJlRXhlY3V0aW5nID0gZmFsc2U7Ci0gICAgICAgICAgICBjb2RlQmxvY2stPm1fdmlzaXRBZ2dy ZWdhdGVIYXNCZWVuQ2FsbGVkID0gZmFsc2U7CisgICAgICAgICAgICBjb2RlQmxvY2stPm1fdmlz aXRBZ2dyZWdhdGVIYXNCZWVuQ2FsbGVkLnN0b3JlKGZhbHNlLCBzdGQ6Om1lbW9yeV9vcmRlcl9y ZWxheGVkKTsKICAgICAgICAgfSk7CiAgICAgfQogfQo=