142638 2015-03-12 13:26:55 -0700 Prohibit GC while sweeping 2015-03-13 13:15:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren fpizlo kling mhahnenb oldest_to_newest 1076725 0 ggaren 2015-03-12 13:26:55 -0700 Prohibit GC while sweeping 1076732 1 248538 ggaren 2015-03-12 13:36:39 -0700 Created attachment 248538 Patch 1076741 2 248540 ggaren 2015-03-12 13:50:53 -0700 Created attachment 248540 Patch 1076774 3 248540 kling 2015-03-12 15:59:35 -0700 Comment on attachment 248540 Patch This seems entirely reasonable. r=me 1076775 4 248540 fpizlo 2015-03-12 16:02:51 -0700 Comment on attachment 248540 Patch I recommend DeferGCForAWhile, so that if the sweep reports extra cost, then we won't GC as we're popping the DeferGC scope. I believe in such cases it's always preferable to wait until the allocation itself realizes that it should GC. 1076830 5 ggaren 2015-03-12 19:39:51 -0700 (In reply to comment #4) > Comment on attachment 248540 [details] > Patch > > I recommend DeferGCForAWhile, so that if the sweep reports extra cost, then > we won't GC as we're popping the DeferGC scope. I believe in such cases > it's always preferable to wait until the allocation itself realizes that it > should GC. OK. Will do. 1077004 6 ggaren 2015-03-13 13:15:08 -0700 Committed r181486: <http://trac.webkit.org/changeset/181486> 248538 2015-03-12 13:36:39 -0700 2015-03-12 13:50:50 -0700 Patch bug-142638-20150312133613.patch text/plain 3492 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgxNDUxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM3IEBA CisyMDE1LTAzLTEyICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgUHJvaGliaXQgR0Mgd2hpbGUgc3dlZXBpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjYzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEkgbm90aWNlZCBpbiBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQyNjM2IHRoYXQgYSBHQworICAgICAgICBjb3VsZCB0cmlnZ2Vy IGEgc3dlZXAgd2hpY2ggY291bGQgdHJpZ2dlciBhbm90aGVyIEdDLiBZbyBEYXdnLgorCisgICAg ICAgIEkgdHJpZWQgdG8gZmlndXJlIG91dCB3aGV0aGVyIHRoaXMgY291bGQgY2F1c2UgcHJvYmxl bXMgb3Igbm90IGFuZCBpdAorICAgICAgICBtYWRlIG1lIGNyb3NzLWV5ZWQuCisKKyAgICAgICAg KFNvbWUgY2xpZW50cyBsaWtlIHRvIHJlcG9ydCBleHRyYSBtZW1vcnkgY29zdCBkdXJpbmcgZGVh bGxvY2F0aW9uIGFzIGEKKyAgICAgICAgd2F5IHRvIGluZGljYXRlIHRoYXQgdGhlIEdDIG5vdyBv d25zIHNvbWV0aGluZyBleGNsdXNpdmVseS4gSXQncworICAgICAgICBhcmd1YWJseSBhIGJ1ZyB0 byBjb21tdW5pY2F0ZSB3aXRoIHRoZSBHQyBpbiB0aGlzIHdheSwgYnV0IHdlIHNob3VsZG4ndAor ICAgICAgICBkbyBjcmF6eSB3aGVuIHRoaXMgaGFwcGVucy4pCisKKyAgICAgICAgVGhpcyBwYXRj aCBtYWtlcyBleHBsaWNpdCB0aGUgZmFjdCB0aGF0IHdlIGRvbid0IGFsbG93IEdDIHdoaWxlIHN3 ZWVwaW5nLgorCisgICAgICAgIFVzdWFsbHksIHN3ZWVwaW5nIGltcGxpY2l0bHkgZGVmZXJzIEdD IGJ5IHZpcnR1ZSBvZiBoYXBwZW5pbmcgZHVyaW5nCisgICAgICAgIGFsbG9jYXRpb24uIEJ1dCBu b3QgYWx3YXlzLgorCisgICAgICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGVh cDo6Y29sbGVjdEFsbEdhcmJhZ2UpOiBEZWZlciBHQyB3aGlsZSBzd2VlcGluZyBkdWUgdG8gYW4K KyAgICAgICAgZXhwbGljaXQgR0MgcmVxdWVzdC4KKworICAgICAgICAoSlNDOjpIZWFwOjpkaWRG aW5pc2hDb2xsZWN0aW9uKTogTWFrZSBzdXJlIHRoYXQgem9tYmlmeWluZyBzd2VlcAorICAgICAg ICBkZWZlcnMgR0MgYnkgbm90IHJldHVybmluZyB0byB0aGUgbm9uLUdDIHN0YXRlIHVudGlsIHdl J3JlIGFsbCBkb25lLgorCisgICAgICAgICogaGVhcC9JbmNyZW1lbnRhbFN3ZWVwZXIuY3BwOgor ICAgICAgICAoSlNDOjpJbmNyZW1lbnRhbFN3ZWVwZXI6OnN3ZWVwTmV4dEJsb2NrKTogRGVmZXIg R0Mgd2hpbGUgc3dlZXBpbmcgZHVlCisgICAgICAgIHRvIGEgdGltZXIuCisKIDIwMTUtMDMtMTIg IENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBbY21ha2Vd IEZpeCB0aGUgaW5jcmVtZW50YWwgYnVpbGQgaXNzdWUgcmV2ZWFsZWQgYnkgcjE4MTQxOQpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAJKHJldmlzaW9uIDE4MTQ0NikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05ODgs NiArOTg4LDggQEAgdm9pZCBIZWFwOjpjb2xsZWN0QWxsR2FyYmFnZSgpCiAgICAgY29sbGVjdChG dWxsQ29sbGVjdGlvbik7CiAKICAgICBTYW1wbGluZ1JlZ2lvbiBzYW1wbGluZ1JlZ2lvbigiR2Fy YmFnZSBDb2xsZWN0aW9uOiBTd2VlcGluZyIpOworCisgICAgRGVmZXJHQyBkZWZlckdDKHRoaXMp OwogICAgIG1fb2JqZWN0U3BhY2Uuc3dlZXAoKTsKICAgICBtX29iamVjdFNwYWNlLnNocmluaygp OwogfQpAQCAtMTI5MywxMCArMTI5NSw2IEBAIHZvaWQgSGVhcDo6ZGlkRmluaXNoQ29sbGVjdGlv bihkb3VibGUgZ2MKIAogICAgIGlmIChPcHRpb25zOjpyZWNvcmRHQ1BhdXNlVGltZXMoKSkKICAg ICAgICAgSGVhcFN0YXRpc3RpY3M6OnJlY29yZEdDUGF1c2VUaW1lKGdjU3RhcnRUaW1lLCBnY0Vu ZFRpbWUpOwotICAgIFJFTEVBU0VfQVNTRVJUKG1fb3BlcmF0aW9uSW5Qcm9ncmVzcyA9PSBFZGVu Q29sbGVjdGlvbiB8fCBtX29wZXJhdGlvbkluUHJvZ3Jlc3MgPT0gRnVsbENvbGxlY3Rpb24pOwot Ci0gICAgbV9vcGVyYXRpb25JblByb2dyZXNzID0gTm9PcGVyYXRpb247Ci0gICAgSkFWQVNDUklQ VENPUkVfR0NfRU5EKCk7CiAKICAgICBpZiAoT3B0aW9uczo6dXNlWm9tYmllTW9kZSgpKQogICAg ICAgICB6b21iaWZ5RGVhZE9iamVjdHMoKTsKQEAgLTEzMDksNiArMTMwNywxMCBAQCB2b2lkIEhl YXA6OmRpZEZpbmlzaENvbGxlY3Rpb24oZG91YmxlIGdjCiAKICAgICBpZiAoT3B0aW9uczo6bG9n R0MoKSA9PSBHQ0xvZ2dpbmc6OlZlcmJvc2UpCiAgICAgICAgIEdDTG9nZ2luZzo6ZHVtcE9iamVj dEdyYXBoKHRoaXMpOworCisgICAgUkVMRUFTRV9BU1NFUlQobV9vcGVyYXRpb25JblByb2dyZXNz ID09IEVkZW5Db2xsZWN0aW9uIHx8IG1fb3BlcmF0aW9uSW5Qcm9ncmVzcyA9PSBGdWxsQ29sbGVj dGlvbik7CisgICAgbV9vcGVyYXRpb25JblByb2dyZXNzID0gTm9PcGVyYXRpb247CisgICAgSkFW QVNDUklQVENPUkVfR0NfRU5EKCk7CiB9CiAKIHZvaWQgSGVhcDo6cmVzdW1lQ29tcGlsZXJUaHJl YWRzKCkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0luY3JlbWVudGFsU3dlZXBl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSW5jcmVtZW50 YWxTd2VlcGVyLmNwcAkocmV2aXNpb24gMTgxNDQ2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvSW5jcmVtZW50YWxTd2VlcGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTUsNiArOTUs NyBAQCB2b2lkIEluY3JlbWVudGFsU3dlZXBlcjo6c3dlZXBOZXh0QmxvY2soCiAgICAgICAgIGlm ICghYmxvY2stPm5lZWRzU3dlZXBpbmcoKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwogCisgICAg ICAgIERlZmVyR0MgZGVmZXJHQyh0aGlzKTsKICAgICAgICAgYmxvY2stPnN3ZWVwKCk7CiAgICAg ICAgIG1fdm0tPmhlYXAub2JqZWN0U3BhY2UoKS5mcmVlT3JTaHJpbmtCbG9jayhibG9jayk7CiAg ICAgICAgIHJldHVybjsK 248540 2015-03-12 13:50:53 -0700 2015-03-12 15:59:35 -0700 Patch bug-142638-20150312135027.patch text/plain 3499 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgxNDUxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM3IEBA CisyMDE1LTAzLTEyICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgUHJvaGliaXQgR0Mgd2hpbGUgc3dlZXBpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjYzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEkgbm90aWNlZCBpbiBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQyNjM2IHRoYXQgYSBHQworICAgICAgICBjb3VsZCB0cmlnZ2Vy IGEgc3dlZXAgd2hpY2ggY291bGQgdHJpZ2dlciBhbm90aGVyIEdDLiBZbyBEYXdnLgorCisgICAg ICAgIEkgdHJpZWQgdG8gZmlndXJlIG91dCB3aGV0aGVyIHRoaXMgY291bGQgY2F1c2UgcHJvYmxl bXMgb3Igbm90IGFuZCBpdAorICAgICAgICBtYWRlIG1lIGNyb3NzLWV5ZWQuCisKKyAgICAgICAg KFNvbWUgY2xpZW50cyBsaWtlIHRvIHJlcG9ydCBleHRyYSBtZW1vcnkgY29zdCBkdXJpbmcgZGVh bGxvY2F0aW9uIGFzIGEKKyAgICAgICAgd2F5IHRvIGluZGljYXRlIHRoYXQgdGhlIEdDIG5vdyBv d25zIHNvbWV0aGluZyBleGNsdXNpdmVseS4gSXQncworICAgICAgICBhcmd1YWJseSBhIGJ1ZyB0 byBjb21tdW5pY2F0ZSB3aXRoIHRoZSBHQyBpbiB0aGlzIHdheSwgYnV0IHdlIHNob3VsZG4ndAor ICAgICAgICBkbyBjcmF6eSB3aGVuIHRoaXMgaGFwcGVucy4pCisKKyAgICAgICAgVGhpcyBwYXRj aCBtYWtlcyBleHBsaWNpdCB0aGUgZmFjdCB0aGF0IHdlIGRvbid0IGFsbG93IEdDIHdoaWxlIHN3 ZWVwaW5nLgorCisgICAgICAgIFVzdWFsbHksIHN3ZWVwaW5nIGltcGxpY2l0bHkgZGVmZXJzIEdD IGJ5IHZpcnR1ZSBvZiBoYXBwZW5pbmcgZHVyaW5nCisgICAgICAgIGFsbG9jYXRpb24uIEJ1dCBu b3QgYWx3YXlzLgorCisgICAgICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGVh cDo6Y29sbGVjdEFsbEdhcmJhZ2UpOiBEZWZlciBHQyB3aGlsZSBzd2VlcGluZyBkdWUgdG8gYW4K KyAgICAgICAgZXhwbGljaXQgR0MgcmVxdWVzdC4KKworICAgICAgICAoSlNDOjpIZWFwOjpkaWRG aW5pc2hDb2xsZWN0aW9uKTogTWFrZSBzdXJlIHRoYXQgem9tYmlmeWluZyBzd2VlcAorICAgICAg ICBkZWZlcnMgR0MgYnkgbm90IHJldHVybmluZyB0byB0aGUgbm9uLUdDIHN0YXRlIHVudGlsIHdl J3JlIGFsbCBkb25lLgorCisgICAgICAgICogaGVhcC9JbmNyZW1lbnRhbFN3ZWVwZXIuY3BwOgor ICAgICAgICAoSlNDOjpJbmNyZW1lbnRhbFN3ZWVwZXI6OnN3ZWVwTmV4dEJsb2NrKTogRGVmZXIg R0Mgd2hpbGUgc3dlZXBpbmcgZHVlCisgICAgICAgIHRvIGEgdGltZXIuCisKIDIwMTUtMDMtMTIg IENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBbY21ha2Vd IEZpeCB0aGUgaW5jcmVtZW50YWwgYnVpbGQgaXNzdWUgcmV2ZWFsZWQgYnkgcjE4MTQxOQpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAJKHJldmlzaW9uIDE4MTQ0NikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05ODgs NiArOTg4LDggQEAgdm9pZCBIZWFwOjpjb2xsZWN0QWxsR2FyYmFnZSgpCiAgICAgY29sbGVjdChG dWxsQ29sbGVjdGlvbik7CiAKICAgICBTYW1wbGluZ1JlZ2lvbiBzYW1wbGluZ1JlZ2lvbigiR2Fy YmFnZSBDb2xsZWN0aW9uOiBTd2VlcGluZyIpOworCisgICAgRGVmZXJHQyBkZWZlckdDKCp0aGlz KTsKICAgICBtX29iamVjdFNwYWNlLnN3ZWVwKCk7CiAgICAgbV9vYmplY3RTcGFjZS5zaHJpbmso KTsKIH0KQEAgLTEyOTMsMTAgKzEyOTUsNiBAQCB2b2lkIEhlYXA6OmRpZEZpbmlzaENvbGxlY3Rp b24oZG91YmxlIGdjCiAKICAgICBpZiAoT3B0aW9uczo6cmVjb3JkR0NQYXVzZVRpbWVzKCkpCiAg ICAgICAgIEhlYXBTdGF0aXN0aWNzOjpyZWNvcmRHQ1BhdXNlVGltZShnY1N0YXJ0VGltZSwgZ2NF bmRUaW1lKTsKLSAgICBSRUxFQVNFX0FTU0VSVChtX29wZXJhdGlvbkluUHJvZ3Jlc3MgPT0gRWRl bkNvbGxlY3Rpb24gfHwgbV9vcGVyYXRpb25JblByb2dyZXNzID09IEZ1bGxDb2xsZWN0aW9uKTsK LQotICAgIG1fb3BlcmF0aW9uSW5Qcm9ncmVzcyA9IE5vT3BlcmF0aW9uOwotICAgIEpBVkFTQ1JJ UFRDT1JFX0dDX0VORCgpOwogCiAgICAgaWYgKE9wdGlvbnM6OnVzZVpvbWJpZU1vZGUoKSkKICAg ICAgICAgem9tYmlmeURlYWRPYmplY3RzKCk7CkBAIC0xMzA5LDYgKzEzMDcsMTAgQEAgdm9pZCBI ZWFwOjpkaWRGaW5pc2hDb2xsZWN0aW9uKGRvdWJsZSBnYwogCiAgICAgaWYgKE9wdGlvbnM6Omxv Z0dDKCkgPT0gR0NMb2dnaW5nOjpWZXJib3NlKQogICAgICAgICBHQ0xvZ2dpbmc6OmR1bXBPYmpl Y3RHcmFwaCh0aGlzKTsKKworICAgIFJFTEVBU0VfQVNTRVJUKG1fb3BlcmF0aW9uSW5Qcm9ncmVz cyA9PSBFZGVuQ29sbGVjdGlvbiB8fCBtX29wZXJhdGlvbkluUHJvZ3Jlc3MgPT0gRnVsbENvbGxl Y3Rpb24pOworICAgIG1fb3BlcmF0aW9uSW5Qcm9ncmVzcyA9IE5vT3BlcmF0aW9uOworICAgIEpB VkFTQ1JJUFRDT1JFX0dDX0VORCgpOwogfQogCiB2b2lkIEhlYXA6OnJlc3VtZUNvbXBpbGVyVGhy ZWFkcygpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9JbmNyZW1lbnRhbFN3ZWVw ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0luY3JlbWVu dGFsU3dlZXBlci5jcHAJKHJldmlzaW9uIDE4MTQ0NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL0luY3JlbWVudGFsU3dlZXBlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk1LDYgKzk1 LDcgQEAgdm9pZCBJbmNyZW1lbnRhbFN3ZWVwZXI6OnN3ZWVwTmV4dEJsb2NrKAogICAgICAgICBp ZiAoIWJsb2NrLT5uZWVkc1N3ZWVwaW5nKCkpCiAgICAgICAgICAgICBjb250aW51ZTsKIAorICAg ICAgICBEZWZlckdDIGRlZmVyR0MobV92bS0+aGVhcCk7CiAgICAgICAgIGJsb2NrLT5zd2VlcCgp OwogICAgICAgICBtX3ZtLT5oZWFwLm9iamVjdFNwYWNlKCkuZnJlZU9yU2hyaW5rQmxvY2soYmxv Y2spOwogICAgICAgICByZXR1cm47Cg==