142637 2015-03-12 13:11:59 -0700 ASSERT(m_plugin) on plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html 2015-03-16 16:59:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=133227 https://bugs.webkit.org/show_bug.cgi?id=142754 P2 Normal --- 1 ap ap andersca commit-queue dino oldest_to_newest 1076718 0 ap 2015-03-12 13:11:59 -0700 I get an assertion when running this test locally, always reproducible by repeating it multiple times: run-webkit-tests plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html --repeat 100 The reason is that the QuickTime plug-in is 32-bit, so it fails to initialize, PluginView::didFailToInitializePlugin() sets m_plugin to 0, but then we start m_pluginSnapshotTimer regardless. This makes me confused about how this test (or other snapshotting tests) can ever pass on any debug local builds. They all expect a snapshot that shouldn't be possible to make. See also rdar://problem/18994117, rdar://problem/16097212. 1077623 1 248764 ap 2015-03-16 16:11:23 -0700 Created attachment 248764 proposed fix 1077648 2 248764 commit-queue 2015-03-16 16:59:04 -0700 Comment on attachment 248764 proposed fix Clearing flags on attachment: 248764 Committed r181599: <http://trac.webkit.org/changeset/181599> 1077649 3 commit-queue 2015-03-16 16:59:08 -0700 All reviewed patches have been landed. Closing bug. 248764 2015-03-16 16:11:23 -0700 2015-03-16 16:59:04 -0700 proposed fix snapshotting.txt text/plain 1694 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTU4NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE1LTAzLTE2ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEFTU0VSVChtX3BsdWdpbikg b24gcGx1Z2lucy9zbmFwc2hvdHRpbmcvc25hcHNob3QtcGx1Z2luLW5vdC1xdWl0ZS1ibG9ja2Vk LWJ5LWltYWdlLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0MjYzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwOiAoV2ViS2l0OjpQbHVn aW5WaWV3OjpwbHVnaW5TbmFwc2hvdFRpbWVyRmlyZWQpOgorICAgICAgICBtX3BsdWdpbiBjYW4g YmUgbGVnaXRpbWF0ZWx5IG51bGwuCisKIDIwMTUtMDMtMTYgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBPbmUgbW9yZSBVUlRCRiBhZnRlciByMTgxNTc4 LgpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5W aWV3LmNwcAkocmV2aXNpb24gMTgxNTcyKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Q bHVnaW5zL1BsdWdpblZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzM4LDggKzE3MzgsNiBA QCBzdGF0aWMgYm9vbCBpc0FsbW9zdFNvbGlkQ29sb3IoQml0bWFwSW1hCiAKIHZvaWQgUGx1Z2lu Vmlldzo6cGx1Z2luU25hcHNob3RUaW1lckZpcmVkKCkKIHsKLSAgICBBU1NFUlQobV9wbHVnaW4p OwotCiAjaWYgRU5BQkxFKFBSSU1BUllfU05BUFNIT1RURURfUExVR0lOX0hFVVJJU1RJQykKICAg ICBIVE1MUGx1Z0luSW1hZ2VFbGVtZW50JiBwbHVnSW5JbWFnZUVsZW1lbnQgPSBkb3duY2FzdDxI VE1MUGx1Z0luSW1hZ2VFbGVtZW50PigqbV9wbHVnaW5FbGVtZW50KTsKICAgICBib29sIGlzUGx1 Z0luT25TY3JlZW4gPSBtX3dlYlBhZ2UtPnBsdWdJbkludGVyc2VjdHNTZWFyY2hSZWN0KHBsdWdJ bkltYWdlRWxlbWVudCk7CkBAIC0xNzQ3LDcgKzE3NDUsNyBAQCB2b2lkIFBsdWdpblZpZXc6OnBs dWdpblNuYXBzaG90VGltZXJGaXJlCiAgICAgYm9vbCBzbmFwc2hvdEZvdW5kID0gZmFsc2U7CiAj ZW5kaWYKIAotICAgIGlmIChtX3BsdWdpbi0+c3VwcG9ydHNTbmFwc2hvdHRpbmcoKSkgeworICAg IGlmIChtX3BsdWdpbiAmJiBtX3BsdWdpbi0+c3VwcG9ydHNTbmFwc2hvdHRpbmcoKSkgewogICAg ICAgICAvLyBTbmFwc2hvdCBtaWdodCBiZSAwIGlmIHBsdWdpbiBzaXplIGlzIDB4MC4KICAgICAg ICAgUmVmUHRyPFNoYXJlYWJsZUJpdG1hcD4gc25hcHNob3QgPSBtX3BsdWdpbi0+c25hcHNob3Qo KTsKICAgICAgICAgUmVmUHRyPEltYWdlPiBzbmFwc2hvdEltYWdlOwo=