142623 2015-03-12 08:15:04 -0700 PDFs don't snapshot properly in iOS Safari 2015-04-10 19:08:11 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad iOS 8.2 RESOLVED FIXED InRadar P2 Normal --- 1 ian webkit-unassigned commit-queue ddkilzer mitz thorton oldest_to_newest 1076631 0 ian 2015-03-12 08:15:04 -0700 PDFs show up as blank white tabs in iOS Safari's tab view. That's because we don't snapshot custom content views in WKWebView. 1076640 1 248517 ian 2015-03-12 08:36:34 -0700 Created attachment 248517 patch 1076641 2 248518 ian 2015-03-12 08:38:40 -0700 Created attachment 248518 patch w/ corrected changelog 1076662 3 248518 commit-queue 2015-03-12 10:27:57 -0700 Comment on attachment 248518 patch w/ corrected changelog Clearing flags on attachment: 248518 Committed r181443: <http://trac.webkit.org/changeset/181443> 1076663 4 commit-queue 2015-03-12 10:28:00 -0700 All reviewed patches have been landed. Closing bug. 1076975 5 ddkilzer 2015-03-13 11:43:39 -0700 <rdar://problem/18283459> 1076976 6 ddkilzer 2015-03-13 11:43:52 -0700 Thanks Ian! 1077142 7 ian 2015-03-14 02:18:04 -0700 Thank *you* (and dbates specifically I suppose) for supporting the public simulator (which made it so I could actually test this change). 248517 2015-03-12 08:36:34 -0700 2015-03-12 08:38:40 -0700 patch 142623.patch text/plain 3030 ian SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTQzNikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTEyICBJYW4gSGVu ZGVyc29uICA8SWFuIEhlbmRlcnNvbiA8aWFuQGlhbmhlbmRlcnNvbi5vcmc+PgorCisgICAgICAg IFBERnMgZG9uJ3Qgc25hcHNob3QgcHJvcGVybHkgaW4gaU9TIFNhZmFyaQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyNjIzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29h L1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9zbmFwc2hvdFJlY3Q6aW50b0lt YWdlT2ZXaWR0aDpjb21wbGV0aW9uSGFuZGxlcjpdKToKKyAgICAgICAgSWYgd2UgaGF2ZSBhIF9j dXN0b21Db250ZW50VmlldywgdXNlIFVJVmlldyBzbmFwc2hvdHRpbmcgaW5zdGVhZCBvZgorICAg ICAgICB0cnlpbmcgdG8gc25hcHNob3QgdGhlIHdlYiBwYWdlLgorCiAyMDE1LTAzLTExICBBbnR0 aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBDYWNoZSB0cmF2ZXJzYWwg bWlzc2luZyBsYXJnZSBlbnRyaWVzCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQkocmV2aXNpb24gMTgxNDM2KQorKysgU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAg LTI0NDYsOSArMjQ0NiwzMCBAQAogCiAtICh2b2lkKV9zbmFwc2hvdFJlY3Q6KENHUmVjdClyZWN0 SW5WaWV3Q29vcmRpbmF0ZXMgaW50b0ltYWdlT2ZXaWR0aDooQ0dGbG9hdClpbWFnZVdpZHRoIGNv bXBsZXRpb25IYW5kbGVyOih2b2lkKF4pKENHSW1hZ2VSZWYpKWNvbXBsZXRpb25IYW5kbGVyCiB7 Ci0gICAgQ0dSZWN0IHNuYXBzaG90UmVjdEluQ29udGVudENvb3JkaW5hdGVzID0gW3NlbGYgY29u dmVydFJlY3Q6cmVjdEluVmlld0Nvb3JkaW5hdGVzIHRvVmlldzpfY29udGVudFZpZXcuZ2V0KCld OwotICAgIENHRmxvYXQgaW1hZ2VIZWlnaHQgPSBpbWFnZVdpZHRoIC8gc25hcHNob3RSZWN0SW5D b250ZW50Q29vcmRpbmF0ZXMuc2l6ZS53aWR0aCAqIHNuYXBzaG90UmVjdEluQ29udGVudENvb3Jk aW5hdGVzLnNpemUuaGVpZ2h0OworICAgIENHUmVjdCBzbmFwc2hvdFJlY3RJbkNvbnRlbnRDb29y ZGluYXRlcyA9IFtzZWxmIGNvbnZlcnRSZWN0OnJlY3RJblZpZXdDb29yZGluYXRlcyB0b1ZpZXc6 c2VsZi5fY3VycmVudENvbnRlbnRWaWV3XTsKKyAgICBDR0Zsb2F0IGltYWdlU2NhbGUgPSBpbWFn ZVdpZHRoIC8gc25hcHNob3RSZWN0SW5Db250ZW50Q29vcmRpbmF0ZXMuc2l6ZS53aWR0aDsKKyAg ICBDR0Zsb2F0IGltYWdlSGVpZ2h0ID0gaW1hZ2VTY2FsZSAqIHNuYXBzaG90UmVjdEluQ29udGVu dENvb3JkaW5hdGVzLnNpemUuaGVpZ2h0OwogICAgIENHU2l6ZSBpbWFnZVNpemUgPSBDR1NpemVN YWtlKGltYWdlV2lkdGgsIGltYWdlSGVpZ2h0KTsKKworICAgIGlmIChfY3VzdG9tQ29udGVudFZp ZXcpIHsKKyAgICAgICAgVUlHcmFwaGljc0JlZ2luSW1hZ2VDb250ZXh0V2l0aE9wdGlvbnMoaW1h Z2VTaXplLCBZRVMsIDEpOworCisgICAgICAgIFVJVmlldyAqY3VzdG9tQ29udGVudFZpZXcgPSBf Y3VzdG9tQ29udGVudFZpZXcuZ2V0KCk7CisgICAgICAgIFtjdXN0b21Db250ZW50Vmlldy5iYWNr Z3JvdW5kQ29sb3Igc2V0XTsKKyAgICAgICAgVUlSZWN0RmlsbChDR1JlY3RNYWtlKDAsIDAsIGlt YWdlV2lkdGgsIGltYWdlSGVpZ2h0KSk7CisKKyAgICAgICAgQ0dSZWN0IGRlc3RpbmF0aW9uUmVj dCA9IGN1c3RvbUNvbnRlbnRWaWV3LmJvdW5kczsKKyAgICAgICAgZGVzdGluYXRpb25SZWN0Lm9y aWdpbi54ID0gLXNuYXBzaG90UmVjdEluQ29udGVudENvb3JkaW5hdGVzLm9yaWdpbi54ICogaW1h Z2VTY2FsZTsKKyAgICAgICAgZGVzdGluYXRpb25SZWN0Lm9yaWdpbi55ID0gLXNuYXBzaG90UmVj dEluQ29udGVudENvb3JkaW5hdGVzLm9yaWdpbi55ICogaW1hZ2VTY2FsZTsKKyAgICAgICAgZGVz dGluYXRpb25SZWN0LnNpemUud2lkdGggKj0gaW1hZ2VTY2FsZTsKKyAgICAgICAgZGVzdGluYXRp b25SZWN0LnNpemUuaGVpZ2h0ICo9IGltYWdlU2NhbGU7CisgICAgICAgIFtjdXN0b21Db250ZW50 VmlldyBkcmF3Vmlld0hpZXJhcmNoeUluUmVjdDpkZXN0aW5hdGlvblJlY3QgYWZ0ZXJTY3JlZW5V cGRhdGVzOk5PXTsKKworICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihbVUlHcmFwaGljc0dldElt YWdlRnJvbUN1cnJlbnRJbWFnZUNvbnRleHQoKSBDR0ltYWdlXSk7CisKKyAgICAgICAgVUlHcmFw aGljc0VuZEltYWdlQ29udGV4dCgpOworICAgICAgICByZXR1cm47CisgICAgfQogICAgIAogICAg IHZvaWQoXmNvcGllZENvbXBsZXRpb25IYW5kbGVyKShDR0ltYWdlUmVmKSA9IFtjb21wbGV0aW9u SGFuZGxlciBjb3B5XTsKICAgICBfcGFnZS0+dGFrZVNuYXBzaG90KFdlYkNvcmU6OmVuY2xvc2lu Z0ludFJlY3Qoc25hcHNob3RSZWN0SW5Db250ZW50Q29vcmRpbmF0ZXMpLCBXZWJDb3JlOjpleHBh bmRlZEludFNpemUoV2ViQ29yZTo6RmxvYXRTaXplKGltYWdlU2l6ZSkpLCBXZWJLaXQ6OlNuYXBz aG90T3B0aW9uc0V4Y2x1ZGVEZXZpY2VTY2FsZUZhY3RvciwgWz1dKGNvbnN0IFdlYktpdDo6U2hh cmVhYmxlQml0bWFwOjpIYW5kbGUmIGltYWdlSGFuZGxlLCBXZWJLaXQ6OkNhbGxiYWNrQmFzZTo6 RXJyb3IpIHsK 248518 2015-03-12 08:38:40 -0700 2015-03-12 10:27:57 -0700 patch w/ corrected changelog 142623.patch text/plain 3014 ian SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTQzNikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTEyICBJYW4gSGVu ZGVyc29uICA8aWFuQGlhbmhlbmRlcnNvbi5vcmc+CisKKyAgICAgICAgUERGcyBkb24ndCBzbmFw c2hvdCBwcm9wZXJseSBpbiBpT1MgU2FmYXJpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI2MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgor ICAgICAgICAoLVtXS1dlYlZpZXcgX3NuYXBzaG90UmVjdDppbnRvSW1hZ2VPZldpZHRoOmNvbXBs ZXRpb25IYW5kbGVyOl0pOgorICAgICAgICBJZiB3ZSBoYXZlIGEgX2N1c3RvbUNvbnRlbnRWaWV3 LCB1c2UgVUlWaWV3IHNuYXBzaG90dGluZyBpbnN0ZWFkIG9mCisgICAgICAgIHRyeWluZyB0byBz bmFwc2hvdCB0aGUgd2ViIHBhZ2UuCisKIDIwMTUtMDMtMTEgIEFudHRpIEtvaXZpc3RvICA8YW50 dGlAYXBwbGUuY29tPgogCiAgICAgICAgIENhY2hlIHRyYXZlcnNhbCBtaXNzaW5nIGxhcmdlIGVu dHJpZXMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3 Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tX ZWJWaWV3Lm1tCShyZXZpc2lvbiAxODE0MzYpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLV2ViVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjQ0Niw5ICsyNDQ2LDMw IEBACiAKIC0gKHZvaWQpX3NuYXBzaG90UmVjdDooQ0dSZWN0KXJlY3RJblZpZXdDb29yZGluYXRl cyBpbnRvSW1hZ2VPZldpZHRoOihDR0Zsb2F0KWltYWdlV2lkdGggY29tcGxldGlvbkhhbmRsZXI6 KHZvaWQoXikoQ0dJbWFnZVJlZikpY29tcGxldGlvbkhhbmRsZXIKIHsKLSAgICBDR1JlY3Qgc25h cHNob3RSZWN0SW5Db250ZW50Q29vcmRpbmF0ZXMgPSBbc2VsZiBjb252ZXJ0UmVjdDpyZWN0SW5W aWV3Q29vcmRpbmF0ZXMgdG9WaWV3Ol9jb250ZW50Vmlldy5nZXQoKV07Ci0gICAgQ0dGbG9hdCBp bWFnZUhlaWdodCA9IGltYWdlV2lkdGggLyBzbmFwc2hvdFJlY3RJbkNvbnRlbnRDb29yZGluYXRl cy5zaXplLndpZHRoICogc25hcHNob3RSZWN0SW5Db250ZW50Q29vcmRpbmF0ZXMuc2l6ZS5oZWln aHQ7CisgICAgQ0dSZWN0IHNuYXBzaG90UmVjdEluQ29udGVudENvb3JkaW5hdGVzID0gW3NlbGYg Y29udmVydFJlY3Q6cmVjdEluVmlld0Nvb3JkaW5hdGVzIHRvVmlldzpzZWxmLl9jdXJyZW50Q29u dGVudFZpZXddOworICAgIENHRmxvYXQgaW1hZ2VTY2FsZSA9IGltYWdlV2lkdGggLyBzbmFwc2hv dFJlY3RJbkNvbnRlbnRDb29yZGluYXRlcy5zaXplLndpZHRoOworICAgIENHRmxvYXQgaW1hZ2VI ZWlnaHQgPSBpbWFnZVNjYWxlICogc25hcHNob3RSZWN0SW5Db250ZW50Q29vcmRpbmF0ZXMuc2l6 ZS5oZWlnaHQ7CiAgICAgQ0dTaXplIGltYWdlU2l6ZSA9IENHU2l6ZU1ha2UoaW1hZ2VXaWR0aCwg aW1hZ2VIZWlnaHQpOworCisgICAgaWYgKF9jdXN0b21Db250ZW50VmlldykgeworICAgICAgICBV SUdyYXBoaWNzQmVnaW5JbWFnZUNvbnRleHRXaXRoT3B0aW9ucyhpbWFnZVNpemUsIFlFUywgMSk7 CisKKyAgICAgICAgVUlWaWV3ICpjdXN0b21Db250ZW50VmlldyA9IF9jdXN0b21Db250ZW50Vmll dy5nZXQoKTsKKyAgICAgICAgW2N1c3RvbUNvbnRlbnRWaWV3LmJhY2tncm91bmRDb2xvciBzZXRd OworICAgICAgICBVSVJlY3RGaWxsKENHUmVjdE1ha2UoMCwgMCwgaW1hZ2VXaWR0aCwgaW1hZ2VI ZWlnaHQpKTsKKworICAgICAgICBDR1JlY3QgZGVzdGluYXRpb25SZWN0ID0gY3VzdG9tQ29udGVu dFZpZXcuYm91bmRzOworICAgICAgICBkZXN0aW5hdGlvblJlY3Qub3JpZ2luLnggPSAtc25hcHNo b3RSZWN0SW5Db250ZW50Q29vcmRpbmF0ZXMub3JpZ2luLnggKiBpbWFnZVNjYWxlOworICAgICAg ICBkZXN0aW5hdGlvblJlY3Qub3JpZ2luLnkgPSAtc25hcHNob3RSZWN0SW5Db250ZW50Q29vcmRp bmF0ZXMub3JpZ2luLnkgKiBpbWFnZVNjYWxlOworICAgICAgICBkZXN0aW5hdGlvblJlY3Quc2l6 ZS53aWR0aCAqPSBpbWFnZVNjYWxlOworICAgICAgICBkZXN0aW5hdGlvblJlY3Quc2l6ZS5oZWln aHQgKj0gaW1hZ2VTY2FsZTsKKyAgICAgICAgW2N1c3RvbUNvbnRlbnRWaWV3IGRyYXdWaWV3SGll cmFyY2h5SW5SZWN0OmRlc3RpbmF0aW9uUmVjdCBhZnRlclNjcmVlblVwZGF0ZXM6Tk9dOworCisg ICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKFtVSUdyYXBoaWNzR2V0SW1hZ2VGcm9tQ3VycmVudElt YWdlQ29udGV4dCgpIENHSW1hZ2VdKTsKKworICAgICAgICBVSUdyYXBoaWNzRW5kSW1hZ2VDb250 ZXh0KCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CiAgICAgCiAgICAgdm9pZCheY29waWVkQ29t cGxldGlvbkhhbmRsZXIpKENHSW1hZ2VSZWYpID0gW2NvbXBsZXRpb25IYW5kbGVyIGNvcHldOwog ICAgIF9wYWdlLT50YWtlU25hcHNob3QoV2ViQ29yZTo6ZW5jbG9zaW5nSW50UmVjdChzbmFwc2hv dFJlY3RJbkNvbnRlbnRDb29yZGluYXRlcyksIFdlYkNvcmU6OmV4cGFuZGVkSW50U2l6ZShXZWJD b3JlOjpGbG9hdFNpemUoaW1hZ2VTaXplKSksIFdlYktpdDo6U25hcHNob3RPcHRpb25zRXhjbHVk ZURldmljZVNjYWxlRmFjdG9yLCBbPV0oY29uc3QgV2ViS2l0OjpTaGFyZWFibGVCaXRtYXA6Okhh bmRsZSYgaW1hZ2VIYW5kbGUsIFdlYktpdDo6Q2FsbGJhY2tCYXNlOjpFcnJvcikgewo=