142622 2015-03-12 07:24:08 -0700 Unreviewed GTK+ gardening on 12th Mar. 2015-05-19 08:09:02 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 hs85.jeong hs85.jeong cgarcia chavarria1991 clopez oldest_to_newest 1076627 0 hs85.jeong 2015-03-12 07:24:08 -0700 Mark attachment-foo test and update the missing tests to existing bugs. 1076628 1 248515 hs85.jeong 2015-03-12 07:26:29 -0700 Created attachment 248515 Patch 1076868 2 248515 cgarcia 2015-03-12 23:36:29 -0700 Comment on attachment 248515 Patch Shouldn't we use Skip instead of Missing in these cases? 1076884 3 248575 hs85.jeong 2015-03-13 00:22:56 -0700 Created attachment 248575 Patch 1076885 4 hs85.jeong 2015-03-13 00:23:07 -0700 I changed Missing to Skip. 1076932 5 248575 clopez 2015-03-13 06:38:32 -0700 Comment on attachment 248575 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248575&action=review > LayoutTests/platform/gtk/TestExpectations:2376 > +# GTK port doesn't support attachment feature yet. > +Bug(GTK) fast/attachment/attachment-progress.html [ Skip ] > +Bug(GTK) fast/attachment/attachment-select-on-click-inside-user-select-all.html [ Skip ] > +Bug(GTK) fast/attachment/attachment-select-on-click.html [ Skip ] > +Bug(GTK) fast/attachment/attachment-subtitle.html [ Skip ] > +Bug(GTK) fast/attachment/attachment-title.html [ Skip ] I think is beter if you can open a bug number telling that we still dont support the feature and then use that bug number here instead of just using "Bug(GTK)". 1076933 6 clopez 2015-03-13 06:41:14 -0700 Regarding the usage of Missing vs Skip. When there is a test that only has an expectation for another port (Mac for example) and there isn't a general expected. There are two options: 1) The test is specific to that port (Mac), so just use "Skip". 2) The test can be used also on our port, but still nobody generated a valid expected for our port, then use "Missing" In the second case, if you know that the expected generated for the GTK port is valid you can add it. If you have doubts, better open a bug report CC'ing the author of the test, and mark the test as Missing. 1095928 7 hs85.jeong 2015-05-19 08:08:11 -0700 Thanks for your guide, but I closed this bug because it is old one. 248515 2015-03-12 07:26:29 -0700 2015-03-13 00:22:46 -0700 Patch bug-142622-20150312232604.patch text/plain 2488 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNDM1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTFhN2I4MmM0ODU1NmQ3ZWY1OGYw ZDM2YWY0NzAyYTgzMGJkMDY0ZC4uYjIxM2YyYmNkNDMxMDgxZDU1OWYzYjE5NzI0ZTI5MjExM2Yy OWMyMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTAzLTEyICBIdW5zZW9wIEplb25nICA8 aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBVbnJldmlld2VkIEdUSysgZ2FyZGVu aW5nIG9uIDEydGggTWFyLiAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0MjYyMgorCisgICAgICAgIE1hcmsgYXR0YWNobWVudC1mb28gdGVzdCBhbmQg dXBkYXRlIHRoZSBtaXNzaW5nIHRlc3RzIHRvIGV4aXN0aW5nIGJ1Z3MuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNS0wMy0xMSAgQnJlbnQgRnVsZ2hh bSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBVcGRhdGUgdGVzdCBleHBl Y3RhdGlvbnMgYWZ0ZXIgcjE4MTQwOC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBl Y3RhdGlvbnMKaW5kZXggMzNlZDkzNDZlYmVkNWIwZjllYmNjYjhlYTQzZDA0NWVlMzg0MDlmMy4u ZjRjZDQ5NDE5NWMxMzc3MGIyNTAyZDIxNDg5NmRmNWE3MjYxOGNjMSAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTIzNTcsNiArMjM1Nyw4IEBAIHdlYmtp dC5vcmcvYi8xNDAyNTIgZmFzdC90ZXh0L2tobWVyLWxhby1mb250Lmh0bWwgWyBGYWlsdXJlIF0K IHdlYmtpdC5vcmcvYi8xNDAyNTIgZmFzdC90ZXh0L21pZHdvcmQtYnJlYWstYmVmb3JlLXN1cnJv Z2F0ZS1wYWlyLTIuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE0MDI1MiBzdmcvY3Vz dG9tL3N2Zy1mb250cy1mYWxsYmFjay54aHRtbCBbIEZhaWx1cmUgXQogCit3ZWJraXQub3JnL2Iv MTQxMDc0IGFjY2Vzc2liaWxpdHkvYXV0by1maWxsZWQtdmFsdWUuaHRtbCBbIE1pc3NpbmcgXQor CiB3ZWJraXQub3JnL2IvMTQyNDc5IHN2Zy90ZXh0L3NlbGVjdC10ZXh0TGVuZ3RoLXNwYWNpbmdB bmRHbHlwaHMtc3F1ZWV6ZS0yLnN2ZyBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE0MjQ3OSBz dmcvdGV4dC9zZWxlY3QtdGV4dExlbmd0aC1zcGFjaW5nQW5kR2x5cGhzLXNxdWVlemUtMy5zdmcg WyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNDI0Nzkgc3ZnL3RleHQvc2VsZWN0LXRleHRMZW5n dGgtc3BhY2luZ0FuZEdseXBocy1zcXVlZXplLTQuc3ZnIFsgRmFpbHVyZSBdCkBAIC0yMzY5LDYg KzIzNzEsMTUgQEAgd2Via2l0Lm9yZy9iLzE0MjQ4MiBodHRwL3Rlc3RzL3NlY3VyaXR5L21peGVk Q29udGVudC9pbnNlY3VyZS1hdWRpby12aWRlby1pbi1tYWkKIHdlYmtpdC5vcmcvYi8xNDI0ODcg ZmFzdC9yZWdpb25zL3JlZ2lvbi1vdmVyZmxvdy1icmVhay5odG1sIFsgSW1hZ2VPbmx5RmFpbHVy ZSBdCiB3ZWJraXQub3JnL2IvMTQyNDIzIHN2Zy9mb250cy9zdmctZm9udC1ob3Jpei1vcmlnaW4u aHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogCisjIEdUSyBwb3J0IGRvZXNuJ3Qgc3VwcG9ydCBh dHRhY2htZW50IGZlYXR1cmUgeWV0LgorQnVnKEdUSykgZmFzdC9hdHRhY2htZW50L2F0dGFjaG1l bnQtcHJvZ3Jlc3MuaHRtbCBbIE1pc3NpbmcgXQorQnVnKEdUSykgZmFzdC9hdHRhY2htZW50L2F0 dGFjaG1lbnQtc2VsZWN0LW9uLWNsaWNrLWluc2lkZS11c2VyLXNlbGVjdC1hbGwuaHRtbCBbIE1p c3NpbmcgXQorQnVnKEdUSykgZmFzdC9hdHRhY2htZW50L2F0dGFjaG1lbnQtc2VsZWN0LW9uLWNs aWNrLmh0bWwgWyBNaXNzaW5nIF0KK0J1ZyhHVEspIGZhc3QvYXR0YWNobWVudC9hdHRhY2htZW50 LXN1YnRpdGxlLmh0bWwgWyBNaXNzaW5nIF0KK0J1ZyhHVEspIGZhc3QvYXR0YWNobWVudC9hdHRh Y2htZW50LXRpdGxlLmh0bWwgWyBNaXNzaW5nIF0KKword2Via2l0Lm9yZy9iLzE0MjYyMSBmYXN0 L2Nzcy9mb2N1cy1yaW5nLWV4aXN0cy1mb3Itc2VhcmNoLWZpZWxkLmh0bWwgWyBNaXNzaW5nIF0K KwogIy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KICMgRW5kIG9mIFRlc3RzIGZhaWxp bmcKICMvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCg== 248575 2015-03-13 00:22:56 -0700 2015-05-19 08:09:02 -0700 Patch bug-142622-20150313162230.patch text/plain 2511 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNDY5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzkwMTEwYmQ5NGU0MTJlMzBhYTJl NzQ1ZDBlYThjOGRjODZiNmZkOS4uNWM0N2E3OGZlZjA5Y2I2YjBlZWY1Y2JmYWYxZWUzNTIwNWZh NzFiNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTAzLTEzICBIdW5zZW9wIEplb25nICA8 aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBVbnJldmlld2VkIEdUSysgZ2FyZGVu aW5nIG9uIDEydGggTWFyLiAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0MjYyMgorCisgICAgICAgIE1hcmsgYXR0YWNobWVudC1mb28gdGVzdCBhbmQg dXBkYXRlIHRoZSBtaXNzaW5nIHRlc3RzIHRvIGV4aXN0aW5nIGJ1Z3MuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNS0wMy0xMiAgUnlvc3VrZSBOaXdh ICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxODA3MjYpOiBSZW1v dmluZyBhbiBlbXB0eSBsaW5lIGF0IHRoZSBlbmQgb2YgdGV4dGFyZWEgY2xlYXJzIHRoZSBlbnRp cmUgdGV4dHVyZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBl Y3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRl eCA1MGQ3ODI4YWViNzMwZWJjNGNjYjIwZjllYzYwM2UxNDZkMWEzOTYxLi5mMzc0OWI2NDIyYzZj ZjEyNWQ4ZWRhNjFmNTA1NjIwODgzZWE1N2U3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsv VGVzdEV4cGVjdGF0aW9ucwpAQCAtMjM1NCw2ICsyMzU0LDggQEAgd2Via2l0Lm9yZy9iLzE0MDI1 MiBmYXN0L3RleHQva2htZXItbGFvLWZvbnQuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9i LzE0MDI1MiBmYXN0L3RleHQvbWlkd29yZC1icmVhay1iZWZvcmUtc3Vycm9nYXRlLXBhaXItMi5o dG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTQwMjUyIHN2Zy9jdXN0b20vc3ZnLWZvbnRz LWZhbGxiYWNrLnhodG1sIFsgRmFpbHVyZSBdCiAKK3dlYmtpdC5vcmcvYi8xNDEwNzQgYWNjZXNz aWJpbGl0eS9hdXRvLWZpbGxlZC12YWx1ZS5odG1sIFsgU2tpcCBdCisKIHdlYmtpdC5vcmcvYi8x NDI0Nzkgc3ZnL3RleHQvc2VsZWN0LXRleHRMZW5ndGgtc3BhY2luZ0FuZEdseXBocy1zcXVlZXpl LTIuc3ZnIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTQyNDc5IHN2Zy90ZXh0L3NlbGVjdC10 ZXh0TGVuZ3RoLXNwYWNpbmdBbmRHbHlwaHMtc3F1ZWV6ZS0zLnN2ZyBbIEZhaWx1cmUgXQogd2Vi a2l0Lm9yZy9iLzE0MjQ3OSBzdmcvdGV4dC9zZWxlY3QtdGV4dExlbmd0aC1zcGFjaW5nQW5kR2x5 cGhzLXNxdWVlemUtNC5zdmcgWyBGYWlsdXJlIF0KQEAgLTIzNjYsNiArMjM2OCwxNSBAQCB3ZWJr aXQub3JnL2IvMTQyNDgyIGh0dHAvdGVzdHMvc2VjdXJpdHkvbWl4ZWRDb250ZW50L2luc2VjdXJl LWF1ZGlvLXZpZGVvLWluLW1haQogd2Via2l0Lm9yZy9iLzE0MjQ4NyBmYXN0L3JlZ2lvbnMvcmVn aW9uLW92ZXJmbG93LWJyZWFrLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcv Yi8xNDI0MjMgc3ZnL2ZvbnRzL3N2Zy1mb250LWhvcml6LW9yaWdpbi5odG1sIFsgSW1hZ2VPbmx5 RmFpbHVyZSBdCiAKKyMgR1RLIHBvcnQgZG9lc24ndCBzdXBwb3J0IGF0dGFjaG1lbnQgZmVhdHVy ZSB5ZXQuCitCdWcoR1RLKSBmYXN0L2F0dGFjaG1lbnQvYXR0YWNobWVudC1wcm9ncmVzcy5odG1s IFsgU2tpcCBdCitCdWcoR1RLKSBmYXN0L2F0dGFjaG1lbnQvYXR0YWNobWVudC1zZWxlY3Qtb24t Y2xpY2staW5zaWRlLXVzZXItc2VsZWN0LWFsbC5odG1sIFsgU2tpcCBdCitCdWcoR1RLKSBmYXN0 L2F0dGFjaG1lbnQvYXR0YWNobWVudC1zZWxlY3Qtb24tY2xpY2suaHRtbCBbIFNraXAgXQorQnVn KEdUSykgZmFzdC9hdHRhY2htZW50L2F0dGFjaG1lbnQtc3VidGl0bGUuaHRtbCBbIFNraXAgXQor QnVnKEdUSykgZmFzdC9hdHRhY2htZW50L2F0dGFjaG1lbnQtdGl0bGUuaHRtbCBbIFNraXAgXQor Cit3ZWJraXQub3JnL2IvMTQyNjIxIGZhc3QvY3NzL2ZvY3VzLXJpbmctZXhpc3RzLWZvci1zZWFy Y2gtZmllbGQuaHRtbCBbIFNraXAgXQorCiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v LwogIyBFbmQgb2YgVGVzdHMgZmFpbGluZwogIy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8K