142613 2015-03-12 02:07:07 -0700 [cmake] Fix the incremental build issue revealed by r181419 2015-03-12 03:28:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 142600 1 ossy ossy cgarcia clopez commit-queue gyuyoung.kim mark.lam ossy rniwa oldest_to_newest 1076589 0 ossy 2015-03-12 02:07:07 -0700 After https://trac.webkit.org/changeset/181419 the build was broken on the EFL performance bot and the GTK ARM bot. But it must be an incremental build issue, because clean build solved the problem. The goal of this bug is to add the missing dependency to the cmake build system to avoid same error in the future. 1076590 1 ossy 2015-03-12 02:12:27 -0700 error log: In file included from ../../Source/JavaScriptCore/parser/Lexer.cpp:41:0: DerivedSources/JavaScriptCore/KeywordLookup.h: In member function 'JSC::JSTokenType JSC::Lexer<T>::parseKeyword(JSC::JSTokenData*) [with bool shouldCreateIdentifier = shouldCreateIdentifier; T = short unsigned int]': DerivedSources/JavaScriptCore/KeywordLookup.h:434:24: error: 'STATICTOKEN' was not declared in this scope DerivedSources/JavaScriptCore/KeywordLookup.h: In member function 'JSC::JSTokenType JSC::Lexer<T>::parseKeyword(JSC::JSTokenData*) [with bool shouldCreateIdentifier = shouldCreateIdentifier; T = unsigned char]': DerivedSources/JavaScriptCore/KeywordLookup.h:798:24: error: 'STATICTOKEN' was not declared in this scope 1076592 2 ossy 2015-03-12 02:17:28 -0700 DerivedSources/JavaScriptCore/KeywordLookup.h wasn't regenerated, but it should have been. Keywords.table is missing from the dependency list. Fix is coming. 1076593 3 248503 ossy 2015-03-12 02:19:08 -0700 Created attachment 248503 Patch 1076600 4 commit-queue 2015-03-12 03:17:05 -0700 The commit-queue encountered the following flaky tests while processing attachment 248503: The commit-queue is continuing to process your patch. 1076603 5 commit-queue 2015-03-12 03:17:48 -0700 The commit-queue encountered the following flaky tests while processing attachment 248503: compositing/geometry/clipped-video-controller.html bug 142615 (authors: adamk@chromium.org, mihaip@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) The commit-queue is continuing to process your patch. 1076604 6 248503 commit-queue 2015-03-12 03:28:15 -0700 Comment on attachment 248503 Patch Clearing flags on attachment: 248503 Committed r181435: <http://trac.webkit.org/changeset/181435> 1076605 7 commit-queue 2015-03-12 03:28:20 -0700 All reviewed patches have been landed. Closing bug. 248503 2015-03-12 02:19:08 -0700 2015-03-12 03:28:15 -0700 Patch bug-142613-20150312021842.patch text/plain 1624 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxNDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NmJhZjU3MTc3NjgwM2YxODg3OWYyNzRhNmUyY2VhNjJiYjYxOTE3Li44OTc0MTk0Y2VjMWFiODRk NDVhYjU2OWU5YTE4MDkyOTQyNTI1ZTFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNS0wMy0xMiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFtjbWFrZV0gRml4IHRoZSBpbmNyZW1lbnRhbCBidWlsZCBpc3N1ZSBy ZXZlYWxlZCBieSByMTgxNDE5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDI2MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDE1LTAzLTExICBSeW9zdWtlIE5pd2Eg IDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgICJzdGF0aWMiIHNob3VsZCBub3QgYmUgYSBy ZXNlcnZlZCBrZXl3b3JkIGluIG5vbi1zdHJpY3QgbW9kZSBldmVuIHdoZW4gRVM2IGNsYXNzIGlz IGVuYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4 dCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCBjMTRlNjU4ZDA4 OTY4ZDI4N2RkN2QzM2ViOTIwNTNiOTJkMTY5NzNhLi5kYThhNWIxMTIzYjlhOTFmMTNlMGFjN2U5 ZTJmMzBlMmVkYjM2NDE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VM aXN0cy50eHQKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC05 OTcsNiArOTk3LDcgQEAgQUREX1NPVVJDRV9ERVBFTkRFTkNJRVMoJHtDTUFLRV9DVVJSRU5UX1NP VVJDRV9ESVJ9L3lhcnIvWWFyclBhdHRlcm4uY3BwICR7REVSSVYKIGFkZF9jdXN0b21fY29tbWFu ZCgKICAgICBPVVRQVVQgJHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVfRElSfS9LZXl3 b3JkTG9va3VwLmgKICAgICBNQUlOX0RFUEVOREVOQ1kgJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9E SVJ9L0tleXdvcmRMb29rdXBHZW5lcmF0b3IucHkKKyAgICBERVBFTkRTICR7Q01BS0VfQ1VSUkVO VF9TT1VSQ0VfRElSfS9wYXJzZXIvS2V5d29yZHMudGFibGUKICAgICBDT01NQU5EICR7UFlUSE9O X0VYRUNVVEFCTEV9ICR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9LZXl3b3JkTG9va3VwR2Vu ZXJhdG9yLnB5ICR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9wYXJzZXIvS2V5d29yZHMudGFi bGUgPiAke0RFUklWRURfU09VUkNFU19KQVZBU0NSSVBUQ09SRV9ESVJ9L0tleXdvcmRMb29rdXAu aAogICAgIFZFUkJBVElNKQogQUREX1NPVVJDRV9ERVBFTkRFTkNJRVMoJHtDTUFLRV9DVVJSRU5U X1NPVVJDRV9ESVJ9L3BhcnNlci9MZXhlci5jcHAgJHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQ VENPUkVfRElSfS9LZXl3b3JkTG9va3VwLmgpCg==