142606 2015-03-11 18:12:11 -0700 Broke updating media element time following r181279 2015-03-11 22:01:33 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned commit-queue dino roger_fong oldest_to_newest 1076521 0 roger_fong 2015-03-11 18:12:11 -0700 Following http://trac.webkit.org/changeset/181279 I broke updating time while scrubbing. The reason is that before we were blanket updating the whole control panel anytime the mouse moved. I changed it such that it only updated as a result of a mouse move if the controls were hidden (to unhide them) However I didn’t quite think it through enough and forgot that we also need to update the times of the control display as a result of a mouse move if we are scrubbing. 1076522 1 roger_fong 2015-03-11 18:14:42 -0700 rdar://problem/20131014 1076523 2 248474 roger_fong 2015-03-11 18:18:04 -0700 Created attachment 248474 patch 1076565 3 248474 commit-queue 2015-03-11 22:01:30 -0700 Comment on attachment 248474 patch Clearing flags on attachment: 248474 Committed r181428: <http://trac.webkit.org/changeset/181428> 1076566 4 commit-queue 2015-03-11 22:01:33 -0700 All reviewed patches have been landed. Closing bug. 248474 2015-03-11 18:18:04 -0700 2015-03-11 22:01:30 -0700 patch patch.patch text/plain 1363 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTQyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTExICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTWVkaWEgZWxlbWVudCB0aW1l IG5vIGxvbmdlciB1cGRhdGVzIHdoaWxlIHNjcnViYmluZyBmb2xsb3dpbmcgcjE4MTI3OS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjYwNi4KKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIwMTMxMDE0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29u dHJvbHNBcHBsZS5qczoKKyAgICAgICAgKENvbnRyb2xsZXIucHJvdG90eXBlLmhhbmRsZVdyYXBw ZXJNb3VzZU1vdmUpOgorICAgICAgICBVcGRhdGUgdGltZSBhcyBhIHJlc3VsdCBvZiBhIG1vdXNl IG1vdmUgaWYgd2UgYXJlIHNjcnViYmluZy4KKwogMjAxNS0wMy0xMSAgQWxleCBDaHJpc3RlbnNl biAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFtDb250ZW50IEV4dGVuc2lv bnNdIEFkZCByZXNvdXJjZSB0eXBlIGFuZCBsb2FkIHR5cGUgdHJpZ2dlcnMuCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNv bnRyb2xzQXBwbGUuanMJKHJldmlzaW9uIDE4MTQxMykKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMJKHdvcmtpbmcgY29weSkKQEAg LTcxMCw2ICs3MTAsOSBAQCBDb250cm9sbGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYgKHRo aXMuY29udHJvbHNBcmVIaWRkZW4oKSkKICAgICAgICAgICAgIHRoaXMuc2hvd0NvbnRyb2xzKCk7 CiAgICAgICAgIHRoaXMucmVzZXRIaWRlQ29udHJvbHNUaW1lcigpOworICAgICAgICAKKyAgICAg ICAgaWYgKHRoaXMuc2NydWJiaW5nKQorICAgICAgICAgICAgdGhpcy51cGRhdGVUaW1lKCk7CiAK ICAgICAgICAgaWYgKCF0aGlzLmlzRHJhZ2dpbmcpCiAgICAgICAgICAgICByZXR1cm47Cg==