142603 2015-03-11 17:44:46 -0700 Web Inspector: Console Errors during provisional document loads get lost with "Clear Log on Reload" 2015-03-12 09:10:36 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1076505 0 joepeck 2015-03-11 17:44:46 -0700 * SUMMARY Console Errors during provisional document loads get lost with "Clear Log on Reload". * STEPS TO REPRODUCE 1. Enable "Clear Log on Reload" in Web Inspector's console (context menu in Console Log View) 2. Inspect <https://docs.google.com/spreadsheets/d/1ch7X6RljdfAFjfGY926UkLrPxZTrcbIYg0bGmrJ8gHQ/edit?usp=sharing_eid> [you do not need access to the file] 3. Reload => error message shows in console then gets cleared * NOTES Order of events: -> Page.reload -> Page.frameWillStartLoading -> Network.requestWillBeSent -> Network.responseReceived (error) -> Console.messageAdded -> commit -> Console.messagesCleared -> Page.frameNavigated So we receive the error during provisional loading, and auto-clear it. We should preserve these messages that relate more to the new page, not the old page. <rdar://problem/20044957> 1076507 1 248470 joepeck 2015-03-11 17:50:00 -0700 Created attachment 248470 [PATCH] Proposed Fix I tried an approach using a marker ConsoleSession in the JavaScriptLogViewController. It quickly got more complex then this, and being yet-another-Session had styling issues that I couldn't figure out. This approach is far simpler and gives expected behavior with very few drawbacks given the rare cases it would occur. 1076637 2 248470 timothy 2015-03-12 08:25:46 -0700 Comment on attachment 248470 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=248470&action=review > Source/WebInspectorUI/ChangeLog:11 > + Detect a provisional load has started to start save messages that come in at this time. Whoa. Nice fix. > Source/WebInspectorUI/UserInterface/Views/LogContentView.js:33 > + // FIXME: Try to use a marker, instead of a list of messages that get re-added. Yeah, that would be good. Maybe the console rework can fix this. 1076644 3 248470 commit-queue 2015-03-12 09:10:31 -0700 Comment on attachment 248470 [PATCH] Proposed Fix Clearing flags on attachment: 248470 Committed r181437: <http://trac.webkit.org/changeset/181437> 1076645 4 commit-queue 2015-03-12 09:10:36 -0700 All reviewed patches have been landed. Closing bug. 248470 2015-03-11 17:50:00 -0700 2015-03-12 09:10:31 -0700 [PATCH] Proposed Fix provisional.patch text/plain 4448 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDM1NjhlOGMuLjk4MTJjMDkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE1LTAzLTExICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ29uc29s ZSBFcnJvcnMgZHVyaW5nIHByb3Zpc2lvbmFsIGRvY3VtZW50IGxvYWRzIGdldCBsb3N0IHdpdGgg IkNsZWFyIExvZyBvbiBSZWxvYWQiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDI2MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTG9nQ29udGVudFZpZXcuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcucHJvdG90eXBlLl9tZXNzYWdlQWRk ZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3LnByb3RvdHlwZS5fcHJv dmlzaW9uYWxMb2FkU3RhcnRlZCk6CisgICAgICAgIERldGVjdCBhIHByb3Zpc2lvbmFsIGxvYWQg aGFzIHN0YXJ0ZWQgdG8gc3RhcnQgc2F2ZSBtZXNzYWdlcyB0aGF0IGNvbWUgaW4gYXQgdGhpcyB0 aW1lLgorCisgICAgICAgIChXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcucHJvdG90eXBlLl9z ZXNzaW9uU3RhcnRlZCk6CisgICAgICAgIFJlYXBwZW5kIHByb3Zpc2lvbmFsIGxvYWQgbWVzc2Fn ZXMgaWYgd2UgYXV0by1jbGVhcmVkLgorCisgICAgICAgIChXZWJJbnNwZWN0b3IuTG9nQ29udGVu dFZpZXcucHJvdG90eXBlLl9yZWFwcGVuZFByb3Zpc2lvbmFsTWVzc2FnZXMpOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3LnByb3RvdHlwZS5fY2xlYXJQcm92aXNpb25hbFN0 YXRlKToKKyAgICAgICAgSGVscGVycyBmb3IgZGVhbGluZyB3aXRoIHRoZSBwcm92aXNpb25hbCBs b2FkaW5nIHN0YXRlLgorCisyMDE1LTAzLTExICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0Bh cHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ1NTIHBhcnNlciBlcnJvcnMgaW4g dGhlIGNvbnNvbGUgc2hvdWxkIGluY2x1ZGUgY29sdW1uIG51bWJlcnMKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExNDMxMwogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRW aWV3LmpzCmluZGV4IDY5YjJlNzYuLmZmNDk0ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzCkBA IC0zMCw2ICszMCw5IEBAIFdlYkluc3BlY3Rvci5Mb2dDb250ZW50VmlldyA9IGZ1bmN0aW9uKHJl cHJlc2VudGVkT2JqZWN0KQogICAgIHRoaXMuX25lc3RpbmdMZXZlbCA9IDA7CiAgICAgdGhpcy5f c2VsZWN0ZWRNZXNzYWdlcyA9IFtdOwogCisgICAgLy8gRklYTUU6IFRyeSB0byB1c2UgYSBtYXJr ZXIsIGluc3RlYWQgb2YgYSBsaXN0IG9mIG1lc3NhZ2VzIHRoYXQgZ2V0IHJlLWFkZGVkLgorICAg IHRoaXMuX3Byb3Zpc2lvbmFsTWVzc2FnZXMgPSBbXTsKKwogICAgIHRoaXMuZWxlbWVudC5jbGFz c0xpc3QuYWRkKFdlYkluc3BlY3Rvci5Mb2dDb250ZW50Vmlldy5TdHlsZUNsYXNzTmFtZSk7CiAK ICAgICB0aGlzLm1lc3NhZ2VzRWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIp OwpAQCAtODgsNiArOTEsOCBAQCBXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcgPSBmdW5jdGlv bihyZXByZXNlbnRlZE9iamVjdCkKICAgICBXZWJJbnNwZWN0b3IubG9nTWFuYWdlci5hZGRFdmVu dExpc3RlbmVyKFdlYkluc3BlY3Rvci5Mb2dNYW5hZ2VyLkV2ZW50Lk1lc3NhZ2VBZGRlZCwgdGhp cy5fbWVzc2FnZUFkZGVkLCB0aGlzKTsKICAgICBXZWJJbnNwZWN0b3IubG9nTWFuYWdlci5hZGRF dmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5Mb2dNYW5hZ2VyLkV2ZW50LlByZXZpb3VzTWVzc2Fn ZVJlcGVhdENvdW50VXBkYXRlZCwgdGhpcy5fcHJldmlvdXNNZXNzYWdlUmVwZWF0Q291bnRVcGRh dGVkLCB0aGlzKTsKICAgICBXZWJJbnNwZWN0b3IubG9nTWFuYWdlci5hZGRFdmVudExpc3RlbmVy KFdlYkluc3BlY3Rvci5Mb2dNYW5hZ2VyLkV2ZW50LkFjdGl2ZUxvZ0NsZWFyZWQsIHRoaXMuX2Fj dGl2ZUxvZ0NsZWFyZWQsIHRoaXMpOworCisgICAgV2ViSW5zcGVjdG9yLkZyYW1lLmFkZEV2ZW50 TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkZyYW1lLkV2ZW50LlByb3Zpc2lvbmFsTG9hZFN0YXJ0ZWQs IHRoaXMuX3Byb3Zpc2lvbmFsTG9hZFN0YXJ0ZWQsIHRoaXMpOwogfTsKIAogV2ViSW5zcGVjdG9y LkxvZ0NvbnRlbnRWaWV3LlNjb3BlcyA9IHsKQEAgLTMxMCwxNCArMzE1LDIwIEBAIFdlYkluc3Bl Y3Rvci5Mb2dDb250ZW50Vmlldy5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICBpZiAodGhp cy5fY2xlYXJMb2dPblJlbG9hZFNldHRpbmcudmFsdWUpICB7CiAgICAgICAgICAgICB0aGlzLl9j bGVhckxvZygpOworICAgICAgICAgICAgdGhpcy5fcmVhcHBlbmRQcm92aXNpb25hbE1lc3NhZ2Vz KCk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAogICAgICAgICB0aGlzLl9sb2dW aWV3Q29udHJvbGxlci5zdGFydE5ld1Nlc3Npb24oKTsKKworICAgICAgICB0aGlzLl9jbGVhclBy b3Zpc2lvbmFsU3RhdGUoKTsKICAgICB9LAogCiAgICAgX21lc3NhZ2VBZGRlZDogZnVuY3Rpb24o ZXZlbnQpCiAgICAgeworICAgICAgICBpZiAodGhpcy5fc3RhcnRlZFByb3Zpc2lvbmFsTG9hZCkK KyAgICAgICAgICAgIHRoaXMuX3Byb3Zpc2lvbmFsTWVzc2FnZXMucHVzaChldmVudC5kYXRhLm1l c3NhZ2UpOworCiAgICAgICAgIHZhciBtZXNzYWdlID0gdGhpcy5fbG9nVmlld0NvbnRyb2xsZXIu YXBwZW5kQ29uc29sZU1lc3NhZ2UoZXZlbnQuZGF0YS5tZXNzYWdlKTsKICAgICAgICAgaWYgKG1l c3NhZ2UudHlwZSAhPT0gV2ViSW5zcGVjdG9yLkNvbnNvbGVNZXNzYWdlLk1lc3NhZ2VUeXBlLkVu ZEdyb3VwKQogICAgICAgICAgICAgdGhpcy5fZmlsdGVyTWVzc2FnZXMoW21lc3NhZ2UudG9NZXNz YWdlRWxlbWVudCgpXSk7CkBAIC05NjksNiArOTgwLDMzIEBAIFdlYkluc3BlY3Rvci5Mb2dDb250 ZW50Vmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX3NlbGVjdGVkU2VhcmNoTWF0Y2gu aGlnaGxpZ2h0LmNsYXNzTGlzdC5hZGQoV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3LlNlbGVj dGVkU3R5bGVDbGFzc05hbWUpOwogCiAgICAgICAgIHRoaXMuX2Vuc3VyZU1lc3NhZ2VJc1Zpc2li bGUodGhpcy5fc2VsZWN0ZWRTZWFyY2hNYXRjaC5tZXNzYWdlKTsKKyAgICB9LAorCisgICAgX3By b3Zpc2lvbmFsTG9hZFN0YXJ0ZWQ6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHRoaXMuX3N0 YXJ0ZWRQcm92aXNpb25hbExvYWQgPSB0cnVlOworICAgIH0sCisKKyAgICBfcmVhcHBlbmRQcm92 aXNpb25hbE1lc3NhZ2VzOiBmdW5jdGlvbigpCisgICAgeworICAgICAgICBpZiAoIXRoaXMuX3N0 YXJ0ZWRQcm92aXNpb25hbExvYWQpCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgdGhp cy5fc3RhcnRlZFByb3Zpc2lvbmFsTG9hZCA9IGZhbHNlOworCisgICAgICAgIGZvciAodmFyIHBy b3Zpc2lvbmFsTWVzc2FnZSBvZiB0aGlzLl9wcm92aXNpb25hbE1lc3NhZ2VzKSB7CisgICAgICAg ICAgICB2YXIgbWVzc2FnZSA9IHRoaXMuX2xvZ1ZpZXdDb250cm9sbGVyLmFwcGVuZENvbnNvbGVN ZXNzYWdlKHByb3Zpc2lvbmFsTWVzc2FnZSk7CisgICAgICAgICAgICBpZiAobWVzc2FnZS50eXBl ICE9PSBXZWJJbnNwZWN0b3IuQ29uc29sZU1lc3NhZ2UuTWVzc2FnZVR5cGUuRW5kR3JvdXApCisg ICAgICAgICAgICAgICAgdGhpcy5fZmlsdGVyTWVzc2FnZXMoW21lc3NhZ2UudG9NZXNzYWdlRWxl bWVudCgpXSk7CisgICAgICAgIH0KKworICAgICAgICB0aGlzLl9wcm92aXNpb25hbE1lc3NhZ2Vz ID0gW107CisgICAgfSwKKworICAgIF9jbGVhclByb3Zpc2lvbmFsU3RhdGU6IGZ1bmN0aW9uKCkK KyAgICB7CisgICAgICAgIHRoaXMuX3N0YXJ0ZWRQcm92aXNpb25hbExvYWQgPSBmYWxzZTsKKyAg ICAgICAgdGhpcy5fcHJvdmlzaW9uYWxNZXNzYWdlcyA9IFtdOyAgICAgICAgCiAgICAgfQogfTsK IAo=