142595 2015-03-11 14:32:26 -0700 Users of Heap::deprecatedReportExtraMemory should switch to reportExtraMemoryAllocated+reportExtraMemoryVisited 2016-06-01 15:03:04 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified REOPENED https://bugs.webkit.org/show_bug.cgi?id=158274 P2 Normal --- 142457 1 ggaren ggaren cdumez fpizlo kling mhahnenb oldest_to_newest 1076442 0 ggaren 2015-03-11 14:32:26 -0700 This will reduce GC pressure when GenGC is successful. 1076490 1 248465 ggaren 2015-03-11 17:03:17 -0700 Created attachment 248465 Patch 1076491 2 248465 kling 2015-03-11 17:14:08 -0700 Comment on attachment 248465 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248465&action=review r=me > Source/WebCore/html/HTMLCanvasElement.h:138 > + size_t memoryCost() const; memoryCost() and not extraMemoryCost() seems like a mild misnomer, but it's not terribly important. 1076492 3 ggaren 2015-03-11 17:15:48 -0700 Committed r181415: <http://trac.webkit.org/changeset/181415> 1076493 4 ggaren 2015-03-11 17:16:15 -0700 Keeping this open to cover the non-canvas classes. 248465 2015-03-11 17:03:17 -0700 2015-03-11 17:14:08 -0700 Patch bug-142595-20150311170251.patch text/plain 3311 ggaren SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTQxNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE1LTAzLTExICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlcnMgb2YgSGVhcDo6ZGVw cmVjYXRlZFJlcG9ydEV4dHJhTWVtb3J5IHNob3VsZCBzd2l0Y2ggdG8gcmVwb3J0RXh0cmFNZW1v cnlBbGxvY2F0ZWQrcmVwb3J0RXh0cmFNZW1vcnlWaXNpdGVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI1OTUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCB0aGlzIGJ1ZyBmb3IgY2FudmFzLgor CisgICAgICAgICogaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MQ2FudmFzRWxlbWVudDo6bWVtb3J5Q29zdCk6IEZhY3RvcmVkIG91dCB0aGUgaGVscGVy IGZ1bmN0aW9uCisgICAgICAgIHJlcXVpcmVkIGJ5IG91ciBJREwgZ2VuZXJhdG9yLgorCisgICAg ICAgIChXZWJDb3JlOjpIVE1MQ2FudmFzRWxlbWVudDo6Y3JlYXRlSW1hZ2VCdWZmZXIpOiBVc2UK KyAgICAgICAgcmVwb3J0RXh0cmFNZW1vcnlBbGxvY2F0ZWQuCisKKyAgICAgICAgKiBodG1sL0hU TUxDYW52YXNFbGVtZW50Lmg6CisKKyAgICAgICAgKiBodG1sL0hUTUxDYW52YXNFbGVtZW50Lmlk bDogQWRvcHQgdGhlIElETCBmb3IgcmVwb3J0aW5nIGNvc3QgaW4gdGhlCisgICAgICAgIHJpZ2h0 IHdheSBkdXJpbmcgR0MuIFRoaXMgd2lsbCBtYXRjaCBvdXIgcmVwb3J0RXh0cmFNZW1vcnlBbGxv Y2F0ZWQKKyAgICAgICAgd2l0aCBhIHJlcG9ydEV4dHJhTWVtb3J5VmlzaXRlZCBkdXJpbmcgR0Mu CisKIDIwMTUtMDMtMTEgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNvbT4KIAogICAg ICAgICBBIG51bWJlciBvZiBtaW5vciBlZGl0cyB0byB0aGUgbWVkaWEgY29udHJvbHMgb24gT1NY LgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAJKHJldmlz aW9uIDE4MTQxMSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC01MzgsNiArNTM4LDEzIEBAIGJvb2wgSFRNTENhbnZhc0VsZW1l bnQ6OnNob3VsZEFjY2VsZXJhdGUKICNlbmRpZgogfQogCitzaXplX3QgSFRNTENhbnZhc0VsZW1l bnQ6Om1lbW9yeUNvc3QoKSBjb25zdAoreworICAgIGlmICghbV9pbWFnZUJ1ZmZlcikKKyAgICAg ICAgcmV0dXJuIDA7CisgICAgcmV0dXJuIDQgKiBtX2ltYWdlQnVmZmVyLT5pbnRlcm5hbFNpemUo KS53aWR0aCgpICogbV9pbWFnZUJ1ZmZlci0+aW50ZXJuYWxTaXplKCkuaGVpZ2h0KCk7Cit9CisK IHZvaWQgSFRNTENhbnZhc0VsZW1lbnQ6OmNyZWF0ZUltYWdlQnVmZmVyKCkgY29uc3QKIHsKICAg ICBBU1NFUlQoIW1faW1hZ2VCdWZmZXIpOwpAQCAtNTc1LDEwICs1ODIsNyBAQCB2b2lkIEhUTUxD YW52YXNFbGVtZW50OjpjcmVhdGVJbWFnZUJ1ZmZlCiAgICAgbV9jb250ZXh0U3RhdGVTYXZlciA9 IHN0ZDo6bWFrZV91bmlxdWU8R3JhcGhpY3NDb250ZXh0U3RhdGVTYXZlcj4oKm1faW1hZ2VCdWZm ZXItPmNvbnRleHQoKSk7CiAKICAgICBKU0M6OkpTTG9ja0hvbGRlciBsb2NrKHNjcmlwdEV4ZWN1 dGlvbkNvbnRleHQoKS0+dm0oKSk7Ci0gICAgc2l6ZV90IG51bUJ5dGVzID0gNCAqIG1faW1hZ2VC dWZmZXItPmludGVybmFsU2l6ZSgpLndpZHRoKCkgKiBtX2ltYWdlQnVmZmVyLT5pbnRlcm5hbFNp emUoKS5oZWlnaHQoKTsKLSAgICAvLyBGSVhNRTogQWRvcHQgcmVwb3J0RXh0cmFNZW1vcnlWaXNp dGVkLCBhbmQgc3dpdGNoIHRvIHJlcG9ydEV4dHJhTWVtb3J5QWxsb2NhdGVkLgotICAgIC8vIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI1OTUKLSAgICBzY3JpcHRF eGVjdXRpb25Db250ZXh0KCktPnZtKCkuaGVhcC5kZXByZWNhdGVkUmVwb3J0RXh0cmFNZW1vcnko bnVtQnl0ZXMpOworICAgIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKS0+dm0oKS5oZWFwLnJlcG9y dEV4dHJhTWVtb3J5QWxsb2NhdGVkKG1lbW9yeUNvc3QoKSk7CiAKICNpZiBVU0UoSU9TVVJGQUNF X0NBTlZBU19CQUNLSU5HX1NUT1JFKSB8fCBFTkFCTEUoQUNDRUxFUkFURURfMkRfQ0FOVkFTKQog ICAgIGlmIChtX2NvbnRleHQgJiYgbV9jb250ZXh0LT5pczJkKCkpCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5oCShyZXZpc2lvbiAxODE0MTApCisrKyBTb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTEzNSw2 ICsxMzUsOCBAQCBwdWJsaWM6CiAKICAgICBib29sIHNob3VsZEFjY2VsZXJhdGUoY29uc3QgSW50 U2l6ZSYpIGNvbnN0OwogCisgICAgc2l6ZV90IG1lbW9yeUNvc3QoKSBjb25zdDsKKwogcHJpdmF0 ZToKICAgICBIVE1MQ2FudmFzRWxlbWVudChjb25zdCBRdWFsaWZpZWROYW1lJiwgRG9jdW1lbnQm KTsKIApJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5pZGwKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5pZGwJKHJl dmlzaW9uIDE4MTQxMCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQu aWRsCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw2ICsyNiw3IEBACiAKIFsKICAgICBKU0dlbmVyYXRl VG9OYXRpdmVPYmplY3QsCisgICAgUmVwb3J0RXh0cmFNZW1vcnlDb3N0CiBdIGludGVyZmFjZSBI VE1MQ2FudmFzRWxlbWVudCA6IEhUTUxFbGVtZW50IHsKIAogICAgIGF0dHJpYnV0ZSBsb25nIHdp ZHRoOwo=