142586 2015-03-11 11:21:51 -0700 [Mac] Update fullscreen placeholder UI to use Vibrancy. 2015-03-11 13:28:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue webkit-bug-importer oldest_to_newest 1076377 0 jer.noble 2015-03-11 11:21:51 -0700 [Mac] Update fullscreen placeholder view to support Vibrancy. 1076380 1 248436 jer.noble 2015-03-11 11:43:58 -0700 Created attachment 248436 Patch 1076383 2 248436 eric.carlson 2015-03-11 11:47:47 -0700 Comment on attachment 248436 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248436&action=review > Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:61 > + _effectView.get().wantsLayer = YES; > + _effectView.get().autoresizesSubviews = YES; > + _effectView.get().autoresizingMask = NSViewWidthSizable | NSViewHeightSizable; > + _effectView.get().blendingMode = NSVisualEffectBlendingModeWithinWindow; > + _effectView.get().hidden = YES; > + _effectView.get().material = NSVisualEffectMaterialLight; > + _effectView.get().state = NSVisualEffectStateActive; Nit: that is a lot of ".get()."s > Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:72 > + _exitWarning = adoptNS([[NSTextField alloc] initWithFrame:NSZeroRect]); > + _exitWarning.get().autoresizingMask = NSViewMinXMargin | NSViewMaxXMargin | NSViewMinYMargin | NSViewMaxYMargin; > + _exitWarning.get().bordered = NO; > + _exitWarning.get().drawsBackground = NO; > + _exitWarning.get().editable = NO; > + _exitWarning.get().font = [NSFont systemFontOfSize:27]; > + _exitWarning.get().selectable = NO; > + _exitWarning.get().stringValue = clickToExitFullScreenText(); > + _exitWarning.get().textColor = [NSColor tertiaryLabelColor]; Ditto. 1076384 3 jer.noble 2015-03-11 11:48:35 -0700 (In reply to comment #2) > Comment on attachment 248436 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=248436&action=review > > > Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:61 > > + _effectView.get().wantsLayer = YES; > > + _effectView.get().autoresizesSubviews = YES; > > + _effectView.get().autoresizingMask = NSViewWidthSizable | NSViewHeightSizable; > > + _effectView.get().blendingMode = NSVisualEffectBlendingModeWithinWindow; > > + _effectView.get().hidden = YES; > > + _effectView.get().material = NSVisualEffectMaterialLight; > > + _effectView.get().state = NSVisualEffectStateActive; > > Nit: that is a lot of ".get()."s > > > Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm:72 > > + _exitWarning = adoptNS([[NSTextField alloc] initWithFrame:NSZeroRect]); > > + _exitWarning.get().autoresizingMask = NSViewMinXMargin | NSViewMaxXMargin | NSViewMinYMargin | NSViewMaxYMargin; > > + _exitWarning.get().bordered = NO; > > + _exitWarning.get().drawsBackground = NO; > > + _exitWarning.get().editable = NO; > > + _exitWarning.get().font = [NSFont systemFontOfSize:27]; > > + _exitWarning.get().selectable = NO; > > + _exitWarning.get().stringValue = clickToExitFullScreenText(); > > + _exitWarning.get().textColor = [NSColor tertiaryLabelColor]; > > Ditto. The alternative is (e.g.) [_exitWarning setBordered:NO] which is (underneath the hood) an equal number of get()s. 1076405 4 jer.noble 2015-03-11 12:44:18 -0700 <rdar://problem/20062753> 1076422 5 248436 commit-queue 2015-03-11 13:28:13 -0700 Comment on attachment 248436 Patch Clearing flags on attachment: 248436 Committed r181403: <http://trac.webkit.org/changeset/181403> 1076423 6 commit-queue 2015-03-11 13:28:17 -0700 All reviewed patches have been landed. Closing bug. 248436 2015-03-11 11:43:58 -0700 2015-03-11 13:28:13 -0700 Patch bug-142586-20150311114333.patch text/plain 6488 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2I0ODJhM2M4NzUwMmE0 OWNhMDM2OWI1NWZjZTdkZWI4M2M2NjBlNi4uYmQ4MzZlMDIyY2MwMWFhNjc3ODFhMGNhNDEwZWE4 MmQwNjE4NGQ3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE1LTAzLTExICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIFVwZGF0ZSBmdWxs c2NyZWVuIHBsYWNlaG9sZGVyIFVJIHRvIHVzZSBWaWJyYW5jeS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjU4NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSB0aGUgZnVsbHNjcmVlbiBwbGFj ZWhvbGRlciB3aXRoIGEgdHJhbnNsdWNlbnQgdmlicmFudCBhcHBlYXJhbmNlCisgICAgICAgIHVz aW5nIE5TVmlzdWFsRWZmZWN0Vmlldy4gU2luY2UgTlNWaXN1YUVmZmVjdFZpZXcgaXMgb25seSBh dmFpbGFibGUgZm9yCisgICAgICAgIE9TIFggMTAuMTAgYW5kIGFib3ZlLCB3cmFwIHRoZSBuZXcg aW1wbGVtZW50YXRpb24gaW4gYSB2ZXJzaW9uIGNoZWNrIGFuZAorICAgICAgICByZXRhaW4gdGhl IG9sZCBpbXBsZW1lbnRhdGlvbi4KKworICAgICAgICBEcml2ZS1ieTogVXBkYXRlIHRoZSBzdHJp bmdzIGZvciB0aGUgcGxhY2Vob2xkZXIgdmlldyB3aXRoIG5ldyBISSBndWlkYW5jZQorICAgICAg ICBhcyB3ZWxsLgorCisgICAgICAgICogRW5nbGlzaC5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdz OgorICAgICAgICAqIHBsYXRmb3JtL0xvY2FsaXplZFN0cmluZ3MuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Y2xpY2tUb0V4aXRGdWxsU2NyZWVuVGV4dCk6CisgICAgICAgICogcGxhdGZvcm0vbWFj L1dlYkNvcmVGdWxsU2NyZWVuUGxhY2Vob2xkZXJWaWV3Lmg6CisgICAgICAgICogcGxhdGZvcm0v bWFjL1dlYkNvcmVGdWxsU2NyZWVuUGxhY2Vob2xkZXJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJD b3JlRnVsbFNjcmVlblBsYWNlaG9sZGVyVmlldyBzZXRFeGl0V2FybmluZ1Zpc2libGU6XSk6CisK IDIwMTUtMDItMjggIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAg W1dLMl1bTWFjXSBGdWxsc2NyZWVuIGFuaW1hdGlvbnMgd2l0aCBtaXNtYXRjaGVkIGFzcGVjdCBy YXRpb3MgYXJlICJzcXVpc2hlZCIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9FbmdsaXNo Lmxwcm9qL0xvY2FsaXphYmxlLnN0cmluZ3MgYi9Tb3VyY2UvV2ViQ29yZS9FbmdsaXNoLmxwcm9q L0xvY2FsaXphYmxlLnN0cmluZ3MKaW5kZXggNzdmNDVkZmI3NjFiZTZkMTQzZTU0MGRhNWQzYzBh Yzc4ZjM3ZGJiNC4uMTk1NzQ2YzM2MjgwYTc1NzE0ZmVkZjIzM2E5OGJjZGM5MzFmNWIxNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvRW5nbGlzaC5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdz CisrKyBiL1NvdXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovTG9jYWxpemFibGUuc3RyaW5ncwpA QCAtMTY3LDcgKzE2Nyw3IEBACiAiQ2xlYXIgUmVjZW50IFNlYXJjaGVzIiA9ICJDbGVhciBSZWNl bnQgU2VhcmNoZXMiOwogCiAvKiBNZXNzYWdlIHRvIGRpc3BsYXkgaW4gYnJvd3NlciB3aW5kb3cg d2hlbiBpbiB3ZWJraXQgZnVsbCBzY3JlZW4gbW9kZS4gKi8KLSJDbGljayB0byBleGl0IGZ1bGwg c2NyZWVuIG1vZGUiID0gIkNsaWNrIHRvIGV4aXQgZnVsbCBzY3JlZW4gbW9kZSI7CisiQ2xpY2sg dG8gRXhpdCBGdWxsIFNjcmVlbiIgPSAiQ2xpY2sgdG8gRXhpdCBGdWxsIFNjcmVlbiI7CiAKIC8q IFN1YnRpdGxlIG9mIHRoZSBsYWJlbCB0byBzaG93IG9uIGEgc25hcHNob3R0ZWQgcGx1Zy1pbiAq LwogIkNsaWNrIHRvIHJlc3RhcnQiID0gIkNsaWNrIHRvIHJlc3RhcnQiOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9jYWxpemVkU3RyaW5ncy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9Mb2NhbGl6ZWRTdHJpbmdzLmNwcAppbmRleCBlY2JlNjBmNzAwY2JlOWNi NjZlNzk4MjljZjM0YTA0NTg3ZTU3ZTFkLi45M2QyZTkwNTMyMDMwMzEwNjg2MDljYTNjM2I1YmM3 ZjVjYTE5MmJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2NhbGl6ZWRT dHJpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2NhbGl6ZWRTdHJpbmdz LmNwcApAQCAtMTA1Niw3ICsxMDU2LDcgQEAgU3RyaW5nIHZhbGlkYXRpb25NZXNzYWdlQmFkSW5w dXRGb3JOdW1iZXJUZXh0KCkKIAogU3RyaW5nIGNsaWNrVG9FeGl0RnVsbFNjcmVlblRleHQoKQog ewotICAgIHJldHVybiBXRUJfVUlfU1RSSU5HKCJDbGljayB0byBleGl0IGZ1bGwgc2NyZWVuIG1v ZGUiLCAiTWVzc2FnZSB0byBkaXNwbGF5IGluIGJyb3dzZXIgd2luZG93IHdoZW4gaW4gd2Via2l0 IGZ1bGwgc2NyZWVuIG1vZGUuIik7CisgICAgcmV0dXJuIFdFQl9VSV9TVFJJTkcoIkNsaWNrIHRv IEV4aXQgRnVsbCBTY3JlZW4iLCAiTWVzc2FnZSB0byBkaXNwbGF5IGluIGJyb3dzZXIgd2luZG93 IHdoZW4gaW4gd2Via2l0IGZ1bGwgc2NyZWVuIG1vZGUuIik7CiB9CiAKICNpZiBFTkFCTEUoVklE RU9fVFJBQ0spCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29y ZUZ1bGxTY3JlZW5QbGFjZWhvbGRlclZpZXcuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21h Yy9XZWJDb3JlRnVsbFNjcmVlblBsYWNlaG9sZGVyVmlldy5oCmluZGV4IDZlNWViNDZkMWU3ZmE3 ODFkNDE5ODgzOGI5ZDhmMDBhOTA3YTAwNTcuLjc3MGY2NDU0NzBkNDc3NjEzOTIzYTI5NjdkMmQ1 MDc3NTQ5ZjlkYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJD b3JlRnVsbFNjcmVlblBsYWNlaG9sZGVyVmlldy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL21hYy9XZWJDb3JlRnVsbFNjcmVlblBsYWNlaG9sZGVyVmlldy5oCkBAIC0zMSw3ICszMSwx MiBAQAogI2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgogCiBXRUJDT1JFX0VYUE9SVCBAaW50ZXJm YWNlIFdlYkNvcmVGdWxsU2NyZWVuUGxhY2Vob2xkZXJWaWV3IDogTlNWaWV3IHsKKyNpZiBfX01B Q19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTAwMAorICAgIFJldGFpblB0cjxOU1Zp c3VhbEVmZmVjdFZpZXc+IF9lZmZlY3RWaWV3OworICAgIFJldGFpblB0cjxOU1RleHRGaWVsZD4g X2V4aXRXYXJuaW5nOworI2Vsc2UKICAgICBSZXRhaW5QdHI8TlNWaWV3PiBfZXhpdFdhcm5pbmc7 CisjZW5kaWYKICAgICBOU09iamVjdCogX3RhcmdldDsKICAgICBTRUwgX2FjdGlvbjsKIH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlRnVsbFNjcmVlblBs YWNlaG9sZGVyVmlldy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlRnVs bFNjcmVlblBsYWNlaG9sZGVyVmlldy5tbQppbmRleCAxM2Y1NjNlOTI4MWU3YTdjMmU3NWM2NjM2 YTNjOWYxNTU5YmZmOWNiLi42ZTZiZDk0NWE4MjYwNWI4YTI4YmMzMTY0MDg1MjNlMzMxYzk3MjU4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZUZ1bGxTY3Jl ZW5QbGFjZWhvbGRlclZpZXcubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dl YkNvcmVGdWxsU2NyZWVuUGxhY2Vob2xkZXJWaWV3Lm1tCkBAIC00NSw2ICs0NSwzOCBAQCB1c2lu ZyBuYW1lc3BhY2UgV2ViQ29yZTsKICAgICBpZiAoIXNlbGYpCiAgICAgICAgIHJldHVybiBuaWw7 CiAKKyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTAwMAorICAgIHNl bGYud2FudHNMYXllciA9IFlFUzsKKyAgICBzZWxmLmF1dG9yZXNpemVzU3Vidmlld3MgPSBZRVM7 CisgICAgc2VsZi5sYXllckNvbnRlbnRzUGxhY2VtZW50ID0gTlNWaWV3TGF5ZXJDb250ZW50c1Bs YWNlbWVudFRvcExlZnQ7CisgICAgc2VsZi5sYXllckNvbnRlbnRzUmVkcmF3UG9saWN5ID0gTlNW aWV3TGF5ZXJDb250ZW50c1JlZHJhd05ldmVyOworCisgICAgX2VmZmVjdFZpZXcgPSBhZG9wdE5T KFtbTlNWaXN1YWxFZmZlY3RWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOmZyYW1lUmVjdF0pOwor ICAgIF9lZmZlY3RWaWV3LmdldCgpLndhbnRzTGF5ZXIgPSBZRVM7CisgICAgX2VmZmVjdFZpZXcu Z2V0KCkuYXV0b3Jlc2l6ZXNTdWJ2aWV3cyA9IFlFUzsKKyAgICBfZWZmZWN0Vmlldy5nZXQoKS5h dXRvcmVzaXppbmdNYXNrID0gTlNWaWV3V2lkdGhTaXphYmxlIHwgTlNWaWV3SGVpZ2h0U2l6YWJs ZTsKKyAgICBfZWZmZWN0Vmlldy5nZXQoKS5ibGVuZGluZ01vZGUgPSBOU1Zpc3VhbEVmZmVjdEJs ZW5kaW5nTW9kZVdpdGhpbldpbmRvdzsKKyAgICBfZWZmZWN0Vmlldy5nZXQoKS5oaWRkZW4gPSBZ RVM7CisgICAgX2VmZmVjdFZpZXcuZ2V0KCkubWF0ZXJpYWwgPSBOU1Zpc3VhbEVmZmVjdE1hdGVy aWFsTGlnaHQ7CisgICAgX2VmZmVjdFZpZXcuZ2V0KCkuc3RhdGUgPSBOU1Zpc3VhbEVmZmVjdFN0 YXRlQWN0aXZlOworICAgIFtzZWxmIGFkZFN1YnZpZXc6X2VmZmVjdFZpZXcuZ2V0KCldOworCisg ICAgX2V4aXRXYXJuaW5nID0gYWRvcHROUyhbW05TVGV4dEZpZWxkIGFsbG9jXSBpbml0V2l0aEZy YW1lOk5TWmVyb1JlY3RdKTsKKyAgICBfZXhpdFdhcm5pbmcuZ2V0KCkuYXV0b3Jlc2l6aW5nTWFz ayA9IE5TVmlld01pblhNYXJnaW4gfCBOU1ZpZXdNYXhYTWFyZ2luIHwgTlNWaWV3TWluWU1hcmdp biB8IE5TVmlld01heFlNYXJnaW47CisgICAgX2V4aXRXYXJuaW5nLmdldCgpLmJvcmRlcmVkID0g Tk87CisgICAgX2V4aXRXYXJuaW5nLmdldCgpLmRyYXdzQmFja2dyb3VuZCA9IE5POworICAgIF9l eGl0V2FybmluZy5nZXQoKS5lZGl0YWJsZSA9IE5POworICAgIF9leGl0V2FybmluZy5nZXQoKS5m b250ID0gW05TRm9udCBzeXN0ZW1Gb250T2ZTaXplOjI3XTsKKyAgICBfZXhpdFdhcm5pbmcuZ2V0 KCkuc2VsZWN0YWJsZSA9IE5POworICAgIF9leGl0V2FybmluZy5nZXQoKS5zdHJpbmdWYWx1ZSA9 IGNsaWNrVG9FeGl0RnVsbFNjcmVlblRleHQoKTsKKyAgICBfZXhpdFdhcm5pbmcuZ2V0KCkudGV4 dENvbG9yID0gW05TQ29sb3IgdGVydGlhcnlMYWJlbENvbG9yXTsKKyAgICBbX2V4aXRXYXJuaW5n IHNpemVUb0ZpdF07CisKKyAgICBOU1JlY3Qgd2FybmluZ0ZyYW1lID0gW19leGl0V2FybmluZy5n ZXQoKSBmcmFtZV07CisgICAgd2FybmluZ0ZyYW1lLm9yaWdpbiA9IE5TTWFrZVBvaW50KChmcmFt ZVJlY3Quc2l6ZS53aWR0aCAtIHdhcm5pbmdGcmFtZS5zaXplLndpZHRoKSAvIDIsIGZyYW1lUmVj dC5zaXplLmhlaWdodCAvIDIpOworICAgIF9leGl0V2FybmluZy5nZXQoKS5mcmFtZSA9IHdhcm5p bmdGcmFtZTsKKyAgICBbX2VmZmVjdFZpZXcgYWRkU3VidmlldzpfZXhpdFdhcm5pbmcuZ2V0KCld OworI2Vsc2UKICAgICBbc2VsZiBzZXRMYXllcjpbQ0FMYXllciBsYXllcl1dOwogICAgIFtzZWxm IHNldExheWVyQ29udGVudHNSZWRyYXdQb2xpY3k6TlNWaWV3TGF5ZXJDb250ZW50c1JlZHJhd05l dmVyXTsKICAgICBbc2VsZiBzZXRXYW50c0xheWVyOllFU107CkBAIC01NSw2ICs4Nyw3IEBAIHVz aW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogICAgIFtfZXhpdFdhcm5pbmcuZ2V0KCkgc2V0RnJhbWU6 d2FybmluZ0ZyYW1lXTsKICAgICBbX2V4aXRXYXJuaW5nLmdldCgpIHNldEhpZGRlbjpZRVNdOwog ICAgIFtzZWxmIGFkZFN1YnZpZXc6X2V4aXRXYXJuaW5nLmdldCgpXTsKKyNlbmRpZgogCiAgICAg cmV0dXJuIHNlbGY7CiB9CkBAIC03NSw2ICsxMDgsOSBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29y ZTsKIAogLSAodm9pZClzZXRFeGl0V2FybmluZ1Zpc2libGU6KEJPT0wpdmlzaWJsZQogeworI2lm IF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMDAwCisgICAgW19lZmZlY3RW aWV3IHNldEhpZGRlbjohdmlzaWJsZV07CisjZWxzZQogICAgIFtfZXhpdFdhcm5pbmcuZ2V0KCkg c2V0SGlkZGVuOiF2aXNpYmxlXTsKICAgICBpZiAodmlzaWJsZSkgewogICAgICAgICBDQUZpbHRl ciogZmlsdGVyID0gW0NBRmlsdGVyIGZpbHRlcldpdGhUeXBlOkAiY29sb3JNb25vY2hyb21lIl07 CkBAIC04Myw2ICsxMTksNyBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKICAgICAgICAgW1tz ZWxmIGxheWVyXSBzZXRGaWx0ZXJzOltOU0FycmF5IGFycmF5V2l0aE9iamVjdDpmaWx0ZXJdXTsK ICAgICB9IGVsc2UKICAgICAgICAgW1tzZWxmIGxheWVyXSBzZXRGaWx0ZXJzOm5pbF07CisjZW5k aWYKIH0KIAogLSAodm9pZCltb3VzZURvd246KE5TRXZlbnQgKil0aGVFdmVudAo=