142578 2015-03-11 06:16:40 -0700 [WinCairo] Crash when leaving page while video is playing. 2015-03-26 03:07:59 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen arcoun bfulgham commit-queue ossy oldest_to_newest 1076301 0 peavo 2015-03-11 06:16:40 -0700 I'm sometimes getting a crash when leaving a page, while a video is playing. This can happen when there is an asynchronous event invoked from a worker thread, accessing the media player object after it has been deleted. 1076304 1 248417 peavo 2015-03-11 06:26:12 -0700 Created attachment 248417 Patch 1078876 2 peavo 2015-03-20 10:15:13 -0700 Thanks for reviewing :) 1078894 3 248417 commit-queue 2015-03-20 10:54:10 -0700 Comment on attachment 248417 Patch Clearing flags on attachment: 248417 Committed r181805: <http://trac.webkit.org/changeset/181805> 1078895 4 commit-queue 2015-03-20 10:54:14 -0700 All reviewed patches have been landed. Closing bug. 1080246 5 arcoun 2015-03-26 03:07:59 -0700 I don't know if it is related but I have created bug 143088 for a crash when page is left/closed while video is loading (not yet playing). 248417 2015-03-11 06:26:12 -0700 2015-03-20 10:54:10 -0700 Patch bug-142578-20150311142544.patch text/plain 6603 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTM4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE1LTAzLTExICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIENyYXNo IHdoZW4gbGVhdmluZyBwYWdlIHdoaWxlIHZpZGVvIGlzIHBsYXlpbmcuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI1NzgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGNhbiBoYXBwZW4gd2hlbiB0 aGVyZSBpcyBhbiBhc3luY2hyb25vdXMgZXZlbnQgaW52b2tlZCBmcm9tIGEgdmlkZW8gd29ya2Vy CisgICAgICAgIHRocmVhZCwgYWNjZXNzaW5nIHRoZSBtZWRpYSBwbGF5ZXIgb2JqZWN0IGFmdGVy IGl0IGhhcyBiZWVuIGRlbGV0ZWQuCisgICAgICAgIFRoaXMgaXMgc29sdmVkIGJ5IHJlc2V0dGlu ZyB0aGUgbWVkaWEgcGxheWVyIHBvaW50ZXIgaW4gdGhlIGV2ZW50IG9iamVjdCwKKyAgICAgICAg d2hlbiB0aGUgbWVkaWEgcGxheWVyIGlzIGRlbGV0ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy93aW4vTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6fk1lZGlhUGxh eWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXll clByaXZhdGVNZWRpYUZvdW5kYXRpb246OmFkZExpc3RlbmVyKToKKyAgICAgICAgKFdlYkNvcmU6 Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6cmVtb3ZlTGlzdGVuZXIpOgorICAg ICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uOjpub3RpZnlE ZWxldGVkKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRh dGlvbjo6QXN5bmNDYWxsYmFjazo6QXN5bmNDYWxsYmFjayk6CisgICAgICAgIChXZWJDb3JlOjpN ZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OkFzeW5jQ2FsbGJhY2s6On5Bc3luY0Nh bGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRh dGlvbjo6QXN5bmNDYWxsYmFjazo6SW52b2tlKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxh eWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6QXN5bmNDYWxsYmFjazo6b25NZWRpYVBsYXllckRl bGV0ZWQpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZh dGVNZWRpYUZvdW5kYXRpb24uaDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0 ZU1lZGlhRm91bmRhdGlvbjo6TWVkaWFQbGF5ZXJMaXN0ZW5lcjo6TWVkaWFQbGF5ZXJMaXN0ZW5l cik6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246 Ok1lZGlhUGxheWVyTGlzdGVuZXI6On5NZWRpYVBsYXllckxpc3RlbmVyKToKKyAgICAgICAgKFdl YkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6TWVkaWFQbGF5ZXJMaXN0 ZW5lcjo6b25NZWRpYVBsYXllckRlbGV0ZWQpOgorCiAyMDE1LTAzLTEwICBQaGlsaXBwZSBOb3Jt YW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZW5hbWUgTWVkaWFTdHJlYW1D ZW50ZXIgdG8gUmVhbHRpbWVNZWRpYVNvdXJjZUNlbnRlcgpJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01l ZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5jcHAJKHJldmlzaW9uIDE4MTM4NCkKKysr IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVN ZWRpYUZvdW5kYXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NSw2ICs3NSw3IEBAIE1lZGlh UGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6TWVkaWEKIAogTWVkaWFQbGF5ZXJQcml2YXRl TWVkaWFGb3VuZGF0aW9uOjp+TWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uKCkKIHsK KyAgICBub3RpZnlEZWxldGVkKCk7CiAgICAgZGVzdHJveVZpZGVvV2luZG93KCk7CiAgICAgZW5k U2Vzc2lvbigpOwogfQpAQCAtNDc3LDYgKzQ3OCwyOCBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0 ZU1lZGlhRm91bmRhdGlvbjo6CiAgICAgfQogfQogCit2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZU1l ZGlhRm91bmRhdGlvbjo6YWRkTGlzdGVuZXIoTWVkaWFQbGF5ZXJMaXN0ZW5lciogbGlzdGVuZXIp Cit7CisgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fbXV0ZXhMaXN0ZW5lcnMpOworCisgICAgbV9s aXN0ZW5lcnMuYWRkKGxpc3RlbmVyKTsKK30KKwordm9pZCBNZWRpYVBsYXllclByaXZhdGVNZWRp YUZvdW5kYXRpb246OnJlbW92ZUxpc3RlbmVyKE1lZGlhUGxheWVyTGlzdGVuZXIqIGxpc3RlbmVy KQoreworICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX211dGV4TGlzdGVuZXJzKTsKKworICAgIG1f bGlzdGVuZXJzLnJlbW92ZShsaXN0ZW5lcik7Cit9CisKK3ZvaWQgTWVkaWFQbGF5ZXJQcml2YXRl TWVkaWFGb3VuZGF0aW9uOjpub3RpZnlEZWxldGVkKCkKK3sKKyAgICBNdXRleExvY2tlciBsb2Nr ZXIobV9tdXRleExpc3RlbmVycyk7CisKKyAgICBmb3IgKEhhc2hTZXQ8TWVkaWFQbGF5ZXJMaXN0 ZW5lcio+Ojpjb25zdF9pdGVyYXRvciBpdCA9IG1fbGlzdGVuZXJzLmJlZ2luKCk7IGl0ICE9IG1f bGlzdGVuZXJzLmVuZCgpOyArK2l0KQorICAgICAgICAoKml0KS0+b25NZWRpYVBsYXllckRlbGV0 ZWQoKTsKK30KKwogYm9vbCBNZWRpYVBsYXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OmNyZWF0 ZU91dHB1dE5vZGUoQ09NUHRyPElNRlN0cmVhbURlc2NyaXB0b3I+IHNvdXJjZVNELCBDT01QdHI8 SU1GVG9wb2xvZ3lOb2RlPiYgbm9kZSkKIHsKICAgICBpZiAoIU1GQ3JlYXRlVG9wb2xvZ3lOb2Rl UHRyKCkgfHwgIU1GQ3JlYXRlQXVkaW9SZW5kZXJlckFjdGl2YXRlUHRyKCkgfHwgIU1GQ3JlYXRl VmlkZW9SZW5kZXJlckFjdGl2YXRlUHRyKCkpCkBAIC01OTMsMTAgKzYxNiwxNCBAQCBNZWRpYVBs YXllclByaXZhdGVNZWRpYUZvdW5kYXRpb246OkFzeW5jCiAgICAgLCBtX21lZGlhUGxheWVyKG1l ZGlhUGxheWVyKQogICAgICwgbV9ldmVudChldmVudCkKIHsKKyAgICBpZiAobV9tZWRpYVBsYXll cikKKyAgICAgICAgbV9tZWRpYVBsYXllci0+YWRkTGlzdGVuZXIodGhpcyk7CiB9CiAKIE1lZGlh UGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbjo6QXN5bmNDYWxsYmFjazo6fkFzeW5jQ2FsbGJh Y2soKQogeworICAgIGlmIChtX21lZGlhUGxheWVyKQorICAgICAgICBtX21lZGlhUGxheWVyLT5y ZW1vdmVMaXN0ZW5lcih0aGlzKTsKIH0KIAogSFJFU1VMVCBNZWRpYVBsYXllclByaXZhdGVNZWRp YUZvdW5kYXRpb246OkFzeW5jQ2FsbGJhY2s6OlF1ZXJ5SW50ZXJmYWNlKFJFRklJRCByaWlkLCBf X1JQQ19fZGVyZWZfb3V0IHZvaWQgX19SUENfRkFSICpfX1JQQ19GQVIgKnBwdk9iamVjdCkKQEAg LTYzMyw2ICs2NjAsMTEgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBNZWRpYVBsYXllclBy aQogCiBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91 bmRhdGlvbjo6QXN5bmNDYWxsYmFjazo6SW52b2tlKF9fUlBDX19pbl9vcHQgSU1GQXN5bmNSZXN1 bHQgKnBBc3luY1Jlc3VsdCkKIHsKKyAgICBNdXRleExvY2tlciBsb2NrZXIobV9tdXRleCk7CisK KyAgICBpZiAoIW1fbWVkaWFQbGF5ZXIpCisgICAgICAgIHJldHVybiBTX09LOworCiAgICAgaWYg KG1fZXZlbnQpCiAgICAgICAgIG1fbWVkaWFQbGF5ZXItPmVuZEdldEV2ZW50KHBBc3luY1Jlc3Vs dCk7CiAgICAgZWxzZQpAQCAtNjQxLDYgKzY3MywxMyBAQCBIUkVTVUxUIFNURE1FVEhPRENBTExU WVBFIE1lZGlhUGxheWVyUHJpCiAgICAgcmV0dXJuIFNfT0s7CiB9CiAKK3ZvaWQgTWVkaWFQbGF5 ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uOjpBc3luY0NhbGxiYWNrOjpvbk1lZGlhUGxheWVyRGVs ZXRlZCgpCit7CisgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fbXV0ZXgpOworCisgICAgbV9tZWRp YVBsYXllciA9IG51bGxwdHI7Cit9CisKIH0KIAogI2VuZGlmCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9u LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01l ZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbi5oCShyZXZpc2lvbiAxODEzODQpCisrKyBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vTWVkaWFQbGF5ZXJQcml2YXRlTWVk aWFGb3VuZGF0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTMxLDYgKzMxLDggQEAKICNpbmNsdWRl IDxNZmlkbC5oPgogI2luY2x1ZGUgPGV2ci5oPgogCisjaW5jbHVkZSA8d3RmL1RocmVhZGluZ1By aW1pdGl2ZXMuaD4KKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBNZWRpYVBsYXllclBy aXZhdGVNZWRpYUZvdW5kYXRpb24gOiBwdWJsaWMgTWVkaWFQbGF5ZXJQcml2YXRlSW50ZXJmYWNl IHsKQEAgLTgzLDYgKzg1LDEwIEBAIHByaXZhdGU6CiAgICAgTWVkaWFQbGF5ZXI6OlJlYWR5U3Rh dGUgbV9yZWFkeVN0YXRlOwogICAgIEZsb2F0UmVjdCBtX2xhc3RQYWludFJlY3Q7CiAKKyAgICBj bGFzcyBNZWRpYVBsYXllckxpc3RlbmVyOworICAgIEhhc2hTZXQ8TWVkaWFQbGF5ZXJMaXN0ZW5l cio+IG1fbGlzdGVuZXJzOworICAgIE11dGV4IG1fbXV0ZXhMaXN0ZW5lcnM7CisKICAgICBDT01Q dHI8SU1GTWVkaWFTZXNzaW9uPiBtX21lZGlhU2Vzc2lvbjsKICAgICBDT01QdHI8SU1GU291cmNl UmVzb2x2ZXI+IG1fc291cmNlUmVzb2x2ZXI7CiAgICAgQ09NUHRyPElNRk1lZGlhU291cmNlPiBt X21lZGlhU291cmNlOwpAQCAtMTA3LDkgKzExMywyMSBAQCBwcml2YXRlOgogICAgIHZvaWQgY3Jl YXRlVmlkZW9XaW5kb3coKTsKICAgICB2b2lkIGRlc3Ryb3lWaWRlb1dpbmRvdygpOwogCisgICAg dm9pZCBhZGRMaXN0ZW5lcihNZWRpYVBsYXllckxpc3RlbmVyKik7CisgICAgdm9pZCByZW1vdmVM aXN0ZW5lcihNZWRpYVBsYXllckxpc3RlbmVyKik7CisgICAgdm9pZCBub3RpZnlEZWxldGVkKCk7 CisKICAgICBzdGF0aWMgTFJFU1VMVCBDQUxMQkFDSyBWaWRlb1ZpZXdXbmRQcm9jKEhXTkQgaFdu ZCwgVUlOVCBtZXNzYWdlLCBXUEFSQU0gd1BhcmFtLCBMUEFSQU0gbFBhcmFtKTsKIAotICAgIGNs YXNzIEFzeW5jQ2FsbGJhY2sgOiBwdWJsaWMgSU1GQXN5bmNDYWxsYmFjayB7CisgICAgY2xhc3Mg TWVkaWFQbGF5ZXJMaXN0ZW5lciB7CisgICAgcHVibGljOgorICAgICAgICBNZWRpYVBsYXllckxp c3RlbmVyKCkgeyB9CisgICAgICAgIHZpcnR1YWwgfk1lZGlhUGxheWVyTGlzdGVuZXIoKSB7IH0K KworICAgICAgICB2aXJ0dWFsIHZvaWQgb25NZWRpYVBsYXllckRlbGV0ZWQoKSB7IH0KKyAgICB9 OworCisgICAgY2xhc3MgQXN5bmNDYWxsYmFjayA6IHB1YmxpYyBJTUZBc3luY0NhbGxiYWNrLCBw dWJsaWMgTWVkaWFQbGF5ZXJMaXN0ZW5lciB7CiAgICAgcHVibGljOgogICAgICAgICBBc3luY0Nh bGxiYWNrKE1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhRm91bmRhdGlvbiosIGJvb2wgZXZlbnQpOwog ICAgICAgICB+QXN5bmNDYWxsYmFjaygpOwpAQCAtMTIxLDEwICsxMzksMTMgQEAgcHJpdmF0ZToK ICAgICAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIEdldFBhcmFtZXRlcnMo X19SUENfX291dCBEV09SRCAqcGR3RmxhZ3MsIF9fUlBDX19vdXQgRFdPUkQgKnBkd1F1ZXVlKSBv dmVycmlkZTsKICAgICAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIEludm9r ZShfX1JQQ19faW5fb3B0IElNRkFzeW5jUmVzdWx0ICpwQXN5bmNSZXN1bHQpIG92ZXJyaWRlOwog CisgICAgICAgIHZpcnR1YWwgdm9pZCBvbk1lZGlhUGxheWVyRGVsZXRlZCgpIG92ZXJyaWRlOwor CiAgICAgcHJpdmF0ZToKICAgICAgICAgVUxPTkcgbV9yZWZDb3VudDsKICAgICAgICAgTWVkaWFQ bGF5ZXJQcml2YXRlTWVkaWFGb3VuZGF0aW9uKiBtX21lZGlhUGxheWVyOwogICAgICAgICBib29s IG1fZXZlbnQ7CisgICAgICAgIE11dGV4IG1fbXV0ZXg7CiAgICAgfTsKIAogfTsK