142577 2015-03-11 06:07:10 -0700 [CMake][GStreamer] Building EFL or GTK with ENABLE_VIDEO and without ENABLE_WEB_AUDIO is broken. 2015-03-11 07:00:51 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez andersca cgarcia commit-queue jonathon mrobinson ossy pnormand sam oldest_to_newest 1076298 0 clopez 2015-03-11 06:07:10 -0700 Building EFL or GTK with -DENABLE_WEB_AUDIO=OFF is broken (ENABLE_VIDEO is by default on) because the linker needs the flag -lgstaudio-1.0 due to the included functions of gst_stream_volume_get_volume/gst_stream_volume_set_volume/gst_stream_volume_get_type on MediaPlayerPrivateGStreamerBase.cpp when ENABLE_VIDEO is active, and this flag is only used when WEB_AUDIO is also enabled (the default). This is the error: $ Tools/Scripts/build-webkit --gtk --release --cmakeargs='-DENABLE_WEB_AUDIO=OFF' FAILED: : && /usr/lib/ccache/clang++ -fPIC -std=c++11 -Qunused-arguments -O3 -DNDEBUG -fno-exceptions -fno-strict-aliasing -fno-rtti -Wl,--no-undefined -L/home/clopez/webkit/webkit/WebKitBuild/DependenciesGTK/Root/lib64 -fuse-ld=gold -Wl,--disable-new-dtags -fuse-ld=gold -Wl,--disable-new-dtags -shared -Wl,-soname,libwebkit2gtk-4.0.so.37 -o lib/libwebkit2gtk-4.0.so.37.5.0 @CMakeFiles/WebKit2.rsp && : lib/libWebCoreGTK.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp.o):-:function WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin(): error: undefined reference to 'gst_stream_volume_get_type' lib/libWebCoreGTK.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp.o):-:function WebCore::MediaPlayerPrivateGStreamerBase::setVolume(float): error: undefined reference to 'gst_stream_volume_set_volume' lib/libWebCoreGTK.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp.o):-:function WebCore::MediaPlayerPrivateGStreamerBase::volume() const: error: undefined reference to 'gst_stream_volume_get_volume' lib/libWebCoreGTK.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp.o):-:function WebCore::MediaPlayerPrivateGStreamerBase::notifyPlayerOfVolumeChange(): error: undefined reference to 'gst_stream_volume_get_volume' lib/libWebCoreGTK.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp.o):-:function WebCore::mediaPlayerPrivateVolumeChangedCallback(_GObject*, _GParamSpec*, WebCore::MediaPlayerPrivateGStreamerBase*): error: undefined reference to 'gst_stream_volume_get_volume' clang: error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed. The commit that added that functions to MediaPlayerPrivateGStreamerBase.cpp is r142005 <http://trac.webkit.org/r142005>. 1076299 1 248415 clopez 2015-03-11 06:10:11 -0700 Created attachment 248415 Patch 1076302 2 248415 cgarcia 2015-03-11 06:16:58 -0700 Comment on attachment 248415 Patch It makes sense. Thanks! 1076306 3 248415 commit-queue 2015-03-11 07:00:45 -0700 Comment on attachment 248415 Patch Clearing flags on attachment: 248415 Committed r181385: <http://trac.webkit.org/changeset/181385> 1076307 4 commit-queue 2015-03-11 07:00:51 -0700 All reviewed patches have been landed. Closing bug. 248415 2015-03-11 06:10:11 -0700 2015-03-11 07:00:45 -0700 Patch bug-142577-20150311140946.patch text/plain 2804 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMzczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjYxYmM0MTkwN2IzYTZk YTY5NmE0MWI0ZDJiOTRmMTFkOTRmNjQyOC4uOGE1YjAxYTZjYWE5ODQ0YTdjZmE1ODA1NzE4M2Qx N2I0ZWE5ODA5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTExICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtD TWFrZV1bR1N0cmVhbWVyXSBCdWlsZGluZyBFRkwgb3IgR1RLIHdpdGggRU5BQkxFX1ZJREVPIGFu ZCB3aXRob3V0IEVOQUJMRV9XRUJfQVVESU8gaXMgYnJva2VuLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyNTc3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGlzIGlzIGEgYnVp bGQgZml4LgorCisgICAgICAgICogUGxhdGZvcm1FZmwuY21ha2U6IEluY2x1ZGUgR1NUUkVBTUVS X0FVRElPX0xJQlJBUklFUyBvbiB0aGUgbGluayBzdGVwIGJvdGggZm9yIEVOQUJMRV9WSURFTyBh bmQgRU5BQkxFX1dFQl9BVURJTy4KKyAgICAgICAgKiBQbGF0Zm9ybUdUSy5jbWFrZTogSWRlbS4K KwogMjAxNS0wMy0xMCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAK ICAgICAgICAgUmVuYW1lIE1lZGlhU3RyZWFtQ2VudGVyIHRvIFJlYWx0aW1lTWVkaWFTb3VyY2VD ZW50ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlIGIvU291 cmNlL1dlYkNvcmUvUGxhdGZvcm1FZmwuY21ha2UKaW5kZXggNjFkZTcyNjRjYzhjNWNmNjczYjhl NDQ0YTRiYTRlMWFhNzgyMjkxMC4uZGNlMzY3MGJjMzU1ZmY3NmJhODhlYjgxM2MyNTQ0NTUzNTYz OWI1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1FZmwuY21ha2UKKysrIGIv U291cmNlL1dlYkNvcmUvUGxhdGZvcm1FZmwuY21ha2UKQEAgLTM0Nyw2ICszNDcsNyBAQCBpZiAo RU5BQkxFX1ZJREVPIE9SIEVOQUJMRV9XRUJfQVVESU8pCiAgICAgICAgICR7R1NUUkVBTUVSX0JB U0VfTElCUkFSSUVTfQogICAgICAgICAke0dTVFJFQU1FUl9MSUJSQVJJRVN9CiAgICAgICAgICR7 R1NUUkVBTUVSX1BCVVRJTFNfTElCUkFSSUVTfQorICAgICAgICAke0dTVFJFQU1FUl9BVURJT19M SUJSQVJJRVN9CiAgICAgKQogICAgICMgQXZvaWRpbmcgYSBHTGliIGRlcHJlY2F0aW9uIHdhcm5p bmcgZHVlIHRvIEdTdHJlYW1lciBBUEkgdXNpbmcgZGVwcmVjYXRlZCBjbGFzc2VzLgogICAgIHNl dF9zb3VyY2VfZmlsZXNfcHJvcGVydGllcyhwbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0 V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3BwIFBST1BFUlRJRVMgQ09NUElMRV9ERUZJTklUSU9O UyAiR0xJQl9ESVNBQkxFX0RFUFJFQ0FUSU9OX1dBUk5JTkdTPTEiKQpAQCAtNDI4LDcgKzQyOSw2 IEBAIGlmIChFTkFCTEVfV0VCX0FVRElPKQogICAgICAgICAke0dTVFJFQU1FUl9GRlRfSU5DTFVE RV9ESVJTfQogICAgICkKICAgICBsaXN0KEFQUEVORCBXZWJDb3JlX0xJQlJBUklFUwotICAgICAg ICAke0dTVFJFQU1FUl9BVURJT19MSUJSQVJJRVN9CiAgICAgICAgICR7R1NUUkVBTUVSX0ZGVF9M SUJSQVJJRVN9CiAgICAgKQogICAgIHNldChXRUJfQVVESU9fRElSICR7Q01BS0VfSU5TVEFMTF9Q UkVGSVh9LyR7REFUQV9JTlNUQUxMX0RJUn0vd2ViYXVkaW8vcmVzb3VyY2VzKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0 Zm9ybUdUSy5jbWFrZQppbmRleCA4NDg5ZDlmZThmOGJlZmFhOGViMWUxYjVhYWQxNTdkYzgzZmJh Yzg5Li40NTI2YzA2NjhiOTYzMDMxOTM0NDQzODczMDM1ODU5MjA5MjAzYTYzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9Q bGF0Zm9ybUdUSy5jbWFrZQpAQCAtMzIxLDYgKzMyMSw3IEBAIGlmIChFTkFCTEVfVklERU8gT1Ig RU5BQkxFX1dFQl9BVURJTykKICAgICAgICAgJHtHU1RSRUFNRVJfQkFTRV9MSUJSQVJJRVN9CiAg ICAgICAgICR7R1NUUkVBTUVSX0xJQlJBUklFU30KICAgICAgICAgJHtHU1RSRUFNRVJfUEJVVElM U19MSUJSQVJJRVN9CisgICAgICAgICR7R1NUUkVBTUVSX0FVRElPX0xJQlJBUklFU30KICAgICAp CiAgICAgIyBBdm9pZGluZyBhIEdMaWIgZGVwcmVjYXRpb24gd2FybmluZyBkdWUgdG8gR1N0cmVh bWVyIEFQSSB1c2luZyBkZXByZWNhdGVkIGNsYXNzZXMuCiAgICAgc2V0X3NvdXJjZV9maWxlc19w cm9wZXJ0aWVzKHBsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9XZWJLaXRXZWJBdWRpb1NvdXJjZUdT dHJlYW1lci5jcHAgUFJPUEVSVElFUyBDT01QSUxFX0RFRklOSVRJT05TICJHTElCX0RJU0FCTEVf REVQUkVDQVRJT05fV0FSTklOR1M9MSIpCkBAIC0zNTQsNyArMzU1LDYgQEAgaWYgKEVOQUJMRV9X RUJfQVVESU8pCiAgICAgICAgICR7R1NUUkVBTUVSX0ZGVF9JTkNMVURFX0RJUlN9CiAgICAgKQog ICAgIGxpc3QoQVBQRU5EIFdlYkNvcmVfTElCUkFSSUVTCi0gICAgICAgICR7R1NUUkVBTUVSX0FV RElPX0xJQlJBUklFU30KICAgICAgICAgJHtHU1RSRUFNRVJfRkZUX0xJQlJBUklFU30KICAgICAp CiBlbmRpZiAoKQo=