142576 2015-03-11 04:51:32 -0700 [GTK] Add support for handling TLS errors to MiniBrowser 2015-03-11 12:14:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned clopez commit-queue gustavo pnormand zan oldest_to_newest 1076288 0 cgarcia 2015-03-11 04:51:32 -0700 It's useful for testing TLS errors handling itself, but also to allow ignoring TLS errors when testing. 1076289 1 248412 cgarcia 2015-03-11 04:52:53 -0700 Created attachment 248412 Patch 1076290 2 commit-queue 2015-03-11 04:55:37 -0700 Attachment 248412 did not pass style-queue: ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:374: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:375: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:376: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:377: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1076291 3 248413 cgarcia 2015-03-11 04:57:12 -0700 Created attachment 248413 Fix coding style issues 1076314 4 248413 svillar 2015-03-11 07:44:18 -0700 Comment on attachment 248413 Fix coding style issues View in context: https://bugs.webkit.org/attachment.cgi?id=248413&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:374 > + GTK_MESSAGE_QUESTION, GTK_BUTTONS_YES_NO, "%s", "Unacceptable TLS Certificate"); /Unacceptable/Invalid/ ? 1076333 5 clopez 2015-03-11 08:58:34 -0700 BTW. I think we also need a switch to completely disable certificate validation. Otherwise URLs that embed content from sites with invalid certs don't work. Example: http://people.igalia.com/clopez/testssl.html 1076390 6 cgarcia 2015-03-11 12:14:56 -0700 Committed r181399: <http://trac.webkit.org/changeset/181399> 248412 2015-03-11 04:52:53 -0700 2015-03-11 04:57:12 -0700 Patch mb-tls-errors.diff text/plain 3234 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2OGMy ODk2Li41OTRkM2YzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTUtMDMtMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEFkZCBzdXBwb3J0IGZvciBo YW5kbGluZyBUTFMgZXJyb3JzIHRvIE1pbmlCcm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI1NzYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCdzIHVzZWZ1bCBmb3IgdGVzdGluZyBUTFMgZXJy b3JzIGhhbmRsaW5nIGl0c2VsZiwgYnV0IGFsc28gdG8KKyAgICAgICAgYWxsb3cgaWdub3Jpbmcg VExTIGVycm9ycyB3aGVuIHRlc3RpbmcuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9ndGsvQnJv d3NlcldpbmRvdy5jOgorICAgICAgICAod2ViVmlld0xvYWRGYWlsZWRXaXRoVExTZXJyb3JzKToK KyAgICAgICAgKGJyb3dzZXJXaW5kb3dDb25zdHJ1Y3RlZCk6CisKIDIwMTUtMDMtMDYgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFRl c3QgL3dlYmtpdDIvV2ViS2l0V2ViVmlldy9zeW5jLXJlcXVlc3Qtb24tbWF4LWNvbm5zIG1pZ2h0 IGZhaWwgYWZ0ZXIgZmluaXNoZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9C cm93c2VyV2luZG93LmMgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCmlu ZGV4IDE4ZGQ0NWEuLjRjYzEyNzEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9C cm93c2VyV2luZG93LmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cu YwpAQCAtMzY4LDYgKzM2OCwyNyBAQCBzdGF0aWMgZ2Jvb2xlYW4gd2ViVmlld0xvYWRGYWlsZWQo V2ViS2l0V2ViVmlldyAqd2ViVmlldywgV2ViS2l0TG9hZEV2ZW50IGxvYWRFdgogICAgIHJldHVy biBGQUxTRTsKIH0KIAorc3RhdGljIGdib29sZWFuIHdlYlZpZXdMb2FkRmFpbGVkV2l0aFRMU2Vy cm9ycyhXZWJLaXRXZWJWaWV3ICp3ZWJWaWV3LCBjb25zdCBjaGFyICpmYWlsaW5nVVJJLCBHVGxz Q2VydGlmaWNhdGUgKmNlcnRpZmljYXRlLCBHVGxzQ2VydGlmaWNhdGVGbGFncyBlcnJvcnMsIEJy b3dzZXJXaW5kb3cgKndpbmRvdykKK3sKKyAgICBHdGtXaWRnZXQgKmRpYWxvZyA9IGd0a19tZXNz YWdlX2RpYWxvZ19uZXcoR1RLX1dJTkRPVyh3aW5kb3cpLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBHVEtfRElBTE9HX01PREFMIHwgR1RLX0RJQUxPR19E RVNUUk9ZX1dJVEhfUEFSRU5ULAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBHVEtfTUVTU0FHRV9RVUVTVElPTiwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgR1RLX0JVVFRPTlNfWUVTX05PLAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiJXMiLCAiVW5hY2NlcHRhYmxlIFRM UyBDZXJ0aWZpY2F0ZSIpOworICAgIGd0a19tZXNzYWdlX2RpYWxvZ19mb3JtYXRfc2Vjb25kYXJ5 X3RleHQoR1RLX01FU1NBR0VfRElBTE9HKGRpYWxvZyksICJGYWlsZWQgdG8gbG9hZCAlczogRG8g eW91IHdhbnQgdG8gY29udGludWUgaWdub3JpbmcgdGhlIFRMUyBlcnJvcnM/IiwgZmFpbGluZ1VS SSk7CisgICAgaW50IHJlc3BvbnNlID0gZ3RrX2RpYWxvZ19ydW4oR1RLX0RJQUxPRyhkaWFsb2cp KTsKKyAgICBndGtfd2lkZ2V0X2Rlc3Ryb3koZGlhbG9nKTsKKworICAgIGlmIChyZXNwb25zZSA9 PSBHVEtfUkVTUE9OU0VfWUVTKSB7CisgICAgICAgIFNvdXBVUkkgKnVyaSA9IHNvdXBfdXJpX25l dyhmYWlsaW5nVVJJKTsKKyAgICAgICAgd2Via2l0X3dlYl9jb250ZXh0X2FsbG93X3Rsc19jZXJ0 aWZpY2F0ZV9mb3JfaG9zdCh3ZWJraXRfd2ViX3ZpZXdfZ2V0X2NvbnRleHQod2ViVmlldyksIGNl cnRpZmljYXRlLCB1cmktPmhvc3QpOworICAgICAgICBzb3VwX3VyaV9mcmVlKHVyaSk7CisgICAg ICAgIHdlYmtpdF93ZWJfdmlld19sb2FkX3VyaSh3ZWJWaWV3LCBmYWlsaW5nVVJJKTsKKyAgICB9 CisKKyAgICByZXR1cm4gVFJVRTsKK30KKwogc3RhdGljIGdib29sZWFuIHdlYlZpZXdEZWNpZGVQ b2xpY3koV2ViS2l0V2ViVmlldyAqd2ViVmlldywgV2ViS2l0UG9saWN5RGVjaXNpb24gKmRlY2lz aW9uLCBXZWJLaXRQb2xpY3lEZWNpc2lvblR5cGUgZGVjaXNpb25UeXBlLCBCcm93c2VyV2luZG93 ICp3aW5kb3cpCiB7CiAgICAgc3dpdGNoIChkZWNpc2lvblR5cGUpIHsKQEAgLTg3NCw2ICs4OTUs NyBAQCBzdGF0aWMgdm9pZCBicm93c2VyV2luZG93Q29uc3RydWN0ZWQoR09iamVjdCAqZ09iamVj dCkKICAgICBnX3NpZ25hbF9jb25uZWN0KHdpbmRvdy0+d2ViVmlldywgIm5vdGlmeTo6dGl0bGUi LCBHX0NBTExCQUNLKHdlYlZpZXdUaXRsZUNoYW5nZWQpLCB3aW5kb3cpOwogICAgIGdfc2lnbmFs X2Nvbm5lY3Qod2luZG93LT53ZWJWaWV3LCAiY3JlYXRlIiwgR19DQUxMQkFDSyh3ZWJWaWV3Q3Jl YXRlKSwgd2luZG93KTsKICAgICBnX3NpZ25hbF9jb25uZWN0KHdpbmRvdy0+d2ViVmlldywgImxv YWQtZmFpbGVkIiwgR19DQUxMQkFDSyh3ZWJWaWV3TG9hZEZhaWxlZCksIHdpbmRvdyk7CisgICAg Z19zaWduYWxfY29ubmVjdCh3aW5kb3ctPndlYlZpZXcsICJsb2FkLWZhaWxlZC13aXRoLXRscy1l cnJvcnMiLCBHX0NBTExCQUNLKHdlYlZpZXdMb2FkRmFpbGVkV2l0aFRMU2Vycm9ycyksIHdpbmRv dyk7CiAgICAgZ19zaWduYWxfY29ubmVjdCh3aW5kb3ctPndlYlZpZXcsICJkZWNpZGUtcG9saWN5 IiwgR19DQUxMQkFDSyh3ZWJWaWV3RGVjaWRlUG9saWN5KSwgd2luZG93KTsKICAgICBnX3NpZ25h bF9jb25uZWN0KHdpbmRvdy0+d2ViVmlldywgInBlcm1pc3Npb24tcmVxdWVzdCIsIEdfQ0FMTEJB Q0sod2ViVmlld0RlY2lkZVBlcm1pc3Npb25SZXF1ZXN0KSwgd2luZG93KTsKICAgICBnX3NpZ25h bF9jb25uZWN0KHdpbmRvdy0+d2ViVmlldywgIm1vdXNlLXRhcmdldC1jaGFuZ2VkIiwgR19DQUxM QkFDSyh3ZWJWaWV3TW91c2VUYXJnZXRDaGFuZ2VkKSwgd2luZG93KTsK 248413 2015-03-11 04:57:12 -0700 2015-03-11 07:44:18 -0700 Fix coding style issues mb-tls-errors.diff text/plain 3051 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2OGMy ODk2Li41OTRkM2YzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTUtMDMtMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEFkZCBzdXBwb3J0IGZvciBo YW5kbGluZyBUTFMgZXJyb3JzIHRvIE1pbmlCcm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI1NzYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCdzIHVzZWZ1bCBmb3IgdGVzdGluZyBUTFMgZXJy b3JzIGhhbmRsaW5nIGl0c2VsZiwgYnV0IGFsc28gdG8KKyAgICAgICAgYWxsb3cgaWdub3Jpbmcg VExTIGVycm9ycyB3aGVuIHRlc3RpbmcuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9ndGsvQnJv d3NlcldpbmRvdy5jOgorICAgICAgICAod2ViVmlld0xvYWRGYWlsZWRXaXRoVExTZXJyb3JzKToK KyAgICAgICAgKGJyb3dzZXJXaW5kb3dDb25zdHJ1Y3RlZCk6CisKIDIwMTUtMDMtMDYgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFRl c3QgL3dlYmtpdDIvV2ViS2l0V2ViVmlldy9zeW5jLXJlcXVlc3Qtb24tbWF4LWNvbm5zIG1pZ2h0 IGZhaWwgYWZ0ZXIgZmluaXNoZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9C cm93c2VyV2luZG93LmMgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCmlu ZGV4IDE4ZGQ0NWEuLjNhY2U4ZTcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9C cm93c2VyV2luZG93LmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cu YwpAQCAtMzY4LDYgKzM2OCwyNCBAQCBzdGF0aWMgZ2Jvb2xlYW4gd2ViVmlld0xvYWRGYWlsZWQo V2ViS2l0V2ViVmlldyAqd2ViVmlldywgV2ViS2l0TG9hZEV2ZW50IGxvYWRFdgogICAgIHJldHVy biBGQUxTRTsKIH0KIAorc3RhdGljIGdib29sZWFuIHdlYlZpZXdMb2FkRmFpbGVkV2l0aFRMU2Vy cm9ycyhXZWJLaXRXZWJWaWV3ICp3ZWJWaWV3LCBjb25zdCBjaGFyICpmYWlsaW5nVVJJLCBHVGxz Q2VydGlmaWNhdGUgKmNlcnRpZmljYXRlLCBHVGxzQ2VydGlmaWNhdGVGbGFncyBlcnJvcnMsIEJy b3dzZXJXaW5kb3cgKndpbmRvdykKK3sKKyAgICBHdGtXaWRnZXQgKmRpYWxvZyA9IGd0a19tZXNz YWdlX2RpYWxvZ19uZXcoR1RLX1dJTkRPVyh3aW5kb3cpLCBHVEtfRElBTE9HX01PREFMIHwgR1RL X0RJQUxPR19ERVNUUk9ZX1dJVEhfUEFSRU5ULAorICAgICAgICBHVEtfTUVTU0FHRV9RVUVTVElP TiwgR1RLX0JVVFRPTlNfWUVTX05PLCAiJXMiLCAiVW5hY2NlcHRhYmxlIFRMUyBDZXJ0aWZpY2F0 ZSIpOworICAgIGd0a19tZXNzYWdlX2RpYWxvZ19mb3JtYXRfc2Vjb25kYXJ5X3RleHQoR1RLX01F U1NBR0VfRElBTE9HKGRpYWxvZyksICJGYWlsZWQgdG8gbG9hZCAlczogRG8geW91IHdhbnQgdG8g Y29udGludWUgaWdub3JpbmcgdGhlIFRMUyBlcnJvcnM/IiwgZmFpbGluZ1VSSSk7CisgICAgaW50 IHJlc3BvbnNlID0gZ3RrX2RpYWxvZ19ydW4oR1RLX0RJQUxPRyhkaWFsb2cpKTsKKyAgICBndGtf d2lkZ2V0X2Rlc3Ryb3koZGlhbG9nKTsKKworICAgIGlmIChyZXNwb25zZSA9PSBHVEtfUkVTUE9O U0VfWUVTKSB7CisgICAgICAgIFNvdXBVUkkgKnVyaSA9IHNvdXBfdXJpX25ldyhmYWlsaW5nVVJJ KTsKKyAgICAgICAgd2Via2l0X3dlYl9jb250ZXh0X2FsbG93X3Rsc19jZXJ0aWZpY2F0ZV9mb3Jf aG9zdCh3ZWJraXRfd2ViX3ZpZXdfZ2V0X2NvbnRleHQod2ViVmlldyksIGNlcnRpZmljYXRlLCB1 cmktPmhvc3QpOworICAgICAgICBzb3VwX3VyaV9mcmVlKHVyaSk7CisgICAgICAgIHdlYmtpdF93 ZWJfdmlld19sb2FkX3VyaSh3ZWJWaWV3LCBmYWlsaW5nVVJJKTsKKyAgICB9CisKKyAgICByZXR1 cm4gVFJVRTsKK30KKwogc3RhdGljIGdib29sZWFuIHdlYlZpZXdEZWNpZGVQb2xpY3koV2ViS2l0 V2ViVmlldyAqd2ViVmlldywgV2ViS2l0UG9saWN5RGVjaXNpb24gKmRlY2lzaW9uLCBXZWJLaXRQ b2xpY3lEZWNpc2lvblR5cGUgZGVjaXNpb25UeXBlLCBCcm93c2VyV2luZG93ICp3aW5kb3cpCiB7 CiAgICAgc3dpdGNoIChkZWNpc2lvblR5cGUpIHsKQEAgLTg3NCw2ICs4OTIsNyBAQCBzdGF0aWMg dm9pZCBicm93c2VyV2luZG93Q29uc3RydWN0ZWQoR09iamVjdCAqZ09iamVjdCkKICAgICBnX3Np Z25hbF9jb25uZWN0KHdpbmRvdy0+d2ViVmlldywgIm5vdGlmeTo6dGl0bGUiLCBHX0NBTExCQUNL KHdlYlZpZXdUaXRsZUNoYW5nZWQpLCB3aW5kb3cpOwogICAgIGdfc2lnbmFsX2Nvbm5lY3Qod2lu ZG93LT53ZWJWaWV3LCAiY3JlYXRlIiwgR19DQUxMQkFDSyh3ZWJWaWV3Q3JlYXRlKSwgd2luZG93 KTsKICAgICBnX3NpZ25hbF9jb25uZWN0KHdpbmRvdy0+d2ViVmlldywgImxvYWQtZmFpbGVkIiwg R19DQUxMQkFDSyh3ZWJWaWV3TG9hZEZhaWxlZCksIHdpbmRvdyk7CisgICAgZ19zaWduYWxfY29u bmVjdCh3aW5kb3ctPndlYlZpZXcsICJsb2FkLWZhaWxlZC13aXRoLXRscy1lcnJvcnMiLCBHX0NB TExCQUNLKHdlYlZpZXdMb2FkRmFpbGVkV2l0aFRMU2Vycm9ycyksIHdpbmRvdyk7CiAgICAgZ19z aWduYWxfY29ubmVjdCh3aW5kb3ctPndlYlZpZXcsICJkZWNpZGUtcG9saWN5IiwgR19DQUxMQkFD Syh3ZWJWaWV3RGVjaWRlUG9saWN5KSwgd2luZG93KTsKICAgICBnX3NpZ25hbF9jb25uZWN0KHdp bmRvdy0+d2ViVmlldywgInBlcm1pc3Npb24tcmVxdWVzdCIsIEdfQ0FMTEJBQ0sod2ViVmlld0Rl Y2lkZVBlcm1pc3Npb25SZXF1ZXN0KSwgd2luZG93KTsKICAgICBnX3NpZ25hbF9jb25uZWN0KHdp bmRvdy0+d2ViVmlldywgIm1vdXNlLXRhcmdldC1jaGFuZ2VkIiwgR19DQUxMQkFDSyh3ZWJWaWV3 TW91c2VUYXJnZXRDaGFuZ2VkKSwgd2luZG93KTsK