142573 2015-03-10 23:18:11 -0700 Fix build warning in WebKit2/NetworkProcess module 2022-03-01 02:47:51 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 shiva.jm shiva.jm commit-queue ossy oldest_to_newest 1076253 0 shiva.jm 2015-03-10 23:18:11 -0700 Got build warnign in latest build for efl port. ../../Source/WebKit2/NetworkProcess/NetworkProcess.cpp:268:13: warning: unused parameter ‘sessionID’ [-Wunused-parameter] static void fetchDiskCacheEntries(SessionID sessionID, std::function<void (Vector<WebsiteData::Entry>)> completionHandler) ^ ../../Source/WebKit2/NetworkProcess/NetworkProcess.cpp:369:6: warning: unused parameter ‘origins’ [-Wunused-parameter] void NetworkProcess::deleteWebsiteDataForOrigins(SessionID sessionID, uint64_t websiteDataTypes, const Vector<SecurityOriginData>& origins, const Vector<String>& cookieHostNames, uint64_t callbackID) 1076255 1 248405 shiva.jm 2015-03-10 23:22:58 -0700 Created attachment 248405 Patch Fix build warning by removing argument name from function. 1076257 2 commit-queue 2015-03-10 23:24:41 -0700 Attachment 248405 did not pass style-queue: ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:268: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1076261 3 248405 darin 2015-03-10 23:54:19 -0700 Comment on attachment 248405 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248405&action=review > Source/WebKit2/NetworkProcess/NetworkProcess.cpp:369 > +void NetworkProcess::deleteWebsiteDataForOrigins(SessionID sessionID, uint64_t websiteDataTypes, const Vector<SecurityOriginData>& , const Vector<String>& cookieHostNames, uint64_t callbackID) Should not have left in a space before the comma. 1076269 4 ossy 2015-03-11 00:44:19 -0700 After http://trac.webkit.org/changeset/181318 we don't need to fix this kind of warnings in WebKit2, they are silenced similar to Mac build. 1076273 5 shiva.jm 2015-03-11 01:31:29 -0700 (In reply to comment #4) > After http://trac.webkit.org/changeset/181318 we don't need to fix this > kind of warnings in WebKit2, they are silenced similar to Mac build. Ok, will mark these issue as wontfix 248405 2015-03-10 23:22:58 -0700 2022-03-01 02:47:51 -0800 Patch bug-142573.patch text/plain 2024 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTM2NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAzLTEwICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IGJ1aWxkIHdhcm5p bmcgaW4gV2ViS2l0Mi9OZXR3b3JrUHJvY2VzcyBtb2R1bGUuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI1NzMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYnVpbGQgd2FybmluZyBieSByZW1vdmlu ZyBhcmd1bWVudCBuYW1lIGZyb20gZnVuY3Rpb24uCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vz cy9OZXR3b3JrUHJvY2Vzcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OmZldGNoRGlza0NhY2hlRW50 cmllcyk6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtQcm9jZXNzOjpkZWxldGVXZWJzaXRlRGF0 YUZvck9yaWdpbnMpOgorCiAyMDE1LTAzLTEwICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxl LmNvbT4KIAogICAgICAgICBBZGQgaW50ZXJmYWNlIHRvIGRlbGV0ZSBkaXNrIGNhY2hlIGVudHJp ZXMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJv Y2Vzcy5jcHAJKHJldmlzaW9uIDE4MTM2MykKKysrIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9j ZXNzL05ldHdvcmtQcm9jZXNzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjY1LDcgKzI2NSw3IEBA IHN0YXRpYyBWZWN0b3I8UmVmUHRyPFNlY3VyaXR5T3JpZ2luPj4gY2YKIH0KICNlbmRpZgogCi1z dGF0aWMgdm9pZCBmZXRjaERpc2tDYWNoZUVudHJpZXMoU2Vzc2lvbklEIHNlc3Npb25JRCwgc3Rk OjpmdW5jdGlvbjx2b2lkIChWZWN0b3I8V2Vic2l0ZURhdGE6OkVudHJ5Pik+IGNvbXBsZXRpb25I YW5kbGVyKQorc3RhdGljIHZvaWQgZmV0Y2hEaXNrQ2FjaGVFbnRyaWVzKFNlc3Npb25JRCwgc3Rk OjpmdW5jdGlvbjx2b2lkIChWZWN0b3I8V2Vic2l0ZURhdGE6OkVudHJ5Pik+IGNvbXBsZXRpb25I YW5kbGVyKQogewogI2lmIEVOQUJMRShORVRXT1JLX0NBQ0hFKQogICAgIGlmIChOZXR3b3JrQ2Fj aGU6OnNpbmdsZXRvbigpLmlzRW5hYmxlZCgpKSB7CkBAIC0zNjYsNyArMzY2LDcgQEAgdm9pZCBO ZXR3b3JrUHJvY2Vzczo6ZGVsZXRlV2Vic2l0ZURhdGEoUwogICAgIGNvbXBsZXRpb25IYW5kbGVy KCk7CiB9CiAKLXZvaWQgTmV0d29ya1Byb2Nlc3M6OmRlbGV0ZVdlYnNpdGVEYXRhRm9yT3JpZ2lu cyhTZXNzaW9uSUQgc2Vzc2lvbklELCB1aW50NjRfdCB3ZWJzaXRlRGF0YVR5cGVzLCBjb25zdCBW ZWN0b3I8U2VjdXJpdHlPcmlnaW5EYXRhPiYgb3JpZ2lucywgY29uc3QgVmVjdG9yPFN0cmluZz4m IGNvb2tpZUhvc3ROYW1lcywgdWludDY0X3QgY2FsbGJhY2tJRCkKK3ZvaWQgTmV0d29ya1Byb2Nl c3M6OmRlbGV0ZVdlYnNpdGVEYXRhRm9yT3JpZ2lucyhTZXNzaW9uSUQgc2Vzc2lvbklELCB1aW50 NjRfdCB3ZWJzaXRlRGF0YVR5cGVzLCBjb25zdCBWZWN0b3I8U2VjdXJpdHlPcmlnaW5EYXRhPiYg LCBjb25zdCBWZWN0b3I8U3RyaW5nPiYgY29va2llSG9zdE5hbWVzLCB1aW50NjRfdCBjYWxsYmFj a0lEKQogewogICAgIGlmICh3ZWJzaXRlRGF0YVR5cGVzICYgV2Vic2l0ZURhdGFUeXBlQ29va2ll cykgewogICAgICAgICBpZiAoYXV0byogbmV0d29ya1N0b3JhZ2VTZXNzaW9uID0gU2Vzc2lvblRy YWNrZXI6OnNlc3Npb24oc2Vzc2lvbklEKSkgewo=