142572 2015-03-10 22:24:10 -0700 Web Inspector: Reload after Global Search results in empty Resources Sidebar. 2026-01-12 09:09:43 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All REOPENED InRadar P2 Normal --- 142580 1 joepeck webkit-unassigned commit-queue graouts inspector-bugzilla-changes jonowells webkit-bug-importer oldest_to_newest 1076237 0 joepeck 2015-03-10 22:24:10 -0700 * SUMMARY Reload after Global Search results in empty Resources Sidebar. * STEPS TO REPRODUCE 1. Inspect webkit.org 2. Global Search "div" (Shift+Cmd+F) 3. Reload (Cmd+R) => Resources sidebar is empty * NOTES - Ideas: a. clear the search b. re-perform the search after page load c. keep the search term, but go back to the non-search Resource tree outline I like (c). If the user wants to search again, they can, and their search term is saved. 1076238 1 webkit-bug-importer 2015-03-10 22:24:28 -0700 <rdar://problem/20117303> 1076244 2 248402 joepeck 2015-03-10 22:45:43 -0700 Created attachment 248402 [PATCH] Proposed Fix 1076315 3 248402 commit-queue 2015-03-11 07:52:34 -0700 Comment on attachment 248402 [PATCH] Proposed Fix Clearing flags on attachment: 248402 Committed r181388: <http://trac.webkit.org/changeset/181388> 1076316 4 commit-queue 2015-03-11 07:52:39 -0700 All reviewed patches have been landed. Closing bug. 1076327 5 commit-queue 2015-03-11 08:52:41 -0700 Re-opened since this is blocked by bug 142580 248402 2015-03-10 22:45:43 -0700 2015-03-11 07:52:34 -0700 [PATCH] Proposed Fix search-fix.patch text/plain 3286 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM0NzI2NmQuLjQzN2MwNGYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE1LTAzLTEwICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVsb2Fk IGFmdGVyIEdsb2JhbCBTZWFyY2ggcmVzdWx0cyBpbiBlbXB0eSBSZXNvdXJjZXMgU2lkZWJhci4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjU3Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIHlvdSBy ZWxvYWQgd2hlbiB0aGUgc2VhcmNoIGNvbnRlbnQgdHJlZSBvdXRsaW5lIGlzIHNob3dpbmcsIGJy ZWFrIG91dAorICAgICAgICB0byBzaG93IHRoZSByZXNvdXJjZSB0cmVlIG91dGxpbmUuCisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlU2lkZWJhclBhbmVsLmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlU2lkZWJhclBhbmVsLnByb3RvdHlwZS5fc2hvd1Jl c291cmNlc0NvbnRlbnRUcmVlT3V0bGluZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3Vy Y2VTaWRlYmFyUGFuZWwucHJvdG90eXBlLl9zaG93U2VhcmNoQ29udGVudFRyZWVPdXRsaW5lKToK KworMjAxNS0wMy0xMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IFNlYXJjaFJlc3VsdFRyZWVFbGVtZW50LnJlcHJlc2VudGVk T2JqZWN0IGlzIG1pc3NpbmcgYSBzYXZlSWRlbnRpdHlUb0Nvb2tpZSBpbXBsZW1lbnRhdGlvbgog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0Njk4CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jl c291cmNlU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvUmVzb3VyY2VTaWRlYmFyUGFuZWwuanMKaW5kZXggNjYyMmY3Yi4uNWJkYTU1YSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVz b3VyY2VTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvUmVzb3VyY2VTaWRlYmFyUGFuZWwuanMKQEAgLTMyMCwxMyArMzIwLDExIEBA IFdlYkluc3BlY3Rvci5SZXNvdXJjZVNpZGViYXJQYW5lbC5wcm90b3R5cGUgPSB7CiAKICAgICAg ICAgc2VhcmNoVGVybSA9IHNlYXJjaFRlcm0udHJpbSgpOwogICAgICAgICBpZiAoIXNlYXJjaFRl cm0ubGVuZ3RoKSB7Ci0gICAgICAgICAgICB0aGlzLmZpbHRlckJhci5wbGFjZWhvbGRlciA9IFdl Ykluc3BlY3Rvci5VSVN0cmluZygiRmlsdGVyIFJlc291cmNlIExpc3QiKTsKLSAgICAgICAgICAg IHRoaXMuY29udGVudFRyZWVPdXRsaW5lID0gdGhpcy5fcmVzb3VyY2VzQ29udGVudFRyZWVPdXRs aW5lOworICAgICAgICAgICAgdGhpcy5fc2hvd1Jlc291cmNlc0NvbnRlbnRUcmVlT3V0bGluZSgp OwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKLSAgICAgICAgdGhpcy5maWx0ZXJC YXIucGxhY2Vob2xkZXIgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkZpbHRlciBTZWFyY2ggUmVz dWx0cyIpOwotICAgICAgICB0aGlzLmNvbnRlbnRUcmVlT3V0bGluZSA9IHRoaXMuX3NlYXJjaENv bnRlbnRUcmVlT3V0bGluZTsKKyAgICAgICAgdGhpcy5fc2hvd1NlYXJjaENvbnRlbnRUcmVlT3V0 bGluZSgpOwogCiAgICAgICAgIC8vIEZJWE1FOiBQcm92aWRlIFVJIHRvIHRvZ2dsZSByZWdleCBh bmQgY2FzZSBzZW5zaXRpdmUgc2VhcmNoZXMuCiAgICAgICAgIHZhciBpc0Nhc2VTZW5zaXRpdmUg PSBmYWxzZTsKQEAgLTUyMSw2ICs1MTksMTggQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlU2lkZWJh clBhbmVsLnByb3RvdHlwZSA9IHsKIAogICAgIC8vIFByaXZhdGUKIAorICAgIF9zaG93UmVzb3Vy Y2VzQ29udGVudFRyZWVPdXRsaW5lOiBmdW5jdGlvbigpCisgICAgeworICAgICAgICB0aGlzLmZp bHRlckJhci5wbGFjZWhvbGRlciA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiRmlsdGVyIFJlc291 cmNlIExpc3QiKTsKKyAgICAgICAgdGhpcy5jb250ZW50VHJlZU91dGxpbmUgPSB0aGlzLl9yZXNv dXJjZXNDb250ZW50VHJlZU91dGxpbmU7CisgICAgfSwKKworICAgIF9zaG93U2VhcmNoQ29udGVu dFRyZWVPdXRsaW5lOiBmdW5jdGlvbigpCisgICAgeworICAgICAgICB0aGlzLmZpbHRlckJhci5w bGFjZWhvbGRlciA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiRmlsdGVyIFNlYXJjaCBSZXN1bHRz Iik7CisgICAgICAgIHRoaXMuY29udGVudFRyZWVPdXRsaW5lID0gdGhpcy5fc2VhcmNoQ29udGVu dFRyZWVPdXRsaW5lOworICAgIH0sCisKICAgICBfc2VhcmNoRmllbGRDaGFuZ2VkOiBmdW5jdGlv bihldmVudCkKICAgICB7CiAgICAgICAgIHRoaXMucGVyZm9ybVNlYXJjaChldmVudC50YXJnZXQu dmFsdWUpOwpAQCAtNjIyLDYgKzYzMiw5IEBAIFdlYkluc3BlY3Rvci5SZXNvdXJjZVNpZGViYXJQ YW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIFdlYkluc3BlY3Rvci5jb250ZW50QnJvd3Nlci5j b250ZW50Vmlld0NvbnRhaW5lci5jbG9zZUFsbENvbnRlbnRWaWV3c09mUHJvdG90eXBlKFdlYklu c3BlY3Rvci5GcmFtZUNvbnRlbnRWaWV3KTsKICAgICAgICAgV2ViSW5zcGVjdG9yLmNvbnRlbnRC cm93c2VyLmNvbnRlbnRWaWV3Q29udGFpbmVyLmNsb3NlQWxsQ29udGVudFZpZXdzT2ZQcm90b3R5 cGUoV2ViSW5zcGVjdG9yLlNjcmlwdENvbnRlbnRWaWV3KTsKIAorICAgICAgICAvLyBCcmVhayBv dXQgb2Ygc2VhcmNoIHRyZWUgb3V0bGluZSBpZiB0aGVyZSB3YXMgYW4gYWN0aXZlIHNlYXJjaC4K KyAgICAgICAgdGhpcy5fc2hvd1Jlc291cmNlc0NvbnRlbnRUcmVlT3V0bGluZSgpOworCiAgICAg ICAgIGZ1bmN0aW9uIGRlbGF5ZWRXb3JrKCkKICAgICAgICAgewogICAgICAgICAgICAgLy8gU2hv dyB0aGUgbWFpbiBmcmFtZSBzaW5jZSB0aGVyZSBpcyBubyBjb250ZW50IHZpZXcgc2hvd2luZyBv ciB3ZSB3ZXJlIHNob3dpbmcgYSByZXNvdXJjZSBiZWZvcmUuCg==