142560 2015-03-10 19:43:08 -0700 Regression(r181257): WTF_WorkQueue.Simple is flaky 2015-03-23 15:57:36 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 142471 1 cdumez bfulgham ap bfulgham cdumez commit-queue ddkilzer simon.fraser oldest_to_newest 1076195 0 cdumez 2015-03-10 19:43:08 -0700 WTF_WorkQueue.Simple is flaky after r181257 I believe: https://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK2%20%28Tests%29/builds/10090/steps/run-api-tests/logs/stdio ================= FAIL WTF_WorkQueue.Simple /Volumes/Data/slave/mavericks-debug/build/Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp:87 Value of: queue->refCount() Actual: 2 Expected: 1 ================= 1076197 1 bfulgham 2015-03-10 19:53:42 -0700 Landed an attempt to improve this in r181362 <https://trac.webkit.org/changeset/181362>. 1079226 2 ap 2015-03-22 23:31:12 -0700 I saw it fail today: https://build.webkit.org/builders/Apple%20Win%207%20Debug%20%28Tests%29/builds/65343/steps/run-api-tests/logs/stdio ..\Tests\WTF\WorkQueue.cpp:90 Value of: queue->refCount() Actual: 3 Expected: 1 1079303 3 249238 bfulgham 2015-03-23 10:32:20 -0700 Created attachment 249238 Patch 1079454 4 249238 ap 2015-03-23 15:08:53 -0700 Comment on attachment 249238 Patch ok 1079458 5 249238 commit-queue 2015-03-23 15:12:05 -0700 Comment on attachment 249238 Patch Rejecting attachment 249238 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 249238, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/6241216349863936 1079495 6 bfulgham 2015-03-23 15:57:36 -0700 Committed r181880: <http://trac.webkit.org/changeset/181880> 249238 2015-03-23 10:32:20 -0700 2015-03-23 15:12:05 -0700 Patch bug-142560-20150323103144.patch text/plain 2413 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MTg1NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE1LTAzLTIzICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFJlZ3Jlc3Npb24ocjE4MTI1Nyk6IFdURl9Xb3JrUXVldWUuU2ltcGxlIGlz IGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDI1NjAKKworICAgICAgICBSZW1vdmUgdGhlIGNoZWNrIHRoYXQgdGhlIHJlZkNvdW50IGhhcyBy ZXR1cm5lZCB0byBvbmUgYWZ0ZXIgdGhlCisgICAgICAgIGluZGl2aWR1YWwgdGFza3MgaGF2ZSBj b21wbGV0ZWQuIEl0J3MgdG9vIG5vbmRldGVybWluaXN0aWMgd2hlbgorICAgICAgICB0aGUgcmVm ZXJlbmNlIGNvdW50IHdpbGwgYmUgcmVkdWNlZC4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkv VGVzdHMvV1RGL1dvcmtRdWV1ZS5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKTog UmVtb3ZlIHRlc3QgdGhhdCByZWZDb3VudCBpcyBiYWNrIHRvIDEuCisKIDIwMTUtMDMtMjMgIEd5 dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbQ01ha2Vd W0VGTF0gUHV0IGZhaWx1cmUgQVBJIHRlc3QgZXhjdXRhYmxlcyBpbnRvIGZhaWx1cmUgZGlyZWN0 b3J5CkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9Xb3JrUXVldWUuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1dvcmtRdWV1ZS5jcHAJ KHJldmlzaW9uIDE4MTg1NSkKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1dvcmtR dWV1ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg3LDcgKzg3LDYgQEAgVEVTVChXVEZfV29ya1F1 ZXVlLCBTaW1wbGUpCiAgICAgRVhQRUNUX1RSVUUoY2FsbGVkU2ltcGxlVGVzdCk7CiAgICAgRVhQ RUNUX1RSVUUoY2FsbGVkTG9uZ1Rlc3QpOwogICAgIEVYUEVDVF9UUlVFKGNhbGxlZFRoaXJkVGVz dCk7Ci0gICAgRVhQRUNUX0VRKDEsIHF1ZXVlLT5yZWZDb3VudCgpKTsKIAogICAgIEVYUEVDVF9F UShzdGF0aWNfY2FzdDxzaXplX3Q+KDMpLCBtX2Z1bmN0aW9uQ2FsbE9yZGVyLnNpemUoKSk7CiAg ICAgRVhQRUNUX1NUUkVRKHNpbXBsZVRlc3RMYWJlbCwgbV9mdW5jdGlvbkNhbGxPcmRlclswXS5j X3N0cigpKTsKQEAgLTEwOCwxMCArMTA3LDggQEAgVEVTVChXVEZfV29ya1F1ZXVlLCBUd29RdWV1 ZXMpCiAgICAgYXV0byBxdWV1ZTEgPSBXb3JrUXVldWU6OmNyZWF0ZSgiY29tLmFwcGxlLldlYktp dC5UZXN0LnR3b1F1ZXVlczEiKTsKICAgICBhdXRvIHF1ZXVlMiA9IFdvcmtRdWV1ZTo6Y3JlYXRl KCJjb20uYXBwbGUuV2ViS2l0LlRlc3QudHdvUXVldWVzMiIpOwogCi0gICAgaW50IGluaXRpYWxR dWV1ZTFSZWZDb3VudCA9IHF1ZXVlMS0+cmVmQ291bnQoKTsKLSAgICBpbnQgaW5pdGlhbFF1ZXVl MlJlZkNvdW50ID0gcXVldWUyLT5yZWZDb3VudCgpOwotICAgIEVYUEVDVF9FUSgxLCBpbml0aWFs UXVldWUxUmVmQ291bnQpOwotICAgIEVYUEVDVF9FUSgxLCBpbml0aWFsUXVldWUyUmVmQ291bnQp OworICAgIEVYUEVDVF9FUSgxLCBxdWV1ZTEtPnJlZkNvdW50KCkpOworICAgIEVYUEVDVF9FUSgx LCBxdWV1ZTItPnJlZkNvdW50KCkpOwogCiAgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fbG9jayk7 CiAgICAgCkBAIC0xNDYsMTQgKzE0MywxMiBAQCBURVNUKFdURl9Xb3JrUXVldWUsIFR3b1F1ZXVl cykKICAgICBFWFBFQ1RfVFJVRShjYWxsZWRTaW1wbGVUZXN0KTsKICAgICBFWFBFQ1RfRkFMU0Uo Y2FsbGVkTG9uZ1Rlc3QpOwogICAgIEVYUEVDVF9UUlVFKGNhbGxlZFRoaXJkVGVzdCk7Ci0gICAg RVhQRUNUX0VRKDEsIHF1ZXVlMS0+cmVmQ291bnQoKSk7CiAKICAgICBtX3Rlc3RRdWV1ZTJDb21w bGV0ZWQud2FpdChtX2xvY2spOwogCiAgICAgRVhQRUNUX1RSVUUoY2FsbGVkU2ltcGxlVGVzdCk7 CiAgICAgRVhQRUNUX1RSVUUoY2FsbGVkTG9uZ1Rlc3QpOwogICAgIEVYUEVDVF9UUlVFKGNhbGxl ZFRoaXJkVGVzdCk7Ci0gICAgRVhQRUNUX0VRKDEsIHF1ZXVlMi0+cmVmQ291bnQoKSk7CiAKICAg ICBFWFBFQ1RfRVEoc3RhdGljX2Nhc3Q8c2l6ZV90PigzKSwgbV9mdW5jdGlvbkNhbGxPcmRlci5z aXplKCkpOwogICAgIEVYUEVDVF9TVFJFUShzaW1wbGVUZXN0TGFiZWwsIG1fZnVuY3Rpb25DYWxs T3JkZXJbMF0uY19zdHIoKSk7Cg==