142559 2015-03-10 19:27:55 -0700 Inline block children do not have correct baselines if their children are also block elements 2015-03-11 07:41:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield commit-queue dino esprehn+autocc glenn hyatt jonlee kondapallykalyan simon.fraser thorton oldest_to_newest 1076189 0 mmaxfield 2015-03-10 19:27:55 -0700 Inline block children do not have correct baselines if their children are also block elements 1076190 1 248387 mmaxfield 2015-03-10 19:29:08 -0700 Created attachment 248387 Patch 1076248 2 248387 darin 2015-03-10 22:53:39 -0700 Comment on attachment 248387 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248387&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:3023 > + const FontMetrics& fontMetrics = firstLineStyle().fontMetrics(); Maybe auto& here? > Source/WebCore/rendering/RenderBlockFlow.cpp:3033 > + const RenderStyle& style = isFirstLine ? firstLineStyle() : this->style(); Maybe auto& here? 1076312 3 248387 mmaxfield 2015-03-11 07:40:34 -0700 Comment on attachment 248387 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248387&action=review >> Source/WebCore/rendering/RenderBlockFlow.cpp:3023 >> + const FontMetrics& fontMetrics = firstLineStyle().fontMetrics(); > > Maybe auto& here? Done. >> Source/WebCore/rendering/RenderBlockFlow.cpp:3033 >> + const RenderStyle& style = isFirstLine ? firstLineStyle() : this->style(); > > Maybe auto& here? Done. 1076313 4 mmaxfield 2015-03-11 07:41:30 -0700 Committed r181387: <http://trac.webkit.org/changeset/181387> 248387 2015-03-10 19:29:08 -0700 2015-03-10 22:53:39 -0700 Patch bug-142559-20150310192844.patch text/plain 5965 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMzU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDBiNTU5MzUzMzhiYTBj ZTdjY2RkZGUzNzMxOWJkZWQ4MGY5NmE4OC4uM2I5MDZhZjkwOTQ5YTI3MGE3MDkxZjdlYTQ0ODRl NzAzZWE0NmU2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAzLTEwICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgSW5saW5lIGJs b2NrIGNoaWxkcmVuIGRvIG5vdCBoYXZlIGNvcnJlY3QgYmFzZWxpbmVzIGlmIHRoZWlyIGNoaWxk cmVuIGFyZSBhbHNvIGJsb2NrIGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI1NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBQZXJmb3JtIHRoZSBzYW1lIGNvbXB1dGF0aW9uIG9uIGNoaWxk IGJsb2NrIGVsZW1lbnRzIGFzIGNoaWxkIGlubGluZSBlbGVtZW50cy4KKworICAgICAgICBUZXN0 OiBmYXN0L3RleHQvYmFzZWxpbmUtaW5saW5lLWJsb2NrLWJsb2NrLWNoaWxkcmVuLmh0bWwKKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyQmxvY2tGbG93OjppbmxpbmVCbG9ja0Jhc2VsaW5lKToKKwogMjAxNS0wMy0xMCAg RGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgU29tZSBldmVudCBoYW5k bGVyIGZpeGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxv Y2tGbG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3Bw CmluZGV4IGU1MzI0MzgyMzAxNmM5N2RjZjYxMjlmMGE2MDE0MTVlN2FlNGUxMDUuLmM2M2QyMDFh MjFiNTQ5NTAzYzI5YmNlNWIxNGYyZWM0YjlmMDY0NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCkBAIC0zMDExLDI3ICszMDExLDI4IEBAIGludCBS ZW5kZXJCbG9ja0Zsb3c6OmlubGluZUJsb2NrQmFzZWxpbmUoTGluZURpcmVjdGlvbk1vZGUgbGlu ZURpcmVjdGlvbikgY29uc3QKICAgICBpZiAoaXNXcml0aW5nTW9kZVJvb3QoKSAmJiAhaXNSdWJ5 UnVuKCkpCiAgICAgICAgIHJldHVybiAtMTsKIAotICAgIGlmICghY2hpbGRyZW5JbmxpbmUoKSkK LSAgICAgICAgcmV0dXJuIFJlbmRlckJsb2NrOjppbmxpbmVCbG9ja0Jhc2VsaW5lKGxpbmVEaXJl Y3Rpb24pOwotCi0gICAgaWYgKCFoYXNMaW5lcygpKSB7Ci0gICAgICAgIGlmICghaGFzTGluZUlm RW1wdHkoKSkKLSAgICAgICAgICAgIHJldHVybiAtMTsKLSAgICAgICAgY29uc3QgRm9udE1ldHJp Y3MmIGZvbnRNZXRyaWNzID0gZmlyc3RMaW5lU3R5bGUoKS5mb250TWV0cmljcygpOwotICAgICAg ICByZXR1cm4gZm9udE1ldHJpY3MuYXNjZW50KCkKLSAgICAgICAgICAgICArIChsaW5lSGVpZ2h0 KHRydWUsIGxpbmVEaXJlY3Rpb24sIFBvc2l0aW9uT2ZJbnRlcmlvckxpbmVCb3hlcykgLSBmb250 TWV0cmljcy5oZWlnaHQoKSkgLyAyCi0gICAgICAgICAgICAgKyAobGluZURpcmVjdGlvbiA9PSBI b3Jpem9udGFsTGluZSA/IGJvcmRlclRvcCgpICsgcGFkZGluZ1RvcCgpIDogYm9yZGVyUmlnaHQo KSArIHBhZGRpbmdSaWdodCgpKTsKLSAgICB9Ci0KICAgICAvLyBOb3RlIHRoYXQgaGVyZSB3ZSBv bmx5IHRha2UgdGhlIGxlZnQgYW5kIGJvdHRvbSBpbnRvIGNvbnNpZGVyYXRpb24uIE91ciBjYWxs ZXIgdGFrZXMgdGhlIHJpZ2h0IGFuZCB0b3AgaW50byBjb25zaWRlcmF0aW9uLgogICAgIGZsb2F0 IGJveEhlaWdodCA9IGxpbmVEaXJlY3Rpb24gPT0gSG9yaXpvbnRhbExpbmUgPyBoZWlnaHQoKSAr IG1fbWFyZ2luQm94LmJvdHRvbSgpIDogd2lkdGgoKSArIG1fbWFyZ2luQm94LmxlZnQoKTsKICAg ICBmbG9hdCBsYXN0QmFzZWxpbmU7Ci0gICAgaWYgKGF1dG8gc2ltcGxlTGluZUxheW91dCA9IHRo aXMtPnNpbXBsZUxpbmVMYXlvdXQoKSkKLSAgICAgICAgbGFzdEJhc2VsaW5lID0gU2ltcGxlTGlu ZUxheW91dDo6Y29tcHV0ZUZsb3dMYXN0TGluZUJhc2VsaW5lKCp0aGlzLCAqc2ltcGxlTGluZUxh eW91dCk7CisgICAgaWYgKCFjaGlsZHJlbklubGluZSgpKQorICAgICAgICBsYXN0QmFzZWxpbmUg PSBSZW5kZXJCbG9jazo6aW5saW5lQmxvY2tCYXNlbGluZShsaW5lRGlyZWN0aW9uKTsKICAgICBl bHNlIHsKLSAgICAgICAgYm9vbCBpc0ZpcnN0TGluZSA9IGxhc3RSb290Qm94KCkgPT0gZmlyc3RS b290Qm94KCk7Ci0gICAgICAgIGNvbnN0IFJlbmRlclN0eWxlJiBzdHlsZSA9IGlzRmlyc3RMaW5l ID8gZmlyc3RMaW5lU3R5bGUoKSA6IHRoaXMtPnN0eWxlKCk7Ci0gICAgICAgIGxhc3RCYXNlbGlu ZSA9IGxhc3RSb290Qm94KCktPmxvZ2ljYWxUb3AoKSArIHN0eWxlLmZvbnRNZXRyaWNzKCkuYXNj ZW50KGxhc3RSb290Qm94KCktPmJhc2VsaW5lVHlwZSgpKTsKKyAgICAgICAgaWYgKCFoYXNMaW5l cygpKSB7CisgICAgICAgICAgICBpZiAoIWhhc0xpbmVJZkVtcHR5KCkpCisgICAgICAgICAgICAg ICAgcmV0dXJuIC0xOworICAgICAgICAgICAgY29uc3QgRm9udE1ldHJpY3MmIGZvbnRNZXRyaWNz ID0gZmlyc3RMaW5lU3R5bGUoKS5mb250TWV0cmljcygpOworICAgICAgICAgICAgcmV0dXJuIGZv bnRNZXRyaWNzLmFzY2VudCgpCisgICAgICAgICAgICAgICAgKyAobGluZUhlaWdodCh0cnVlLCBs aW5lRGlyZWN0aW9uLCBQb3NpdGlvbk9mSW50ZXJpb3JMaW5lQm94ZXMpIC0gZm9udE1ldHJpY3Mu aGVpZ2h0KCkpIC8gMgorICAgICAgICAgICAgICAgICsgKGxpbmVEaXJlY3Rpb24gPT0gSG9yaXpv bnRhbExpbmUgPyBib3JkZXJUb3AoKSArIHBhZGRpbmdUb3AoKSA6IGJvcmRlclJpZ2h0KCkgKyBw YWRkaW5nUmlnaHQoKSk7CisgICAgICAgIH0KKworICAgICAgICBpZiAoYXV0byBzaW1wbGVMaW5l TGF5b3V0ID0gdGhpcy0+c2ltcGxlTGluZUxheW91dCgpKQorICAgICAgICAgICAgbGFzdEJhc2Vs aW5lID0gU2ltcGxlTGluZUxheW91dDo6Y29tcHV0ZUZsb3dMYXN0TGluZUJhc2VsaW5lKCp0aGlz LCAqc2ltcGxlTGluZUxheW91dCk7CisgICAgICAgIGVsc2UgeworICAgICAgICAgICAgYm9vbCBp c0ZpcnN0TGluZSA9IGxhc3RSb290Qm94KCkgPT0gZmlyc3RSb290Qm94KCk7CisgICAgICAgICAg ICBjb25zdCBSZW5kZXJTdHlsZSYgc3R5bGUgPSBpc0ZpcnN0TGluZSA/IGZpcnN0TGluZVN0eWxl KCkgOiB0aGlzLT5zdHlsZSgpOworICAgICAgICAgICAgbGFzdEJhc2VsaW5lID0gbGFzdFJvb3RC b3goKS0+bG9naWNhbFRvcCgpICsgc3R5bGUuZm9udE1ldHJpY3MoKS5hc2NlbnQobGFzdFJvb3RC b3goKS0+YmFzZWxpbmVUeXBlKCkpOworICAgICAgICB9CiAgICAgfQogICAgIC8vIEFjY29yZGlu ZyB0byB0aGUgQ1NTIHNwZWMgaHR0cDovL3d3dy53My5vcmcvVFIvQ1NTMjEvdmlzdWRldC5odG1s LCB3ZSBzaG91bGRuJ3QgYmUgcGVyZm9ybWluZyB0aGlzIG1pbiwgYnV0IHNob3VsZAogICAgIC8v IGluc3RlYWQgYmUgcmV0dXJuaW5nIGJveEhlaWdodCBkaXJlY3RseS4gSG93ZXZlciwgd2UgZmVl bCB0aGF0IGEgbWluIGhlcmUgaXMgYmV0dGVyIGJlaGF2aW9yIChhbmQgaXMgY29uc2lzdGVudApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IGEyNzMwNWVkODU2YjA2ZDgzOWY0YTZmMzNlZTY5NDVkMzc1NGU4ZTcuLmZiYWZmNGZh ZjdmNTU5NDJhNDIzNGU2NDNlYjJlZjIyMGM4NTBiNTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxNS0wMy0xMCAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgorCisg ICAgICAgIElubGluZSBibG9jayBjaGlsZHJlbiBkbyBub3QgaGF2ZSBjb3JyZWN0IGJhc2VsaW5l cyBpZiB0aGVpciBjaGlsZHJlbiBhcmUgYWxzbyBibG9jayBlbGVtZW50cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyNTU5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L3RleHQvYmFzZWxpbmUt aW5saW5lLWJsb2NrLWJsb2NrLWNoaWxkcmVuLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvdGV4dC9iYXNlbGluZS1pbmxpbmUtYmxvY2stYmxvY2stY2hpbGRyZW4uaHRtbDog QWRkZWQuCisKIDIwMTUtMDMtMDkgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFNvbWUgZXZlbnQgaGFuZGxlciBmaXhlcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC90ZXh0L2Jhc2VsaW5lLWlubGluZS1ibG9jay1ibG9jay1jaGlsZHJlbi1leHBlY3RlZC5o dG1sIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2Jhc2VsaW5lLWlubGluZS1ibG9jay1ibG9jay1j aGlsZHJlbi1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjJlNDc4OTc3ZmFmYjYwNDQ3ZjYwYTFk MTk1YmU3YWU5ODc4NmQ4NTAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3Rl eHQvYmFzZWxpbmUtaW5saW5lLWJsb2NrLWJsb2NrLWNoaWxkcmVuLWV4cGVjdGVkLmh0bWwKQEAg LTAsMCArMSw3IEBACitUaGlzIHRlc3RzIHRoYXQgYmxvY2sgY2hpbGRyZW4gb2Ygb3ZlcmZsb3c6 IHNjcm9sbCBoYXZlIHRoZSBjb3JyZWN0IGJhc2VsaW5lIGNhbGN1bGF0ZWQuPGJyPgorPGRpdiBz dHlsZT0iZGlzcGxheTogaW5saW5lLWJsb2NrOyBiYWNrZ3JvdW5kOiBncmVlbjsiPgorICAgIDxk aXYgc3R5bGU9ImhlaWdodDogMTUwcHg7IHdpZHRoOiAyMDBweDsgb3ZlcmZsb3c6IHNjcm9sbDsi PgorICAgICAgICBPdmVyZmxvdyB3aXRoPGJyPm92ZXJmbG93OiBzY3JvbGw8YnI+TTxicj5NPGJy Pk08YnI+TTxicj5NPGJyPk08YnI+TTxicj5NPGJyPk08YnI+TTxicj5NCisgICAgPC9kaXY+Cis8 L2Rpdj4KK0Jhc2VsaW5lCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3RleHQvYmFzZWxp bmUtaW5saW5lLWJsb2NrLWJsb2NrLWNoaWxkcmVuLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3Rl eHQvYmFzZWxpbmUtaW5saW5lLWJsb2NrLWJsb2NrLWNoaWxkcmVuLmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u MGVlOTgwYWU0MTAxM2IyOGQzZjllODZkOTExYjY2MzgzMDU4NzdiMAotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9iYXNlbGluZS1pbmxpbmUtYmxvY2stYmxvY2stY2hp bGRyZW4uaHRtbApAQCAtMCwwICsxLDcgQEAKK1RoaXMgdGVzdHMgdGhhdCBibG9jayBjaGlsZHJl biBvZiBvdmVyZmxvdzogc2Nyb2xsIGhhdmUgdGhlIGNvcnJlY3QgYmFzZWxpbmUgY2FsY3VsYXRl ZC48YnI+Cis8ZGl2IHN0eWxlPSJkaXNwbGF5OiBpbmxpbmUtYmxvY2s7IGJhY2tncm91bmQ6IGdy ZWVuOyI+CisgICAgPGRpdiBzdHlsZT0iaGVpZ2h0OiAxNTBweDsgd2lkdGg6IDIwMHB4OyBvdmVy Zmxvdzogc2Nyb2xsOyI+CisgICAgICAgIDxkaXY+T3ZlcmZsb3cgd2l0aDxicj5vdmVyZmxvdzog c2Nyb2xsPC9kaXY+TTxicj5NPGJyPk08YnI+TTxicj5NPGJyPk08YnI+TTxicj5NPGJyPk08YnI+ TTxicj5NCisgICAgPC9kaXY+Cis8L2Rpdj4KK0Jhc2VsaW5lCg==